)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07da05780b29364d257ae468fbebb1c4d6966e4c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Oliver Walsh \u003cowalsh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-16 10:38:29 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add parameters for Nova/Glance image copy when using multiple RBD Glance stores"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Expose the Nova config options to allow an image to be automatically"},{"line_number":10,"context_line":"copied into the local Glance store when Glance is configured to use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0568e7_80f1f295","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":31},"updated":"2021-04-16 13:18:43.000000000","message":"Maybe we can remove this to shorten the commit title.","commit_id":"7606df5105aa70f5494a9cf264ef80d8c099b2c1"}],"manifests/compute/rbd.pp":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"6db67d413622ac8015968f4cfb18359d958bd394","unresolved":true,"context_lines":[{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# [*libvirt_images_rbd_glance_copy_timeout*]"},{"line_number":78,"context_line":"#  (optional) The overall maximum time we will wait for Glance to complete"},{"line_number":79,"context_line":"#  an image copy to our local rbd store."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class nova::compute::rbd ("},{"line_number":82,"context_line":"  $libvirt_rbd_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"182b21d6_c5f5458d","line":79,"updated":"2021-04-16 03:41:53.000000000","message":"you need to add default value below.\nDefaults to $::os_service_default.","commit_id":"042f66fa5170183bf5645a26a7f497e436640c53"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"37266fc9b93e9471b5683489e8441b47671688ce","unresolved":false,"context_lines":[{"line_number":76,"context_line":"#"},{"line_number":77,"context_line":"# [*libvirt_images_rbd_glance_copy_timeout*]"},{"line_number":78,"context_line":"#  (optional) The overall maximum time we will wait for Glance to complete"},{"line_number":79,"context_line":"#  an image copy to our local rbd store."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class nova::compute::rbd ("},{"line_number":82,"context_line":"  $libvirt_rbd_user,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"faa939df_6cc43208","line":79,"in_reply_to":"182b21d6_c5f5458d","updated":"2021-04-16 09:38:54.000000000","message":"Done","commit_id":"042f66fa5170183bf5645a26a7f497e436640c53"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07da05780b29364d257ae468fbebb1c4d6966e4c","unresolved":true,"context_lines":[{"line_number":62,"context_line":"#  (optional) Ensure value for ceph client package."},{"line_number":63,"context_line":"#  Defaults to \u0027present\u0027."},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*libvirt_images_rbd_glance_store_name*]"},{"line_number":66,"context_line":"#  (optional) Name of the Glance store that represents the local rbd cluster."},{"line_number":67,"context_line":"#  If set, this will allow Nova to request that Glance copy an image from"},{"line_number":68,"context_line":"#  an existing non-local store into the one named by this option before"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e14db878_29bae51c","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":40},"updated":"2021-04-16 13:18:43.000000000","message":"How about adding these parameters just after libvirt_images_rbd_ceph_conf regarding the similar functionality ?","commit_id":"7606df5105aa70f5494a9cf264ef80d8c099b2c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55625477b92ca84e9148960a3912d45f71ed49ce","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    }"},{"line_number":181,"context_line":"  } else {"},{"line_number":182,"context_line":"    nova_config {"},{"line_number":183,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      ensure \u003d\u003e absent;"},{"line_number":184,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: ensure \u003d\u003e absent;"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":"  }"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"37f4ddb6_2b27a669","line":184,"range":{"start_line":182,"start_character":17,"end_line":184,"end_character":55},"updated":"2021-07-01 00:49:43.000000000","message":"Please add new parameters here to ensure all these parameters are reset when ephemeral_storage is false.","commit_id":"b24c4ce9ba7f978dbb915549dbe8ea9141dd5b3f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c28779c90ca020337701cc4a94f99b80c2503b19","unresolved":true,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    }"},{"line_number":181,"context_line":"  } else {"},{"line_number":182,"context_line":"    nova_config {"},{"line_number":183,"context_line":"      \u0027libvirt/images_rbd_pool\u0027:      ensure \u003d\u003e absent;"},{"line_number":184,"context_line":"      \u0027libvirt/images_rbd_ceph_conf\u0027: ensure \u003d\u003e absent;"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":"  }"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f043daa0_46f83ded","line":184,"range":{"start_line":182,"start_character":17,"end_line":184,"end_character":55},"in_reply_to":"37f4ddb6_2b27a669","updated":"2021-07-01 10:42:29.000000000","message":"ack. Nova doesn\u0027t care but better not to set unused params in nova.conf.","commit_id":"b24c4ce9ba7f978dbb915549dbe8ea9141dd5b3f"}],"releasenotes/notes/glance_image_copy-b4f888c8f981e6b3.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07da05780b29364d257ae468fbebb1c4d6966e4c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add parameters for Nova/Glance image copy when using multiple RBD Glance stores:"},{"line_number":5,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_store_name`"},{"line_number":6,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_copy_poll_interval`"},{"line_number":7,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_copy_timeout`"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8c6036d1_b90b68e1","line":4,"range":{"start_line":4,"start_character":83,"end_line":4,"end_character":84},"updated":"2021-04-16 13:18:43.000000000","message":"It seems this colon or no empty line makes this line recognizes as title. Can we replace this by . and add one blank line ?\n\nhttps://68df46ae9335237a384d-beccc8c74927db18ecc6d28abe62d057.ssl.cf2.rackcdn.com/786401/2/check/build-openstack-releasenotes/d74fa6e/docs/unreleased.html","commit_id":"7606df5105aa70f5494a9cf264ef80d8c099b2c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07da05780b29364d257ae468fbebb1c4d6966e4c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add parameters for Nova/Glance image copy when using multiple RBD Glance stores:"},{"line_number":5,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_store_name`"},{"line_number":6,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_copy_poll_interval`"},{"line_number":7,"context_line":"      `nova::compute::rbd::libvirt_images_rbd_glance_copy_timeout`"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d34478a0_6bf97cbb","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":7},"updated":"2021-04-16 13:18:43.000000000","message":"Please use `` ... `` so that this is rendered in bold instead if italic.","commit_id":"7606df5105aa70f5494a9cf264ef80d8c099b2c1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55625477b92ca84e9148960a3912d45f71ed49ce","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    - ``nova::compute::rbd::libvirt_images_rbd_glance_store_name``"},{"line_number":7,"context_line":"    - ``nova::compute::rbd::libvirt_images_rbd_glance_copy_poll_interval``"},{"line_number":8,"context_line":"    - ``nova::compute::rbd::libvirt_images_rbd_glance_copy_timeout``"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"739219c5_170b9a8a","line":9,"updated":"2021-07-01 00:49:43.000000000","message":"(nit) trailing blank lines can be deleted.","commit_id":"b24c4ce9ba7f978dbb915549dbe8ea9141dd5b3f"}],"spec/classes/nova_compute_rbd_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07da05780b29364d257ae468fbebb1c4d6966e4c","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      :libvirt_rbd_secret_uuid      \u003d\u003e false,"},{"line_number":28,"context_line":"      :libvirt_images_rbd_pool      \u003d\u003e \u0027rbd\u0027,"},{"line_number":29,"context_line":"      :libvirt_images_rbd_ceph_conf \u003d\u003e \u0027/etc/ceph/ceph.conf\u0027,"},{"line_number":30,"context_line":"      :ephemeral_storage            \u003d\u003e true }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  shared_examples_for \u0027nova compute rbd\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"525041ff_0929e646","side":"PARENT","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":43},"updated":"2021-04-16 13:18:43.000000000","message":"I like these changes because it allows us to test defaults !","commit_id":"e134afc2971222e14acb8d18c23eb49a666ed388"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"488e383b4d56353d9f0fc31b51db07b4f9a596f3","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      :libvirt_rbd_secret_uuid      \u003d\u003e false,"},{"line_number":28,"context_line":"      :libvirt_images_rbd_pool      \u003d\u003e \u0027rbd\u0027,"},{"line_number":29,"context_line":"      :libvirt_images_rbd_ceph_conf \u003d\u003e \u0027/etc/ceph/ceph.conf\u0027,"},{"line_number":30,"context_line":"      :ephemeral_storage            \u003d\u003e true }"},{"line_number":31,"context_line":"  end"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  shared_examples_for \u0027nova compute rbd\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"03f53a7f_30501536","side":"PARENT","line":30,"range":{"start_line":30,"start_character":42,"end_line":30,"end_character":43},"in_reply_to":"525041ff_0929e646","updated":"2021-04-16 13:34:27.000000000","message":"Yes, that definitely appears to be the intention since there is a context to test with overridden params. Perhaps I should split it into another review though...","commit_id":"e134afc2971222e14acb8d18c23eb49a666ed388"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b5bc2070389a6ab7bf233bb276a4aaed9ab4dc97","unresolved":true,"context_lines":[{"line_number":126,"context_line":"      end"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"      it \u0027should only set user and secret_uuid in nova.conf \u0027 do"},{"line_number":129,"context_line":"          is_expected.to contain_nova_config(\u0027libvirt/images_rbd_pool\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":130,"context_line":"          is_expected.to contain_nova_config(\u0027libvirt/images_rbd_ceph_conf\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":131,"context_line":"          is_expected.to contain_nova_config(\u0027libvirt/images_rbd_glance_store_name\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":132,"context_line":"          is_expected.to contain_nova_config(\u0027libvirt/images_rbd_glance_copy_poll_interval\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":133,"context_line":"          is_expected.to contain_nova_config(\u0027libvirt/images_rbd_glance_copy_timeout\u0027).with_ensure(\u0027absent\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"36842d70_9455bdf2","line":130,"range":{"start_line":129,"start_character":10,"end_line":130,"end_character":98},"updated":"2021-07-01 12:45:16.000000000","message":"good catch.","commit_id":"920f2fbf7e1d455b0f8ab0e7655dc576e0642cd7"}]}