)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"74df68da10348816f6305382c9fa3c247a4d9d1d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-30 14:14:12 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete policy file if policies hash is empty"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If all policies get deleted, previously created policy files won\u0027t"},{"line_number":10,"context_line":"get removed and the api policy file is still used. Let\u0027s make"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"f9e79f82_3c791d17","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":44},"updated":"2021-09-04 12:54:31.000000000","message":"Oops. The commit message should have been updated as well...","commit_id":"d7c27f5051422089b95ad9291f8d43f07a63166d"}],"manifests/policy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e0cac718932dfa3ac240dc1aa3eefbf9724b52e9","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      ensure \u003d\u003e absent,"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":"  } else {"},{"line_number":58,"context_line":"    Openstacklib::Policy::Base {"},{"line_number":59,"context_line":"      file_path   \u003d\u003e $policy_path,"},{"line_number":60,"context_line":"      file_user   \u003d\u003e \u0027root\u0027,"},{"line_number":61,"context_line":"      file_group  \u003d\u003e $::nova::params::group,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a1d76613_fc678821","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":30},"updated":"2021-07-26 13:35:37.000000000","message":"I\u0027d fix it in openstacklib since all the classes leverage that","commit_id":"58af07ac06147b3a9dc7d752937eb6dd2e87aa13"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"09c1c733e4fb3561b2d7e39016e65db84c600d86","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    file_user    \u003d\u003e \u0027root\u0027,"},{"line_number":57,"context_line":"    file_group   \u003d\u003e $::nova::params::group,"},{"line_number":58,"context_line":"    file_format  \u003d\u003e \u0027json\u0027,"},{"line_number":59,"context_line":"    purge_config \u003d\u003e true,"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  oslo::policy { \u0027nova_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"07e888f0_a60d5023","line":59,"updated":"2021-07-27 09:27:41.000000000","message":"might be good to make this a parameter","commit_id":"a9815f8b84d7c3b1e53610040b863dcb429a88f9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b34bd637b6cb80d8bf1e82e055751f733ec22dc2","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $policies)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  $policy_defaults \u003d {"},{"line_number":59,"context_line":"    policies     \u003d\u003e $policies,"},{"line_number":60,"context_line":"    policy_path  \u003d\u003e $policy_path,"},{"line_number":61,"context_line":"    file_user    \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3882d18c_668c28d9","line":58,"range":{"start_line":58,"start_character":3,"end_line":58,"end_character":18},"updated":"2021-08-10 08:31:42.000000000","message":"This parameter no longer defines default, but the actual parameters to define a resource so should be renamed.","commit_id":"82069d0bc461f487c6aa06a3fc2a9d4f370ca19f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b34bd637b6cb80d8bf1e82e055751f733ec22dc2","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    policy_path  \u003d\u003e $policy_path,"},{"line_number":61,"context_line":"    file_user    \u003d\u003e \u0027root\u0027,"},{"line_number":62,"context_line":"    file_group   \u003d\u003e $::nova::params::group,"},{"line_number":63,"context_line":"    file_format  \u003d\u003e regsubst(stdlib::extname($policy_path), \u0027^.(.*)$\u0027, \u0027\\1\u0027),"},{"line_number":64,"context_line":"    purge_config \u003d\u003e $purge_config,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"e5e8c005_93b757f8","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":76},"updated":"2021-08-10 08:31:42.000000000","message":"I\u0027d leave the hard coded \u0027yaml\u0027 here to enforce users to use yaml file instead of json file.","commit_id":"82069d0bc461f487c6aa06a3fc2a9d4f370ca19f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b34bd637b6cb80d8bf1e82e055751f733ec22dc2","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    purge_config \u003d\u003e $purge_config,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  ensure_resource(\u0027openstacklib::policy\u0027, $policy_path, $policy_defaults)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  oslo::policy { \u0027nova_config\u0027:"},{"line_number":70,"context_line":"    enforce_scope        \u003d\u003e $enforce_scope,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"403a958b_9658cff5","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":17},"updated":"2021-08-10 08:31:42.000000000","message":"This should be create_resource. ensure_resource is used to workaround duplicated declaration but here duplication is not expected.","commit_id":"82069d0bc461f487c6aa06a3fc2a9d4f370ca19f"}]}