)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c850ddf7eb9d987e0f6996b46e9f9f2ad079567","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for [DEFAULT] mkisofs_cmd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since genisoimage is no longuer maintained, modern distributions are"},{"line_number":10,"context_line":"going toward xorriso path which provides dropin replacement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":13,"context_line":"Change-Id: Id20319ca2c5d4b458b566ca878ca83db51d240e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8115e6fb_5c126180","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":60},"updated":"2021-09-24 16:11:19.000000000","message":"The current description sounds like this is a common agreement in all distros. If this is still specific to CentOS/RHEL and that should be explained, IMO.","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f4515a26df80ef874c67cf2fabb692aa2fa02509","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Since genisoimage is no longuer maintained, modern distributions are"},{"line_number":10,"context_line":"going toward xorriso path which provides dropin replacement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related: https://bugzilla.redhat.com/show_bug.cgi?id\u003d2002949"},{"line_number":13,"context_line":"Change-Id: Id20319ca2c5d4b458b566ca878ca83db51d240e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7b1bc627_fcf3a2df","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":60},"updated":"2021-09-24 16:07:39.000000000","message":"Please create an appropriate upstream bug.","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b013dabcfc21261785020c3fe5b19135750ca24","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Since genisoimage is no longuer maintained, RHEL/CentOS family"},{"line_number":10,"context_line":"is going toward xorriso path which provides dropin replacement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"While mkisofs command is a symlink with alternatives, it might"},{"line_number":13,"context_line":"a good idea to control this parameter for future use."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, we ensure that the right package is installed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b31a6934_0ec1d2c0","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":52},"updated":"2021-10-01 02:29:22.000000000","message":"I think this should be updated ?","commit_id":"1ead3e1c5b57cecad942d46cb3c24325ada3ada2"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"6f9bad5f3d6241835c20407ad33cb56fed16e8e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since genisoimage is no longuer maintained, RHEL/CentOS family"},{"line_number":10,"context_line":"is going toward xorriso path which provides dropin replacement."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"While mkisofs command is a symlink with alternatives, it might"},{"line_number":13,"context_line":"a good idea to control this parameter for future use."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, we ensure that the right package is installed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5ca42dd1_03adb237","line":12,"range":{"start_line":12,"start_character":6,"end_line":12,"end_character":52},"in_reply_to":"b31a6934_0ec1d2c0","updated":"2021-10-01 03:03:47.000000000","message":"Agreed, fixed.","commit_id":"1ead3e1c5b57cecad942d46cb3c24325ada3ada2"}],"manifests/compute.pp":[{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"c184b09df33b0569be3168c3c4af99efb854439d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*mkisofs_cmd*]"},{"line_number":58,"context_line":"#   (optional) Name or path of the tool used for ISO image creation."},{"line_number":59,"context_line":"#   Defaults to $::os_service_default"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*virtio_nic*]"},{"line_number":62,"context_line":"#   (optional) Whether to use virtio for the nic driver of VMs"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e5260345_dc0043d2","line":59,"updated":"2021-09-24 15:19:30.000000000","message":"We could also default to mkisofs as the default which is on centos/rhel provided by both packages:\n\nwith genisoimage package: /usr/bin/mkisofs -\u003e /etc/alternatives/mkisofs and /etc/alternatives/mkisofs -\u003e /usr/bin/genisoimage\n\nwith xorriso package: /usr/bin/mkisofs -\u003e /etc/alternatives/mkisofs and /etc/alternatives/mkisofs -\u003e /usr/bin/xorriso\n\nIt needs to be verified if that is the same for debian/ubuntu. If not let the deployment tool which relies puppet-nova to handle it.\n\nWith https://review.opendev.org/c/openstack/nova/+/808921/ it seems the plan is to default to mkisofs, but iiuc is not something which could be backported. In a later release when nova switched the default we could set it to $::os_service_default","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"05c4fd32bf4e94b871aa13752fbb5e110a6b8208","unresolved":true,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*mkisofs_cmd*]"},{"line_number":58,"context_line":"#   (optional) Name or path of the tool used for ISO image creation."},{"line_number":59,"context_line":"#   Defaults to $::os_service_default"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*virtio_nic*]"},{"line_number":62,"context_line":"#   (optional) Whether to use virtio for the nic driver of VMs"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6ff86cd5_8e847221","line":59,"in_reply_to":"533c307c_b0c84a31","updated":"2021-09-24 16:05:40.000000000","message":"I agree with Alex and we should not implement our own default and follow the current default in nova.","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"11f0b6274021a41bfc71c82056cd711769d50c69","unresolved":true,"context_lines":[{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*mkisofs_cmd*]"},{"line_number":58,"context_line":"#   (optional) Name or path of the tool used for ISO image creation."},{"line_number":59,"context_line":"#   Defaults to $::os_service_default"},{"line_number":60,"context_line":"#"},{"line_number":61,"context_line":"# [*virtio_nic*]"},{"line_number":62,"context_line":"#   (optional) Whether to use virtio for the nic driver of VMs"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"533c307c_b0c84a31","line":59,"in_reply_to":"e5260345_dc0043d2","updated":"2021-09-24 15:22:41.000000000","message":"We don\u0027t want to specify here. puppet tries to be agnostic for these things so if we need to set this in tripleo we can. But here should default to whatever the nova default is","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"05c4fd32bf4e94b871aa13752fbb5e110a6b8208","unresolved":true,"context_lines":[{"line_number":582,"context_line":"    }"},{"line_number":583,"context_line":"  }"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"  if is_service_default($config_drive_format) or $config_drive_format \u003d\u003d \u0027iso9660\u0027 {"},{"line_number":586,"context_line":"    ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":587,"context_line":"      tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":588,"context_line":"    })"},{"line_number":589,"context_line":"  }"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"  nova_config {"},{"line_number":592,"context_line":"    \u0027DEFAULT/config_drive_format\u0027:     value \u003d\u003e $config_drive_format;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"42c88c7c_6c1fe138","line":589,"range":{"start_line":585,"start_character":0,"end_line":589,"end_character":3},"updated":"2021-09-24 16:05:40.000000000","message":"This resource should be disabled depending on mkisofs_cmd.","commit_id":"68c1cf06faed4402f1c555ef22a1525c11bd21ba"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7ded54d65e0fb00b45258f1a3dc3e5356b7b70a7","unresolved":true,"context_lines":[{"line_number":589,"context_line":"      })"},{"line_number":590,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":591,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":592,"context_line":"        ensure \u003d\u003e \u0027absent\u0027,"},{"line_number":593,"context_line":"      })"},{"line_number":594,"context_line":"    } else {"},{"line_number":595,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"8430ceb2_aa3d06d1","line":592,"updated":"2021-09-28 07:56:15.000000000","message":"does this package have any dependencies that might get removed that we don\u0027t want if it\u0027s removed?","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"066b1962eea5a34abb4c7636eb509ccee091fe83","unresolved":true,"context_lines":[{"line_number":587,"context_line":"      ensure_packages($::nova::params::xorriso_package_name, {"},{"line_number":588,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":589,"context_line":"      })"},{"line_number":590,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":591,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":592,"context_line":"        ensure \u003d\u003e \u0027absent\u0027,"},{"line_number":593,"context_line":"      })"},{"line_number":594,"context_line":"    } else {"},{"line_number":595,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ceaf5230_97cd1e8a","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":27},"updated":"2021-09-28 13:59:34.000000000","message":"probably puppet should not uninstall packages, let\u0027s leave that up to users to decide","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":false,"context_lines":[{"line_number":587,"context_line":"      ensure_packages($::nova::params::xorriso_package_name, {"},{"line_number":588,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":589,"context_line":"      })"},{"line_number":590,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":591,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":592,"context_line":"        ensure \u003d\u003e \u0027absent\u0027,"},{"line_number":593,"context_line":"      })"},{"line_number":594,"context_line":"    } else {"},{"line_number":595,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"53071fa1_62365458","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":27},"in_reply_to":"80d16639_4b0d7db1","updated":"2021-09-29 17:50:30.000000000","message":"Done","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":false,"context_lines":[{"line_number":589,"context_line":"      })"},{"line_number":590,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":591,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":592,"context_line":"        ensure \u003d\u003e \u0027absent\u0027,"},{"line_number":593,"context_line":"      })"},{"line_number":594,"context_line":"    } else {"},{"line_number":595,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"e368ff69_77fabbbb","line":592,"in_reply_to":"8430ceb2_aa3d06d1","updated":"2021-09-29 17:50:30.000000000","message":"Done","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"623214a1d8b24603a82a71151ab73c900a5e27b9","unresolved":true,"context_lines":[{"line_number":587,"context_line":"      ensure_packages($::nova::params::xorriso_package_name, {"},{"line_number":588,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":589,"context_line":"      })"},{"line_number":590,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"},{"line_number":591,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":592,"context_line":"        ensure \u003d\u003e \u0027absent\u0027,"},{"line_number":593,"context_line":"      })"},{"line_number":594,"context_line":"    } else {"},{"line_number":595,"context_line":"      ensure_packages($::nova::params::genisoimage_package_name, {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"80d16639_4b0d7db1","line":592,"range":{"start_line":590,"start_character":0,"end_line":592,"end_character":27},"in_reply_to":"ceaf5230_97cd1e8a","updated":"2021-09-29 14:02:18.000000000","message":"I think we can leave the genisoimage package here, and just decide which of genisoimage and xorriso is installed.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8b013dabcfc21261785020c3fe5b19135750ca24","unresolved":true,"context_lines":[{"line_number":583,"context_line":"  }"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"  if is_service_default($config_drive_format) or $config_drive_format \u003d\u003d \u0027iso9660\u0027 {"},{"line_number":586,"context_line":"      ensure_packages($::nova::params::mkisofs_package_name, {"},{"line_number":587,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":588,"context_line":"      })"},{"line_number":589,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"44c01c4a_3e03c049","line":586,"range":{"start_line":586,"start_character":4,"end_line":586,"end_character":6},"updated":"2021-10-01 02:29:22.000000000","message":"please remove these additional spaces.","commit_id":"1ead3e1c5b57cecad942d46cb3c24325ada3ada2"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"6f9bad5f3d6241835c20407ad33cb56fed16e8e1","unresolved":false,"context_lines":[{"line_number":583,"context_line":"  }"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"  if is_service_default($config_drive_format) or $config_drive_format \u003d\u003d \u0027iso9660\u0027 {"},{"line_number":586,"context_line":"      ensure_packages($::nova::params::mkisofs_package_name, {"},{"line_number":587,"context_line":"        tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":588,"context_line":"      })"},{"line_number":589,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3929aab5_79606445","line":586,"range":{"start_line":586,"start_character":4,"end_line":586,"end_character":6},"in_reply_to":"44c01c4a_3e03c049","updated":"2021-10-01 03:03:47.000000000","message":"Done","commit_id":"1ead3e1c5b57cecad942d46cb3c24325ada3ada2"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"623214a1d8b24603a82a71151ab73c900a5e27b9","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"8a135259_540272b8","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":55},"updated":"2021-09-29 14:02:18.000000000","message":"How about determining genisoimage_package_name according to major version ?","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87de2b933274d188d118081d301e3233ecbed948","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"91035102_15337e38","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":55},"in_reply_to":"87c9c4ee_34643ade","updated":"2021-09-30 00:22:45.000000000","message":"There is a tradeoff, but naming can\u0027t be consistent among all distros and we need to accept this kind of difference sometimes. I believe it\u0027s better than implementing additional logic to install a different package, for the same purpose. Alto, using params would allow us to gather all switch based on distro in a single place, instead of distributing all logics among different files(though some of them are already distributed in puppet-nova, unfortunately)","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"87c9c4ee_34643ade","line":31,"range":{"start_line":31,"start_character":44,"end_line":31,"end_character":55},"in_reply_to":"8a135259_540272b8","updated":"2021-09-29 17:50:30.000000000","message":"I thought about this but over time, it means that this naming won\u0027t make any sense. Maybe at some point we could call this mkisofs_package_name but I wanted to keep a separate line for now, if that works for you.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"71f40cd59bdbeb563280ff347dcd1cce7b7e239d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"},{"line_number":35,"context_line":"      $api_metadata_service_name         \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"835349a3_796bf125","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":52},"updated":"2021-09-30 13:52:34.000000000","message":"so let\u0027s add mkisofs_package_name instead of these two?","commit_id":"056ee8d963a53b16f8a799d9522b438379613054"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"ec9c32ea57894b5916616e4895df05f01d616c75","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"},{"line_number":35,"context_line":"      $api_metadata_service_name         \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"908b2337_aa4edba6","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":52},"in_reply_to":"5a98a745_ca48b550","updated":"2021-09-30 18:05:42.000000000","message":"I was hesitating between creating mkisofs_package_name and removing genisoimage but then I thought it might be a good idea to keep them both. But I also like the idea of centralizing the logic here instead of everywhere else, so I\u0027ll update this patch soon with mkisofs_package_name.","commit_id":"056ee8d963a53b16f8a799d9522b438379613054"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e41bedf45607451aca74daa0ee5ce86cd625934e","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      $serialproxy_package_name          \u003d \u0027openstack-nova-serialproxy\u0027"},{"line_number":29,"context_line":"      $spicehtml5proxy_package_name      \u003d \u0027openstack-nova-console\u0027"},{"line_number":30,"context_line":"      $ceph_client_package_name          \u003d \u0027ceph-common\u0027"},{"line_number":31,"context_line":"      $genisoimage_package_name          \u003d \u0027genisoimage\u0027"},{"line_number":32,"context_line":"      $xorriso_package_name              \u003d \u0027xorriso\u0027"},{"line_number":33,"context_line":"      # service names"},{"line_number":34,"context_line":"      $api_service_name                  \u003d \u0027openstack-nova-api\u0027"},{"line_number":35,"context_line":"      $api_metadata_service_name         \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a98a745_ca48b550","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":52},"in_reply_to":"835349a3_796bf125","updated":"2021-09-30 14:14:31.000000000","message":"That would be a better option.","commit_id":"056ee8d963a53b16f8a799d9522b438379613054"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"623214a1d8b24603a82a71151ab73c900a5e27b9","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      it { is_expected.to contain_class(\u0027nova::availability_zone\u0027) }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it \u0027installs mkisofs package and sets config_drive_format\u0027 do"},{"line_number":76,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/config_drive_format\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).with("},{"line_number":78,"context_line":"          :ensure \u003d\u003e \u0027installed\u0027,"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"a537c034_da7303f5","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":26},"updated":"2021-09-29 14:02:18.000000000","message":"I\u0027d keep genisoimage here","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      it { is_expected.to contain_class(\u0027nova::availability_zone\u0027) }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it \u0027installs mkisofs package and sets config_drive_format\u0027 do"},{"line_number":76,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/config_drive_format\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).with("},{"line_number":78,"context_line":"          :ensure \u003d\u003e \u0027installed\u0027,"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"bef49aa4_cd39b271","line":75,"range":{"start_line":75,"start_character":19,"end_line":75,"end_character":26},"in_reply_to":"a537c034_da7303f5","updated":"2021-09-29 17:50:30.000000000","message":"So the command is in fact mkisofs and the package providing this command can be either genisoimage or xorriso. I believe we want to move away from genisoimage naming.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"623214a1d8b24603a82a71151ab73c900a5e27b9","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it \u0027installs mkisofs package and sets config_drive_format\u0027 do"},{"line_number":76,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/config_drive_format\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).with("},{"line_number":78,"context_line":"          :ensure \u003d\u003e \u0027installed\u0027,"},{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).that_requires(\u0027Anchor[nova::install::begin]\u0027)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"4c5ded80_86f3aeca","line":77,"range":{"start_line":77,"start_character":56,"end_line":77,"end_character":71},"updated":"2021-09-29 14:02:18.000000000","message":"This is confusing because this doesn\u0027t align with the parameter name in Debian/Ubuntu. I\u0027d prefer keeping genisoimage here.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      it \u0027installs mkisofs package and sets config_drive_format\u0027 do"},{"line_number":76,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/config_drive_format\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).with("},{"line_number":78,"context_line":"          :ensure \u003d\u003e \u0027installed\u0027,"},{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":"        is_expected.to contain_package(platform_params[:mkisofs_package]).that_requires(\u0027Anchor[nova::install::begin]\u0027)"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"6bb63523_e85c005b","line":77,"range":{"start_line":77,"start_character":56,"end_line":77,"end_character":71},"in_reply_to":"4c5ded80_86f3aeca","updated":"2021-09-29 17:50:30.000000000","message":"Debian/Ubuntu has a symlink of mkisofs to genisoimage by default when we install it, at least in 20.04. That\u0027s why I thought it made sense to go with this naming.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7ded54d65e0fb00b45258f1a3dc3e5356b7b70a7","unresolved":true,"context_lines":[{"line_number":472,"context_line":"            platform_params.merge!({"},{"line_number":473,"context_line":"              :mkisofs_package \u003d\u003e \u0027genisoimage\u0027 })"},{"line_number":474,"context_line":"          end"},{"line_number":475,"context_line":"        when \u00279\u0027"},{"line_number":476,"context_line":"          before do"},{"line_number":477,"context_line":"            platform_params.merge!({"},{"line_number":478,"context_line":"              :mkisofs_package \u003d\u003e \u0027xorriso\u0027 })"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"410e2307_07ad29b5","line":475,"updated":"2021-09-28 07:56:15.000000000","message":"the logic would need to be \"if \u003e\u003d 9\" right so we don\u0027t need to update this","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"4cd8f6a8c51742e21b1de210ba69d7face2ec63c","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            platform_params.merge!({"},{"line_number":473,"context_line":"              :mkisofs_package \u003d\u003e \u0027genisoimage\u0027 })"},{"line_number":474,"context_line":"          end"},{"line_number":475,"context_line":"        when \u00279\u0027"},{"line_number":476,"context_line":"          before do"},{"line_number":477,"context_line":"            platform_params.merge!({"},{"line_number":478,"context_line":"              :mkisofs_package \u003d\u003e \u0027xorriso\u0027 })"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"050c37d8_9da06e4c","line":475,"in_reply_to":"39b475fd_24315f0f","updated":"2021-09-29 17:50:30.000000000","message":"Thanks for the info, fixed the conditions.","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"623214a1d8b24603a82a71151ab73c900a5e27b9","unresolved":true,"context_lines":[{"line_number":472,"context_line":"            platform_params.merge!({"},{"line_number":473,"context_line":"              :mkisofs_package \u003d\u003e \u0027genisoimage\u0027 })"},{"line_number":474,"context_line":"          end"},{"line_number":475,"context_line":"        when \u00279\u0027"},{"line_number":476,"context_line":"          before do"},{"line_number":477,"context_line":"            platform_params.merge!({"},{"line_number":478,"context_line":"              :mkisofs_package \u003d\u003e \u0027xorriso\u0027 })"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7d96f6b7_b27d6ade","line":475,"in_reply_to":"410e2307_07ad29b5","updated":"2021-09-29 14:02:18.000000000","message":"That sounds more simple.\n\nhttps://github.com/openstack/puppet-nova/blob/b4be9b148a3da41a9bfa9a626b129fc85de84a83/spec/classes/nova_client_spec.rb#L35-L39","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b706f0a39c00ec34609085377c5d25186e0c34e9","unresolved":true,"context_lines":[{"line_number":472,"context_line":"            platform_params.merge!({"},{"line_number":473,"context_line":"              :mkisofs_package \u003d\u003e \u0027genisoimage\u0027 })"},{"line_number":474,"context_line":"          end"},{"line_number":475,"context_line":"        when \u00279\u0027"},{"line_number":476,"context_line":"          before do"},{"line_number":477,"context_line":"            platform_params.merge!({"},{"line_number":478,"context_line":"              :mkisofs_package \u003d\u003e \u0027xorriso\u0027 })"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"39b475fd_24315f0f","line":475,"in_reply_to":"7d96f6b7_b27d6ade","updated":"2021-09-29 14:04:55.000000000","message":"Just FYI. This logic is not used until we add CentOS9 here[1]. We can\u0027t add it until a new facter db with CentOS9 support is released so it would take some time until we can actually use this.\n\n[1] https://github.com/openstack/puppet-openstack_spec_helper/blob/master/lib/puppet-openstack_spec_helper/defaults.rb#L14-L15","commit_id":"e54cc568c35625cc3de27e57470b954722990ef1"}]}