)]}'
{"id":"openstack%2Fpuppet-nova~812196","triplet_id":"openstack%2Fpuppet-nova~stable%2Fwallaby~I394fc6112eb68a9f0decae275299f26e44812b44","project":"openstack/puppet-nova","branch":"stable/wallaby","topic":"stdlib8","hashtags":[],"change_id":"I394fc6112eb68a9f0decae275299f26e44812b44","subject":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0","status":"ABANDONED","created":"2021-10-03 16:27:44.000000000","updated":"2021-10-04 12:49:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":810710,"cherry_pick_of_patch_set":3,"meta_rev_id":"2ee86c1f5160fc4ad90cbc091fb520b22007204b","_number":812196,"virtual_id_number":812196,"owner":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-10-03 19:37:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":-2,"date":"2021-10-04 03:56:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-03 16:27:44.000000000","updated_by":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2021-10-03 16:47:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0fcc977b71f723685775b34dc8f2825381103146","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 16:27:44.000000000","message":"Patch Set 1: Cherry Picked from branch master.\n\nThe following files contain Git conflicts:\n* spec/classes/nova_key_manager_barbican_spec.rb","accounts_in_message":[],"_revision_number":1},{"id":"83fa926ba879ab08918050ac9bb64e15b1bd9509","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 16:29:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bb6fa51409bc4d8d87145c7a8c50c020eaba7b03","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 16:29:43.000000000","message":"Patch Set 2:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"f2ec9831c906abceb15d487e1af07b70497f12fb","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 16:31:50.000000000","message":"Topic stdlib8-stable/wallaby removed","accounts_in_message":[],"_revision_number":2},{"id":"36bc4e5fac158fdd2f1e95a303241569ac9dce05","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 16:31:56.000000000","message":"Topic set to stdlib8","accounts_in_message":[],"_revision_number":2},{"id":"97f292093da1a341d04d99eb1c839296872b1806","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-03 16:47:02.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c52ffa359d91469eb2d37d760eca6b10 : SUCCESS in 3m 52s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6f5b2814aeb044619c37dbec745ef7e3 : SUCCESS in 3m 37s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/1ac1450780bc40f8bada04946eb6a884 : FAILURE in 16m 14s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a63f45fd399d49edb33f66825a9d04d7 : FAILURE in 14m 54s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/79df6162bd694644bed02cc0bbde6846 : FAILURE in 15m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f1e6245eec07e1471901318361ff81ed53452f03","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 18:36:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9a6c9a5f97f499b3be1a25caa6bedd268be6e703","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-03 19:03:34.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e9748831cb344414bcf5b035aa688bc7 : SUCCESS in 4m 20s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1bbe34fcee344b168c0edc21e724eeb9 : SUCCESS in 6m 45s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/206c6a119fac4f0f8d71dea40860b543 : FAILURE in 17m 53s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a6a8d6591acf46cb9477e69baea4e460 : FAILURE in 16m 29s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b027a87add8d4b68b2e54384ba7f27ad : FAILURE in 15m 54s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d7728f213024c32e0eb0ac06beadb4f0551094b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-03 19:12:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2564661159f5a113de1134030cac9d640dea2410","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-03 19:37:06.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bcb5be648d7f45f891e78298ff8d41ab : SUCCESS in 4m 16s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/cc9f517775424d9289598278163ddd28 : SUCCESS in 4m 29s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/5ae072357b704232a5e1c94805662dc7 : FAILURE in 15m 35s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b6c6a77c30df4d5b8aaca46fbe370edc : FAILURE in 17m 06s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0ebd762d8c584ea48b894136b630eef7 : FAILURE in 17m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"8ad94b442c2f4f87aca6e9fd6e43270b5e4c4056","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-10-04 03:56:21.000000000","message":"Patch Set 4: Code-Review-2\n\nThis should not be backported to Wallaby. The change was needed to fix unit tests incompatible with puppetlabs-stdlib 8.0.0 but we pinned the library to older version in stable releases.","accounts_in_message":[],"_revision_number":4},{"id":"2ee86c1f5160fc4ad90cbc091fb520b22007204b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"date":"2021-10-04 12:49:36.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1fc6b86dc33dafa64e205831cb6fc85018c5ebf2","revisions":{"e63ab9235e735d178cacb00944903fc0e7567acb":{"kind":"REWORK","_number":1,"created":"2021-10-03 16:27:44.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/96/812196/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/96/812196/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/1"}}},"commit":{"parents":[{"commit":"bdd7c0c95b14a9901887172d2eaffb8bbf101a2d","subject":"Fix how libvirt package resource is looked up","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/bdd7c0c95b14a9901887172d2eaffb8bbf101a2d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-23 15:24:40.000000000","tz":540},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2021-10-03 16:27:44.000000000","tz":0},"subject":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0","message":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0\n\nSince puppetlabs-stdlib 8.0.0, ensure_packages automatically translates\n\u0027ensure \u003d\u003e present\u0027  to \u0027ensure \u003d\u003e installed\u0027 and that translation\nbreaks existing assertions in unit tests.\n\nChange-Id: I394fc6112eb68a9f0decae275299f26e44812b44\n(cherry picked from commit 123acbb3025db3a18fb202f746abd9dd68010ab3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/e63ab9235e735d178cacb00944903fc0e7567acb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/e63ab9235e735d178cacb00944903fc0e7567acb"}]},"branch":"refs/heads/stable/wallaby"},"5a535daf601c3726e2e4f23541e84860ae63adab":{"kind":"REWORK","_number":2,"created":"2021-10-03 16:29:21.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/96/812196/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/96/812196/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/2"}}},"commit":{"parents":[{"commit":"bdd7c0c95b14a9901887172d2eaffb8bbf101a2d","subject":"Fix how libvirt package resource is looked up","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/bdd7c0c95b14a9901887172d2eaffb8bbf101a2d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-23 15:24:40.000000000","tz":540},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2021-10-03 16:28:52.000000000","tz":-240},"subject":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0","message":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0\n\nSince puppetlabs-stdlib 8.0.0, ensure_packages automatically translates\n\u0027ensure \u003d\u003e present\u0027  to \u0027ensure \u003d\u003e installed\u0027 and that translation\nbreaks existing assertions in unit tests.\n\nConflicts:\n  - spec/classes/nova_key_manager_barbican_spec.rb: File is absent\n    in wallaby\n\nChange-Id: I394fc6112eb68a9f0decae275299f26e44812b44\n(cherry picked from commit 123acbb3025db3a18fb202f746abd9dd68010ab3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5a535daf601c3726e2e4f23541e84860ae63adab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/5a535daf601c3726e2e4f23541e84860ae63adab"}]},"branch":"refs/heads/stable/wallaby"},"afc0aba0222f2fdaedb51d07f3701553575477c9":{"kind":"REWORK","_number":3,"created":"2021-10-03 18:36:52.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/96/812196/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/96/812196/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/3"}}},"commit":{"parents":[{"commit":"bdd7c0c95b14a9901887172d2eaffb8bbf101a2d","subject":"Fix how libvirt package resource is looked up","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/bdd7c0c95b14a9901887172d2eaffb8bbf101a2d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-23 15:24:40.000000000","tz":540},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2021-10-03 18:36:47.000000000","tz":-240},"subject":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0","message":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0\n\nSince puppetlabs-stdlib 8.0.0, ensure_packages automatically translates\n\u0027ensure \u003d\u003e present\u0027  to \u0027ensure \u003d\u003e installed\u0027 and that translation\nbreaks existing assertions in unit tests.\n\nConflicts:\n  - spec/classes/nova_key_manager_barbican_spec.rb: File is absent\n    in wallaby\n\nChange-Id: I394fc6112eb68a9f0decae275299f26e44812b44\n(cherry picked from commit 123acbb3025db3a18fb202f746abd9dd68010ab3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/afc0aba0222f2fdaedb51d07f3701553575477c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/afc0aba0222f2fdaedb51d07f3701553575477c9"}]},"branch":"refs/heads/stable/wallaby"},"1fc6b86dc33dafa64e205831cb6fc85018c5ebf2":{"kind":"REWORK","_number":4,"created":"2021-10-03 19:12:21.000000000","uploader":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"ref":"refs/changes/96/812196/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/96/812196/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/96/812196/4"}}},"commit":{"parents":[{"commit":"bdd7c0c95b14a9901887172d2eaffb8bbf101a2d","subject":"Fix how libvirt package resource is looked up","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/bdd7c0c95b14a9901887172d2eaffb8bbf101a2d"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-23 15:24:40.000000000","tz":540},"committer":{"name":"David Vallee Delisle","email":"dvd@redhat.com","date":"2021-10-03 19:11:16.000000000","tz":-240},"subject":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0","message":"Fix unit tests incompatible with puppetlab-stdlib 8.0.0\n\nSince puppetlabs-stdlib 8.0.0, ensure_packages automatically translates\n\u0027ensure \u003d\u003e present\u0027  to \u0027ensure \u003d\u003e installed\u0027 and that translation\nbreaks existing assertions in unit tests.\n\nConflicts:\n  - spec/classes/nova_key_manager_barbican_spec.rb: File is absent\n    in wallaby\n\nChange-Id: I394fc6112eb68a9f0decae275299f26e44812b44\n(cherry picked from commit 123acbb3025db3a18fb202f746abd9dd68010ab3)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/1fc6b86dc33dafa64e205831cb6fc85018c5ebf2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/1fc6b86dc33dafa64e205831cb6fc85018c5ebf2"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[],"submit_requirements":[]}