)]}'
{"id":"openstack%2Fpuppet-nova~813999","triplet_id":"openstack%2Fpuppet-nova~stable%2Fwallaby~I3030ca34088019be932a9cc33344f7fb473a9aea","project":"openstack/puppet-nova","branch":"stable/wallaby","topic":"modular_libvirt","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2021-10-15 00:51:45.000000000","reason":"Takashi Kajinami replied on the change"},"20733":{"account":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"last_update":"2021-10-15 03:08:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3030ca34088019be932a9cc33344f7fb473a9aea","subject":"Libvirt: quote config parameters in resource types","status":"MERGED","created":"2021-10-14 12:26:05.000000000","updated":"2021-10-15 03:10:05.000000000","submitted":"2021-10-15 03:08:15.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"813999-modular_libvirt","meta_rev_id":"c63c137da5bac910384f0a6962c4cb8a1771a514","_number":813999,"virtual_id_number":813999,"owner":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-10-15 03:08:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":2,"date":"2021-10-15 00:51:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2021-10-14 22:14:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":1,"date":"2021-10-15 00:51:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-14 12:26:05.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2021-10-14 14:40:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-14 22:14:44.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"}],"messages":[{"id":"ee4a0580db556b582403155dbad7ecd90d394b61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2021-10-14 12:26:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cec6e3b22ead7e3d1e3202c7e84dddba494ca5e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2021-10-14 12:44:53.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bc39f77483ead647c940aa81a225309a617f05b3","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2021-10-14 12:45:09.000000000","message":"Topic set to modular_libvirt","accounts_in_message":[],"_revision_number":2},{"id":"50ee986b9141ad34813c89c95cccf571f9885fba","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-14 14:40:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/24a09e52d14646da86b3cd687278c273 : SUCCESS in 4m 01s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/cdb8e147959046f9b04361d6aa8644f0 : SUCCESS in 3m 50s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/2d3bdbfec511450ea4fc4f72be0dcc30 : SUCCESS in 19m 58s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f11acd66d8fa4aa7a39916eae65d1eae : SUCCESS in 16m 20s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/688a776d638d492dac01dca5a4004ec3 : SUCCESS in 15m 53s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3ca1f8e142fe4edbac9c14272907bdda : FAILURE in 37m 24s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/282122b829b84bd8ab7eb369d9409d7c : SUCCESS in 51m 20s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/adaf538c6daa490ab867accda1f17d28 : FAILURE in 30m 17s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/13118bd4966d43cd9dc4c0db7f271d23 : SUCCESS in 36m 29s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b294fb8bac554495b1b7bd3c2961d6ad : SUCCESS in 1h 32m 11s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a214d79e88714f86acebc46f59b71314 : SUCCESS in 1h 42m 38s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7accea72369d4f68b13aef6432152a4c : SUCCESS in 1h 28m 01s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7874657bff12497bb46dbc936b1d14ea : SUCCESS in 1h 07m 47s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/46698e9a5a13434e8579a4e91d75b9aa : SUCCESS in 28m 09s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/030f1411d6884a9cbefa3569743a3830 : SUCCESS in 20m 32s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8a19eb939e3946d099e0d0634cf60724 : SUCCESS in 4m 10s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/621c8eb47d7b44c8a68f88cd0ee4d75f : SUCCESS in 1h 50m 52s","accounts_in_message":[],"_revision_number":2},{"id":"69bf338ee8a5944c430ecbdf5aa8988266778e29","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-10-14 22:14:44.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"94a2f25c40dd4a7b7a18f2c9d82173ce6a45c10c","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-10-15 00:51:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"93c3cbd47c5e2e547b58622c8c90d56ce8fc82d4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-15 00:53:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"95e0ecf6a1a74342e737ff94ba0e8f27ab4cfebb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-15 03:08:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/103679f72b9e429483d35ac35c2d4e13 : SUCCESS in 4m 15s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3470777247c140489ec2c071272f606f : SUCCESS in 4m 23s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/65682f4af45a4eb4862aca0c272b1ae3 : SUCCESS in 16m 53s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5f73e5b9387a40f9989947304a6d7dd7 : SUCCESS in 14m 09s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7e75b75512c54d8dbe9088b304b22d80 : SUCCESS in 1h 14m 32s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a71be0243362457cbe48caf334ed4308 : SUCCESS in 1h 18m 23s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ced84bca39da47bd86173f5f3070bfdc : SUCCESS in 1h 15m 35s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/9b92b9f885a04d92be79ae4789d2725e : SUCCESS in 1h 13m 43s\n- puppet-openstack-litmus-centos-8-stream https://zuul.opendev.org/t/openstack/build/4d763d2469124184858a604e6a5be3d1 : SUCCESS in 29m 08s\n- puppet-openstack-litmus-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5dca1dc3cd9649f9b11059e8a0e75914 : SUCCESS in 22m 19s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/42e9ae19276b42928b3b829e5d6435e4 : SUCCESS in 4m 38s\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/c488273c7db94a84901f71d8c6106f96 : SUCCESS in 2h 11m 15s","accounts_in_message":[],"_revision_number":2},{"id":"37dc05d456294917d3ad4f86f5b30e94386692ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-15 03:08:15.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"c63c137da5bac910384f0a6962c4cb8a1771a514","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-15 03:10:05.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6038664135684c30ac82939c7cef2c71 : SUCCESS in 1m 19s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"959c314c3ff97bad21489d0ced56175c1572c3dd","revisions":{"f3a793a112ee0b5aea5116336231978c6f95261b":{"kind":"REWORK","_number":1,"created":"2021-10-14 12:26:05.000000000","uploader":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"ref":"refs/changes/99/813999/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/99/813999/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/1"}}},"commit":{"parents":[{"commit":"58a5b6b9af4aa8a1d96dd852b26a82eecdcbe707","subject":"Add support for [DEFAULT] mkisofs_cmd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/58a5b6b9af4aa8a1d96dd852b26a82eecdcbe707"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-05-08 16:58:32.000000000","tz":540},"committer":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2021-10-14 12:26:00.000000000","tz":330},"subject":"Libvirt: quote config parameters in resource types","message":"Libvirt: quote config parameters in resource types\n\nThis change implements the quote parameter in libvirtd_config and\nvirtlogd_config, so that we can quote the value by that simple\nparameter instead of implementing a logic in each manifests.\n\nAlso, with this change libvirtd_config and virtlogd_config supports\n$::os_service_default, so that we can define absence of parameters more\neasily.\n\nDepends-on: https://review.opendev.org/792735\nChange-Id: I3030ca34088019be932a9cc33344f7fb473a9aea\n(cherry picked from commit 26dbd52717f46a1be8586dd61a6f265f8fe56f11)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/f3a793a112ee0b5aea5116336231978c6f95261b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/f3a793a112ee0b5aea5116336231978c6f95261b"}]},"branch":"refs/heads/stable/wallaby"},"959c314c3ff97bad21489d0ced56175c1572c3dd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-10-14 12:44:53.000000000","uploader":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"ref":"refs/changes/99/813999/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/99/813999/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/99/813999/2"}}},"commit":{"parents":[{"commit":"58a5b6b9af4aa8a1d96dd852b26a82eecdcbe707","subject":"Add support for [DEFAULT] mkisofs_cmd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/58a5b6b9af4aa8a1d96dd852b26a82eecdcbe707"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-05-08 16:58:32.000000000","tz":540},"committer":{"name":"Rajesh Tailor","email":"ratailor@redhat.com","date":"2021-10-14 12:44:53.000000000","tz":0},"subject":"Libvirt: quote config parameters in resource types","message":"Libvirt: quote config parameters in resource types\n\nThis change implements the quote parameter in libvirtd_config and\nvirtlogd_config, so that we can quote the value by that simple\nparameter instead of implementing a logic in each manifests.\n\nAlso, with this change libvirtd_config and virtlogd_config supports\n$::os_service_default, so that we can define absence of parameters more\neasily.\n\nDepends-on: https://review.opendev.org/801477\nChange-Id: I3030ca34088019be932a9cc33344f7fb473a9aea\n(cherry picked from commit 26dbd52717f46a1be8586dd61a6f265f8fe56f11)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/959c314c3ff97bad21489d0ced56175c1572c3dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/959c314c3ff97bad21489d0ced56175c1572c3dd"}]},"branch":"refs/heads/stable/wallaby","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}