)]}'
{"id":"openstack%2Fpuppet-nova~816697","triplet_id":"openstack%2Fpuppet-nova~master~Ie1d6006020970ade3e1597dc9f68f9a5503283b4","project":"openstack/puppet-nova","branch":"master","topic":"os_package_type","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2021-11-08 12:01:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie1d6006020970ade3e1597dc9f68f9a5503283b4","subject":"Avoid usage of custom os_package_type fact","status":"MERGED","created":"2021-11-04 13:33:38.000000000","updated":"2021-11-08 12:01:00.000000000","submitted":"2021-11-08 12:01:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"816697-os_package_type","meta_rev_id":"0956af17ae782dfcde6a6cfc6709ac360bdf674b","_number":816697,"virtual_id_number":816697,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-11-08 12:00:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":2,"date":"2021-11-05 16:21:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2021-11-08 09:53:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2021-11-08 09:53:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-04 15:42:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-05 16:21:49.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-11-08 09:53:50.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"fa2bee287bed4e994439bd9107274b80a9fbdd49","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-04 13:33:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e72d50722bd458dad7d654ecc480d3693577f4f0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-04 15:42:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d87e74a5639b456593b5a8e9cd7ded6f : SUCCESS in 5m 57s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/716f14e59ae74e03acd6fbd720aa9cb5 : SUCCESS in 5m 31s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/43a8f2db8ff449aaa0fe11f02b85d079 : SUCCESS in 5m 36s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/dd0e228366624cac816ebba2a3aab483 : FAILURE in 22m 09s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/537786986699485ca4b3b478f7ed9dd5 : FAILURE in 24m 11s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/66036cadb16b4b6d8dc52db2aacd62d8 : FAILURE in 20m 28s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bb39386f44c84a60ae51794c5adeaf59 : FAILURE in 22m 24s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fc7bc138fe3943ce8e55dd09d2670687 : FAILURE in 20m 53s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3cc53df874ae474b9f3452e3e96b8cb4 : FAILURE in 1h 14m 21s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bf87c97dfbd64e8d966a10c4a871a352 : FAILURE in 1h 12m 28s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/afb205877b2b45c29c42fd1233c1a7df : FAILURE in 36m 58s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/996c3380acfc41bc9cacffee0b7747e1 : FAILURE in 25m 40s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/6c6e4ef5b2414358b08ede3503010865 : SUCCESS in 24m 58s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/cb3d99f72ed14da68447bed44edc9cc1 : SUCCESS in 1h 20m 36s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8ea93483fe4b45ed9678bf6c0b930d14 : SUCCESS in 1h 29m 25s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/14197758630847b7b9acad0713ea49d3 : SUCCESS in 1h 25m 37s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/dba3ebf4544e4cac98e1fdd9cdb8d6f2 : SUCCESS in 1h 06m 09s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c0214c9e1d134b36bb72c4519cfad3c0 : SUCCESS in 23m 54s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/a36c24f6c25e44958cd8ba16249dedda : SUCCESS in 32m 59s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/55c510a02dbe497297216062e3ebe046 : FAILURE in 20m 38s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5de03c81b3e14d6ab2f0c5a0b787c2d8 : SUCCESS in 25m 23s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/54dd5dfa7ea5467db2999fedcf6bd5ae : SUCCESS in 1h 54m 11s","accounts_in_message":[],"_revision_number":1},{"id":"5655309394de2a8421ff34c2abe227b5c11c81bd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-11-05 00:15:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bf72fc30963b74ce6fdb1f4a0e5b223af6ff37fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-05 01:59:44.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/41ba11104abb42379c7af22762905840 : SUCCESS in 3m 47s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b4a7c6420ef345b693b07af46f182493 : SUCCESS in 4m 54s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5cea0b3bd4be4e43b954e274776e58f7 : SUCCESS in 3m 31s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/bb1f556876904d2f8fc94fab9c7e1761 : SUCCESS in 20m 30s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/77b18fcc9ce9412b83d265f55e0d8b30 : SUCCESS in 20m 39s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/15efdb71ac3f423697494d1743779c65 : SUCCESS in 15m 06s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a385285f70db454993f04aab6d5d09db : SUCCESS in 19m 29s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5bf503aa689448c68ef372b56d1e39fa : SUCCESS in 17m 37s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ee088ee23cd745e5a176153066b1fec7 : FAILURE in 1h 10m 13s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a6150b9c4e234f51865779c546c93d8b : FAILURE in 35m 18s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1f53d8a11c2f4c03822ede13b074c826 : FAILURE in 30m 27s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/166da5357ebe474cb3c1344836dbf87e : FAILURE in 50m 56s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/5fa6f72da8ef45bca2fe02be304b1791 : SUCCESS in 23m 32s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/186ec6c0e0cf404fba3fc84e9495b165 : SUCCESS in 1h 14m 01s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/2be2021cdc024ec8850d5722014a8b0e : SUCCESS in 1h 12m 31s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/7b335ba3a05c4a2fb0b1362b318463cd : SUCCESS in 1h 10m 24s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b7595af1aade4823bebcf7ce27fd3754 : SUCCESS in 1h 03m 35s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7a6ba06c59694321907f5fd682d56e70 : FAILURE in 22m 11s (non-voting)\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/0b4d6d07147e4b2d924630f64de9e9ad : SUCCESS in 28m 01s\n- puppet-openstack-litmus-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/4cb7c06b17b8429caf1b729acce58525 : FAILURE in 17m 34s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/97b7df2cc8684a778b431e7da29d7d8a : FAILURE in 19m 41s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/cb6736b0c3bf48df884079f12b453007 : SUCCESS in 1h 41m 45s","accounts_in_message":[],"_revision_number":2},{"id":"7a5c172db25f613b0b7bfe80ffd9e0d0663433cb","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-11-05 16:21:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f4526eeff18a38f216f2a58513a824b94dbc0b1e","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-11-08 09:53:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d36a448abab81ff47c382c82dfd549f4fab954f9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 09:55:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a7e771de3fdb6c10f16fdeb5da40abc76f2aad6e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 12:00:59.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a482a79f5f5f4d0ba73f4b0b4e8b607b : SUCCESS in 4m 08s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/2f2c083e68554a178b2f8d16343cb3d7 : SUCCESS in 4m 00s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a1b7294453f848f3a0d80c34c30d3388 : SUCCESS in 4m 05s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/b0b1605135a1482495d56c1d176ddec7 : SUCCESS in 21m 13s\n- puppet-openstack-unit-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/a0a7fc467ae84ba4b5a2eec0bc4f3b77 : SUCCESS in 20m 17s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/dcd8c0d6f9c74732aae3309ffd3bf741 : SUCCESS in 17m 55s\n- puppet-openstack-unit-7.8-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6732e3c721ff461381ce68578d3d50fb : SUCCESS in 17m 26s\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/229b13003a3d4e809096747885083487 : SUCCESS in 1h 28m 51s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/6d6436786bca48409c77a9544c12a603 : SUCCESS in 1h 33m 22s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/d5b224492c9d477a96a47623e2a4b5fc : SUCCESS in 1h 22m 27s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a49727052d0d479c88b6d761b31e231d : SUCCESS in 1h 13m 49s\n- puppet-openstack-litmus-7.8-centos-8-stream https://zuul.opendev.org/t/openstack/build/a424e773f5e34a2f859a2351520abf67 : SUCCESS in 27m 20s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/09552ec88fd2437db15caccc7bf72fd9 : SUCCESS in 20m 55s (non-voting)\n- puppet-nova-tripleo-standalone https://zuul.opendev.org/t/openstack/build/ce50d048c24241bf8859075d34f98fae : SUCCESS in 2h 01m 39s","accounts_in_message":[],"_revision_number":2},{"id":"0956af17ae782dfcde6a6cfc6709ac360bdf674b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-08 12:01:00.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b553afc8ce82deb4c5306c96168ec05b056a2f2","revisions":{"de70729711393a609dc67b4ad74d5eba17dac186":{"kind":"REWORK","_number":1,"created":"2021-11-04 13:33:38.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/97/816697/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/97/816697/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/1"}}},"commit":{"parents":[{"commit":"76c5e9b955862772216590cd8a34c52215e7b4cc","subject":"Merge \"Bump puppetlabs-inifile\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/76c5e9b955862772216590cd8a34c52215e7b4cc"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:31:33.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:31:50.000000000","tz":540},"subject":"Avoid usage of custom os_package_type fact","message":"Avoid usage of custom os_package_type fact\n\nCurrently the os_package_type fact is used to distinguish Ubuntu and\nDebian but it\u0027s redundant and built-in $::operatingsystem should be\nenough. What is worse the custom fact is not injected while composing\nfacts data in unit tests and has never been tested properly.\n\nChange-Id: Ie1d6006020970ade3e1597dc9f68f9a5503283b4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/de70729711393a609dc67b4ad74d5eba17dac186"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/de70729711393a609dc67b4ad74d5eba17dac186"}]},"branch":"refs/heads/master"},"4b553afc8ce82deb4c5306c96168ec05b056a2f2":{"kind":"REWORK","_number":2,"created":"2021-11-05 00:15:31.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/97/816697/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/97/816697/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/97/816697/2"}}},"commit":{"parents":[{"commit":"76c5e9b955862772216590cd8a34c52215e7b4cc","subject":"Merge \"Bump puppetlabs-inifile\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/76c5e9b955862772216590cd8a34c52215e7b4cc"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-04 13:31:33.000000000","tz":540},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-11-05 00:15:22.000000000","tz":540},"subject":"Avoid usage of custom os_package_type fact","message":"Avoid usage of custom os_package_type fact\n\nCurrently the os_package_type fact is used to distinguish Ubuntu and\nDebian but it\u0027s redundant and built-in $::operatingsystem should be\nenough. What is worse the custom fact is not injected while composing\nfacts data in unit tests and has never been tested properly.\n\nChange-Id: Ie1d6006020970ade3e1597dc9f68f9a5503283b4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/4b553afc8ce82deb4c5306c96168ec05b056a2f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/4b553afc8ce82deb4c5306c96168ec05b056a2f2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}