)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"c32ff681feee0a74bdb394402b00309f65fade57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2959b29_e277bf5b","updated":"2021-11-15 14:43:15.000000000","message":"I\u0027m good with this change but please note that nova plans on defaulting to mkisofs soon [1]\n\nAlso, please add the cs9 hashtag to this change [2].\n\nThanks,\n\nDVD\n\n[1] https://review.opendev.org/c/openstack/nova/+/808921\n[2] https://review.opendev.org/q/hashtag:%22cs9%22+(status:open%20OR%20status:merged)","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"5bc9214f7ac284cdd7ba8ec3ff6ac9a6d38e0d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff4c2a13_915879b0","updated":"2021-11-15 16:23:54.000000000","message":"Testing it in cs9 in https://review.opendev.org/c/openstack/puppet-openstack-integration/+/793462/ ","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d52359e0fbd354449ec2a7eca9d59cba853e6327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30e7d8a9_b5523399","updated":"2021-11-15 19:23:35.000000000","message":"recheck","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"623c4a984f038222345094b503358b3cbfbf5edd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cea28b3e_323145f3","updated":"2021-11-17 08:35:42.000000000","message":"recheck","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e4e6c22ee07a47a31ee9d193bb66b77fb77e6d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"66fd4822_6c2bf081","in_reply_to":"e2959b29_e277bf5b","updated":"2021-11-15 15:17:19.000000000","message":"TBH it\u0027s not yet clear how long it takes until that can be merged. Also, the change updates the default, which is unlikely to be backportable.\n\nWe can revisit this implementation later before we officially mark CentOS9 as a supported OS. If any fix is implemented in nova(which is the most ideal solution) then we can revert this change at that time.","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"}],"manifests/compute.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4f918f52cc4725fa45fc5f3b334e627646b6267f","unresolved":true,"context_lines":[{"line_number":321,"context_line":"  $virtio_nic                                  \u003d false,"},{"line_number":322,"context_line":"  $instance_usage_audit                        \u003d false,"},{"line_number":323,"context_line":"  $instance_usage_audit_period                 \u003d \u0027month\u0027,"},{"line_number":324,"context_line":"  $mkisofs_cmd                                 \u003d $::nova::params::mkisofs_cmd,"},{"line_number":325,"context_line":"  $use_cow_images                              \u003d $::os_service_default,"},{"line_number":326,"context_line":"  $force_raw_images                            \u003d $::os_service_default,"},{"line_number":327,"context_line":"  $virt_mkfs                                   \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"44b1c6ca_a616ac73","line":324,"range":{"start_line":324,"start_character":66,"end_line":324,"end_character":77},"updated":"2021-11-15 14:25:12.000000000","message":"If you intend to backport this change then you should avoid updating the default in the distros expect for CentOS9. Otherwise backporting this change updates nova.conf which triggers restarting services.","commit_id":"b0e14101aaf2c6bd7adfb3ff00b9fec1d0a3d37e"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ba9b71b9aca1930fc849ea9094011347028a2fca","unresolved":true,"context_lines":[{"line_number":61,"context_line":"      $nova_group                        \u003d \u0027nova\u0027"},{"line_number":62,"context_line":"      if $::operatingsystemmajrelease \u003e\u003d \u00279\u0027 {"},{"line_number":63,"context_line":"        $mkisofs_package_name            \u003d \u0027xorriso\u0027"},{"line_number":64,"context_line":"        $mkisofs_cmd                     \u003d \u0027mkisofs\u0027"},{"line_number":65,"context_line":"      } else {"},{"line_number":66,"context_line":"        $mkisofs_package_name            \u003d \u0027genisoimage\u0027"},{"line_number":67,"context_line":"        $mkisofs_cmd                     \u003d false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e247d109_9a3648ff","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":20},"updated":"2021-11-15 14:40:03.000000000","message":"might be better to name this as mkisofs_cmd_override ?","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e90636f17bb458f20cc674e190a688c92bb2842c","unresolved":true,"context_lines":[{"line_number":61,"context_line":"      $nova_group                        \u003d \u0027nova\u0027"},{"line_number":62,"context_line":"      if $::operatingsystemmajrelease \u003e\u003d \u00279\u0027 {"},{"line_number":63,"context_line":"        $mkisofs_package_name            \u003d \u0027xorriso\u0027"},{"line_number":64,"context_line":"        $mkisofs_cmd                     \u003d \u0027mkisofs\u0027"},{"line_number":65,"context_line":"      } else {"},{"line_number":66,"context_line":"        $mkisofs_package_name            \u003d \u0027genisoimage\u0027"},{"line_number":67,"context_line":"        $mkisofs_cmd                     \u003d false"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bb262f7d_80ffb938","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":20},"in_reply_to":"e247d109_9a3648ff","updated":"2021-11-17 14:51:20.000000000","message":"it\u0027s not really an override. i think this is fine","commit_id":"39d206911997c4208baae6f2220e7756fdb985c7"}]}
