)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10843d04d31f0f981db646351f45a2b3e15f7848","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The current way things were setup, it was impossible to correctly"},{"line_number":10,"context_line":"call nova::migration::libvirt to setup live migration over TLS."},{"line_number":11,"context_line":"Indeed, one has to call ::nova::compute::libvirt to set the"},{"line_number":12,"context_line":"::nova::compute::libvirt::libvirt_service_name paramenter, however"},{"line_number":13,"context_line":"this class has an include nova::migration::libvirt, which then"},{"line_number":14,"context_line":"prevents calling ::nova::compute::libvirt with custom parameters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also, libvirtd is hard-coded in a few places in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6cde291c_d21b4e0b","line":13,"range":{"start_line":12,"start_character":59,"end_line":13,"end_character":50},"updated":"2021-12-06 12:05:23.000000000","message":"You can disable this by setting migration_support. Does the following example meet your requirement ?\n\n```\nclass { \u0027nova::compute::libvirt\u0027:\n  migration_support \u003d\u003e false,\n  ...\n}\n\nclass { \u0027nova::migration::libvirt\u0027:\n  transport \u003d\u003e \u0027tls\u0027,\n  ...\n}\n```","commit_id":"60de082e8addd592cd5f1a1de25be6a5bf4003e0"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"edd23d127b8d3fe2934d2d07797b01ec35b25124","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The current way things were setup, it was impossible to correctly"},{"line_number":10,"context_line":"call nova::migration::libvirt to setup live migration over TLS."},{"line_number":11,"context_line":"Indeed, one has to call ::nova::compute::libvirt to set the"},{"line_number":12,"context_line":"::nova::compute::libvirt::libvirt_service_name paramenter, however"},{"line_number":13,"context_line":"this class has an include nova::migration::libvirt, which then"},{"line_number":14,"context_line":"prevents calling ::nova::compute::libvirt with custom parameters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also, libvirtd is hard-coded in a few places in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b4024a8e_bd30c501","line":13,"range":{"start_line":12,"start_character":59,"end_line":13,"end_character":50},"in_reply_to":"6cde291c_d21b4e0b","updated":"2021-12-09 10:30:44.000000000","message":"Does this still get live migration working? Setting migration_support \u003d\u003e false feels like counter-intuitive...","commit_id":"60de082e8addd592cd5f1a1de25be6a5bf4003e0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13856921a11539521168c7eeca6efb465928f827","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The current way things were setup, it was impossible to correctly"},{"line_number":10,"context_line":"call nova::migration::libvirt to setup live migration over TLS."},{"line_number":11,"context_line":"Indeed, one has to call ::nova::compute::libvirt to set the"},{"line_number":12,"context_line":"::nova::compute::libvirt::libvirt_service_name paramenter, however"},{"line_number":13,"context_line":"this class has an include nova::migration::libvirt, which then"},{"line_number":14,"context_line":"prevents calling ::nova::compute::libvirt with custom parameters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Also, libvirtd is hard-coded in a few places in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0b5e04fc_71bb6b5d","line":13,"range":{"start_line":12,"start_character":59,"end_line":13,"end_character":50},"in_reply_to":"b4024a8e_bd30c501","updated":"2021-12-09 15:26:26.000000000","message":"If migration_support is set to false then the nova::migration::libvirt class is not automatically included. Then you can separately include the nova::migration::libvirt class after that with customizing the other parameters.","commit_id":"60de082e8addd592cd5f1a1de25be6a5bf4003e0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13856921a11539521168c7eeca6efb465928f827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"36c02344_e0f6247b","updated":"2021-12-09 15:26:26.000000000","message":"Anyway we already hard-coded the service name and I don\u0027t think users are likely to use customized service names. They might want to disable some services by setting service name parameters to undef(or false) but even that doesn\u0027t work with current usage, and that issue is fixed by this change.","commit_id":"60de082e8addd592cd5f1a1de25be6a5bf4003e0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"10843d04d31f0f981db646351f45a2b3e15f7848","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22109b09_bdfc0edd","updated":"2021-12-06 12:05:23.000000000","message":"Just leaving one potential solution of the fix, though I agree with switching to hardcoded filename.","commit_id":"60de082e8addd592cd5f1a1de25be6a5bf4003e0"}]}