)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"108302c06644c76592200653a7a9242773879dee","unresolved":true,"context_lines":[{"line_number":10,"context_line":"nodes while some parameters in the same section like catalog_info is"},{"line_number":11,"context_line":"used by both controller nodes and compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change makes all credential parameters unset if the password is"},{"line_number":14,"context_line":"given. If the parameters are intentionally set the provided values are"},{"line_number":15,"context_line":"honored."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8f797c6f_bc3d2a56","line":13,"range":{"start_line":13,"start_character":50,"end_line":13,"end_character":52},"updated":"2022-01-13 14:40:14.000000000","message":"Did you mean \"unless\" (not \"if\")?","commit_id":"27a54b03223f558e3d1e12c27b68996cb7e2f63e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"05ec7ce3090aa1a0578fa10eddaa48e2cf7934b9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"nodes while some parameters in the same section like catalog_info is"},{"line_number":11,"context_line":"used by both controller nodes and compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change makes all credential parameters unset if the password is"},{"line_number":14,"context_line":"given. If the parameters are intentionally set the provided values are"},{"line_number":15,"context_line":"honored."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f4750723_766ecb67","line":13,"range":{"start_line":13,"start_character":50,"end_line":13,"end_character":52},"in_reply_to":"8f797c6f_bc3d2a56","updated":"2022-01-13 15:13:59.000000000","message":"Done.","commit_id":"27a54b03223f558e3d1e12c27b68996cb7e2f63e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0211cc08dd52d9816d442c25afca646661387fb3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"nodes while some parameters in the same section like catalog_info is"},{"line_number":11,"context_line":"used by both controller nodes and compute nodes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change makes all credential parameters unset if the password is"},{"line_number":14,"context_line":"given. If the parameters are intentionally set the provided values are"},{"line_number":15,"context_line":"honored."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ec4be968_71d85116","line":13,"range":{"start_line":13,"start_character":50,"end_line":13,"end_character":52},"in_reply_to":"f4750723_766ecb67","updated":"2022-01-13 15:14:19.000000000","message":"Done","commit_id":"27a54b03223f558e3d1e12c27b68996cb7e2f63e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"108302c06644c76592200653a7a9242773879dee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f9ee681a_d8460308","updated":"2022-01-13 14:40:14.000000000","message":"I\u0027m not sure I see a \"big win\" with this change, and wonder if this could break deployments that are not using auth_type\u003d\u003dpassword, but rely on the other existing defaults.\n","commit_id":"27a54b03223f558e3d1e12c27b68996cb7e2f63e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"05ec7ce3090aa1a0578fa10eddaa48e2cf7934b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ecf707b2_359a80dd","in_reply_to":"f9ee681a_d8460308","updated":"2022-01-13 15:13:59.000000000","message":"The reason I came up with this is that in TripleO we include nova::cinder in the base nova manifest and because of that we have [cinder]project_name\u003dservices which does not align with the service project we use. These parameters are unused thus doesn\u0027t affect the behavior but IMO we should avoid leaving unamanged/unused parameters to avoid confusion or any unexpected issue caused by a future change.\n\nConsidering the effect on existin deployments, we generally use password authentication which requires the password parameter, so I believe this rarely would break any existing deployment. The auth_section might be another popular option but that doesn\u0027t require these credential parameters thus this change doesn\u0027t break it. Even if any of these parameters are needed, we allow users to override some parameters forcefully as a workaround.","commit_id":"27a54b03223f558e3d1e12c27b68996cb7e2f63e"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9dcc520b36a87792096695c7f4df35550c380961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"232072e1_d3078169","updated":"2022-01-20 08:45:58.000000000","message":"Should we really unset the \"services\" project_name? This is the default spanning all Puppet modules but IIRC the actual default for this config opt is usually \"service\" which means this could be a breaking change if somebody doesn\u0027t set this explicitly.\n\nI know that we for example assume the Puppet layer will set project_name\u003dservices and don\u0027t set it ourselves.","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"88c78695241a45e5562076e534571e4077564d98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3794277e_fd5f0df8","updated":"2022-01-28 08:02:13.000000000","message":"Thanks for clearing it up for me, now I\u0027m understanding that it won\u0027t change the defaults.","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6f776861a066ba332a42fafcd847c64848b2cfef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"17afd833_72cb1a9d","updated":"2022-01-18 23:08:34.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"482e737d56186386e0b46fde3a60fc7e9d573c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42fbab6d_71ae5101","updated":"2022-01-15 12:18:15.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"37dbbe58ff08c4e3ecaf56f8f2f5188bd5a90a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8e7371da_46286b03","updated":"2022-01-31 09:22:00.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"485752e96093d815eea554795f9dbb1b7c38b57d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f6ac599_c0c3f595","updated":"2022-01-19 14:07:50.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"97d9792a8694645b456a6970f4340789eeb2824f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9aca2e6a_cc8bd99e","updated":"2022-02-01 02:02:26.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9137c9d1b0d92dcb62f0272e68267d0564919cdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dbb84442_aaca9ee1","updated":"2022-01-29 06:54:57.000000000","message":"recheck","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"09ccce89cb90182f28bcaa2ade586a6881d43dc9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"776bd4b1_73dc9558","in_reply_to":"232072e1_d3078169","updated":"2022-01-20 09:08:44.000000000","message":"The parameters like project_name can not be used unless the password is set. So setting these defaults without the password parameter has no effect.\n\nThe existing defaults (and the new default of auth_url) are populated when user gives the password parameter which is required to set up the credential. If the password parameter is not set then these parameters are not used, thus removing these defaults doesn\u0027t break anything.\n\nWe usually don\u0027t do this because we expect the credential is required when the class is loaded. However for this specific class we have a clear use case where the class is included but the credential is unnecessary, which I described in the commit message, and this allows such use case to work without unused parameters configured.","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"704a32943ebdd8659af822c391fa0786a6f00e95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d20b0bb9_e775c59d","in_reply_to":"776bd4b1_73dc9558","updated":"2022-01-27 19:00:14.000000000","message":"So if I understand it correctly, you are intending to do that is password is set the current defaults is still there?","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"da6d217692339acb5ae9d5d3f9cec1af5a41d1cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"69144c7e_d85ae204","in_reply_to":"d20b0bb9_e775c59d","updated":"2022-01-28 00:04:11.000000000","message":"Yes. I hope these test cases would explain that more clearly.\n\nwhen password is not set\n https://review.opendev.org/c/openstack/puppet-nova/+/824393/5/spec/classes/nova_cinder_spec.rb#6\n\nwhen password is set.\n　https://review.opendev.org/c/openstack/puppet-nova/+/824393/5/spec/classes/nova_cinder_spec.rb#23","commit_id":"65eea0d9c5a7ee2eb21e86fdfd71f57d652181d8"}],"manifests/cinder.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"495c0ea51a8e35a5a090dd5e8a283a0e1598f932","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    $auth_url_real            \u003d pick($auth_url, $::os_service_default)"},{"line_number":93,"context_line":"    $project_name_real        \u003d pick($project_name, $::os_service_default)"},{"line_number":94,"context_line":"    $project_domain_name_real \u003d pick($project_domain_name, $::os_service_default)"},{"line_number":95,"context_line":"    $user_name_real           \u003d pick($username, $::os_service_default)"},{"line_number":96,"context_line":"    $user_domain_name_real    \u003d pick($user_domain_name, $::os_service_default)"},{"line_number":97,"context_line":"  } else {"},{"line_number":98,"context_line":"    $auth_type_real           \u003d pick($auth_type, \u0027password\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"be611c92_dfa256c2","line":95,"range":{"start_line":95,"start_character":5,"end_line":95,"end_character":19},"updated":"2022-01-12 12:53:00.000000000","message":"username_real","commit_id":"7af333e676e17815f86a98a48fbeba7ff199362d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"495c0ea51a8e35a5a090dd5e8a283a0e1598f932","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    $auth_url_real            \u003d pick($auth_url, \u0027http://127.0.0.1:5000/\u0027)"},{"line_number":100,"context_line":"    $project_name_real        \u003d pick($project_name, \u0027services\u0027)"},{"line_number":101,"context_line":"    $project_domain_name_real \u003d pick($project_domain_name, \u0027Default\u0027)"},{"line_number":102,"context_line":"    $user_name_real           \u003d pick($username, \u0027cinder\u0027)"},{"line_number":103,"context_line":"    $user_domain_name_real    \u003d pick($user_domain_name, \u0027Default\u0027)"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4dcaf76e_b19c196d","line":102,"range":{"start_line":102,"start_character":5,"end_line":102,"end_character":19},"updated":"2022-01-12 12:53:00.000000000","message":"ditto","commit_id":"7af333e676e17815f86a98a48fbeba7ff199362d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"20e926dedb99a7f8035971c2746d94db5843da9a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   (optional) Points to the OpenStack Identity server IP and port."},{"line_number":18,"context_line":"#   This is the Identity (keystone) admin API server IP and port value,"},{"line_number":19,"context_line":"#   and not the Identity service API IP and port."},{"line_number":20,"context_line":"#   Defaults to $::os_service_default"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*timeout*]"},{"line_number":23,"context_line":"#   (optional) Timeout value for connecting to cinder in seconds."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"356ef69e_8b72c11d","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":37},"updated":"2022-01-12 12:54:11.000000000","message":"this should be updated.","commit_id":"3e18891d94276c506fc3fc16872e4791c511e92d"}]}