)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01114c85996344830826736d80dc171dfffed53a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56f7a923_b6aa26e7","updated":"2022-08-29 13:59:21.000000000","message":"I\u0027ll take another look later but the overall implementation looks good to me. A few conf files provided by CentOS packages do not include the options so we better check whether these are really supported.","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"85a1c64bf5ba2223607d6038e331ac5ddced9257","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7259011a_d08b1c74","updated":"2022-08-29 15:04:56.000000000","message":"I\u0027m not a libvirt export but the commit which added the max_client_requets parameter mainly touch files in the qemu directory and this indicates the parameter is related to the interaction between libvirt and qemu.\n https://github.com/libvirt/libvirt/commit/f61341173bdaa2e0f4d0bc5b8c10900d48ca5646\n\nIf that is true then it is reasonable that these parameters are not supported by virtlockd and virtlogd.","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6c915b33f034c33f1840734dfc38d9f1fe5bd6f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ce0e436_0cad39a3","updated":"2022-08-29 15:11:44.000000000","message":"thanks!","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d587e9e6f76b61639f4a111468803077b4c3018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db8173c6_6c8c5fb8","updated":"2022-08-30 16:26:16.000000000","message":"LGTM. Just 2 nits which would not block this change.","commit_id":"de886cd1dda892aa74ebeae00e0d17d391862f86"}],"manifests/compute/libvirt/libvirtd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d587e9e6f76b61639f4a111468803077b4c3018","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  libvirtd_config {"},{"line_number":71,"context_line":"    \u0027log_level\u0027:                 value \u003d\u003e $log_level;"},{"line_number":72,"context_line":"    \u0027log_filters\u0027:               value \u003d\u003e $log_filters_real, quote  \u003d\u003e true;"},{"line_number":73,"context_line":"    \u0027log_outputs\u0027:               value \u003d\u003e $log_outputs_real, quote  \u003d\u003e true;"},{"line_number":74,"context_line":"    \u0027max_clients\u0027:               value \u003d\u003e $max_clients;"},{"line_number":75,"context_line":"    \u0027admin_max_clients\u0027:         value \u003d\u003e $admin_max_clients;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7d09c650_28815aa1","line":72,"range":{"start_line":72,"start_character":67,"end_line":72,"end_character":68},"updated":"2022-08-30 16:26:16.000000000","message":"nit: this is not needed","commit_id":"de886cd1dda892aa74ebeae00e0d17d391862f86"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d587e9e6f76b61639f4a111468803077b4c3018","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  libvirtd_config {"},{"line_number":71,"context_line":"    \u0027log_level\u0027:                 value \u003d\u003e $log_level;"},{"line_number":72,"context_line":"    \u0027log_filters\u0027:               value \u003d\u003e $log_filters_real, quote  \u003d\u003e true;"},{"line_number":73,"context_line":"    \u0027log_outputs\u0027:               value \u003d\u003e $log_outputs_real, quote  \u003d\u003e true;"},{"line_number":74,"context_line":"    \u0027max_clients\u0027:               value \u003d\u003e $max_clients;"},{"line_number":75,"context_line":"    \u0027admin_max_clients\u0027:         value \u003d\u003e $admin_max_clients;"},{"line_number":76,"context_line":"    \u0027max_client_requests\u0027:       value \u003d\u003e $max_client_requests;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1c271b63_cd2196cc","line":73,"range":{"start_line":73,"start_character":67,"end_line":73,"end_character":68},"updated":"2022-08-30 16:26:16.000000000","message":"nit: ditto","commit_id":"de886cd1dda892aa74ebeae00e0d17d391862f86"}],"manifests/compute/libvirt/virtlockd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01114c85996344830826736d80dc171dfffed53a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"#   on administrative socket."},{"line_number":29,"context_line":"#   Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*max_client_requests*]"},{"line_number":32,"context_line":"#   Limit on concurrent requests from a single client connection."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*admin_max_client_requests*]"},{"line_number":36,"context_line":"#   Limit on concurrent requests from a single client connection"},{"line_number":37,"context_line":"#   for the admin interface."},{"line_number":38,"context_line":"#   Defaults to $::os_service_default"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*max_size*]"},{"line_number":41,"context_line":"#   Maximum file size before rolling over."},{"line_number":42,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e1bee901_938a89f6","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":1},"updated":"2022-08-29 13:59:21.000000000","message":"these are not listed in virtlockd.conf\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a70/854880/1/check/puppet-openstack-integration-7-scenario001-tempest-centos-9-stream/a70da7b/logs/etc/libvirt/virtlockd.conf.txt","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6c915b33f034c33f1840734dfc38d9f1fe5bd6f0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   on administrative socket."},{"line_number":29,"context_line":"#   Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*max_client_requests*]"},{"line_number":32,"context_line":"#   Limit on concurrent requests from a single client connection."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*admin_max_client_requests*]"},{"line_number":36,"context_line":"#   Limit on concurrent requests from a single client connection"},{"line_number":37,"context_line":"#   for the admin interface."},{"line_number":38,"context_line":"#   Defaults to $::os_service_default"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*max_size*]"},{"line_number":41,"context_line":"#   Maximum file size before rolling over."},{"line_number":42,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"022b7d20_df08be4f","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":1},"in_reply_to":"e1bee901_938a89f6","updated":"2022-08-29 15:11:44.000000000","message":"Done","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"}],"manifests/compute/libvirt/virtlogd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"01114c85996344830826736d80dc171dfffed53a","unresolved":true,"context_lines":[{"line_number":28,"context_line":"#   on administrative socket."},{"line_number":29,"context_line":"#   Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*max_client_requests*]"},{"line_number":32,"context_line":"#   Limit on concurrent requests from a single client connection."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*admin_max_client_requests*]"},{"line_number":36,"context_line":"#   Limit on concurrent requests from a single client connection"},{"line_number":37,"context_line":"#   for the admin interface."},{"line_number":38,"context_line":"#   Defaults to $::os_service_default"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*max_size*]"},{"line_number":41,"context_line":"#   Maximum file size before rolling over."},{"line_number":42,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dd899f89_c3c4d20f","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":1},"updated":"2022-08-29 13:59:21.000000000","message":"these are not listed in virtlogd.conf\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a70/854880/1/check/puppet-openstack-integration-7-scenario001-tempest-centos-9-stream/a70da7b/logs/etc/libvirt/virtlogd.conf.txt","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6c915b33f034c33f1840734dfc38d9f1fe5bd6f0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#   on administrative socket."},{"line_number":29,"context_line":"#   Defaults to $::os_service_default"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*max_client_requests*]"},{"line_number":32,"context_line":"#   Limit on concurrent requests from a single client connection."},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*admin_max_client_requests*]"},{"line_number":36,"context_line":"#   Limit on concurrent requests from a single client connection"},{"line_number":37,"context_line":"#   for the admin interface."},{"line_number":38,"context_line":"#   Defaults to $::os_service_default"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*max_size*]"},{"line_number":41,"context_line":"#   Maximum file size before rolling over."},{"line_number":42,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4397511a_5bdf91ca","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":1},"in_reply_to":"dd899f89_c3c4d20f","updated":"2022-08-29 15:11:44.000000000","message":"Done","commit_id":"6007b6d1c5ccba27498194799bb9d229e5f223e3"}]}