)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"434b2e0720301fdf6cba03458dad2150130d0436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d819dbf_acb47227","updated":"2023-03-08 16:15:40.000000000","message":"PTAL","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59f549f5d5dad633f5d2ca96c190fb4183e8ee84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14c0363f_71331f86","in_reply_to":"4d819dbf_acb47227","updated":"2023-03-09 13:33:43.000000000","message":"keep in mind that our review bw is not really high, because of limited number of core reviewers and no one else has provided continuous attention to be nominated as a core. Our review is quite best-effort thing atm.","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"}],"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c2f877a4dcc987dddde5990ba34e415d201bf1d","unresolved":true,"context_lines":[{"line_number":239,"context_line":"  }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"  if $instance_name_template !\u003d undef {"},{"line_number":242,"context_line":"    warning(\"The nova::api::instance_name_template parameter is deprecated. \\"},{"line_number":243,"context_line":"Use the nova::instance_name_template parameter instead.\")"},{"line_number":244,"context_line":"    nova_config {"},{"line_number":245,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"042930e2_a614fb0d","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":74},"updated":"2023-03-07 13:58:07.000000000","message":"we probably should not deprecate the parameter in stable branches but keep it valid. we can add the warning to inform that using this parameter results in incomplete settings in case nova-compute is running in a different node.","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6bc30b3a804793d9a722a6e309374ac5fe94baff","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"  if $instance_name_template !\u003d undef {"},{"line_number":242,"context_line":"    warning(\"The nova::api::instance_name_template parameter is deprecated. \\"},{"line_number":243,"context_line":"Use the nova::instance_name_template parameter instead.\")"},{"line_number":244,"context_line":"    nova_config {"},{"line_number":245,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3cfd7129_8c146d86","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":74},"in_reply_to":"042930e2_a614fb0d","updated":"2023-03-09 13:28:09.000000000","message":"Am going to solve that for Wallaby backport","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"59f549f5d5dad633f5d2ca96c190fb4183e8ee84","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"  if $instance_name_template !\u003d undef {"},{"line_number":242,"context_line":"    warning(\"The nova::api::instance_name_template parameter is deprecated. \\"},{"line_number":243,"context_line":"Use the nova::instance_name_template parameter instead.\")"},{"line_number":244,"context_line":"    nova_config {"},{"line_number":245,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"645c2353_d062b4d0","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":74},"in_reply_to":"3cfd7129_8c146d86","updated":"2023-03-09 13:33:43.000000000","message":"If we agree with merging the current version then you don\u0027t have to adjust it in wallaby backport","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e45729240f794093a2f2a3b0d199006dbf549a74","unresolved":false,"context_lines":[{"line_number":239,"context_line":"  }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"  if $instance_name_template !\u003d undef {"},{"line_number":242,"context_line":"    warning(\"The nova::api::instance_name_template parameter is deprecated. \\"},{"line_number":243,"context_line":"Use the nova::instance_name_template parameter instead.\")"},{"line_number":244,"context_line":"    nova_config {"},{"line_number":245,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2205d321_aae5c8fa","line":242,"range":{"start_line":242,"start_character":64,"end_line":242,"end_character":74},"in_reply_to":"645c2353_d062b4d0","updated":"2023-03-10 12:29:45.000000000","message":"LGTM, thanks for aligning this with my W backport","commit_id":"819c704c2dadbc761d8af8bcb25c83038ad1ad0c"}]}