)]}'
{"id":"openstack%2Fpuppet-nova~885730","triplet_id":"openstack%2Fpuppet-nova~stable%2Fzed~I0ace8e21815ccf18196eb0ba6055bc9e64abacac","project":"openstack/puppet-nova","branch":"stable/zed","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2023-06-09 11:42:16.000000000","reason":"Change was abandoned"},"16137":{"account":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"last_update":"2023-06-09 11:26:15.000000000","reason":"\u003cGERRIT_ACCOUNT_16137\u003e replied on the change","reason_account":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"}}},"hashtags":[],"change_id":"I0ace8e21815ccf18196eb0ba6055bc9e64abacac","subject":"Add manage_service to nova::migration::libvirt","status":"ABANDONED","created":"2023-06-09 08:50:24.000000000","updated":"2023-06-09 11:42:16.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"8c80754e9df08b27815c936bb76dd23e8902ce4e","_number":885730,"virtual_id_number":885730,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-06-09 10:20:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-09 09:06:07.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"},{"updated":"2023-06-09 10:20:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bf2618bca19890ad3ea621703eadaaac9c9af6fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2023-06-09 08:50:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"26ef9bc7b475cd201d83f33376a30f88c9d6c297","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2023-06-09 09:06:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0f49e5126dce2c8818cdd111fa80f76cf75f13ed","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-09 10:20:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6f57fa8776304cffb716608f60afc5cc\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3fa4315b90184ed088b11c02328cec10 : SUCCESS in 3m 33s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7fd630e3758f493b9557433615d3a47d : SUCCESS in 3m 33s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/530ac41d272b4eb2a6d3e084751e60f8 : SUCCESS in 3m 05s\n- puppet-openstack-unit-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/b7964715858b42e99facb847f1550434 : SUCCESS in 16m 05s\n- puppet-openstack-unit-6.28-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f0e0314264eb456f9042fabba91d9ac8 : SUCCESS in 16m 55s\n- puppet-openstack-unit-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/11db0156c59a4d78ac00a5df8d8665c5 : SUCCESS in 14m 31s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5166048da0214fb39c5ee864abe79146 : SUCCESS in 16m 26s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/fbe0aaa88c5b48cc9f1b53328f46f20e : FAILURE in 19m 36s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7ed67c6489184a10821a10bd01590ec0 : FAILURE in 15m 13s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b50c2ed542c547a3b7462677dbc43a2f : FAILURE in 16m 03s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a0543f76b8fb49aa8f262e361ab2d8bf : FAILURE in 17m 25s (non-voting)\n- puppet-openstack-integration-6-scenario005-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f9990f4c6ec9493a9ecaa065a4657956 : FAILURE in 13m 59s (non-voting)\n- puppet-openstack-integration-7-scenario000-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/a14f691b90524d8b9c3de630d469ae80 : SUCCESS in 20m 13s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/074964c6aa834072bc6d59917426cef0 : SUCCESS in 1h 02m 47s\n- puppet-openstack-integration-7-scenario002-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/0b9411239af144bda740f3649fb9f5bf : SUCCESS in 1h 22m 19s\n- puppet-openstack-integration-7-scenario003-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/2a15aa355f944ac7a725eee5f6f91a62 : SUCCESS in 1h 04m 55s\n- puppet-openstack-integration-7-scenario004-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/a7a6aecfc58d465aa84d09279cd320c6 : SUCCESS in 57m 16s\n- puppet-openstack-integration-7-scenario005-tempest-centos-9-stream https://zuul.opendev.org/t/openstack/build/dabcd47358a84c738485a5890c597864 : SUCCESS in 51m 24s\n- puppet-openstack-litmus-6.28-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d7d9dac09019417e887ae6f594e8961b : FAILURE in 12m 30s (non-voting)\n- puppet-openstack-litmus-7.16-centos-9-stream https://zuul.opendev.org/t/openstack/build/7d5e7f40d5784564afb25305a7831f11 : SUCCESS in 25m 28s\n- puppet-openstack-litmus-7.16-ubuntu-focal https://zuul.opendev.org/t/openstack/build/4fb28b50d45e43a2b2590227f49b77ae : FAILURE in 31m 40s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/851a1bbc9f064e87b28e884c61d1db28 : FAILURE in 34m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0c7beddbf8c168bd8e49e29ad67ce67f1623fe50","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2023-06-09 11:26:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8c80754e9df08b27815c936bb76dd23e8902ce4e","tag":"autogenerated:gerrit:abandon","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2023-06-09 11:42:16.000000000","message":"Abandoned\n\nabandon in favor of backporting","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3d24e699a2906f94579b2e6253194fe2bea6868f","revisions":{"3d24e699a2906f94579b2e6253194fe2bea6868f":{"kind":"REWORK","_number":1,"created":"2023-06-09 08:50:24.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/30/885730/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-nova","ref":"refs/changes/30/885730/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/30/885730/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/30/885730/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-nova refs/changes/30/885730/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-nova refs/changes/30/885730/1"}}},"commit":{"parents":[{"commit":"b518ec5f9d4f963ade725bdcd621a75d2f817b39","subject":"Dont log output when setting virsh secret","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/b518ec5f9d4f963ade725bdcd621a75d2f817b39"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.com","date":"2023-06-09 08:36:27.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.com","date":"2023-06-09 08:36:27.000000000","tz":120},"subject":"Add manage_service to nova::migration::libvirt","message":"Add manage_service to nova::migration::libvirt\n\nIf you want to use modular libvirt with older versions such\nas Zed and Yoga the Puppet layer that handles the\n\u003cdaemon\u003e-\u003ctransport\u003e.socket service is not handled when\nusing nova::compute::libvirt::services class directly and\nsetting modular_libvirt to true which requires you to set\nthe nova::compute::libvirt::manage_libvirt_services parameter to\nfalse for the class to not be included.\n\nThe \u003cdaemon\u003e-\u003ctransport\u003e.socket service depends on the\nmanage_libvirt_services from the nova::compute::libvirt class to\nbe true in order for it to work.\n\nThis adds the same manage_service parameter to the\nnova::migration::libvirt class that is available in newer\nversions but with a undef default value and since it uses\npick() for that value we keep backward compatibility.\n\nChange-Id: I0ace8e21815ccf18196eb0ba6055bc9e64abacac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/3d24e699a2906f94579b2e6253194fe2bea6868f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-nova/commit/3d24e699a2906f94579b2e6253194fe2bea6868f"}]},"branch":"refs/heads/stable/zed"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}