)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0d382628293ef02785d6d1889cf0d39177320c17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64991c0b_e6546d04","updated":"2023-06-15 18:16:29.000000000","message":"since the class inherits params i\u0027d rather see we just set the default value for the parameter to that instead of doing pick()","commit_id":"056ae4821154109f98a9cd80d38f8ed3886dad77"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"1ce3726dfbfc49bf8f1573939732de4de96d53e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e59e52c6_3f310f1e","in_reply_to":"64991c0b_e6546d04","updated":"2023-06-15 20:11:28.000000000","message":"hm, I\u0027m not happy at all with inheritance, I think we should remove them (which will be done with hiera anyway).\nSo I agree, that the change will be simpler.","commit_id":"056ae4821154109f98a9cd80d38f8ed3886dad77"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4fa6a4499f0487dd88ea50c6a9c309d40e183afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fee0ab31_9c008625","updated":"2023-06-21 08:47:55.000000000","message":"I dont really understand this use-case since we do python version based on OS version but it still follows a standard way Puppet modules usually allow overrides just that we don\u0027t do this consistently.\n\nI will let Takashi decide on this but I\u0027m fine with it.","commit_id":"a3bdabe0fd90c713a19083bfbcf5e0786a40c56f"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"523b6f46508c640997d9f462344589fdcc6fff35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7125960_19b1d49b","updated":"2023-06-19 21:30:44.000000000","message":"recheck","commit_id":"a3bdabe0fd90c713a19083bfbcf5e0786a40c56f"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"a592069c2aa27b468c6230e89045615c983ec77f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a3cbeea_969cb3bf","updated":"2023-06-17 15:18:39.000000000","message":"recheck timeout","commit_id":"a3bdabe0fd90c713a19083bfbcf5e0786a40c56f"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"c5d9b99d58da6878b01830daa724622a64f763f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9aa88ecb_b33b7a23","in_reply_to":"fee0ab31_9c008625","updated":"2023-06-21 09:13:39.000000000","message":"in debian, package names are different for python 2 and 3.","commit_id":"a3bdabe0fd90c713a19083bfbcf5e0786a40c56f"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"256b04f3f35bae564fc39401b4eb49c2417108ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4e8d743b_47df388e","updated":"2025-08-25 09:38:31.000000000","message":"The patch is incomplete as it doesn\u0027t update the common package name in the manifest. I understand that we could introduce this as it\u0027s a common pattern to be able to override the package name, but I don\u0027t understand the Python 2 argument as that hasn\u0027t been a things in year and was removed with [1].\n\n[1] https://review.opendev.org/c/openstack/puppet-nova/+/792566","commit_id":"060d9cae988a1f17a9aaf08d155442c519812956"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"131c80d9e76c56b1d315d8f3d4f3e2fb437e2de3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a3fd7948_1aa0ac5c","in_reply_to":"4e8d743b_47df388e","updated":"2025-08-25 10:59:44.000000000","message":"I used this patch for migrating from python2 to python3, so take it as an example why it is usefull to have this configurable. But it has no other relation with any python version.\nSince it will also help at the day we migrate away from these terrible params.pp class towards \u0027modern\u0027 hiera lookups I think this patch is still usefull.","commit_id":"060d9cae988a1f17a9aaf08d155442c519812956"}],"manifests/init.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"09e8d1df7ba6b390da9a07c3e7d9ea0428290706","unresolved":true,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"  package { \u0027nova-common\u0027:"},{"line_number":502,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":503,"context_line":"    name    \u003d\u003e $nova::params::common_package_name,"},{"line_number":504,"context_line":"    require \u003d\u003e Package[\u0027python-nova\u0027],"},{"line_number":505,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027nova-package\u0027],"},{"line_number":506,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"d847d53c_750251e3","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":50},"updated":"2025-08-25 09:38:54.000000000","message":"missing here","commit_id":"060d9cae988a1f17a9aaf08d155442c519812956"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"131c80d9e76c56b1d315d8f3d4f3e2fb437e2de3","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"  package { \u0027nova-common\u0027:"},{"line_number":502,"context_line":"    ensure  \u003d\u003e $ensure_package,"},{"line_number":503,"context_line":"    name    \u003d\u003e $nova::params::common_package_name,"},{"line_number":504,"context_line":"    require \u003d\u003e Package[\u0027python-nova\u0027],"},{"line_number":505,"context_line":"    tag     \u003d\u003e [\u0027openstack\u0027, \u0027nova-package\u0027],"},{"line_number":506,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"92c42ca7_38998280","line":503,"range":{"start_line":503,"start_character":15,"end_line":503,"end_character":50},"in_reply_to":"d847d53c_750251e3","updated":"2025-08-25 10:59:44.000000000","message":"ups, that got lost in one of the rebases...","commit_id":"060d9cae988a1f17a9aaf08d155442c519812956"}]}