)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b89fa3818ff282e0cfc6501644da679ff1367d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9861b197_527adab5","updated":"2023-09-22 06:13:06.000000000","message":"Thanks !","commit_id":"466d4fb3254eeb81f2dee2ff6c0237481b31e432"}],"manifests/scheduler/filter.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8f4db13cfeb17ce0dbda9d78b673a302fc2fa46","unresolved":true,"context_lines":[{"line_number":129,"context_line":"  $max_instances_per_host                                                    \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":130,"context_line":"  $isolated_images                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":131,"context_line":"  $isolated_hosts                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":132,"context_line":"  Variant[Openstacklib::ServiceDefault, Array[String[1]]] $available_filters \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":133,"context_line":"  $enabled_filters                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":134,"context_line":"  $weight_classes                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":135,"context_line":"  $track_instance_changes                                                    \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c23f0e7c_ceceabe6","line":132,"updated":"2023-09-19 13:09:15.000000000","message":"I\u0027m wondering using [] can be simpler. Alternatively we can probably drop the type validation here because we don\u0027t consistently implement validation for all MultiStr Opt now.","commit_id":"4d86fb5fc107fdc99cbafeb1886ad1f394b95a01"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"47c510e620ff98a307414a6bd54b7a85f41582ef","unresolved":true,"context_lines":[{"line_number":129,"context_line":"  $max_instances_per_host                                                    \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":130,"context_line":"  $isolated_images                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":131,"context_line":"  $isolated_hosts                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":132,"context_line":"  Variant[Openstacklib::ServiceDefault, Array[String[1]]] $available_filters \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":133,"context_line":"  $enabled_filters                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":134,"context_line":"  $weight_classes                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":135,"context_line":"  $track_instance_changes                                                    \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"c55b2e7f_96753326","line":132,"in_reply_to":"4f245615_cfb20a96","updated":"2023-09-21 05:38:40.000000000","message":"Because we already merged https://review.opendev.org/c/openstack/puppet-neutron/+/895122, I think it\u0027s more simple and consistent that we remove the validation.","commit_id":"4d86fb5fc107fdc99cbafeb1886ad1f394b95a01"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d4ebaa62a891961afbf957802a4911ecd979ab02","unresolved":true,"context_lines":[{"line_number":129,"context_line":"  $max_instances_per_host                                                    \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":130,"context_line":"  $isolated_images                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":131,"context_line":"  $isolated_hosts                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":132,"context_line":"  Variant[Openstacklib::ServiceDefault, Array[String[1]]] $available_filters \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":133,"context_line":"  $enabled_filters                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":134,"context_line":"  $weight_classes                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":135,"context_line":"  $track_instance_changes                                                    \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"4f245615_cfb20a96","line":132,"in_reply_to":"c23f0e7c_ceceabe6","updated":"2023-09-19 13:57:46.000000000","message":"Do you mean to drop the validation completely or just use Array and default value of [] (empty array)..? I wanted this option to removed by default in the config","commit_id":"4d86fb5fc107fdc99cbafeb1886ad1f394b95a01"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2b89fa3818ff282e0cfc6501644da679ff1367d4","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  $max_instances_per_host                                                    \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":130,"context_line":"  $isolated_images                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":131,"context_line":"  $isolated_hosts                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":132,"context_line":"  Variant[Openstacklib::ServiceDefault, Array[String[1]]] $available_filters \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":133,"context_line":"  $enabled_filters                                                           \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":134,"context_line":"  $weight_classes                                                            \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":135,"context_line":"  $track_instance_changes                                                    \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fe3b0b6b_4a0fb628","line":132,"in_reply_to":"c55b2e7f_96753326","updated":"2023-09-22 06:13:06.000000000","message":"Done","commit_id":"4d86fb5fc107fdc99cbafeb1886ad1f394b95a01"}]}