)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"72b2648d_8ed293c5","updated":"2024-04-19 13:22:33.000000000","message":"Thanks updated with a new proposal, let me know what you think.","commit_id":"1c60cdb0c43f1e4331085c42131b224da82dd731"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c89c14f8bdc2a6788714f9e4cadf3d516dfe9fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4671e19e_19b6f7f2","updated":"2024-04-23 07:07:09.000000000","message":"dont merge until patch depending on this is passing","commit_id":"acc519f5917a09e22e57c9a937b3b58084e10d02"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"91eb7fe7b637a3707087bee84e7a6cf68f577621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"03a58207_d3b1537b","updated":"2024-04-23 07:13:49.000000000","message":"check that dependent patch is green before merging","commit_id":"c5810389d842a8bbecd5964f899a629c7880fab3"}],"manifests/compute/libvirt/secret_ceph.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e2d8ffb4f4ba2e8b527136acb5d4456bf443392","unresolved":true,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*uuid*]"},{"line_number":24,"context_line":"# (Required) The UUID of the libvirt secret."},{"line_number":25,"context_line":"# Defaults to undef"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*value*]"},{"line_number":28,"context_line":"# (Required) The value to store in the secret, in this case the base64"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4c9369a5_ef7b4cf5","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":19},"updated":"2024-04-19 09:10:43.000000000","message":"this line can be removed because of no default","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*uuid*]"},{"line_number":24,"context_line":"# (Required) The UUID of the libvirt secret."},{"line_number":25,"context_line":"# Defaults to undef"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*value*]"},{"line_number":28,"context_line":"# (Required) The value to store in the secret, in this case the base64"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f3a5e105_027beb9b","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":19},"in_reply_to":"4c9369a5_ef7b4cf5","updated":"2024-04-19 13:22:33.000000000","message":"Done","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e2d8ffb4f4ba2e8b527136acb5d4456bf443392","unresolved":true,"context_lines":[{"line_number":27,"context_line":"# [*value*]"},{"line_number":28,"context_line":"# (Required) The value to store in the secret, in this case the base64"},{"line_number":29,"context_line":"# encoded Ceph authx key."},{"line_number":30,"context_line":"# Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"define nova::compute::libvirt::secret_ceph("},{"line_number":33,"context_line":"  String $name \u003d $title,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"2d2886c4_94beebb2","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":19},"updated":"2024-04-19 09:10:43.000000000","message":"this line can be removed because of no default","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# [*value*]"},{"line_number":28,"context_line":"# (Required) The value to store in the secret, in this case the base64"},{"line_number":29,"context_line":"# encoded Ceph authx key."},{"line_number":30,"context_line":"# Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"define nova::compute::libvirt::secret_ceph("},{"line_number":33,"context_line":"  String $name \u003d $title,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"44aa50d7_41572c63","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":19},"in_reply_to":"2d2886c4_94beebb2","updated":"2024-04-19 13:22:33.000000000","message":"Done","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e2d8ffb4f4ba2e8b527136acb5d4456bf443392","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"define nova::compute::libvirt::secret_ceph("},{"line_number":33,"context_line":"  String $name \u003d $title,"},{"line_number":34,"context_line":"  String $uuid,"},{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dd5df891_83e6b5cc","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":8},"updated":"2024-04-19 09:10:43.000000000","message":"Maybe you can use `String[1]` to reject empty values.\n\nAlso, I suspect you have to put $name after the other two required parameters but let\u0027s see how lint says.","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c2685d380e7fe28dc912cf09f325bf57e76b64a7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"define nova::compute::libvirt::secret_ceph("},{"line_number":33,"context_line":"  String $name \u003d $title,"},{"line_number":34,"context_line":"  String $uuid,"},{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e7eac563_0277f9b2","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":8},"in_reply_to":"b6076fa9_50c80782","updated":"2024-04-19 13:23:00.000000000","message":"$name and $title as both reserved so changed to $secret_name","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Defaults to undef"},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"define nova::compute::libvirt::secret_ceph("},{"line_number":33,"context_line":"  String $name \u003d $title,"},{"line_number":34,"context_line":"  String $uuid,"},{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b6076fa9_50c80782","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":8},"in_reply_to":"dd5df891_83e6b5cc","updated":"2024-04-19 13:22:33.000000000","message":"Done","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e2d8ffb4f4ba2e8b527136acb5d4456bf443392","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  $xml_file \u003d \"/etc/nova/libvirt-secret-${uuid}.xml\""},{"line_number":39,"context_line":"  file { $xml_file:"},{"line_number":40,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":41,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6e70e0ed_7487f437","line":38,"range":{"start_line":38,"start_character":15,"end_line":38,"end_character":24},"updated":"2024-04-19 09:10:43.000000000","message":"I wonder if we can make the directory path configurable (and probably required) because the manifests in the directory libvirt is so far generic libvirt support implementations.","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa86193445f7656e4cb5a949d51a3ac98adf146b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  $xml_file \u003d \"/etc/nova/libvirt-secret-${uuid}.xml\""},{"line_number":39,"context_line":"  file { $xml_file:"},{"line_number":40,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":41,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"59fd5d1a_273c01c1","line":38,"range":{"start_line":38,"start_character":15,"end_line":38,"end_character":24},"in_reply_to":"376674e9_a753eb81","updated":"2024-04-22 08:17:45.000000000","message":"Done","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":true,"context_lines":[{"line_number":35,"context_line":"  String $value,"},{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  $xml_file \u003d \"/etc/nova/libvirt-secret-${uuid}.xml\""},{"line_number":39,"context_line":"  file { $xml_file:"},{"line_number":40,"context_line":"    ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":41,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"376674e9_a753eb81","line":38,"range":{"start_line":38,"start_character":15,"end_line":38,"end_character":24},"in_reply_to":"6e70e0ed_7487f437","updated":"2024-04-19 13:22:33.000000000","message":"Might be a good idea to make it configurable, I tried sticking to the original implementation as much as possible except for fixing for example setting the secret value using a file (because passing it directly as a argument is deprecated in libvirt docs).","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0e2d8ffb4f4ba2e8b527136acb5d4456bf443392","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":56,"context_line":"    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":57,"context_line":"    content \u003d\u003e $value,"},{"line_number":58,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f3875edc_78ae869f","line":57,"updated":"2024-04-19 09:10:43.000000000","message":"Do we need `show_diff \u003d false` ?","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"bc3666fe64653c95c0f83f20b8126ac6f76a7d76","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":56,"context_line":"    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":57,"context_line":"    content \u003d\u003e $value,"},{"line_number":58,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b66783c5_e9afb671","line":57,"in_reply_to":"e51f897c_dcb32c34","updated":"2024-04-22 08:17:34.000000000","message":"Done","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dc5e26301aa9cd5e46f837d90f6d8a48118c02d1","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":56,"context_line":"    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":57,"context_line":"    content \u003d\u003e $value,"},{"line_number":58,"context_line":"    require \u003d\u003e Anchor[\u0027nova::config::begin\u0027],"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e51f897c_dcb32c34","line":57,"in_reply_to":"f3875edc_78ae869f","updated":"2024-04-19 13:22:33.000000000","message":"nice catch!","commit_id":"3690bdc48186e37a53ccaeaa2a0dd8cbc58f2e38"}]}