)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"450bb1f8b26aec24748d2a35ad40344de744b058","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-29 11:29:09 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(params): change $modular_libvirt default for RedHat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of EL9, modular libvirt is the default. Adjust $modular_libvirt in"},{"line_number":10,"context_line":"params.pp accordingly. This reflects on nova::compute::libvirt::services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"91fe42bd_62b7b3c6","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2024-05-29 09:48:28.000000000","message":"Mentioning the actual file being updated here (and in the paragraph below) is redundant because git blame would tell it.","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"237b08e4b7c98f6d8f8012b5cbb22d89d21ea347","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-29 11:29:09 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(params): change $modular_libvirt default for RedHat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of EL9, modular libvirt is the default. Adjust $modular_libvirt in"},{"line_number":10,"context_line":"params.pp accordingly. This reflects on nova::compute::libvirt::services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"33f836c4_80f1175c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"in_reply_to":"07c51191_d48536b9","updated":"2024-05-29 13:17:09.000000000","message":"Yes, we (especially I) usually add the \"scope name\"... However for this specific case, \"Updating param.pp\" does not give much information because it does not explain how the change would affect the deployment. I should have pointed that more clearly.","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"7c21b0c0df2ff910ff7d0855705b0bc81752fc10","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Francesco Di Nucci \u003cd1nuc0m@protonmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-05-29 11:29:09 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(params): change $modular_libvirt default for RedHat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of EL9, modular libvirt is the default. Adjust $modular_libvirt in"},{"line_number":10,"context_line":"params.pp accordingly. This reflects on nova::compute::libvirt::services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"07c51191_d48536b9","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"in_reply_to":"91fe42bd_62b7b3c6","updated":"2024-05-29 11:47:15.000000000","message":"Done in patch set 3, tried to use scope as defined in Conventional Commits but probably is not needed.","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"450bb1f8b26aec24748d2a35ad40344de744b058","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(params): change $modular_libvirt default for RedHat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of EL9, modular libvirt is the default. Adjust $modular_libvirt in"},{"line_number":10,"context_line":"params.pp accordingly. This reflects on nova::compute::libvirt::services"},{"line_number":11,"context_line":"and nova::migration::libvirt. See also bug #2062168"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa40395_44e919ee","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":42},"updated":"2024-05-29 09:48:28.000000000","message":"This is not accurate because there is not default mechanism for libvirt daemon architecture. Probably recommended ?","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"7c21b0c0df2ff910ff7d0855705b0bc81752fc10","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(params): change $modular_libvirt default for RedHat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of EL9, modular libvirt is the default. Adjust $modular_libvirt in"},{"line_number":10,"context_line":"params.pp accordingly. This reflects on nova::compute::libvirt::services"},{"line_number":11,"context_line":"and nova::migration::libvirt. See also bug #2062168"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6cbf52b3_9fe42280","line":9,"range":{"start_line":9,"start_character":30,"end_line":9,"end_character":42},"in_reply_to":"3fa40395_44e919ee","updated":"2024-05-29 11:47:15.000000000","message":"Yes, bad choice of word - I meant that monolithic libvirtd is now deprecated on EL9 (see reference), so now modular one should be used instead. Done in patch set 3.","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"450bb1f8b26aec24748d2a35ad40344de744b058","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8a46c61_b541bb44","updated":"2024-05-29 09:48:28.000000000","message":"I\u0027d be ok with the proposed direction but this change needs further work.\n\n* Unit tests may need to be adjusted\n* A release note should be added, and it should explain the upgrade impact","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"237b08e4b7c98f6d8f8012b5cbb22d89d21ea347","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a44f5351_2ecfc743","in_reply_to":"702e880d_f0902593","updated":"2024-05-29 13:17:09.000000000","message":"For unit tests, we can probably start with checking the result of unit tests and consider how we update the relevant tests.\n\nFor release note, what we needs is generating a note file by the `reno` tool\n```\n$ reno new very-nice-feature-to-make-this-module-better\n```\nthen edit the file with the template content and add it to the git repository.\nThe reno tool can be installed by pip or packages.","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"4647eaca37c703b8b9336286a4c19e21fce8a575","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a81f039b_9a491a51","in_reply_to":"a44f5351_2ecfc743","updated":"2024-05-30 08:26:34.000000000","message":"For unit tests, patch set 4 should manage service correctly on EL, let\u0027s see how it goes\n\nFor release notes, I tried to use reno, let me know","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"58650ae794f718387b754e98554db8ac69d5bf13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8138a9e1_4fd23953","in_reply_to":"a81f039b_9a491a51","updated":"2024-06-11 07:03:50.000000000","message":"Done","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"7c21b0c0df2ff910ff7d0855705b0bc81752fc10","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"702e880d_f0902593","in_reply_to":"a8a46c61_b541bb44","updated":"2024-05-29 11:47:15.000000000","message":"* Regarding unit tests, should only the part relative to expected service change? (I have not edited it yet)\n* Ok, tried to add it, couldn\u0027t find the guidelines about release notes, do you have a pointer to it? Thanks in advance","commit_id":"580fb7e93d62e2190ffdb7052d888a5d8804c4bb"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"ee3d46452f02658e02f038ada102ba6c6afa4cc6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b6149227_1bcf19b8","updated":"2024-07-16 13:03:32.000000000","message":"Any news about this/are there any other problems that should be fixed?","commit_id":"3cd25fb69e57f4d690aa3897f9c24cc2181280ec"}],"releasenotes/notes/change_modular_libvirt_default_rhel-5984f51659edf2ec.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be1967419098072a915a62452c4d83da323ff7e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``modular_libvirt`` variable now defaults to true on EL systems. As of "},{"line_number":5,"context_line":"    EL9 it is recommended to use modular libvirt daemons, while the monolithic "},{"line_number":6,"context_line":"    daemon has been deprecated. When using on EL8 set ```modular_libvirt``` to "},{"line_number":7,"context_line":"    false.  When upgrading from EL8, the system will still use the monolithic "},{"line_number":8,"context_line":"    daemon, it is recommended to enable modular libvirt daemons, otherwise set"},{"line_number":9,"context_line":"    ```modular_libvirt``` to false. Note that the current manifests do not"},{"line_number":10,"context_line":"    manage the transition from monolithic to modular libvirt daemon, additional"},{"line_number":11,"context_line":"    cleanup is needed. No changes are required on EL9."},{"line_number":12,"context_line":"critical:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f1bd579e_76a3cc9e","line":9,"range":{"start_line":6,"start_character":32,"end_line":9,"end_character":35},"updated":"2024-06-11 05:17:42.000000000","message":"CentOS/RHEL 8 is no longer supported so this statement is not needed.","commit_id":"cb5e5256b7797a8873fbc16f9bbea92cb0709f3c"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"58650ae794f718387b754e98554db8ac69d5bf13","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``modular_libvirt`` variable now defaults to true on EL systems. As of "},{"line_number":5,"context_line":"    EL9 it is recommended to use modular libvirt daemons, while the monolithic "},{"line_number":6,"context_line":"    daemon has been deprecated. When using on EL8 set ```modular_libvirt``` to "},{"line_number":7,"context_line":"    false.  When upgrading from EL8, the system will still use the monolithic "},{"line_number":8,"context_line":"    daemon, it is recommended to enable modular libvirt daemons, otherwise set"},{"line_number":9,"context_line":"    ```modular_libvirt``` to false. Note that the current manifests do not"},{"line_number":10,"context_line":"    manage the transition from monolithic to modular libvirt daemon, additional"},{"line_number":11,"context_line":"    cleanup is needed. No changes are required on EL9."},{"line_number":12,"context_line":"critical:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a25979b5_2c010c0e","line":9,"range":{"start_line":6,"start_character":32,"end_line":9,"end_character":35},"in_reply_to":"f1bd579e_76a3cc9e","updated":"2024-06-11 07:03:50.000000000","message":"Ack, thanks","commit_id":"cb5e5256b7797a8873fbc16f9bbea92cb0709f3c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9be1967419098072a915a62452c4d83da323ff7e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    ```modular_libvirt``` to false. Note that the current manifests do not"},{"line_number":10,"context_line":"    manage the transition from monolithic to modular libvirt daemon, additional"},{"line_number":11,"context_line":"    cleanup is needed. No changes are required on EL9."},{"line_number":12,"context_line":"critical:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The ``modular_libvirt`` variable now defaults to true on EL systems. When "},{"line_number":15,"context_line":"    upgrading from EL8, the system will still use the monolithic daemon, set"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"e5ca2c60_65fb4448","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"updated":"2024-06-11 05:17:42.000000000","message":"The critical section is used to describe any critical problem like data corruption but IMO this change is not.","commit_id":"cb5e5256b7797a8873fbc16f9bbea92cb0709f3c"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"58650ae794f718387b754e98554db8ac69d5bf13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    ```modular_libvirt``` to false. Note that the current manifests do not"},{"line_number":10,"context_line":"    manage the transition from monolithic to modular libvirt daemon, additional"},{"line_number":11,"context_line":"    cleanup is needed. No changes are required on EL9."},{"line_number":12,"context_line":"critical:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    The ``modular_libvirt`` variable now defaults to true on EL systems. When "},{"line_number":15,"context_line":"    upgrading from EL8, the system will still use the monolithic daemon, set"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4e2ab4a6_65b1a307","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"in_reply_to":"e5ca2c60_65fb4448","updated":"2024-06-11 07:03:50.000000000","message":"Ack, thanks","commit_id":"cb5e5256b7797a8873fbc16f9bbea92cb0709f3c"}],"releasenotes/notes/change_modular_libvirt_default_rhel.580fb7e93d62e2190ffdb7052d888a5d8804c4bb.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"237b08e4b7c98f6d8f8012b5cbb22d89d21ea347","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``modular_libvirt`` now defaults to true on EL systems. As of EL9 it is"},{"line_number":5,"context_line":"    recommended to use modular libvirt daemons, while the monolithic daemon has "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"19ce5f14_5069d0ca","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2024-05-29 13:17:09.000000000","message":"We may also need to mention that the current manifests do not clean up the libvirt daemon completely and needs additional clean up when transitioning from monolithic daemon to modular daemons.","commit_id":"fea491aaef370c9b2a2e2d968e208159ab32f452"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"4647eaca37c703b8b9336286a4c19e21fce8a575","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``modular_libvirt`` now defaults to true on EL systems. As of EL9 it is"},{"line_number":5,"context_line":"    recommended to use modular libvirt daemons, while the monolithic daemon has "}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8ed2f05b_3f3795dd","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"in_reply_to":"19ce5f14_5069d0ca","updated":"2024-05-30 08:26:34.000000000","message":"Done in patch set 4","commit_id":"fea491aaef370c9b2a2e2d968e208159ab32f452"}]}