)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a542803788b01e781f29d9bd0d7f68ca85c3470","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"86c4264f_7ed4d887","updated":"2025-01-19 02:22:01.000000000","message":"Please add a test case to validate the parameter.\n\nAlso a release note should be added to explain the new parameter","commit_id":"0f6777c1470d6baee3993d6e1fcab34d2555c039"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6fd8089f0faf1dd5dd0ecef432a4beab6b5af3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ca20ac8_c8469d72","updated":"2025-01-20 07:35:25.000000000","message":"recheck the playbook error has been resolved.","commit_id":"5460528c73ad683bbae38d538822353e195229c1"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d9433050d0a0c109f759d0e6a947203271d7612f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"35e029f6_7e953c1e","updated":"2025-01-23 19:51:03.000000000","message":"recheck mistral tempest failure, tempest.lib.exceptions.UnexpectedContentType: Unexpected content type provided","commit_id":"01437929334513cbb20c6d010da3a7f0f1b51028"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f38f50b529da26eb2753d28d4b10ed3e2b146461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c142cde2_08028d01","updated":"2025-01-22 08:19:06.000000000","message":"thanks 😊","commit_id":"01437929334513cbb20c6d010da3a7f0f1b51028"}],"manifests/compute/spice.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8426a6a06bd9f774af126e18ae6259b8c5f4684f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  $html5proxy_base_url        \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":46,"context_line":"  $proxy_host                 \u003d undef,"},{"line_number":47,"context_line":"  $proxy_protocol             \u003d \u0027http\u0027,"},{"line_number":48,"context_line":"  String  $proxy_port         \u003d \u00276082\u0027,"},{"line_number":49,"context_line":"  $proxy_path                 \u003d \u0027/spice_auto.html\u0027,"},{"line_number":50,"context_line":") {"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c9ada72c_38f08266","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":8},"updated":"2025-01-19 02:23:03.000000000","message":"We probably convert this to into so that we can ensure the value is in a valid range. So I\u0027m against forcing string for this parameter now.","commit_id":"0f6777c1470d6baee3993d6e1fcab34d2555c039"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"a7eb82c4919d9223de6ad282278a3027a0650dbf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  $html5proxy_base_url        \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":46,"context_line":"  $proxy_host                 \u003d undef,"},{"line_number":47,"context_line":"  $proxy_protocol             \u003d \u0027http\u0027,"},{"line_number":48,"context_line":"  String  $proxy_port         \u003d \u00276082\u0027,"},{"line_number":49,"context_line":"  $proxy_path                 \u003d \u0027/spice_auto.html\u0027,"},{"line_number":50,"context_line":") {"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"efe962ab_1e216642","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":8},"in_reply_to":"c9ada72c_38f08266","updated":"2025-01-19 08:33:27.000000000","message":"Done","commit_id":"0f6777c1470d6baee3993d6e1fcab34d2555c039"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"535ddb0e197a5c7f04ce2799f19367b1d1a0d5c3","unresolved":true,"context_lines":[{"line_number":18,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*html5proxy_base_url*]"},{"line_number":21,"context_line":"#   (optiona) URL for the html5 console proxy"},{"line_number":22,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":23,"context_line":"#   only used if $proxy_host is not set explicitly"},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"89a2930f_2fc76d42","line":21,"updated":"2025-01-21 07:32:00.000000000","message":"optional","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d1444c459d7c3360f875554d66a537234ee97f8b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*html5proxy_base_url*]"},{"line_number":21,"context_line":"#   (optiona) URL for the html5 console proxy"},{"line_number":22,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":23,"context_line":"#   only used if $proxy_host is not set explicitly"},{"line_number":24,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"090d162a_a11b12ad","line":21,"in_reply_to":"89a2930f_2fc76d42","updated":"2025-01-21 07:47:32.000000000","message":"Done","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"535ddb0e197a5c7f04ce2799f19367b1d1a0d5c3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# [*html5proxy_base_url*]"},{"line_number":21,"context_line":"#   (optiona) URL for the html5 console proxy"},{"line_number":22,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":23,"context_line":"#   only used if $proxy_host is not set explicitly"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*proxy_host*]"},{"line_number":26,"context_line":"#   (optional) Host for the html5 console proxy"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"e72cd7a2_a1c1233b","line":23,"updated":"2025-01-21 07:32:00.000000000","message":"maybe rewrite the sentence so that \"Defaults\" line is the last list","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d1444c459d7c3360f875554d66a537234ee97f8b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# [*html5proxy_base_url*]"},{"line_number":21,"context_line":"#   (optiona) URL for the html5 console proxy"},{"line_number":22,"context_line":"#   Defaults to $facts[\u0027os_service_default\u0027]"},{"line_number":23,"context_line":"#   only used if $proxy_host is not set explicitly"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*proxy_host*]"},{"line_number":26,"context_line":"#   (optional) Host for the html5 console proxy"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fc423587_f1688bbe","line":23,"in_reply_to":"e72cd7a2_a1c1233b","updated":"2025-01-21 07:47:32.000000000","message":"Done","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"535ddb0e197a5c7f04ce2799f19367b1d1a0d5c3","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  include nova::deps"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $proxy_host {"},{"line_number":55,"context_line":"    $_html5proxy_base_url \u003d \"${proxy_protocol}://${proxy_host}:${proxy_port}${proxy_path}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $_html5proxy_base_url \u003d $html5proxy_base_url"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fc075ac0_06047fed","line":55,"updated":"2025-01-21 07:32:00.000000000","message":"nit: naming convention used is normally using suffix `_real` e.g  `$html5proxy_base_url_real`","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d1444c459d7c3360f875554d66a537234ee97f8b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  include nova::deps"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $proxy_host {"},{"line_number":55,"context_line":"    $_html5proxy_base_url \u003d \"${proxy_protocol}://${proxy_host}:${proxy_port}${proxy_path}\""},{"line_number":56,"context_line":"  } else {"},{"line_number":57,"context_line":"    $_html5proxy_base_url \u003d $html5proxy_base_url"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"18ca775f_397be3d1","line":55,"in_reply_to":"fc075ac0_06047fed","updated":"2025-01-21 07:47:32.000000000","message":"Done","commit_id":"bf8f36c3b4cbfbc6c6135398ff24544bf6b33256"}],"spec/classes/nova_compute_spice_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"135030a38e6b3c19280d4500a0ec1c891e3a44c1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      end"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      it { should contain_nova_config(\u0027spice/html5proxy_base_url\u0027).with_value(\u0027https://my.custom.url/test.html\u0027)}"},{"line_number":40,"context_line":"      it { should contain_nova_config(\u0027spice/agent_enabled\u0027).with_value(\u0027true\u0027)}"},{"line_number":41,"context_line":"      it { should contain_nova_config(\u0027spice/server_proxyclient_address\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":42,"context_line":"      it { should contain_nova_config(\u0027spice/server_listen\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":43,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"98551629_30773946","line":40,"updated":"2025-01-21 13:42:00.000000000","message":"we should not test these again here since the logic when using html5proxy_base_url doesn\u0027t change the default behavior","commit_id":"ec1d00d0877c3ea9672c42fd5e2068eafd6ac21d"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"ff6267b5ecd76fefdd92f1574725482382a08a2a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      end"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      it { should contain_nova_config(\u0027spice/html5proxy_base_url\u0027).with_value(\u0027https://my.custom.url/test.html\u0027)}"},{"line_number":40,"context_line":"      it { should contain_nova_config(\u0027spice/agent_enabled\u0027).with_value(\u0027true\u0027)}"},{"line_number":41,"context_line":"      it { should contain_nova_config(\u0027spice/server_proxyclient_address\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":42,"context_line":"      it { should contain_nova_config(\u0027spice/server_listen\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)}"},{"line_number":43,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"f61d4de7_712a7cce","line":40,"in_reply_to":"98551629_30773946","updated":"2025-01-21 14:23:03.000000000","message":"Done","commit_id":"ec1d00d0877c3ea9672c42fd5e2068eafd6ac21d"}]}