)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"f205c5e1a3f183f5779cfcec82d1c7a9962effff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e65250ef_5395b9b8","updated":"2025-04-29 10:07:57.000000000","message":"Edit, I also tried this on the controller node and does *not* work using the same Hiera code, I\u0027m pretty sure the classes are included as report_in_placement is set successfully https://paste.opendev.org/show/bzJl2w7P11fVa4kuiYJU/","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daf9b86b4093873c4cb74c303b94dffea9775764","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"952e5fb6_a2ae572b","updated":"2025-04-03 14:54:30.000000000","message":"I\u0027m not too sure about the benefit of this change because\n - If you are using hiera then you can just set the underlying parameters directly\n - If you define values in your manifest then you can explicitly define nova::compute::pci and nova::pci before nova::compute","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"b41304be9d108ea210d905adb66c023b62cb37f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8462865_b67636f1","in_reply_to":"601fe992_be4ad059","updated":"2025-05-15 13:06:23.000000000","message":"EDIT: tested again and on the controller node it does *not* work with both syntaxes","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"726f339ed9a3d60d3c523aa0d46940b31bcedd5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baa2e449_c2f4a242","in_reply_to":"84184a7a_1f21c4a9","updated":"2025-04-04 10:42:55.000000000","message":"\"stopped working\" has no real information about the issue. Do you see any failure or are these definitions ignored ?","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"42cb662520740c290ff6c67966c4e407b5583a32","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0913a9eb_5f93da01","in_reply_to":"87ec6939_167ecf21","updated":"2025-04-29 08:15:10.000000000","message":"Sorry for the delay, in the end this worked, had some issues in deploying environments\n\nhttps://paste.opendev.org/show/bpjzI74Wm4pCrUlzMC5O/","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"49c1d6e5295371b4c2ab5ab0f83f4bdd2e415a35","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84184a7a_1f21c4a9","in_reply_to":"952e5fb6_a2ae572b","updated":"2025-04-04 06:36:41.000000000","message":"I know, Hiera would be the more elegant solution, but when I tried to \"pass\" the configuration from the Puppet manifest to Hiera it somehow stopped working (see here https://paste.opendev.org/show/b0OgVmz82jOEjKcNim6x/), maybe I should focus on this instead?","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"de0b76e9871fb3ee45dad88d597d9427d8a7ac22","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"601fe992_be4ad059","in_reply_to":"9abdcc25_eec6256b","updated":"2025-05-15 12:57:04.000000000","message":"Thank you, switching to this worked, now I am wondering why it worked on the controller node and not on the compute node...\n\nSorry for the delay, again didn\u0027t have access to the testbed","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"a41d00827f911a4486ea25b54851f9f440b29de3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e450775b_c73c059e","in_reply_to":"baa2e449_c2f4a242","updated":"2025-04-04 11:00:40.000000000","message":"You\u0027re right, there are no errors - the definitions are ignored and the values in nova.conf return to the default (empty) values","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d6646d43ad22cdb03ef6b30cb4ded8a8862499fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9abdcc25_eec6256b","in_reply_to":"c15c7c6d_3cd475d4","updated":"2025-05-02 13:56:57.000000000","message":"I could be wrong but I wonder the hiera format described in the pastbin is correct. Could you try\n\n```\nnova::pci::aliases:\n  - vendor_id: \u002710de\u0027\n    product_id: \u00271ff2\u0027\n    device_type: \u0027type-PCI\u0027\n    name: \u0027nvidia-t400\u0027\n```","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a33d23e409432146cbf429e6d427a93bce644a11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87ec6939_167ecf21","in_reply_to":"e450775b_c73c059e","updated":"2025-04-05 17:07:25.000000000","message":"Hmm The snippet contains no apparent error. I wonder if the manifest is actually loaded. Are you sure that these classes are actually loaded in the node where these options are supposed to be set ?","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"},{"author":{"_account_id":36891,"name":"Francesco Di Nucci","display_name":"Francesco Di Nucci","email":"d1nuc0m@protonmail.com","username":"d1nuc0m","status":"Sysasdmin @ INFN Italy"},"change_message_id":"360ab8d3660075dfa0d10d321d9f6acfd7a539f1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c15c7c6d_3cd475d4","in_reply_to":"e65250ef_5395b9b8","updated":"2025-04-29 10:08:34.000000000","message":"- not solved","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"}],"manifests/compute.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"acccd982d710778023ece27fbb5354283265ce22","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"  $image_type_exclude_list_real \u003d pick(join(any2array($image_type_exclude_list), \u0027,\u0027), $facts[\u0027os_service_default\u0027])"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"  include nova::policy"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  include nova::pci"},{"line_number":332,"context_line":"  include nova::compute::pci"},{"line_number":333,"context_line":"  include nova::compute::mdev"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"  if ($vnc_enabled and $spice_enabled) {"},{"line_number":336,"context_line":"    fail(\u0027vnc_enabled and spice_enabled is mutually exclusive\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a4513ac7_29c827d1","side":"PARENT","line":333,"range":{"start_line":329,"start_character":22,"end_line":333,"end_character":29},"updated":"2025-04-03 14:56:04.000000000","message":"As far as I vaguely remember these class inclusions were added during transition to dedicated pci classes so we may even remove these and let users include these classes if needed explicitly.","commit_id":"d351ec109d721c955852a305000d2e41e9c3fc3b"}],"manifests/compute/pci.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"daf9b86b4093873c4cb74c303b94dffea9775764","unresolved":true,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class nova::compute::pci ("},{"line_number":25,"context_line":"  Array[Hash] $device_specs     \u003d [],"},{"line_number":26,"context_line":"  Boolean $report_in_placement  \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":27,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":28,"context_line":"  Optional[Array[Hash]] $passthrough \u003d undef,"},{"line_number":29,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"b09f96fd_8f4bf07d","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":9},"updated":"2025-04-03 14:54:30.000000000","message":"this does not work because os_service_default fact is actually a string.","commit_id":"c82041e3062b07918be771ae0daa03b9fb78c0b0"}]}