)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3af396078c9e322862f76a5eb278aea0e241d63a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-07-04 14:15:49 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Trixie \u0026 recent Ubuntu support for virtlockd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Under Debian Trixie (aka: Debian 13), for having a working"},{"line_number":10,"context_line":"virtlockd service, one needs to install the package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b2c68494_bc2497b3","line":7,"range":{"start_line":7,"start_character":9,"end_line":7,"end_character":30},"updated":"2025-07-08 05:46:14.000000000","message":"This part probably needs to be removed.","commit_id":"2d8bbc8521674ad58d77d855f62c2f4c760db09f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"ecb068ee9900e142a7a936eefd9ba5b22a3fbdea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b5b2f91_d967b18b","updated":"2025-06-24 06:33:06.000000000","message":"I also added support for Ubuntu that has the same package name.","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"6ec2a6fa7964b0c61923e01be16a683d1088183d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a323724_42f99435","updated":"2025-06-27 13:17:39.000000000","message":"Thanks for the reviews and useful suggestions. Done as suggested.","commit_id":"10d26af07b63dd8ed405d5bf7a2ba4ebbf755d1c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b1b828b1236f4c0917519308c1fe0ed2b8ca144e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ad7156d8_bb8c44fe","updated":"2025-07-04 12:15:55.000000000","message":"Hi Takashi-san,\n\nThanks a lot for your always very helpful and accurate reviews! All done as you suggested.","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"}],"manifests/compute/libvirt/services.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9592063faa83a36a5d2027536fb3526f161ab335","unresolved":true,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":156,"context_line":"      package { \u0027libvirt-daemon-plugin-lockd\u0027:"},{"line_number":157,"context_line":"        ensure \u003d\u003e present,"},{"line_number":158,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"55536586_a45eaade","line":155,"range":{"start_line":155,"start_character":4,"end_line":155,"end_character":136},"updated":"2025-06-24 02:35:49.000000000","message":"Please add virtlock_package_name to params and determine installation according to the variable, instead of pulling more complicated logic into this specific manifest.","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"ecb068ee9900e142a7a936eefd9ba5b22a3fbdea","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":156,"context_line":"      package { \u0027libvirt-daemon-plugin-lockd\u0027:"},{"line_number":157,"context_line":"        ensure \u003d\u003e present,"},{"line_number":158,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ae155929_03e86667","line":155,"range":{"start_line":155,"start_character":4,"end_line":155,"end_character":136},"in_reply_to":"55536586_a45eaade","updated":"2025-06-24 06:33:06.000000000","message":"Done","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6fd6839a9a123487cdd2e8306662bfc0f5ac7eb4","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        name   \u003d\u003e $virtlock_service_name,"},{"line_number":163,"context_line":"        tag    \u003d\u003e \u0027libvirt-service\u0027,"},{"line_number":164,"context_line":"      }"},{"line_number":165,"context_line":"    }else{"},{"line_number":166,"context_line":"      service { \u0027virtlockd\u0027:"},{"line_number":167,"context_line":"        ensure \u003d\u003e running,"},{"line_number":168,"context_line":"        enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"f60ec69a_97781b9d","line":165,"updated":"2025-06-23 20:45:50.000000000","message":"should probably add some spaces around else here","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"ecb068ee9900e142a7a936eefd9ba5b22a3fbdea","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        name   \u003d\u003e $virtlock_service_name,"},{"line_number":163,"context_line":"        tag    \u003d\u003e \u0027libvirt-service\u0027,"},{"line_number":164,"context_line":"      }"},{"line_number":165,"context_line":"    }else{"},{"line_number":166,"context_line":"      service { \u0027virtlockd\u0027:"},{"line_number":167,"context_line":"        ensure \u003d\u003e running,"},{"line_number":168,"context_line":"        enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dd31b82e_f08db330","line":165,"in_reply_to":"2898c702_e7ee881d","updated":"2025-06-24 06:33:06.000000000","message":"Done.","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9592063faa83a36a5d2027536fb3526f161ab335","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        name   \u003d\u003e $virtlock_service_name,"},{"line_number":163,"context_line":"        tag    \u003d\u003e \u0027libvirt-service\u0027,"},{"line_number":164,"context_line":"      }"},{"line_number":165,"context_line":"    }else{"},{"line_number":166,"context_line":"      service { \u0027virtlockd\u0027:"},{"line_number":167,"context_line":"        ensure \u003d\u003e running,"},{"line_number":168,"context_line":"        enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2898c702_e7ee881d","line":165,"in_reply_to":"f60ec69a_97781b9d","updated":"2025-06-24 02:35:49.000000000","message":"+1","commit_id":"d52865a856db10d64c7a4ace43287005316aeb16"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"51df5fc71749a6069b5ac2e30b45c8a5db97e388","unresolved":true,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and (($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13)"},{"line_number":156,"context_line":"      or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 25.04)) {"},{"line_number":157,"context_line":"      package { $::nova::params::virtlock_package_name:"},{"line_number":158,"context_line":"        ensure \u003d\u003e present,"},{"line_number":159,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bc7a8e4f_f9068b52","line":156,"range":{"start_line":155,"start_character":4,"end_line":156,"end_character":105},"updated":"2025-06-24 08:45:04.000000000","message":"Move this version check logic to params class and only check if virtlock_package_name is not undef in here.\n\nAlso, we do not support non LTS ubuntu so I\u0027d prefer not adding the logic for \u003e\u003d 25.05 now. It is not actually tested.","commit_id":"10d26af07b63dd8ed405d5bf7a2ba4ebbf755d1c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"6ec2a6fa7964b0c61923e01be16a683d1088183d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  }"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and (($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13)"},{"line_number":156,"context_line":"      or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 25.04)) {"},{"line_number":157,"context_line":"      package { $::nova::params::virtlock_package_name:"},{"line_number":158,"context_line":"        ensure \u003d\u003e present,"},{"line_number":159,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6ff4001b_2739314d","line":156,"range":{"start_line":155,"start_character":4,"end_line":156,"end_character":105},"in_reply_to":"bc7a8e4f_f9068b52","updated":"2025-06-27 13:17:39.000000000","message":"Done","commit_id":"10d26af07b63dd8ed405d5bf7a2ba4ebbf755d1c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"51df5fc71749a6069b5ac2e30b45c8a5db97e388","unresolved":true,"context_lines":[{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and (($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13)"},{"line_number":156,"context_line":"      or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 25.04)) {"},{"line_number":157,"context_line":"      package { $::nova::params::virtlock_package_name:"},{"line_number":158,"context_line":"        ensure \u003d\u003e present,"},{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"      -\u003e service { \u0027virtlockd\u0027:"},{"line_number":161,"context_line":"        ensure \u003d\u003e running,"},{"line_number":162,"context_line":"        enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"08f12661_ec86970e","line":159,"range":{"start_line":157,"start_character":0,"end_line":159,"end_character":7},"updated":"2025-06-24 08:45:04.000000000","message":"Please follow the common format (use name for actual package name)","commit_id":"10d26af07b63dd8ed405d5bf7a2ba4ebbf755d1c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"6ec2a6fa7964b0c61923e01be16a683d1088183d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027Debian\u0027 and (($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13)"},{"line_number":156,"context_line":"      or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 25.04)) {"},{"line_number":157,"context_line":"      package { $::nova::params::virtlock_package_name:"},{"line_number":158,"context_line":"        ensure \u003d\u003e present,"},{"line_number":159,"context_line":"      }"},{"line_number":160,"context_line":"      -\u003e service { \u0027virtlockd\u0027:"},{"line_number":161,"context_line":"        ensure \u003d\u003e running,"},{"line_number":162,"context_line":"        enable \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8ac9049a_d6c226eb","line":159,"range":{"start_line":157,"start_character":0,"end_line":159,"end_character":7},"in_reply_to":"08f12661_ec86970e","updated":"2025-06-27 13:17:39.000000000","message":"Done","commit_id":"10d26af07b63dd8ed405d5bf7a2ba4ebbf755d1c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42c15421c361147685b8ed92120f53fb8c0f8a79","unresolved":true,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $::nova::params::virtlock_package_name !\u003d undef {"},{"line_number":156,"context_line":"      package { \u0027virtlockd\u0027:"},{"line_number":157,"context_line":"        ensure \u003d\u003e present,"},{"line_number":158,"context_line":"        name   \u003d\u003e $::nova::params::virtlock_package_name,"},{"line_number":159,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"cf89e8ae_4126f0da","line":156,"range":{"start_line":156,"start_character":17,"end_line":156,"end_character":26},"updated":"2025-07-04 12:04:12.000000000","message":"Please add `tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],`\nAlso you should notify (~\u003e) the service to restart it when the package is updated.\n\nFinally, please try\n```\nif $::nova::poarams::virtlock_package_name {\n  package { \u0027virtlockd\u0027:\n    ensure \u003d\u003e present,\n    name   \u003d\u003e $::nova::params::virtlock_package_name,\n    tag \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],\n  }\n  Package[\u0027virtlockd\u0027] ~\u003e Service[\u0027virtlockd\u0027]\n}\nservice { \u0027virtlockd\u0027:\n  ensure \u003d\u003e running,\n  enable \u003d\u003e true,\n  name   \u003d\u003e $virtlock_service_name,\n  tag    \u003d\u003e \u0027libvirt-service\u0027,\n}\n```\nto avoid duplicate declaration","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b1b828b1236f4c0917519308c1fe0ed2b8ca144e","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"  if $virtlock_service_name {"},{"line_number":155,"context_line":"    if $::nova::params::virtlock_package_name !\u003d undef {"},{"line_number":156,"context_line":"      package { \u0027virtlockd\u0027:"},{"line_number":157,"context_line":"        ensure \u003d\u003e present,"},{"line_number":158,"context_line":"        name   \u003d\u003e $::nova::params::virtlock_package_name,"},{"line_number":159,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa2fb688_6843c3c6","line":156,"range":{"start_line":156,"start_character":17,"end_line":156,"end_character":26},"in_reply_to":"cf89e8ae_4126f0da","updated":"2025-07-04 12:15:55.000000000","message":"Done","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"}],"manifests/params.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a8ffbda0da02409fbac959b34ade3aaacfb8c50","unresolved":true,"context_lines":[{"line_number":41,"context_line":"      $libvirt_service_name              \u003d \u0027libvirtd\u0027"},{"line_number":42,"context_line":"      $libvirt_guests_service_name       \u003d \u0027libvirt-guests\u0027"},{"line_number":43,"context_line":"      $virtlock_service_name             \u003d \u0027virtlockd\u0027"},{"line_number":44,"context_line":"      $virtlock_package_name             \u003d undef"},{"line_number":45,"context_line":"      $virtlog_service_name              \u003d \u0027virtlogd\u0027"},{"line_number":46,"context_line":"      $virtsecret_service_name           \u003d \u0027virtsecretd\u0027"},{"line_number":47,"context_line":"      $virtnodedev_service_name          \u003d \u0027virtnodedevd\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"117fe7a6_aad2df1a","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":48},"updated":"2025-06-27 13:50:12.000000000","message":"Technically libvirt-daemon-lock is the package we have in CentOS. We probably can add it. (It is now installed as a dependency of libvirt-daemon and libvirt-daemon-kvm but these may not be installed always)","commit_id":"b687c0228a1ec5d484aaee83e3b19cd65cb32806"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"520ea796f23535763a683196a0473f5b607b648e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      $libvirt_service_name              \u003d \u0027libvirtd\u0027"},{"line_number":42,"context_line":"      $libvirt_guests_service_name       \u003d \u0027libvirt-guests\u0027"},{"line_number":43,"context_line":"      $virtlock_service_name             \u003d \u0027virtlockd\u0027"},{"line_number":44,"context_line":"      $virtlock_package_name             \u003d undef"},{"line_number":45,"context_line":"      $virtlog_service_name              \u003d \u0027virtlogd\u0027"},{"line_number":46,"context_line":"      $virtsecret_service_name           \u003d \u0027virtsecretd\u0027"},{"line_number":47,"context_line":"      $virtnodedev_service_name          \u003d \u0027virtnodedevd\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"f83acda5_766c2689","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":48},"in_reply_to":"117fe7a6_aad2df1a","updated":"2025-07-01 10:16:41.000000000","message":"As I can\u0027t really test this, I\u0027ll let you do it in a subsequent commit.","commit_id":"b687c0228a1ec5d484aaee83e3b19cd65cb32806"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a8ffbda0da02409fbac959b34ade3aaacfb8c50","unresolved":true,"context_lines":[{"line_number":88,"context_line":"      $libvirt_service_name              \u003d \u0027libvirtd\u0027"},{"line_number":89,"context_line":"      $libvirt_guests_service_name       \u003d \u0027libvirt-guests\u0027"},{"line_number":90,"context_line":"      $virtlock_service_name             \u003d \u0027virtlockd\u0027"},{"line_number":91,"context_line":"      # Starting with Debian 13 and Ubuntu 26.04, virtlockd lives in a separate plugin package."},{"line_number":92,"context_line":"      if ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13) or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 26.04) {"},{"line_number":93,"context_line":"          $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":94,"context_line":"      } else {"},{"line_number":95,"context_line":"          $virtlock_package_name         \u003d undef"},{"line_number":96,"context_line":"      }"},{"line_number":97,"context_line":"      $virtlog_service_name              \u003d \u0027virtlogd\u0027"},{"line_number":98,"context_line":"      $virtsecret_service_name           \u003d undef"},{"line_number":99,"context_line":"      $virtnodedev_service_name          \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"b15daa8c_2976c759","line":96,"range":{"start_line":91,"start_character":1,"end_line":96,"end_character":7},"updated":"2025-06-27 13:50:12.000000000","message":"We already have the case-switch block for os.name in L120 . Please move the logic to there.\n\nAlso, as I said before, remove the logic for ubuntu now because we do not support non LTS release.","commit_id":"b687c0228a1ec5d484aaee83e3b19cd65cb32806"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"520ea796f23535763a683196a0473f5b607b648e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      $libvirt_service_name              \u003d \u0027libvirtd\u0027"},{"line_number":89,"context_line":"      $libvirt_guests_service_name       \u003d \u0027libvirt-guests\u0027"},{"line_number":90,"context_line":"      $virtlock_service_name             \u003d \u0027virtlockd\u0027"},{"line_number":91,"context_line":"      # Starting with Debian 13 and Ubuntu 26.04, virtlockd lives in a separate plugin package."},{"line_number":92,"context_line":"      if ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13) or ($facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Ubuntu\u0027 and Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 26.04) {"},{"line_number":93,"context_line":"          $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":94,"context_line":"      } else {"},{"line_number":95,"context_line":"          $virtlock_package_name         \u003d undef"},{"line_number":96,"context_line":"      }"},{"line_number":97,"context_line":"      $virtlog_service_name              \u003d \u0027virtlogd\u0027"},{"line_number":98,"context_line":"      $virtsecret_service_name           \u003d undef"},{"line_number":99,"context_line":"      $virtnodedev_service_name          \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"e5fa6f80_c5750fa7","line":96,"range":{"start_line":91,"start_character":1,"end_line":96,"end_character":7},"in_reply_to":"b15daa8c_2976c759","updated":"2025-07-01 10:16:41.000000000","message":"Done","commit_id":"b687c0228a1ec5d484aaee83e3b19cd65cb32806"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42c15421c361147685b8ed92120f53fb8c0f8a79","unresolved":true,"context_lines":[{"line_number":120,"context_line":"          $serialproxy_package_name     \u003d \u0027nova-consoleproxy\u0027"},{"line_number":121,"context_line":"          # Starting with Debian 13, virtlockd lives in a separate plugin package."},{"line_number":122,"context_line":"          if Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":123,"context_line":"            $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":124,"context_line":"          } else {"},{"line_number":125,"context_line":"            $virtlock_package_name         \u003d undef"},{"line_number":126,"context_line":"          }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"f4e4b13d_58e0f478","line":123,"range":{"start_line":123,"start_character":43,"end_line":123,"end_character":44},"updated":"2025-07-04 12:04:12.000000000","message":"align \u003d","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b1b828b1236f4c0917519308c1fe0ed2b8ca144e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          $serialproxy_package_name     \u003d \u0027nova-consoleproxy\u0027"},{"line_number":121,"context_line":"          # Starting with Debian 13, virtlockd lives in a separate plugin package."},{"line_number":122,"context_line":"          if Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":123,"context_line":"            $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":124,"context_line":"          } else {"},{"line_number":125,"context_line":"            $virtlock_package_name         \u003d undef"},{"line_number":126,"context_line":"          }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ff020c07_1aa516b9","line":123,"range":{"start_line":123,"start_character":43,"end_line":123,"end_character":44},"in_reply_to":"f4e4b13d_58e0f478","updated":"2025-07-04 12:15:55.000000000","message":"Done","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"42c15421c361147685b8ed92120f53fb8c0f8a79","unresolved":true,"context_lines":[{"line_number":122,"context_line":"          if Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":123,"context_line":"            $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":124,"context_line":"          } else {"},{"line_number":125,"context_line":"            $virtlock_package_name         \u003d undef"},{"line_number":126,"context_line":"          }"},{"line_number":127,"context_line":"          # Use default provider on Debian"},{"line_number":128,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"a7ec2cff_dcd52460","line":125,"range":{"start_line":125,"start_character":43,"end_line":125,"end_character":44},"updated":"2025-07-04 12:04:12.000000000","message":"ditto","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"b1b828b1236f4c0917519308c1fe0ed2b8ca144e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          if Integer.new($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027]) \u003e\u003d 13 {"},{"line_number":123,"context_line":"            $virtlock_package_name         \u003d \u0027libvirt-daemon-plugin-lockd\u0027"},{"line_number":124,"context_line":"          } else {"},{"line_number":125,"context_line":"            $virtlock_package_name         \u003d undef"},{"line_number":126,"context_line":"          }"},{"line_number":127,"context_line":"          # Use default provider on Debian"},{"line_number":128,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"782f88d8_f2b9a1a5","line":125,"range":{"start_line":125,"start_character":43,"end_line":125,"end_character":44},"in_reply_to":"a7ec2cff_dcd52460","updated":"2025-07-04 12:15:55.000000000","message":"Done","commit_id":"19d8c2d6e700937ab3da0659c6e6ba339e487b64"}]}