)]}'
{"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4a648f156816d7eb6c987c3c5e29e0ad5786e9f2","unresolved":true,"context_lines":[{"line_number":144,"context_line":"  Boolean $sync_db_api                       \u003d true,"},{"line_number":145,"context_line":"  Boolean $db_online_data_migrations         \u003d false,"},{"line_number":146,"context_line":"  String[1] $service_name                    \u003d $nova::params::api_service_name,"},{"line_number":147,"context_line":"  Optional[Variant[String[1],Boolean[false]]] $metadata_service_name \u003d $nova::params::api_metadata_service_name,"},{"line_number":148,"context_line":"  $enable_proxy_headers_parsing              \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":149,"context_line":"  $max_request_body_size                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":150,"context_line":"  $max_limit                                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c94207f7_b2101915","line":147,"range":{"start_line":147,"start_character":69,"end_line":147,"end_character":70},"updated":"2026-05-18 15:42:06.000000000","message":"I\u0027m inclined to fix the indentation of all equals because this line has been the \"longest\" line controlling it.","commit_id":"d649bc8cf17423de6855d018e0a0304ed0bbed21"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f01de6c59b0ccf72317eda28b0e30f85c51110f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  Boolean $sync_db_api                       \u003d true,"},{"line_number":145,"context_line":"  Boolean $db_online_data_migrations         \u003d false,"},{"line_number":146,"context_line":"  String[1] $service_name                    \u003d $nova::params::api_service_name,"},{"line_number":147,"context_line":"  Optional[Variant[String[1],Boolean[false]]] $metadata_service_name \u003d $nova::params::api_metadata_service_name,"},{"line_number":148,"context_line":"  $enable_proxy_headers_parsing              \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":149,"context_line":"  $max_request_body_size                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":150,"context_line":"  $max_limit                                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"67535d8a_030a8811","line":147,"updated":"2026-05-13 16:01:22.000000000","message":"This feels like a hack but without adding some new manage_metadata_service param, I\u0027m not sure of a better solution.","commit_id":"d649bc8cf17423de6855d018e0a0304ed0bbed21"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"d810d4fbf0c544a24afdaafbfdd12de4f0d5dd9e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  Boolean $sync_db_api                       \u003d true,"},{"line_number":145,"context_line":"  Boolean $db_online_data_migrations         \u003d false,"},{"line_number":146,"context_line":"  String[1] $service_name                    \u003d $nova::params::api_service_name,"},{"line_number":147,"context_line":"  Optional[Variant[String[1],Boolean[false]]] $metadata_service_name \u003d $nova::params::api_metadata_service_name,"},{"line_number":148,"context_line":"  $enable_proxy_headers_parsing              \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":149,"context_line":"  $max_request_body_size                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":150,"context_line":"  $max_limit                                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"c94c3bba_4c2d6725","line":147,"in_reply_to":"67535d8a_030a8811","updated":"2026-05-13 16:30:42.000000000","message":"Right it\u0027s sort of a hack. The proper solution would be to not use inheritance, and use module specific hiera data to set the default values. Then it\u0027s easy overwritable even with unset.\n\n\nThe pattern with Boolean[false] is also used in the neutron module, so it\u0027s nothing I invented !","commit_id":"d649bc8cf17423de6855d018e0a0304ed0bbed21"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"284e7da51a46190f3ec70a14c6d570663a964fcb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  Boolean $sync_db_api                       \u003d true,"},{"line_number":145,"context_line":"  Boolean $db_online_data_migrations         \u003d false,"},{"line_number":146,"context_line":"  String[1] $service_name                    \u003d $nova::params::api_service_name,"},{"line_number":147,"context_line":"  Optional[Variant[String[1],Boolean[false]]] $metadata_service_name \u003d $nova::params::api_metadata_service_name,"},{"line_number":148,"context_line":"  $enable_proxy_headers_parsing              \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":149,"context_line":"  $max_request_body_size                     \u003d $facts[\u0027os_service_default\u0027],"},{"line_number":150,"context_line":"  $max_limit                                 \u003d $facts[\u0027os_service_default\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"94cf60ad_a78816f4","line":147,"range":{"start_line":147,"start_character":69,"end_line":147,"end_character":70},"in_reply_to":"c94207f7_b2101915","updated":"2026-05-18 15:43:14.000000000","message":"Done","commit_id":"d649bc8cf17423de6855d018e0a0304ed0bbed21"}]}