)]}'
{"manifests/init.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8df49efa710fac3e98e6a23d3ff8bbf27fc5ec2e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"#   (Optional) Password for message broker authentication"},{"line_number":166,"context_line":"#   Defaults to $::os_service_default."},{"line_number":167,"context_line":"#"},{"line_number":168,"context_line":"# [*log_dir*]"},{"line_number":169,"context_line":"#   (optional) Directory where logs should be stored."},{"line_number":170,"context_line":"#   If set to boolean false or the $::os_service_default, it will not log to"},{"line_number":171,"context_line":"#   any directory."},{"line_number":172,"context_line":"#   Defaults to undef."},{"line_number":173,"context_line":"#"},{"line_number":174,"context_line":"# [*debug*]"},{"line_number":175,"context_line":"#   (optional) Set log output to debug output."},{"line_number":176,"context_line":"#   Defaults to undef"},{"line_number":177,"context_line":"#"},{"line_number":178,"context_line":"# [*use_syslog*]"},{"line_number":179,"context_line":"#   (optional) Use syslog for logging"},{"line_number":180,"context_line":"#   Defaults to undef"},{"line_number":181,"context_line":"#"},{"line_number":182,"context_line":"# [*use_stderr*]"},{"line_number":183,"context_line":"#   (optional) Use stderr for logging"},{"line_number":184,"context_line":"#   Defaults to undef"},{"line_number":185,"context_line":"#"},{"line_number":186,"context_line":"# [*log_facility*]"},{"line_number":187,"context_line":"#   (optional) Syslog facility to receive log lines."},{"line_number":188,"context_line":"#   Defaults to undef"},{"line_number":189,"context_line":"#"},{"line_number":190,"context_line":"# [*notification_transport_url*]"},{"line_number":191,"context_line":"#   (optional) A URL representing the messaging driver to use for notifications"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9abb7d3a_b56d5a9b","line":188,"range":{"start_line":168,"start_character":0,"end_line":188,"end_character":21},"updated":"2016-06-03 19:00:47.000000000","message":"I don\u0027t think we need log parameters here, why not handle only in logging? (Same question for db parameters) we can update logging and db class (remove the pick function)","commit_id":"7ab6c7a3991493bc34dce5670a1d625d8dd84ffb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"54e42d1d817d3bc5852a40fa97b994302f25a50f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_5240cd56","line":277,"range":{"start_line":277,"start_character":3,"end_line":277,"end_character":15},"updated":"2016-06-06 11:32:16.000000000","message":"Emilien can you change log_facility to syslog_log_facility? we don\u0027t have log_facility anymore.","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f0f52f71fb84c505fb6a1ce09e0ea8079055d9e9","unresolved":false,"context_lines":[{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_ef8627b8","line":277,"range":{"start_line":277,"start_character":3,"end_line":277,"end_character":15},"in_reply_to":"7aa08908_5240cd56","updated":"2016-06-06 13:57:14.000000000","message":"Done","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fbcf1ef4282f04813920d4c463b81b4313ca6841","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":281,"context_line":"  $notification_topics                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_d917c8eb","line":278,"range":{"start_line":274,"start_character":0,"end_line":278,"end_character":46},"updated":"2016-06-06 10:27:47.000000000","message":"not sure that we need add it here now","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fb9e13db22f3ba80d91f99708e1e59bbef15dbcf","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":281,"context_line":"  $notification_topics                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_edb63a3c","line":278,"range":{"start_line":274,"start_character":0,"end_line":278,"end_character":46},"in_reply_to":"7aa08908_d27e7dad","updated":"2016-06-06 11:37:47.000000000","message":"Well, not sure that we want this actually, take a look on magnum:\n\nhttps://github.com/openstack/puppet-magnum/blob/master/manifests/init.pp\n\nAnd also we updated cookiecutter:\n\nhttps://github.com/openstack/puppet-openstack-cookiecutter/blob/master/puppet-%7B%7Bcookiecutter.project_name%7D%7D/manifests/db.pp\n\nSo, i believe that we won\u0027t.","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"54e42d1d817d3bc5852a40fa97b994302f25a50f","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":281,"context_line":"  $notification_topics                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_d27e7dad","line":278,"range":{"start_line":274,"start_character":0,"end_line":278,"end_character":46},"in_reply_to":"7aa08908_d917c8eb","updated":"2016-06-06 11:32:16.000000000","message":"I agree with you, but take a look at Emilien comment after upload patch #4, in patch #2 i asked about this.","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7300b5d0192ea80ea6fc3f52a5179e089c835cf6","unresolved":false,"context_lines":[{"line_number":271,"context_line":"  $amqp_sasl_config_name              \u003d $::os_service_default,"},{"line_number":272,"context_line":"  $amqp_username                      \u003d $::os_service_default,"},{"line_number":273,"context_line":"  $amqp_password                      \u003d $::os_service_default,"},{"line_number":274,"context_line":"  $debug                              \u003d undef,"},{"line_number":275,"context_line":"  $use_syslog                         \u003d undef,"},{"line_number":276,"context_line":"  $use_stderr                         \u003d undef,"},{"line_number":277,"context_line":"  $log_facility                       \u003d undef,"},{"line_number":278,"context_line":"  $log_dir                            \u003d undef,"},{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":281,"context_line":"  $notification_topics                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_e8aaa86f","line":278,"range":{"start_line":274,"start_character":0,"end_line":278,"end_character":46},"in_reply_to":"7aa08908_edb63a3c","updated":"2016-06-06 11:58:35.000000000","message":"Since these modules are new, I agree with you (not have these options here)","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fbcf1ef4282f04813920d4c463b81b4313ca6841","unresolved":false,"context_lines":[{"line_number":279,"context_line":"  $notification_transport_url         \u003d $::os_service_default,"},{"line_number":280,"context_line":"  $notification_driver                \u003d $::os_service_default,"},{"line_number":281,"context_line":"  $notification_topics                \u003d $::os_service_default,"},{"line_number":282,"context_line":"  $database_connection                \u003d undef,"},{"line_number":283,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":284,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":285,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":286,"context_line":"  $database_max_pool_size             \u003d undef,"},{"line_number":287,"context_line":"  $database_max_retries               \u003d undef,"},{"line_number":288,"context_line":"  $database_retry_interval            \u003d undef,"},{"line_number":289,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":290,"context_line":") inherits octavia::params {"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  include ::octavia::db"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_19d83053","line":289,"range":{"start_line":282,"start_character":0,"end_line":289,"end_character":46},"updated":"2016-06-06 10:27:47.000000000","message":"same","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fbcf1ef4282f04813920d4c463b81b4313ca6841","unresolved":false,"context_lines":[{"line_number":289,"context_line":"  $database_max_overflow              \u003d undef,"},{"line_number":290,"context_line":") inherits octavia::params {"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  include ::octavia::db"},{"line_number":293,"context_line":"  include ::octavia::logging"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"  package { \u0027octavia\u0027:"},{"line_number":296,"context_line":"    ensure \u003d\u003e $ensure_package,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_f9c8c476","line":293,"range":{"start_line":292,"start_character":0,"end_line":293,"end_character":28},"updated":"2016-06-06 10:27:47.000000000","message":"we can keep these includes, but i think we can remove picks from both classes.","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"92e046066f2d2d96e85c2d950c6e96e95774687b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    (optional) Use stderr for logging"},{"line_number":17,"context_line":"#    Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*syslog_log_facility*]"},{"line_number":20,"context_line":"#    (Optional) Syslog facility to receive log lines."},{"line_number":21,"context_line":"#    This option is ignored if log_config_append is set."},{"line_number":22,"context_line":"#    Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_da832bcb","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":26},"updated":"2016-06-06 14:08:01.000000000","message":"actually, we have log_facility parameter. so you don\u0027t need to change this.","commit_id":"9664b3e43a353ebf3e0309a3e47dc13672ce4c3e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"73ec579746b585ce8020abf3376b1051af56e2bc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    (optional) Use stderr for logging"},{"line_number":17,"context_line":"#    Defaults to $::os_service_default"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"#  [*syslog_log_facility*]"},{"line_number":20,"context_line":"#    (Optional) Syslog facility to receive log lines."},{"line_number":21,"context_line":"#    This option is ignored if log_config_append is set."},{"line_number":22,"context_line":"#    Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7aa08908_75f32874","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":26},"in_reply_to":"7aa08908_da832bcb","updated":"2016-06-06 14:20:04.000000000","message":"Done","commit_id":"9664b3e43a353ebf3e0309a3e47dc13672ce4c3e"}],"manifests/params.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"517343acd2a143c866b0176fc33e1f101cd5eee2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      $common_package_name \u003d \u0027openstack-octavia-common\u0027"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    \u0027Debian\u0027: {"},{"line_number":10,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    default: {"},{"line_number":13,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_ae873711","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":45},"updated":"2016-06-04 01:45:05.000000000","message":"This does not seems to be the correct package name \u003d/\n\nThe only thing i\u0027ve found was https://wiki.openstack.org/wiki/Neutron/LBaaS/HowToRun#Ubuntu_Packages_Setup","commit_id":"f55298593b0a945ff1027b72555ef662befc5300"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"cc926fb8e8dfec0fcf0ba7dd8f5e994cb359407a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      $common_package_name \u003d \u0027openstack-octavia-common\u0027"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    \u0027Debian\u0027: {"},{"line_number":10,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    default: {"},{"line_number":13,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_d702166f","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":45},"updated":"2016-06-04 03:54:38.000000000","message":"since it\u0027s not package why not let undef?","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2e4e07092ac1ca7ad34dd3edd3bb6e1c085af96b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      $common_package_name \u003d \u0027openstack-octavia-common\u0027"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    \u0027Debian\u0027: {"},{"line_number":10,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    default: {"},{"line_number":13,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_02573a03","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":45},"in_reply_to":"7aa08908_7706c221","updated":"2016-06-04 04:24:35.000000000","message":"oh that\u0027s awesome ;)","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b8b3f24aedd7403a0fb251a870ab0d6264b97ef5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      $common_package_name \u003d \u0027openstack-octavia-common\u0027"},{"line_number":8,"context_line":"    }"},{"line_number":9,"context_line":"    \u0027Debian\u0027: {"},{"line_number":10,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":11,"context_line":"    }"},{"line_number":12,"context_line":"    default: {"},{"line_number":13,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_7706c221","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":45},"in_reply_to":"7aa08908_d702166f","updated":"2016-06-04 04:12:19.000000000","message":"it will be created during Newton, let\u0027s keep it.","commit_id":"967b818fe2e4d6bdb5dbad37882552f91255d404"}]}