)]}'
{"manifests/api.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"4cd87b8a4c924f7822bae799a79b18713ff646c1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  Class[\u0027octavia::policy\u0027] ~\u003e Service[\u0027octavia-api\u0027]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  Package[\u0027octavia-api\u0027] -\u003e Service[\u0027octavia-api\u0027]"},{"line_number":71,"context_line":"  Package[\u0027octavia-api\u0027] -\u003e Class[\u0027octavia::policy\u0027]"},{"line_number":72,"context_line":"  package { \u0027octavia-api\u0027:"},{"line_number":73,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":74,"context_line":"    name   \u003d\u003e $::octavia::params::api_package_name,"},{"line_number":75,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027octavia-package\u0027],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_ed0f252c","line":72,"range":{"start_line":71,"start_character":2,"end_line":72,"end_character":26},"updated":"2016-06-07 07:47:21.000000000","message":"nit maybe need to add an empty line between these two lines - for readability","commit_id":"087841ed588964277b822d1c3232a9c3fe84895e"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"63860b64883ce36904f553b5475e2d4c612d9cb7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":53,"context_line":"  $keystone_user         \u003d \u0027octavia\u0027,"},{"line_number":54,"context_line":"  $keystone_tenant       \u003d \u0027services\u0027,"},{"line_number":55,"context_line":"  $keystone_password     \u003d false,"},{"line_number":56,"context_line":"  $keystone_auth_uri     \u003d \u0027http://127.0.0.0:5000\u0027,"},{"line_number":57,"context_line":"  $keystone_identity_uri \u003d $::os_service_default,"},{"line_number":58,"context_line":"  $host                  \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_202a6bdb","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":33},"updated":"2016-06-08 13:51:13.000000000","message":"Do we need a default value for password if it\u0027s mandatory? Or please add an additional check that it\u0027s not equal to \u0027false\u0027","commit_id":"5d772264e9a69e82e83ec4fda7abafec3a98da9f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6e0dfb7c82b34f9d0cf018fc3f8f4b2185acf584","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":53,"context_line":"  $keystone_user         \u003d \u0027octavia\u0027,"},{"line_number":54,"context_line":"  $keystone_tenant       \u003d \u0027services\u0027,"},{"line_number":55,"context_line":"  $keystone_password     \u003d false,"},{"line_number":56,"context_line":"  $keystone_auth_uri     \u003d \u0027http://127.0.0.0:5000\u0027,"},{"line_number":57,"context_line":"  $keystone_identity_uri \u003d $::os_service_default,"},{"line_number":58,"context_line":"  $host                  \u003d \u00270.0.0.0\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_9661e9ab","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":33},"in_reply_to":"7aa08908_202a6bdb","updated":"2016-06-08 14:04:55.000000000","message":"you\u0027re right, I\u0027ll fix it in a next patchset, thanks","commit_id":"5d772264e9a69e82e83ec4fda7abafec3a98da9f"}],"manifests/params.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2e6be79505d1fe3c8365fa7394c93e0079c2d46f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u0027Debian\u0027: {"},{"line_number":12,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":13,"context_line":"      $api_package_name    \u003d \u0027octavia-api\u0027"},{"line_number":14,"context_line":"      $api_service_name    \u003d \u0027octavia-api\u0027"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    default: {"},{"line_number":17,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_ab457a43","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":41},"updated":"2016-06-09 00:47:13.000000000","message":"if api_service_name is really the same for both osfamily, why not put before the case?","commit_id":"317e31b9d93c42054e78d4408acef6a9cb48e869"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"63958e647e639e18672a80e3d517d27443cf619d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u0027Debian\u0027: {"},{"line_number":12,"context_line":"      $common_package_name \u003d \u0027octavia-common\u0027"},{"line_number":13,"context_line":"      $api_package_name    \u003d \u0027octavia-api\u0027"},{"line_number":14,"context_line":"      $api_service_name    \u003d \u0027octavia-api\u0027"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"    default: {"},{"line_number":17,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7aa08908_abbd7703","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":41},"in_reply_to":"7aa08908_ab457a43","updated":"2016-06-09 02:47:13.000000000","message":"yeah we could improve that, it\u0027s just that usually service names are different. I\u0027ll improve it in next patchset, thanks","commit_id":"317e31b9d93c42054e78d4408acef6a9cb48e869"}]}