)]}'
{"manifests/worker.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c46ffe5b287b1a097b3b8ef50b486edc21771791","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  } else {"},{"line_number":53,"context_line":"    if $manage_nova_flavor {"},{"line_number":54,"context_line":"      $nova_flavor_default \u003d\u003e {"},{"line_number":55,"context_line":"        \"octavia_$amp_flavor_id\" \u003d\u003e {"},{"line_number":56,"context_line":"          \u0027ensure\u0027\u003d\u003e \u0027present\u0027,"},{"line_number":57,"context_line":"          \u0027id\u0027    \u003d\u003e $amp_flavor_id,"},{"line_number":58,"context_line":"          \u0027ram\u0027   \u003d\u003e \u00271024\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_b1fe1369","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":31},"updated":"2016-06-10 21:46:28.000000000","message":"${amp_flavor_id}","commit_id":"2159a88ec2b40684bbd41739fc6ce46609f593c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91465768c8650f8967fc320e0ece4e9db82650db","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  } else {"},{"line_number":53,"context_line":"    if $manage_nova_flavor {"},{"line_number":54,"context_line":"      $nova_flavor_default \u003d\u003e {"},{"line_number":55,"context_line":"        \"octavia_$amp_flavor_id\" \u003d\u003e {"},{"line_number":56,"context_line":"          \u0027ensure\u0027\u003d\u003e \u0027present\u0027,"},{"line_number":57,"context_line":"          \u0027id\u0027    \u003d\u003e $amp_flavor_id,"},{"line_number":58,"context_line":"          \u0027ram\u0027   \u003d\u003e \u00271024\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_317863f2","line":55,"range":{"start_line":55,"start_character":17,"end_line":55,"end_character":31},"in_reply_to":"7aa08908_b1fe1369","updated":"2016-06-10 21:49:21.000000000","message":"Done","commit_id":"2159a88ec2b40684bbd41739fc6ce46609f593c3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c46ffe5b287b1a097b3b8ef50b486edc21771791","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      $nova_flavor_real \u003d merge($nova_flavor_default, $nova_flavor_config)"},{"line_number":64,"context_line":"      create_resources(\u0027nova_flavor\u0027, $nova_flavor_real)"},{"line_number":65,"context_line":"      Service\u003c| tag \u003d\u003d \u0027nova-service\u0027 |\u003e -\u003e Service[\u0027octavia-worker\u0027]"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_d1f3df9d","line":65,"updated":"2016-06-10 21:46:28.000000000","message":"is there any dependency on the flavor existing before the worker starts?","commit_id":"2159a88ec2b40684bbd41739fc6ce46609f593c3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ca3a5e9bdc026c80478a44a39acf9c84d45094aa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      $nova_flavor_real \u003d merge($nova_flavor_default, $nova_flavor_config)"},{"line_number":64,"context_line":"      create_resources(\u0027nova_flavor\u0027, $nova_flavor_real)"},{"line_number":65,"context_line":"      Service\u003c| tag \u003d\u003d \u0027nova-service\u0027 |\u003e -\u003e Service[\u0027octavia-worker\u0027]"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_d14f5fbc","line":65,"in_reply_to":"7aa08908_918677d9","updated":"2016-06-10 21:50:12.000000000","message":"Probably should restrict it to Nova::Flavor\u003c| tag \u003d\u003d \u0027octavia\u0027 |\u003e","commit_id":"2159a88ec2b40684bbd41739fc6ce46609f593c3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91465768c8650f8967fc320e0ece4e9db82650db","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      $nova_flavor_real \u003d merge($nova_flavor_default, $nova_flavor_config)"},{"line_number":64,"context_line":"      create_resources(\u0027nova_flavor\u0027, $nova_flavor_real)"},{"line_number":65,"context_line":"      Service\u003c| tag \u003d\u003d \u0027nova-service\u0027 |\u003e -\u003e Service[\u0027octavia-worker\u0027]"},{"line_number":66,"context_line":"    }"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7aa08908_918677d9","line":65,"in_reply_to":"7aa08908_d1f3df9d","updated":"2016-06-10 21:49:21.000000000","message":"So, here\u0027s how it will work.\n\n1) Nova API will be deployed and started.\n2) Once Nova API works, Nova Flavor will be created: https://github.com/openstack/puppet-nova/blob/master/lib/puppet/type/nova_flavor.rb#L57-L60\n3) Once we have the flavor, we have to start Octavia worker, so you made me realize I need to change it to:\n\n  Nova::Flavor\u003c||\u003e ~\u003e Service[\u0027octavia-worker\u0027]","commit_id":"2159a88ec2b40684bbd41739fc6ce46609f593c3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b4abbe46cf8242cdbf4cc4617818e5d519d02779","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"  } else {"},{"line_number":53,"context_line":"    if $manage_nova_flavor {"},{"line_number":54,"context_line":"      $nova_flavor_default \u003d\u003e {"},{"line_number":55,"context_line":"        \"octavia_${amp_flavor_id}\" \u003d\u003e {"},{"line_number":56,"context_line":"          \u0027ensure\u0027\u003d\u003e \u0027present\u0027,"},{"line_number":57,"context_line":"          \u0027id\u0027    \u003d\u003e $amp_flavor_id,"},{"line_number":58,"context_line":"          \u0027ram\u0027   \u003d\u003e \u00271024\u0027,"},{"line_number":59,"context_line":"          \u0027disk\u0027  \u003d\u003e \u00272\u0027,"},{"line_number":60,"context_line":"          \u0027vcpus\u0027 \u003d\u003e \u00271\u0027,"},{"line_number":61,"context_line":"        }"},{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      $nova_flavor_real \u003d merge($nova_flavor_default, $nova_flavor_config)"},{"line_number":64,"context_line":"      create_resources(\u0027nova_flavor\u0027, $nova_flavor_real)"},{"line_number":65,"context_line":"      Nova_flavor\u003c||\u003e ~\u003e Service[\u0027octavia-worker\u0027]"},{"line_number":66,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_51340ffa","line":63,"range":{"start_line":54,"start_character":0,"end_line":63,"end_character":74},"updated":"2016-06-10 21:58:00.000000000","message":"Technically this gets kinda weird around the defaults. create_resources takes a default as a 3rd param but it\u0027s a flat hash. We may just wish to do something like...\n\n$octavia_flavor \u003d\u003e { \"octavia_${amp_flavor_id}\" \u003d\u003e { \u0027id\u0027 \u003d\u003e $amp_flavor_id } }\n$octavia_flavor_defaults \u003d\u003e {\n  \u0027ensure\u0027 \u003d\u003e \u0027present\u0027,\n  \u0027ram\u0027    \u003d\u003e \u00271024\u0027,\n  \u0027disk\u0027   \u003d\u003e \u00272\u0027,\n  \u0027vcpus\u0027  \u003d\u003e \u00271\u0027,\n  \u0027tag\u0027    \u003d\u003e [\u0027octavia\u0027]\n}\n$nova_flavor_defaults \u003d merge($octavia_flavor_defaults, $nova_flavor_config}\ncreate_resource(\u0027nova_flavor\u0027, $octavia_flavor, $nova_flavor_defaults)\nNova_flavor\u003c| tag \u003d\u003d \u0027octavia\u0027 |\u003e ~\u003e Service[\u0027octavia-worker\u0027]","commit_id":"bf247dc44c831e67f828a347296257566d55a0b1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"934d0136dd7949b4eba3566f1c48fc58ec87cd37","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $manage_service     \u003d true,"},{"line_number":38,"context_line":"  $enabled            \u003d true,"},{"line_number":39,"context_line":"  $package_ensure     \u003d \u0027present\u0027,"},{"line_number":40,"context_line":"  $amp_flavor_id      \u003d \u002765\u0027,"},{"line_number":41,"context_line":"  $manage_nova_flavor \u003d true,"},{"line_number":42,"context_line":"  $nova_flavor_config \u003d {},"},{"line_number":43,"context_line":") inherits octavia::params {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a9d85d2_6e799993","line":40,"updated":"2016-06-20 19:20:09.000000000","message":"if we want this parameter to be required, drop the default value and update doc to say this param is required.","commit_id":"2a4051291aa951e6d4eacbce4cccddeb90dbcef6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"aeb2faeb2986432c3906df22f7e1a9a6d6cb23fb","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    \u0027controller_worker/amp_image_tag\u0027         : value \u003d\u003e $amp_image_tag;"},{"line_number":124,"context_line":"    \u0027controller_worker/amp_boot_network_list\u0027 : value \u003d\u003e $amp_boot_network_list;"},{"line_number":125,"context_line":"    \u0027controller_worker/loadbalancer_topology\u0027 : value \u003d\u003e $loadbalancer_topology;"},{"line_number":126,"context_line":"    \u0027oslo_messaging/topic\u0027                    : value \u003d\u003e $topic;"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"dada55a8_e84bcfae","line":126,"updated":"2016-07-18 14:11:35.000000000","message":"Don\u0027t add this parameter in this class, it looks like something common so it goes in puppet-oslo and be consummed in init.pp here.\nThough I\u0027m not sure \u0027topic\u0027 is a valid parameter in current oslo messaging. If not, just add it in init.pp, so we can re-use it for other services.\n\nAlso see the duplicated resource: http://logs.openstack.org/95/328495/10/check/gate-puppet-octavia-puppet-beaker-rspec-centos-7/c8af01c/console.html.gz#_2016-07-15_19_00_52_146861","commit_id":"30e6ef506c1f82d862ec05a9f102ca9b249605b0"}],"metadata.json":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"025943f1cc16d2015ad29c4eef99c5fd3f5a9c6f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  \"dependencies\": ["},{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d 4.2.0 \u003c5.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d8.0.0 \u003c9.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/nova\", \"version_requirement\": \"\u003e\u003d8.0.0 \u003c9.0.0\" },"},{"line_number":34,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d9.0.0 \u003c10.0.0\" },"},{"line_number":35,"context_line":"    { \"name\": \"openstack/oslo\", \"version_requirement\": \"\u003e\u003d9.0.0 \u003c10.0.0\" }"},{"line_number":36,"context_line":"  ]"}],"source_content_type":"application/json","patch_set":10,"id":"fad55976_fb161054","line":33,"range":{"start_line":32,"start_character":3,"end_line":33,"end_character":74},"updated":"2016-07-15 19:17:33.000000000","message":"we are in 9.1 i think you need to update to \u003e\u003d 9.1.0 \u003c10.0.0\n\nalso update oslo and openstacklib","commit_id":"30e6ef506c1f82d862ec05a9f102ca9b249605b0"}],"spec/acceptance/octavia_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"aeb2faeb2986432c3906df22f7e1a9a6d6cb23fb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Need more investigation."},{"line_number":66,"context_line":"        octavia_config {"},{"line_number":67,"context_line":"          \u0027oslo_messaging/topic\u0027: value \u003d\u003e \u0027octavia\u0027;"},{"line_number":68,"context_line":"        }"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":"      EOS"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":10,"id":"dada55a8_48c77b12","line":68,"updated":"2016-07-18 14:11:35.000000000","message":"you can remove the workaround.","commit_id":"30e6ef506c1f82d862ec05a9f102ca9b249605b0"}]}