)]}'
{"manifests/worker.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0ec024924813dc3d01f26e19ce654cab300b91fb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $network_driver        \u003d \u0027allowed_address_pairs_driver\u0027,"},{"line_number":106,"context_line":"  $amp_ssh_key_name      \u003d \u0027octavia-ssh-key\u0027,"},{"line_number":107,"context_line":"  $enable_ssh_access     \u003d true,"},{"line_number":108,"context_line":"  $key_path              \u003d \u0027/etc/octavia/.ssh/octavia_ssh_key\u0027,"},{"line_number":109,"context_line":"  $manage_keygen         \u003d false,"},{"line_number":110,"context_line":"  $amp_project_name      \u003d undef"},{"line_number":111,"context_line":") inherits octavia::params {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_dca5054a","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":63},"updated":"2018-10-19 14:12:37.000000000","message":"Move this as the last params, add ### DEPRECATED PARAMS before, set the default value to undef","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cfca5a40e301fb9c1bb5861c0e3d819a5c76099d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $network_driver        \u003d \u0027allowed_address_pairs_driver\u0027,"},{"line_number":106,"context_line":"  $amp_ssh_key_name      \u003d \u0027octavia-ssh-key\u0027,"},{"line_number":107,"context_line":"  $enable_ssh_access     \u003d true,"},{"line_number":108,"context_line":"  $key_path              \u003d \u0027/etc/octavia/.ssh/octavia_ssh_key\u0027,"},{"line_number":109,"context_line":"  $manage_keygen         \u003d false,"},{"line_number":110,"context_line":"  $amp_project_name      \u003d undef"},{"line_number":111,"context_line":") inherits octavia::params {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_82a8868b","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":63},"in_reply_to":"3f79a3b5_dca5054a","updated":"2018-10-19 15:14:13.000000000","message":"I am not deprecating this parameter. What I am proposing is to stop setting [haproxy_amphora]/key_path in octavia config file because that option no longer exist.","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0ec024924813dc3d01f26e19ce654cab300b91fb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  if ! is_service_default($loadbalancer_topology) and  ! ($loadbalancer_topology in [\u0027SINGLE\u0027, \u0027ACTIVE_STANDBY\u0027]) {"},{"line_number":118,"context_line":"      fail(\u0027load balancer topology must be one of SINGLE or ACTIVE_STANDBY\u0027)"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  if ! $amp_flavor_id {"},{"line_number":122,"context_line":"    if $manage_nova_flavor {"},{"line_number":123,"context_line":"      fail(\u0027When managing Nova flavor, octavia::worker::amp_flavor_id is required.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_5c67b525","line":120,"updated":"2018-10-19 14:12:37.000000000","message":"add a warning here\nif $key_path {\n  warning(\u0027octavia::worker::key_path is deprecated and will be removed in a future release\u0027)\n}","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"ec81dceee40ccd077ce38b122200c669ed22ef9b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    fail(\u0027SSH key management cannot be enabled when SSH key access is disabled\u0027)"},{"line_number":174,"context_line":"  }"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"  if $manage_keygen {"},{"line_number":177,"context_line":"    exec {\u0027create_amp_key_dir\u0027:"},{"line_number":178,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":179,"context_line":"      command \u003d\u003e \"mkdir -p ${key_path}\","},{"line_number":180,"context_line":"      creates \u003d\u003e $key_path"},{"line_number":181,"context_line":"    }"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    file { \u0027amp_key_dir\u0027:"},{"line_number":184,"context_line":"      ensure \u003d\u003e directory,"},{"line_number":185,"context_line":"      path   \u003d\u003e $key_path,"},{"line_number":186,"context_line":"      mode   \u003d\u003e \u00270700\u0027,"},{"line_number":187,"context_line":"      group  \u003d\u003e \u0027octavia\u0027,"},{"line_number":188,"context_line":"      owner  \u003d\u003e \u0027octavia\u0027"},{"line_number":189,"context_line":"    }"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    ssh_keygen { $amp_ssh_key_name:"},{"line_number":192,"context_line":"      user     \u003d\u003e \u0027octavia\u0027,"},{"line_number":193,"context_line":"      type     \u003d\u003e \u0027rsa\u0027,"},{"line_number":194,"context_line":"      bits     \u003d\u003e 2048,"},{"line_number":195,"context_line":"      filename \u003d\u003e \"${key_path}/${amp_ssh_key_name}\","},{"line_number":196,"context_line":"      comment  \u003d\u003e \u0027Used for Octavia Service VM\u0027"},{"line_number":197,"context_line":"    }"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    Package\u003c| tag \u003d\u003d \u0027octavia-package\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_3708c07e","line":196,"range":{"start_line":176,"start_character":0,"end_line":196,"end_character":47},"updated":"2018-10-21 14:44:41.000000000","message":"it is being used here","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"}],"releasenotes/notes/remove-haproxy-amphora-key-path-bf21706a6504e28f.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"a64ef612603a309746b354978310e9469069b0f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Octavia option [haproxy_amphora]/key_path will no longer be set. None of"},{"line_number":4,"context_line":"    the maintained Octavia releases support it (removed in Mitaka)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_1c5a9d50","line":3,"updated":"2018-10-19 14:13:33.000000000","message":"add a notice here that the key_path option in the puppet interface for octavia::worker is deprecated and will be removed.","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"cfca5a40e301fb9c1bb5861c0e3d819a5c76099d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Octavia option [haproxy_amphora]/key_path will no longer be set. None of"},{"line_number":4,"context_line":"    the maintained Octavia releases support it (removed in Mitaka)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_2278922a","line":3,"in_reply_to":"3f79a3b5_1c5a9d50","updated":"2018-10-19 15:14:13.000000000","message":"see my other comment.","commit_id":"ba022e30c29ed6bed797926312d8687412d26972"}]}