)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3e79af4d7351977058985da31477d4a1f98fa770","unresolved":false,"context_lines":[{"line_number":10,"context_line":"parameter that sets the [health_manager]/controller_ip_port_list"},{"line_number":11,"context_line":"configuration option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The option is in the health_manager section but is only used by"},{"line_number":14,"context_line":"the octavia worker service when it compiles the amphora configuration."},{"line_number":15,"context_line":"[1] [2]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]"},{"line_number":18,"context_line":"https://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/health_daemon/health_sender.py#L37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_d3e47c44","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":7},"updated":"2018-11-09 08:13:09.000000000","message":"This is not accurate. The health manager also uses this option. See [1] and [2]. I\u0027d suggest setting it in the newly created controller.pp\n\n[1] https://review.openstack.org/#/c/596373/\n[2] https://launchpad.net/bugs/1788571","commit_id":"421909c3fc42819ee91fe7fa0930e52bf0a07486"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"971f508ea290a80c6c71ae7b916c17a1efd94d9a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"parameter that sets the [health_manager]/controller_ip_port_list"},{"line_number":11,"context_line":"configuration option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The option is in the health_manager section but is only used by"},{"line_number":14,"context_line":"the octavia worker service when it compiles the amphora configuration."},{"line_number":15,"context_line":"[1] [2]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]"},{"line_number":18,"context_line":"https://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/health_daemon/health_sender.py#L37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_e43526a8","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"3f79a3b5_d3e47c44","updated":"2018-11-09 21:20:16.000000000","message":"That Launchpad bug [1] doesn\u0027t seems related, it\u0027s not the same config option being spoken about.\n\nCan you point out where in the Octavia code the health-manager service is using this configuration option? IMO this option is misplaced in Octavia, but what I can my statement is accurate and it\u0027s only the Octavia worker service that is using the controll_ip_port_list to populate the configuration inside the amphora. [2] [3]\n\n[1] https://bugs.launchpad.net/tripleo/+bug/1788571\n[1]\nhttps://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/health_daemon/health_sender.py#L37\n[2]\nhttps://github.com/openstack/octavia/blob/master/octavia/controller/worker/tasks/compute_tasks.py#L76","commit_id":"421909c3fc42819ee91fe7fa0930e52bf0a07486"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"33ac698c18c42d5f2d90c76040080cb5a0db533a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"parameter that sets the [health_manager]/controller_ip_port_list"},{"line_number":11,"context_line":"configuration option."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The option is in the health_manager section but is only used by"},{"line_number":14,"context_line":"the octavia worker service when it compiles the amphora configuration."},{"line_number":15,"context_line":"[1] [2]"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1]"},{"line_number":18,"context_line":"https://github.com/openstack/octavia/blob/master/octavia/amphorae/backends/health_daemon/health_sender.py#L37"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_b0a733bc","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"3f79a3b5_e43526a8","updated":"2018-11-14 08:34:03.000000000","message":"Whenever an amphora is failed over by the health manager, the health manager runs tasks (TaskFlow). One of those is task ComputeCreate which calls out build_agent_config [1]. It then loads controller_ip_port_list from configuration [2]. This is why that configuration option, along with many others, is required to be available not only to the worker service. That was why I proposed patch [3] with the use case of composable roles in mind.\n\n\n[1] https://github.com/openstack/octavia/blob/1b71a56791b094988dfbbf731c806c527c63dbf4/octavia/controller/worker/tasks/compute_tasks.py#L77-L78\n[2] https://github.com/openstack/octavia/blob/1b71a56791b094988dfbbf731c806c527c63dbf4/octavia/amphorae/backends/agent/agent_jinja_cfg.py#L52\n[3] https://review.openstack.org/#/c/612395/","commit_id":"421909c3fc42819ee91fe7fa0930e52bf0a07486"}]}