)]}'
{"manifests/health_manager.pp":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e8cc7e01568e1387f1d6d73eb89e749575845835","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027health_manager/event_streamer_driver\u0027  : value \u003d\u003e $event_streamer_driver;"},{"line_number":77,"context_line":"    \u0027health_manager/bind_ip\u0027                : value \u003d\u003e $ip;"},{"line_number":78,"context_line":"    \u0027health_manager/bind_port\u0027              : value \u003d\u003e $port;"},{"line_number":79,"context_line":"    \u0027heatlh_manager/status_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":80,"context_line":"  }"},{"line_number":81,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_7091f743","line":79,"range":{"start_line":79,"start_character":20,"end_line":79,"end_character":41},"updated":"2018-12-20 20:44:32.000000000","message":"status_update_threads is deprecated. It was split out in two new configuration parameters: health_update_threads and stats_update_threads. Available from Queens. We should create two separate parameters here too.\n\nhttps://review.openstack.org/#/c/581585/","commit_id":"7d6dd68d63ef2d1d5d46ea1b39f80b4ad6f37557"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8f1d9be918431c22c701af117abdca9cd7ef8573","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $event_streamer_driver \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $ip                    \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $port                  \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $workers               \u003d $::os_workers,"},{"line_number":45,"context_line":") inherits octavia::params {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_a6ce79b3","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":41},"updated":"2018-12-20 21:55:10.000000000","message":"Why not two worker parameters?\n\nhealth_update_workers \u003d $::os_workers,\nstats_update_workers  \u003d $::os_workers,","commit_id":"ad4751c1041aded1e477389b478b565455678664"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"8b0cdcc4591f080c407eea2dc88be28465495133","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $event_streamer_driver \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $ip                    \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $port                  \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $workers               \u003d $::os_workers,"},{"line_number":45,"context_line":") inherits octavia::params {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_e99f5a60","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":41},"in_reply_to":"3f79a3b5_a6ce79b3","updated":"2018-12-21 12:17:32.000000000","message":"Each of these will be set to $workers -- we will set the health/status_update_workers in the configuration section. \n\nThe only reason to break them out would be to set them to different values.","commit_id":"ad4751c1041aded1e477389b478b565455678664"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"180187b2b43065d9b2ca482052fd07781ae9b5f5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $event_streamer_driver \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $ip                    \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $port                  \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $workers               \u003d $::os_workers,"},{"line_number":45,"context_line":") inherits octavia::params {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_29d6b2f9","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":41},"in_reply_to":"3f79a3b5_e99f5a60","updated":"2018-12-21 13:31:47.000000000","message":"\u003e The only reason to break them out would be to set them to different\n \u003e values.\n\nThat was the point I was trying to make :)\nI can live without breaking them out until proven necessary.","commit_id":"ad4751c1041aded1e477389b478b565455678664"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8f1d9be918431c22c701af117abdca9cd7ef8573","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027health_manager/event_streamer_driver\u0027  : value \u003d\u003e $event_streamer_driver;"},{"line_number":77,"context_line":"    \u0027health_manager/bind_ip\u0027                : value \u003d\u003e $ip;"},{"line_number":78,"context_line":"    \u0027health_manager/bind_port\u0027              : value \u003d\u003e $port;"},{"line_number":79,"context_line":"    \u0027heatlh_manager/status_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":80,"context_line":"    \u0027heatlh_manager/health_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":81,"context_line":"    \u0027heatlh_manager/stats_update_threads\u0027   : value \u003d\u003e $workers;"},{"line_number":82,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_66762194","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":64},"updated":"2018-12-20 21:55:10.000000000","message":"Just drop this altogether. status_update_threads is deprecated and, if set, overrides health_update_threads and stats_update_threads internally in octavia side.","commit_id":"ad4751c1041aded1e477389b478b565455678664"},{"author":{"_account_id":10061,"name":"Joe Talerico","email":"jtaleric@redhat.com","username":"rook"},"change_message_id":"8b0cdcc4591f080c407eea2dc88be28465495133","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027health_manager/event_streamer_driver\u0027  : value \u003d\u003e $event_streamer_driver;"},{"line_number":77,"context_line":"    \u0027health_manager/bind_ip\u0027                : value \u003d\u003e $ip;"},{"line_number":78,"context_line":"    \u0027health_manager/bind_port\u0027              : value \u003d\u003e $port;"},{"line_number":79,"context_line":"    \u0027heatlh_manager/status_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":80,"context_line":"    \u0027heatlh_manager/health_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":81,"context_line":"    \u0027heatlh_manager/stats_update_threads\u0027   : value \u003d\u003e $workers;"},{"line_number":82,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_09a3b6b0","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":64},"in_reply_to":"3f79a3b5_66762194","updated":"2018-12-21 12:17:32.000000000","message":"Roger.","commit_id":"ad4751c1041aded1e477389b478b565455678664"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b353273bab78ddf7c88c494c2518146786989215","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $event_streamer_driver \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $ip                    \u003d $::os_service_default,"},{"line_number":43,"context_line":"  $port                  \u003d $::os_service_default,"},{"line_number":44,"context_line":"  $workers               \u003d $::os_workers,"},{"line_number":45,"context_line":") inherits octavia::params {"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1f769fc5_0c14c79f","line":44,"updated":"2018-12-27 22:49:19.000000000","message":"please add unit tests in specs/classes directory","commit_id":"ecb8d91aff19e012bea6a41a302df96a4290ff31"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d4c6bfa8ef85793d201acad0762d8e5dded142f9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027health_manager/event_streamer_driver\u0027  : value \u003d\u003e $event_streamer_driver;"},{"line_number":77,"context_line":"    \u0027health_manager/bind_ip\u0027                : value \u003d\u003e $ip;"},{"line_number":78,"context_line":"    \u0027health_manager/bind_port\u0027              : value \u003d\u003e $port;"},{"line_number":79,"context_line":"    \u0027heatlh_manager/health_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":80,"context_line":"    \u0027heatlh_manager/stats_update_threads\u0027   : value \u003d\u003e $workers;"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dfd5e7cf_1517cfef","line":79,"range":{"start_line":79,"start_character":5,"end_line":79,"end_character":11},"updated":"2019-01-09 15:54:36.000000000","message":"This is misspelled","commit_id":"a85cd1a9dab248b6c66966436a53eb12f592678b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d4c6bfa8ef85793d201acad0762d8e5dded142f9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u0027health_manager/bind_ip\u0027                : value \u003d\u003e $ip;"},{"line_number":78,"context_line":"    \u0027health_manager/bind_port\u0027              : value \u003d\u003e $port;"},{"line_number":79,"context_line":"    \u0027heatlh_manager/health_update_threads\u0027  : value \u003d\u003e $workers;"},{"line_number":80,"context_line":"    \u0027heatlh_manager/stats_update_threads\u0027   : value \u003d\u003e $workers;"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dfd5e7cf_553a3734","line":80,"range":{"start_line":80,"start_character":5,"end_line":80,"end_character":11},"updated":"2019-01-09 15:54:36.000000000","message":"same","commit_id":"a85cd1a9dab248b6c66966436a53eb12f592678b"}],"spec/classes/octavia_health_manager_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"350e3c734712d11842d9b4ea8a93f740d69d9f9c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"      it { is_expected.to contain_octavia_config(\u0027health_manager/stats_update_threads\u0027).with_value(8) }"},{"line_number":109,"context_line":"    end"},{"line_number":110,"context_line":"  end"},{"line_number":111,"context_line":"  it \u0027configures worker parameters\u0027 do"},{"line_number":112,"context_line":"    is_expected.to contain_octavia_config(\u0027health_manager/health_update_threads\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":113,"context_line":"    is_expected.to contain_octavia_config(\u0027health_manager/stats_update_threads\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":114,"context_line":"  end "},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  on_supported_os({"},{"line_number":117,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"bfdaf3ff_b01d8910","line":114,"range":{"start_line":111,"start_character":0,"end_line":114,"end_character":6},"updated":"2019-01-16 19:16:51.000000000","message":"This needs to be in the shared example context.  You can move it into the \"with minimal parameters\" context","commit_id":"01d13ad6865402cc51e59051ce377b5bc52e2385"}],"spec/classes/octavia_worker_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d676c0891f143dc7b4b5604c4bb794cf8cac2c44","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      is_expected.to contain_octavia_config(\u0027haproxy_amphora/timeout_member_connect\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":79,"context_line":"      is_expected.to contain_octavia_config(\u0027haproxy_amphora/timeout_member_data\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":80,"context_line":"      is_expected.to contain_octavia_config(\u0027haproxy_amphora/timeout_tcp_inspect\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":81,"context_line":"      is_expected.to contain_octavia_config(\u0027heatlh_manager/health_update_threads\u0027).with_value(facts[:os_workers])"},{"line_number":82,"context_line":"      is_expected.to contain_octavia_config(\u0027heatlh_manager/stats_update_threads\u0027).with_value(facts[:os_workers])"},{"line_number":83,"context_line":"    end"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    context \u0027with ssh key access disabled\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"dfd5e7cf_559a4a14","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":113},"updated":"2019-01-08 22:06:29.000000000","message":"These should be \u0027\u003cSERVICE DEFAULT\u003e\u0027 not facts[:os_workers]","commit_id":"bbcd03dc3c72d0b34f411eb539ab166562441bb5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d4c6bfa8ef85793d201acad0762d8e5dded142f9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      it { is_expected.to contain_octavia_config(\u0027controller_worker/amp_boot_network_list\u0027).with_value([\u0027lbnet1\u0027, \u0027lbnet2\u0027]) }"},{"line_number":52,"context_line":"      it { is_expected.to contain_octavia_config(\u0027controller_worker/loadbalancer_topology\u0027).with_value(\u0027SINGLE\u0027) }"},{"line_number":53,"context_line":"      it { is_expected.to contain_octavia_config(\u0027controller_worker/amp_ssh_key_name\u0027).with_value(\u0027custom-amphora-key\u0027) }"},{"line_number":54,"context_line":"      it { is_expected.to contain_octavia_config(\u0027heatlh_manager/health_update_threads\u0027).with_value(facts[:os_workers]) }"},{"line_number":55,"context_line":"      it { is_expected.to contain_octavia_config(\u0027heatlh_manager/stats_update_threads\u0027).with_value(facts[:os_workers]) }"},{"line_number":56,"context_line":"      it \u0027deploys a nova flavor for amphora\u0027 do"},{"line_number":57,"context_line":"        is_expected.to contain_nova_flavor(\u0027octavia_42\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":9,"id":"dfd5e7cf_d598671c","line":54,"updated":"2019-01-09 15:54:36.000000000","message":"I just realized this is the wrong file, it should be spec/classes/octavia_health_manager_spec.rb not octavia_worker_spec.rb\n\nAdditionally if you move this over there, this one would have been 8 and the other would have been facts[:os_workers]","commit_id":"a85cd1a9dab248b6c66966436a53eb12f592678b"}]}
