)]}'
{"manifests/api.pp":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"03345e02a0de02a00250011faac4926aa9ba92f2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $api_v2_enabled                 \u003d $::os_service_default,"},{"line_number":73,"context_line":"  $allow_tls_terminated_listeners \u003d $::os_service_default,"},{"line_number":74,"context_line":"  $sync_db                        \u003d false,"},{"line_number":75,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":76,"context_line":") inherits octavia::params {"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9fdfeff1_873c9593","line":75,"updated":"2019-02-13 14:18:28.000000000","message":"Also need parameter to specify default_provider_driver\n\nhttps://github.com/openstack/octavia/blob/f026372216ce45e3e5ddc95541e235cfd30a1a3e/etc/octavia.conf#L52","commit_id":"d0faf214fabe55054368bbbe0a5b2785cf17f5ff"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"03345e02a0de02a00250011faac4926aa9ba92f2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \u0027api_settings/api_v1_enabled\u0027:                 value \u003d\u003e $api_v1_enabled;"},{"line_number":131,"context_line":"    \u0027api_settings/api_v2_enabled\u0027:                 value \u003d\u003e $api_v2_enabled;"},{"line_number":132,"context_line":"    \u0027api_settings/allow_tls_terminated_listeners\u0027: value \u003d\u003e $allow_tls_terminated_listeners;"},{"line_number":133,"context_line":"    \u0027api_settings/enabled_provider_drivers\u0027:       value \u003d\u003e $provider_drivers;"},{"line_number":134,"context_line":"  }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9fdfeff1_270b69d5","line":133,"updated":"2019-02-13 14:18:28.000000000","message":"The final configuration value type is dictionary [1]. Would it make sense to validate that here in puppet?\n\n[1] https://github.com/openstack/octavia/blob/f026372216ce45e3e5ddc95541e235cfd30a1a3e/etc/octavia.conf#L47-L49","commit_id":"d0faf214fabe55054368bbbe0a5b2785cf17f5ff"}],"spec/classes/octavia_api_spec.rb":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"03345e02a0de02a00250011faac4926aa9ba92f2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      :api_v1_enabled                 \u003d\u003e true,"},{"line_number":12,"context_line":"      :api_v2_enabled                 \u003d\u003e true,"},{"line_number":13,"context_line":"      :allow_tls_terminated_listeners \u003d\u003e false,"},{"line_number":14,"context_line":"      :provider_drivers               \u003d\u003e [\"amphora:\u0027Octavia Amphora Driver\u0027, ovn:\u0027Octavia OVN driver\u0027\"]"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"  end"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9fdfeff1_873335ab","line":14,"updated":"2019-02-13 14:18:28.000000000","message":"Will this translate to a DictValue type in Octavia configuration? If yes, all good.","commit_id":"d0faf214fabe55054368bbbe0a5b2785cf17f5ff"}]}