)]}'
{"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a0003491a511d442e42b0ec49d5c3708063390c7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   Defaults to $::os_service_default"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# [*ovn_nb_connection*]"},{"line_number":67,"context_line":"#   (optional) The connection string for the OVN_Northbound OVSDB."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class octavia::api ("},{"line_number":70,"context_line":"  $enabled                        \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fce034c_e8c9c1ab","line":67,"updated":"2019-04-18 17:17:12.000000000","message":"Defaults to ...","commit_id":"6fae3505505e466fa42a2052ea7e319b4dd07fda"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a0003491a511d442e42b0ec49d5c3708063390c7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $sync_db                        \u003d false,"},{"line_number":82,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $ovn_nb_connection              \u003d undef,"},{"line_number":85,"context_line":") inherits octavia::params {"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fce034c_08cf6db0","line":84,"updated":"2019-04-18 17:17:12.000000000","message":"don\u0027t we want to use os_service_default, which would be unset by default in the configuration file?","commit_id":"6fae3505505e466fa42a2052ea7e319b4dd07fda"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"019255410128ebd7bd9700a85a57be58a9c21a21","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  $sync_db                        \u003d false,"},{"line_number":82,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":83,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":84,"context_line":"  $ovn_nb_connection              \u003d undef,"},{"line_number":85,"context_line":") inherits octavia::params {"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  include ::octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fce034c_884a7da9","line":84,"in_reply_to":"3fce034c_08cf6db0","updated":"2019-04-18 17:48:56.000000000","message":"I don\u0027t see a config default in octavia[1] for it as it\u0027s ovn driver specific implemented in networking-ovn. The ovn section should not be there in the config unless we\u0027ve OVN Provider enabled (which puppet-tripleo patch would do).\n\nDoes the os_service_default work in those driver specific cases?\n\n\n[1] https://github.com/openstack/octavia/blob/master/octavia/common/config.py","commit_id":"6fae3505505e466fa42a2052ea7e319b4dd07fda"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a0003491a511d442e42b0ec49d5c3708063390c7","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  if $ovn_nb_connection {"},{"line_number":147,"context_line":"    octavia_config {"},{"line_number":148,"context_line":"      \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection;"},{"line_number":149,"context_line":"    }"},{"line_number":150,"context_line":"  }"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fce034c_a8c73996","line":148,"updated":"2019-04-18 17:17:12.000000000","message":"if we use os_service_default, just move that to an existing instance of octavia_config, it\u0027ll make it simpler","commit_id":"6fae3505505e466fa42a2052ea7e319b4dd07fda"}]}