)]}'
{"manifests/driver_agent.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c9c9bf0db0466e1511896b3e02edc43f1cb9e0eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class octavia::driver_agent ("},{"line_number":36,"context_line":"    $status_socket_path          \u003d $::os_service_default,"},{"line_number":37,"context_line":"    $stats_socket_path           \u003d $::os_service_default,"},{"line_number":38,"context_line":"    $status_request_timeout      \u003d $::os_service_default,"},{"line_number":39,"context_line":"    $status_max_processes        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_c6140e51","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":4},"updated":"2019-06-07 13:51:33.000000000","message":"should be 2 spaces","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"23b8e28a81a200dba18b196bdbed1e7fb8cfab3c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class octavia::driver_agent ("},{"line_number":36,"context_line":"    $status_socket_path          \u003d $::os_service_default,"},{"line_number":37,"context_line":"    $stats_socket_path           \u003d $::os_service_default,"},{"line_number":38,"context_line":"    $status_request_timeout      \u003d $::os_service_default,"},{"line_number":39,"context_line":"    $status_max_processes        \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df33271e_eb3f2f84","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":4},"in_reply_to":"9fb8cfa7_c6140e51","updated":"2020-04-01 19:43:46.000000000","message":"Done","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c9c9bf0db0466e1511896b3e02edc43f1cb9e0eb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    $stats_max_processes         \u003d $::os_service_default,"},{"line_number":42,"context_line":"    $max_process_warning_percent \u003d $::os_service_default"},{"line_number":43,"context_line":") inherits octavia::params {"},{"line_number":44,"context_line":"  include ::octavia::deps"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_46081e2b","line":44,"updated":"2019-06-07 13:51:33.000000000","message":"add a empty line above this include","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"23b8e28a81a200dba18b196bdbed1e7fb8cfab3c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    $stats_max_processes         \u003d $::os_service_default,"},{"line_number":42,"context_line":"    $max_process_warning_percent \u003d $::os_service_default"},{"line_number":43,"context_line":") inherits octavia::params {"},{"line_number":44,"context_line":"  include ::octavia::deps"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df33271e_2b4d973d","line":44,"in_reply_to":"9fb8cfa7_46081e2b","updated":"2020-04-01 19:43:46.000000000","message":"Done","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6f2891a4d4f15ef9e53d2c24ec29d12f594a64b1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \u0027driver_agent/get_request_timeout\u0027:              value \u003d\u003e $get_request_timeout;"},{"line_number":87,"context_line":"    \u0027driver_agent/get_max_processes\u0027:                value \u003d\u003e $get_max_processes;"},{"line_number":88,"context_line":"    \u0027driver_agent/max_process_warning_percent\u0027:      value \u003d\u003e $max_process_warning_percent;"},{"line_number":89,"context_line":"    \u0027driver_agent/provider_agent_shutdown_timeout\u0027:  value \u003d\u003e $provider_agent_shutdown_timeout;"},{"line_number":90,"context_line":"    \u0027driver_agent/enabled_provider_agents\u0027:          value \u003d\u003e $enabled_provider_agents;"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df33271e_00ceadb2","line":89,"range":{"start_line":89,"start_character":52,"end_line":89,"end_character":53},"updated":"2020-04-01 22:06:59.000000000","message":"nit","commit_id":"54c8e659b570ebe3192c91190ff68ece76ea08f1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f356f8db3602c882c794d4201d0e2cf21034434d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \u0027driver_agent/get_request_timeout\u0027:              value \u003d\u003e $get_request_timeout;"},{"line_number":87,"context_line":"    \u0027driver_agent/get_max_processes\u0027:                value \u003d\u003e $get_max_processes;"},{"line_number":88,"context_line":"    \u0027driver_agent/max_process_warning_percent\u0027:      value \u003d\u003e $max_process_warning_percent;"},{"line_number":89,"context_line":"    \u0027driver_agent/provider_agent_shutdown_timeout\u0027:  value \u003d\u003e $provider_agent_shutdown_timeout;"},{"line_number":90,"context_line":"    \u0027driver_agent/enabled_provider_agents\u0027:          value \u003d\u003e $enabled_provider_agents;"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"df33271e_4ac8cca4","line":89,"range":{"start_line":89,"start_character":52,"end_line":89,"end_character":53},"in_reply_to":"df33271e_00ceadb2","updated":"2020-04-02 06:39:31.000000000","message":"That is a super-duper nit! :D","commit_id":"54c8e659b570ebe3192c91190ff68ece76ea08f1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d000c6c9f05c99d0f3832300baca4b621702966f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $enabled_provider_agents         \u003d $::os_service_default,"},{"line_number":72,"context_line":") inherits octavia::params {"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  include ::octavia::deps"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df33271e_f9f6db8e","line":74,"range":{"start_line":74,"start_character":10,"end_line":74,"end_character":12},"updated":"2020-04-02 11:56:32.000000000","message":"heading :: should be removed.","commit_id":"5f93e78756298143050be0ef85a715a961df8bba"}],"manifests/params.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"c9c9bf0db0466e1511896b3e02edc43f1cb9e0eb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $worker_service_name         \u003d \u0027octavia-worker\u0027"},{"line_number":9,"context_line":"  $health_manager_service_name \u003d \u0027octavia-health-manager\u0027"},{"line_number":10,"context_line":"  $housekeeping_service_name   \u003d \u0027octavia-housekeeping\u0027"},{"line_number":11,"context_line":"  $driver_agent_name           \u003d \u0027octavia-driver-agent\u0027"},{"line_number":12,"context_line":"  $client_package_name         \u003d \"python${pyvers}-octaviaclient\""},{"line_number":13,"context_line":"  $group                       \u003d \u0027octavia\u0027"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_061b0681","line":11,"updated":"2019-06-07 13:51:33.000000000","message":"Not needed right? since we don\u0027t manage any packages with this patch","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"1994a4d1bbdf7107948aa510815b49b654ff4ad3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $worker_service_name         \u003d \u0027octavia-worker\u0027"},{"line_number":9,"context_line":"  $health_manager_service_name \u003d \u0027octavia-health-manager\u0027"},{"line_number":10,"context_line":"  $housekeeping_service_name   \u003d \u0027octavia-housekeeping\u0027"},{"line_number":11,"context_line":"  $driver_agent_name           \u003d \u0027octavia-driver-agent\u0027"},{"line_number":12,"context_line":"  $client_package_name         \u003d \"python${pyvers}-octaviaclient\""},{"line_number":13,"context_line":"  $group                       \u003d \u0027octavia\u0027"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9fb8cfa7_f14d4a72","line":11,"in_reply_to":"9fb8cfa7_061b0681","updated":"2019-06-07 13:53:15.000000000","message":"this is actually the service name but we don\u0027t manage those either so yeah I\u0027ll remove on respin. thanks!","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"23b8e28a81a200dba18b196bdbed1e7fb8cfab3c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $worker_service_name         \u003d \u0027octavia-worker\u0027"},{"line_number":9,"context_line":"  $health_manager_service_name \u003d \u0027octavia-health-manager\u0027"},{"line_number":10,"context_line":"  $housekeeping_service_name   \u003d \u0027octavia-housekeeping\u0027"},{"line_number":11,"context_line":"  $driver_agent_name           \u003d \u0027octavia-driver-agent\u0027"},{"line_number":12,"context_line":"  $client_package_name         \u003d \"python${pyvers}-octaviaclient\""},{"line_number":13,"context_line":"  $group                       \u003d \u0027octavia\u0027"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df33271e_ebb0cfdf","line":11,"in_reply_to":"9fb8cfa7_f14d4a72","updated":"2020-04-01 19:43:46.000000000","message":"Done","commit_id":"5cf285faf66e918c826b95319657edc17bdadb48"}],"spec/classes/octavia_driver_agent_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d000c6c9f05c99d0f3832300baca4b621702966f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  shared_examples_for \u0027octavia-driver-agent\u0027 do"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":14,"context_line":"      it { is_expected.to contain_octavia_config(\u0027driver_agent/status_socket_path\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"df33271e_79192bd5","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2020-04-02 11:56:32.000000000","message":"(nit) one blank line is eough","commit_id":"5f93e78756298143050be0ef85a715a961df8bba"}]}