)]}'
{"manifests/certificates.pp":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"62f78a30f26fc2add0c40120d1b04596e4ce0a70","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  }"},{"line_number":112,"context_line":"  if !$server_certs_key_passphrase  {"},{"line_number":113,"context_line":"    fail(\u0027server_certs_key_passphrase is required for Octavia. Please provide a 32 characters passphrase.\u0027)"},{"line_number":114,"context_line":"  } elsif length($server_certs_key_passphrase)!\u003d32 {"},{"line_number":115,"context_line":"      fail(\"The passphrase: \u0027${server_certs_key_passphrase}\u0027 is invalid for server_certs_key_passphrase. Please provide a 32 characters"},{"line_number":116,"context_line":"      passphrase.\")"},{"line_number":117,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9fb8cfa7_8f0a2287","line":114,"updated":"2019-07-02 09:54:38.000000000","message":"nit: unnecessary elsif after fail()","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"4e2e298b6866ce89195e958a2b0039db9a45f08c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"  }"},{"line_number":112,"context_line":"  if !$server_certs_key_passphrase  {"},{"line_number":113,"context_line":"    fail(\u0027server_certs_key_passphrase is required for Octavia. Please provide a 32 characters passphrase.\u0027)"},{"line_number":114,"context_line":"  } elsif length($server_certs_key_passphrase)!\u003d32 {"},{"line_number":115,"context_line":"      fail(\"The passphrase: \u0027${server_certs_key_passphrase}\u0027 is invalid for server_certs_key_passphrase. Please provide a 32 characters"},{"line_number":116,"context_line":"      passphrase.\")"},{"line_number":117,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9fb8cfa7_2e9d1d57","line":114,"in_reply_to":"9fb8cfa7_8f0a2287","updated":"2019-07-03 15:37:56.000000000","message":"Done","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"62f78a30f26fc2add0c40120d1b04596e4ce0a70","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  if !$server_certs_key_passphrase  {"},{"line_number":113,"context_line":"    fail(\u0027server_certs_key_passphrase is required for Octavia. Please provide a 32 characters passphrase.\u0027)"},{"line_number":114,"context_line":"  } elsif length($server_certs_key_passphrase)!\u003d32 {"},{"line_number":115,"context_line":"      fail(\"The passphrase: \u0027${server_certs_key_passphrase}\u0027 is invalid for server_certs_key_passphrase. Please provide a 32 characters"},{"line_number":116,"context_line":"      passphrase.\")"},{"line_number":117,"context_line":"  }"},{"line_number":118,"context_line":"  # The file creation will create the parent directory for each file if necessary, but"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9fb8cfa7_6f2c8e01","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":27},"updated":"2019-07-02 09:54:38.000000000","message":"nit: remove :","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"4e2e298b6866ce89195e958a2b0039db9a45f08c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  if !$server_certs_key_passphrase  {"},{"line_number":113,"context_line":"    fail(\u0027server_certs_key_passphrase is required for Octavia. Please provide a 32 characters passphrase.\u0027)"},{"line_number":114,"context_line":"  } elsif length($server_certs_key_passphrase)!\u003d32 {"},{"line_number":115,"context_line":"      fail(\"The passphrase: \u0027${server_certs_key_passphrase}\u0027 is invalid for server_certs_key_passphrase. Please provide a 32 characters"},{"line_number":116,"context_line":"      passphrase.\")"},{"line_number":117,"context_line":"  }"},{"line_number":118,"context_line":"  # The file creation will create the parent directory for each file if necessary, but"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9fb8cfa7_eea625ac","line":115,"range":{"start_line":115,"start_character":16,"end_line":115,"end_character":27},"in_reply_to":"9fb8cfa7_6f2c8e01","updated":"2019-07-03 15:37:56.000000000","message":"Done","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"}],"releasenotes/notes/fix-generated-server_certs_key_passphrase-in-spec-524a44297ec76bd0.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"62f78a30f26fc2add0c40120d1b04596e4ce0a70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The passphrase for config option \u0027server_certs_key_passphrase\u0027, is used as"},{"line_number":4,"context_line":"    a Fernet key in Octavia and thus must be 32 chars long. TripleO will now"},{"line_number":5,"context_line":"    auto-generate 32 bytes long passphrase for OctaviaServerCertsKeyPassphrase."},{"line_number":6,"context_line":"    In the case of an operator-provided passphrase, TripleO will validate that."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_af45a6b5","line":6,"range":{"start_line":4,"start_character":60,"end_line":6,"end_character":79},"updated":"2019-07-02 09:54:38.000000000","message":"puppet-octavia is a project outside TripleO. Remove this.","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"4e2e298b6866ce89195e958a2b0039db9a45f08c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The passphrase for config option \u0027server_certs_key_passphrase\u0027, is used as"},{"line_number":4,"context_line":"    a Fernet key in Octavia and thus must be 32 chars long. TripleO will now"},{"line_number":5,"context_line":"    auto-generate 32 bytes long passphrase for OctaviaServerCertsKeyPassphrase."},{"line_number":6,"context_line":"    In the case of an operator-provided passphrase, TripleO will validate that."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_6eb475d2","line":6,"range":{"start_line":4,"start_character":60,"end_line":6,"end_character":79},"in_reply_to":"9fb8cfa7_af45a6b5","updated":"2019-07-03 15:37:56.000000000","message":"Done","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"}],"spec/classes/octavia_certificates_spec.rb":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"62f78a30f26fc2add0c40120d1b04596e4ce0a70","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          :endpoint_type               \u003d\u003e \u0027internalURL\u0027,"},{"line_number":30,"context_line":"          :ca_certificate              \u003d\u003e \u0027/etc/octavia/ca.pem\u0027,"},{"line_number":31,"context_line":"          :ca_private_key              \u003d\u003e \u0027/etc/octavia/key.pem\u0027,"},{"line_number":32,"context_line":"          :server_certs_key_passphrase \u003d\u003e \u0027insecure-key-do-not-use-this-key\u0027,"},{"line_number":33,"context_line":"          :ca_private_key_passphrase   \u003d\u003e \u0027secure123\u0027,"},{"line_number":34,"context_line":"          :client_cert                 \u003d\u003e \u0027/etc/octavia/client.pem\u0027"},{"line_number":35,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9fb8cfa7_6f7a4ef1","line":32,"updated":"2019-07-02 09:54:38.000000000","message":"Could you please include negative tests? One when parameter is empty and another when !\u003d 32 characters.","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"4e2e298b6866ce89195e958a2b0039db9a45f08c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          :endpoint_type               \u003d\u003e \u0027internalURL\u0027,"},{"line_number":30,"context_line":"          :ca_certificate              \u003d\u003e \u0027/etc/octavia/ca.pem\u0027,"},{"line_number":31,"context_line":"          :ca_private_key              \u003d\u003e \u0027/etc/octavia/key.pem\u0027,"},{"line_number":32,"context_line":"          :server_certs_key_passphrase \u003d\u003e \u0027insecure-key-do-not-use-this-key\u0027,"},{"line_number":33,"context_line":"          :ca_private_key_passphrase   \u003d\u003e \u0027secure123\u0027,"},{"line_number":34,"context_line":"          :client_cert                 \u003d\u003e \u0027/etc/octavia/client.pem\u0027"},{"line_number":35,"context_line":"        }"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9fb8cfa7_423945d6","line":32,"in_reply_to":"9fb8cfa7_6f7a4ef1","updated":"2019-07-03 15:37:56.000000000","message":"Done","commit_id":"d78c542e09f5ab0d142129486efbe480c573ccb3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"a1dfd027423a14c0bc228568cddaeb674d57fbea","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    context \u0027When no server_certs_key_passphrase provided\u0027 do"},{"line_number":254,"context_line":"      let :params do"},{"line_number":255,"context_line":"        { :server_certs_key_passphrase \u003d\u003e \u0027\u0027,"},{"line_number":256,"context_line":"        }"},{"line_number":257,"context_line":"      end"},{"line_number":258,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7faddb67_663b4e9c","line":255,"range":{"start_line":255,"start_character":42,"end_line":255,"end_character":44},"updated":"2019-07-03 16:08:17.000000000","message":"note for reviewers: I\u0027m not 100% sure that this gets the purpose of testing as if no value was provided to server_certs_key_passphrase (I\u0027m new this code base).\n\nPlease say this looks off","commit_id":"d9564d7c235bc3073ef6eb444a6f1561fb6dffc5"}]}