)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bb7a21a916e7ef8b6185975ef0766085381565ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Fernandes \u003cflaviof@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 11:17:50 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_5f4cfa95","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":25},"updated":"2020-02-13 17:09:04.000000000","message":"Are you really using SSL or do you mean TLS?\n\nSSL is EOL and should not be used[1].\n\n[1] https://tools.ietf.org/html/rfc7568","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bb7a21a916e7ef8b6185975ef0766085381565ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Fernandes \u003cflaviof@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 11:17:50 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_9f56f22a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2020-02-13 17:09:04.000000000","message":"This is not Octavia, but the \"OVN provider\" for Octavia.","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"2923d593f65bbb2de6401258496ce71586392f5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Fernandes \u003cflaviof@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 11:17:50 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_0fb08d40","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":25},"in_reply_to":"3fa7e38b_03138c03","updated":"2020-02-13 23:09:30.000000000","message":"oops. s/tcl/tls 1.0/  :facepalm","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"eab4ab72102853f07bfbca7a5142353dfb240481","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Fernandes \u003cflaviof@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 11:17:50 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_03138c03","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":25},"in_reply_to":"3fa7e38b_5f4cfa95","updated":"2020-02-13 18:56:17.000000000","message":"Good point. I mean something that is not tcp. :) OVN/OVS uses ssl 3.0, which is actually tcl:\nhttp://docs.openvswitch.org/en/latest/howto/ssl/  \u003d\u003d\u003e  set-ssl","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"eab4ab72102853f07bfbca7a5142353dfb240481","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Fernandes \u003cflaviof@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-12 11:17:50 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_034cec3d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"in_reply_to":"3fa7e38b_9f56f22a","updated":"2020-02-13 18:56:17.000000000","message":"ack. TY Michael! Will work on this.","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bb7a21a916e7ef8b6185975ef0766085381565ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c2cfad24a6a526fdb667c57c6b75eb9c9f2da3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ff2cc6b2","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":27},"updated":"2020-02-13 17:09:04.000000000","message":"OVN provider","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"eab4ab72102853f07bfbca7a5142353dfb240481","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"octavia: Use SSL protocol when TLS is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances Octavia config, so it can connect to"},{"line_number":10,"context_line":"OVN_Northbound DB using SSL."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c2cfad24a6a526fdb667c57c6b75eb9c9f2da3d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_2347a81d","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":27},"in_reply_to":"3fa7e38b_ff2cc6b2","updated":"2020-02-13 18:56:17.000000000","message":"ack.","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"}],"manifests/api.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b013e8dbed2965c218cc06b17163411b81d2e644","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (optional) Configure the loadbalancer provider drivers."},{"line_number":64,"context_line":"#   Defaults to $::os_service_default"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# [*ovn_nb_private_key*]"},{"line_number":67,"context_line":"#   (optional) The PEM file with private key for SSL connection to OVN-NB-DB"},{"line_number":68,"context_line":"#   Defaults to $::os_service_default"},{"line_number":69,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_d1dbef1c","line":66,"updated":"2020-02-14 14:22:07.000000000","message":"IIUC these are for configuring the driver agent so I agree with previous comments that these should probably go in a separate file. I\u0027m not opposed to them being in puppet-octavia but unless this is configuring the API server, it belongs elsewhere. With respect to each provider having their own packaging - we *could* take that approach but there is precedent for collocating *config stuff* under one puppet roof. Neutron for example... if the intent also is to backport this stuff - new packages probably will be harder to pull off. Which btw backporting is another strong case for putting this stuff in a separate file. The fact that there are multiple manifests modifying a single file is not an issue so there is no reason not to do this.","commit_id":"8124678922a22198b935da1b56abf5407ee102ee"}],"releasenotes/notes/ovn-ssl-octavia-f5fbef364de00bdc.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bb7a21a916e7ef8b6185975ef0766085381565ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch introduces parameters which support SSL for Octavia to connect to"},{"line_number":5,"context_line":"    OVN_Northbound DB. This can be set by:"},{"line_number":6,"context_line":"    * \u0027ovn_nb_private_key\u0027: The PEM file with private key for SSL connection to OVN-NB-DB"},{"line_number":7,"context_line":"    * \u0027ovn_nb_certificate\u0027: The PEM file with certificate that certifies the private"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ff15a64c","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":66},"updated":"2020-02-13 17:09:04.000000000","message":"OVN provider for Octavia","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bb7a21a916e7ef8b6185975ef0766085381565ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This patch introduces parameters which support SSL for Octavia to connect to"},{"line_number":5,"context_line":"    OVN_Northbound DB. This can be set by:"},{"line_number":6,"context_line":"    * \u0027ovn_nb_private_key\u0027: The PEM file with private key for SSL connection to OVN-NB-DB"},{"line_number":7,"context_line":"    * \u0027ovn_nb_certificate\u0027: The PEM file with certificate that certifies the private"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_1a2770b7","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":55},"updated":"2020-02-13 17:09:04.000000000","message":"Same question about SSL since it is EOL","commit_id":"f3cde5b064a27737e8e4e1873f05dac19229fe48"}]}