)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"be750f7e6315013d3ea12bfc6ee870ce47c176c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Brent Eagles \u003cbeagles@redhat.com\u003e"},{"line_number":13,"context_line":"Change-Id: I5922eba799eda860926acdb353a6ca275a375e5b"},{"line_number":14,"context_line":"Closes-Bug: #1861886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_add31c38","line":14,"updated":"2020-02-27 15:42:11.000000000","message":"this bug is probably related to this bug not closing it","commit_id":"3f1f1d4688d506063e2a4325e0101b247b1b12a8"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"944e044df665687d32f81d5b64898e19ea87e580","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Brent Eagles \u003cbeagles@redhat.com\u003e"},{"line_number":13,"context_line":"Change-Id: I5922eba799eda860926acdb353a6ca275a375e5b"},{"line_number":14,"context_line":"Closes-Bug: #1861886"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_adbebc62","line":14,"in_reply_to":"1fa4df85_add31c38","updated":"2020-02-27 16:00:41.000000000","message":"indeed. thanks!","commit_id":"3f1f1d4688d506063e2a4325e0101b247b1b12a8"}],"manifests/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bcf1521a94bc9cc1ab4319a299b7008a4a7b914","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (optional) Configure the loadbalancer provider drivers."},{"line_number":64,"context_line":"#   Defaults to $::os_service_default"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# DEPRECATED"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*ovn_nb_connection*]"},{"line_number":69,"context_line":"#   (optional) The connection string for the OVN_Northbound OVSDB."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_db0e328c","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":12},"updated":"2020-03-01 13:44:10.000000000","message":"(nit) It seems that \"DEPRECATED PARAMETERS\" is generally used in puppet-octavia","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a8eb614bb4da6461824fce0ecd1b5f34645a4751","unresolved":false,"context_lines":[{"line_number":63,"context_line":"#   (optional) Configure the loadbalancer provider drivers."},{"line_number":64,"context_line":"#   Defaults to $::os_service_default"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"# DEPRECATED"},{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*ovn_nb_connection*]"},{"line_number":69,"context_line":"#   (optional) The connection string for the OVN_Northbound OVSDB."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_c4cc0ebe","line":66,"range":{"start_line":66,"start_character":2,"end_line":66,"end_character":12},"in_reply_to":"1fa4df85_db0e328c","updated":"2020-03-02 11:32:04.000000000","message":"Done","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bcf1521a94bc9cc1ab4319a299b7008a4a7b914","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*ovn_nb_connection*]"},{"line_number":69,"context_line":"#   (optional) The connection string for the OVN_Northbound OVSDB."},{"line_number":70,"context_line":"#   Defaults to $::os_service_default"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class octavia::api ("},{"line_number":73,"context_line":"  $enabled                        \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_5bf48286","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":37},"updated":"2020-03-01 13:44:10.000000000","message":"This should be undef.","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a8eb614bb4da6461824fce0ecd1b5f34645a4751","unresolved":false,"context_lines":[{"line_number":67,"context_line":"#"},{"line_number":68,"context_line":"# [*ovn_nb_connection*]"},{"line_number":69,"context_line":"#   (optional) The connection string for the OVN_Northbound OVSDB."},{"line_number":70,"context_line":"#   Defaults to $::os_service_default"},{"line_number":71,"context_line":"#"},{"line_number":72,"context_line":"class octavia::api ("},{"line_number":73,"context_line":"  $enabled                        \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_e4cfcaad","line":70,"range":{"start_line":70,"start_character":16,"end_line":70,"end_character":37},"in_reply_to":"1fa4df85_5bf48286","updated":"2020-03-02 11:32:04.000000000","message":"Done","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bcf1521a94bc9cc1ab4319a299b7008a4a7b914","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $sync_db                        \u003d false,"},{"line_number":85,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":87,"context_line":"  # DEPRECATED"},{"line_number":88,"context_line":"  $ovn_nb_connection              \u003d undef"},{"line_number":89,"context_line":") inherits octavia::params {"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_fb11aead","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":14},"updated":"2020-03-01 13:44:10.000000000","message":"(nit) It seems that \"DEPRECATED PARAMETERS\" is generally used in puppet-octavia","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a8eb614bb4da6461824fce0ecd1b5f34645a4751","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $sync_db                        \u003d false,"},{"line_number":85,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":87,"context_line":"  # DEPRECATED"},{"line_number":88,"context_line":"  $ovn_nb_connection              \u003d undef"},{"line_number":89,"context_line":") inherits octavia::params {"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_84c6169a","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":14},"in_reply_to":"1fa4df85_fb11aead","updated":"2020-03-02 11:32:04.000000000","message":"Done","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bcf1521a94bc9cc1ab4319a299b7008a4a7b914","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":87,"context_line":"  # DEPRECATED"},{"line_number":88,"context_line":"  $ovn_nb_connection              \u003d undef"},{"line_number":89,"context_line":") inherits octavia::params {"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_5b49e2cd","line":88,"range":{"start_line":88,"start_character":2,"end_line":88,"end_character":41},"updated":"2020-03-01 13:44:10.000000000","message":"It\u0027s better to show a warning message if this deprecated parameter is still used.","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a8eb614bb4da6461824fce0ecd1b5f34645a4751","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  $default_provider_driver        \u003d $::os_service_default,"},{"line_number":86,"context_line":"  $provider_drivers               \u003d $::os_service_default,"},{"line_number":87,"context_line":"  # DEPRECATED"},{"line_number":88,"context_line":"  $ovn_nb_connection              \u003d undef"},{"line_number":89,"context_line":") inherits octavia::params {"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1fa4df85_c4b64efb","line":88,"range":{"start_line":88,"start_character":2,"end_line":88,"end_character":41},"in_reply_to":"1fa4df85_5b49e2cd","updated":"2020-03-02 11:32:04.000000000","message":"Done","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2b092eebb8a0036348f2214a58c10cc5f118b124","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $ovn_nb_connection {"},{"line_number":100,"context_line":"      warning(\u0027The ovn_nb_connection parameter is deprecated from octavia api. Use ocatvia ovn provider.\u0027)"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  package { \u0027octavia-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1fa4df85_431d6bbb","line":100,"range":{"start_line":100,"start_character":66,"end_line":100,"end_character":77},"updated":"2020-03-02 18:40:42.000000000","message":"octavia::api","commit_id":"593d42e4d5d6220c48054506de59c6b00c216387"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2b092eebb8a0036348f2214a58c10cc5f118b124","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $ovn_nb_connection {"},{"line_number":100,"context_line":"      warning(\u0027The ovn_nb_connection parameter is deprecated from octavia api. Use ocatvia ovn provider.\u0027)"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  package { \u0027octavia-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1fa4df85_833a8331","line":100,"range":{"start_line":100,"start_character":83,"end_line":100,"end_character":90},"updated":"2020-03-02 18:40:42.000000000","message":"typo. Also, it is not clear to users which class they should use. Consider: \"Use octavia::provider::ovn::ovn_nb_connection\"","commit_id":"593d42e4d5d6220c48054506de59c6b00c216387"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e2090d2b768869874a194cd09a419bdfde063ae8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  if $ovn_nb_connection {"},{"line_number":100,"context_line":"      warning(\u0027The ovn_nb_connection parameter is deprecated from octavia api. Use ocatvia ovn provider.\u0027)"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  package { \u0027octavia-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1fa4df85_9ed176d0","line":100,"range":{"start_line":100,"start_character":83,"end_line":100,"end_character":90},"in_reply_to":"1fa4df85_833a8331","updated":"2020-03-02 19:51:04.000000000","message":"Done","commit_id":"593d42e4d5d6220c48054506de59c6b00c216387"}],"manifests/driver_agent.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3d728941460f67be37d8decef4c8575f7ea55a0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $ovn_nb_ca_cert              \u003d $::os_service_default"},{"line_number":23,"context_line":") inherits octavia::params {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  include ::octavia::deps"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_743affe7","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":12},"updated":"2020-02-25 07:14:56.000000000","message":"Leading :: should be removed because we\u0027ve eliminated absolute name inclusion in master.\n\nSee 7a1aaa80ce70a0c1996a5773654d02af0a07c977 .","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"803cc3905b41c2b30a7aadd248fb793989970030","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $ovn_nb_ca_cert              \u003d $::os_service_default"},{"line_number":23,"context_line":") inherits octavia::params {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  include ::octavia::deps"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_edc86275","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":12},"in_reply_to":"1fa4df85_743affe7","updated":"2020-02-25 10:05:08.000000000","message":"Done","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3d728941460f67be37d8decef4c8575f7ea55a0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027:           value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027:           value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:               value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_542103b4","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":49},"updated":"2020-02-25 07:14:56.000000000","message":"(nit) we can reduce the number of spaces.","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"803cc3905b41c2b30a7aadd248fb793989970030","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027:           value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027:           value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:               value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1fa4df85_ed9dc266","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":49},"in_reply_to":"1fa4df85_542103b4","updated":"2020-02-25 10:05:08.000000000","message":"Done","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"095c7c5efdbde5615895724ab2237a8a689d68dc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:     value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1fa4df85_fb2a53e5","line":30,"updated":"2020-02-25 15:36:38.000000000","message":"are these supposed to be under the [driver_agent] or [ovn] config section?","commit_id":"146a5605de6f4b09a740d4cb41f1187bdf9bcdb3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"7e916b8e7e675f550a6fb59cbd831dade31e54f3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:     value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1fa4df85_b6087228","line":30,"in_reply_to":"1fa4df85_9b731fe8","updated":"2020-02-25 15:51:58.000000000","message":"Done","commit_id":"146a5605de6f4b09a740d4cb41f1187bdf9bcdb3"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"65192d54fde00232b6fee314b8d13aa9e9cb1278","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:     value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1fa4df85_9b731fe8","line":30,"in_reply_to":"1fa4df85_fb2a53e5","updated":"2020-02-25 15:47:48.000000000","message":"We need this under [ovn] section","commit_id":"146a5605de6f4b09a740d4cb41f1187bdf9bcdb3"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"3047728668c13d3d826360d03845caf72babf8e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  # Octavia packaging does not currently provide a separate agent service or package."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  octavia_config {"},{"line_number":30,"context_line":"    \u0027driver_agent/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":31,"context_line":"    \u0027driver_agent/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"},{"line_number":32,"context_line":"    \u0027driver_agent/ovn_nb_ca_cert\u0027:     value \u003d\u003e $ovn_nb_ca_cert;"},{"line_number":33,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1fa4df85_5b04c717","line":30,"in_reply_to":"1fa4df85_fb2a53e5","updated":"2020-02-25 15:51:30.000000000","message":"heh.... ovn/ is better. :^)\ndone.","commit_id":"146a5605de6f4b09a740d4cb41f1187bdf9bcdb3"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"33a3064be08adf3ed17f050689efbec78e53e96c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1fa4df85_34953941","updated":"2020-02-27 13:19:20.000000000","message":"forgot to remove this file and other driver_agent related files I guess?","commit_id":"3f1f1d4688d506063e2a4325e0101b247b1b12a8"}],"manifests/provider/ovn.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9b973c855e4e846ece781f8b7474c43f5436686c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class octavia::provider::ovn ("},{"line_number":24,"context_line":"  $ovn_nb_connection           \u003d $::os_service_default,"},{"line_number":25,"context_line":"  $ovn_nb_private_key          \u003d $::os_service_default,"},{"line_number":26,"context_line":"  $ovn_nb_certificate          \u003d $::os_service_default,"},{"line_number":27,"context_line":"  $ovn_nb_ca_cert              \u003d $::os_service_default"},{"line_number":28,"context_line":") inherits octavia::params {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1fa4df85_7cff0601","line":25,"range":{"start_line":25,"start_character":22,"end_line":25,"end_character":31},"updated":"2020-02-28 13:22:07.000000000","message":"to much spacing","commit_id":"871f1db02d46f3b813feae5482d5581d40533650"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"0f0ed240ac18279de6e368890c954994fba88118","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class octavia::provider::ovn ("},{"line_number":24,"context_line":"  $ovn_nb_connection           \u003d $::os_service_default,"},{"line_number":25,"context_line":"  $ovn_nb_private_key          \u003d $::os_service_default,"},{"line_number":26,"context_line":"  $ovn_nb_certificate          \u003d $::os_service_default,"},{"line_number":27,"context_line":"  $ovn_nb_ca_cert              \u003d $::os_service_default"},{"line_number":28,"context_line":") inherits octavia::params {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1fa4df85_6fcae56d","line":25,"range":{"start_line":25,"start_character":22,"end_line":25,"end_character":31},"in_reply_to":"1fa4df85_7cff0601","updated":"2020-02-28 22:27:26.000000000","message":"Done","commit_id":"871f1db02d46f3b813feae5482d5581d40533650"}],"releasenotes/notes/add-driver-agent-71b506e3d81e92fe.yaml":[{"author":{"_account_id":11082,"name":"Kamil Sambor","email":"ksambor@redhat.com","username":"ksambor"},"change_message_id":"be750f7e6315013d3ea12bfc6ee870ce47c176c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added octavia::driver_agent for configuring driver agent properties, like OVN."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_cd8d3832","line":2,"updated":"2020-02-27 15:42:11.000000000","message":"do we really want to have two notes files?","commit_id":"3f1f1d4688d506063e2a4325e0101b247b1b12a8"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"944e044df665687d32f81d5b64898e19ea87e580","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added octavia::driver_agent for configuring driver agent properties, like OVN."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_ed80348e","line":2,"in_reply_to":"1fa4df85_cd8d3832","updated":"2020-02-27 16:00:41.000000000","message":"argh... nope. :^)","commit_id":"3f1f1d4688d506063e2a4325e0101b247b1b12a8"}],"releasenotes/notes/add-ovn-provider-71b506e3d81e92fe.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"2b092eebb8a0036348f2214a58c10cc5f118b124","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added octavia::ovn_provider for configuring OVN driver properties."},{"line_number":5,"context_line":"deprecations:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    octavia::api::ovn_nb_connection is now deprecated and will be removed in the"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1fa4df85_03669352","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":31},"updated":"2020-03-02 18:40:42.000000000","message":"octavia::provider::ovn","commit_id":"593d42e4d5d6220c48054506de59c6b00c216387"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"e2090d2b768869874a194cd09a419bdfde063ae8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added octavia::ovn_provider for configuring OVN driver properties."},{"line_number":5,"context_line":"deprecations:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    octavia::api::ovn_nb_connection is now deprecated and will be removed in the"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1fa4df85_9eead672","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":31},"in_reply_to":"1fa4df85_03669352","updated":"2020-03-02 19:51:04.000000000","message":"Done","commit_id":"593d42e4d5d6220c48054506de59c6b00c216387"}],"spec/classes/octavia_driver_agent_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3d728941460f67be37d8decef4c8575f7ea55a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  shared_examples_for \u0027octavia-driver-agent\u0027 do"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":14,"context_line":"      it { is_expected.to contain_octavia_config(\u0027driver_agent/ovn_nb_private_key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_7413df67","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2020-02-25 07:14:56.000000000","message":"(nit) we can remove one blank line here because generally we use only single blank line, IIUC","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"803cc3905b41c2b30a7aadd248fb793989970030","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  shared_examples_for \u0027octavia-driver-agent\u0027 do"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    context \u0027with default parameters\u0027 do"},{"line_number":14,"context_line":"      it { is_expected.to contain_octavia_config(\u0027driver_agent/ovn_nb_private_key\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_cd8ec62d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"1fa4df85_7413df67","updated":"2020-02-25 10:05:08.000000000","message":"Done","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3d728941460f67be37d8decef4c8575f7ea55a0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    context \u0027with specific parameters\u0027 do"},{"line_number":20,"context_line":"      before do"},{"line_number":21,"context_line":"        params.merge!({"},{"line_number":22,"context_line":"          :ovn_nb_private_key          \u003d\u003e \u0027/foo.key\u0027,"},{"line_number":23,"context_line":"          :ovn_nb_certificate          \u003d\u003e \u0027/foo.pem\u0027,"},{"line_number":24,"context_line":"          :ovn_nb_ca_cert              \u003d\u003e \u0027/ca_foo.pem\u0027"},{"line_number":25,"context_line":"        })"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_340d673e","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":39},"updated":"2020-02-25 07:14:56.000000000","message":"(nit) we can reduce the number of spaces.","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"803cc3905b41c2b30a7aadd248fb793989970030","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    context \u0027with specific parameters\u0027 do"},{"line_number":20,"context_line":"      before do"},{"line_number":21,"context_line":"        params.merge!({"},{"line_number":22,"context_line":"          :ovn_nb_private_key          \u003d\u003e \u0027/foo.key\u0027,"},{"line_number":23,"context_line":"          :ovn_nb_certificate          \u003d\u003e \u0027/foo.pem\u0027,"},{"line_number":24,"context_line":"          :ovn_nb_ca_cert              \u003d\u003e \u0027/ca_foo.pem\u0027"},{"line_number":25,"context_line":"        })"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_8d88ce1f","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":39},"in_reply_to":"1fa4df85_340d673e","updated":"2020-02-25 10:05:08.000000000","message":"Done","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e3d728941460f67be37d8decef4c8575f7ea55a0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      it { is_expected.to contain_octavia_config(\u0027driver_agent/ovn_nb_ca_cert\u0027).with_value(\u0027/ca_foo.pem\u0027) }"},{"line_number":31,"context_line":"    end"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  on_supported_os({"},{"line_number":36,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_9418db81","line":33,"updated":"2020-02-25 07:14:56.000000000","message":"ditto","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"803cc3905b41c2b30a7aadd248fb793989970030","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      it { is_expected.to contain_octavia_config(\u0027driver_agent/ovn_nb_ca_cert\u0027).with_value(\u0027/ca_foo.pem\u0027) }"},{"line_number":31,"context_line":"    end"},{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  on_supported_os({"},{"line_number":36,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1fa4df85_ed76223f","line":33,"in_reply_to":"1fa4df85_9418db81","updated":"2020-02-25 10:05:08.000000000","message":"Done","commit_id":"43e2c72329a4964ee4b38da94dffcce02f21fde4"}],"spec/classes/octavia_ovn_provider_spec.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9b973c855e4e846ece781f8b7474c43f5436686c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    context \u0027with specific parameters\u0027 do"},{"line_number":20,"context_line":"      before do"},{"line_number":21,"context_line":"        params.merge!({"},{"line_number":22,"context_line":"          :ovn_nb_connection \u003d\u003e \u0027tcp:127.0.0.1:6641\u0027,"},{"line_number":23,"context_line":"          :ovn_nb_private_key \u003d\u003e \u0027/foo.key\u0027,"},{"line_number":24,"context_line":"          :ovn_nb_certificate \u003d\u003e \u0027/foo.pem\u0027,"},{"line_number":25,"context_line":"          :ovn_nb_ca_cert     \u003d\u003e \u0027/ca_foo.pem\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"1fa4df85_4914ce4e","line":22,"updated":"2020-02-28 13:22:07.000000000","message":"align \u003d\u003e","commit_id":"871f1db02d46f3b813feae5482d5581d40533650"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"0f0ed240ac18279de6e368890c954994fba88118","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    context \u0027with specific parameters\u0027 do"},{"line_number":20,"context_line":"      before do"},{"line_number":21,"context_line":"        params.merge!({"},{"line_number":22,"context_line":"          :ovn_nb_connection \u003d\u003e \u0027tcp:127.0.0.1:6641\u0027,"},{"line_number":23,"context_line":"          :ovn_nb_private_key \u003d\u003e \u0027/foo.key\u0027,"},{"line_number":24,"context_line":"          :ovn_nb_certificate \u003d\u003e \u0027/foo.pem\u0027,"},{"line_number":25,"context_line":"          :ovn_nb_ca_cert     \u003d\u003e \u0027/ca_foo.pem\u0027"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"1fa4df85_8fc5e15d","line":22,"in_reply_to":"1fa4df85_4914ce4e","updated":"2020-02-28 22:27:26.000000000","message":"Done","commit_id":"871f1db02d46f3b813feae5482d5581d40533650"}],"spec/unit/type/octavia_ovn_provider_config_spec.rb":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"ce1a9ae5085aab1da86851b1d3ac94a58e5e4b5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027puppet\u0027"},{"line_number":2,"context_line":"require \u0027puppet/type/octavia_ovn_provider_config\u0027"},{"line_number":3,"context_line":"describe \u0027Puppet::Type.type(:octavia_ovn_provider_config)\u0027 do"},{"line_number":4,"context_line":"  before :each do"},{"line_number":5,"context_line":"    @octavia_ovn_provider_config \u003d Puppet::Type.type(:octavia_ovn_provider_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":6,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"1fa4df85_f5d1c4ce","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":61},"updated":"2020-02-28 23:24:03.000000000","message":"beagles et all: can you pls confirm that this it correct?","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2bcf1521a94bc9cc1ab4319a299b7008a4a7b914","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027puppet\u0027"},{"line_number":2,"context_line":"require \u0027puppet/type/octavia_ovn_provider_config\u0027"},{"line_number":3,"context_line":"describe \u0027Puppet::Type.type(:octavia_ovn_provider_config)\u0027 do"},{"line_number":4,"context_line":"  before :each do"},{"line_number":5,"context_line":"    @octavia_ovn_provider_config \u003d Puppet::Type.type(:octavia_ovn_provider_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":6,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"1fa4df85_fb5f6e6f","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":61},"in_reply_to":"1fa4df85_f5d1c4ce","updated":"2020-03-01 13:44:10.000000000","message":"LGTM.","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a8eb614bb4da6461824fce0ecd1b5f34645a4751","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027puppet\u0027"},{"line_number":2,"context_line":"require \u0027puppet/type/octavia_ovn_provider_config\u0027"},{"line_number":3,"context_line":"describe \u0027Puppet::Type.type(:octavia_ovn_provider_config)\u0027 do"},{"line_number":4,"context_line":"  before :each do"},{"line_number":5,"context_line":"    @octavia_ovn_provider_config \u003d Puppet::Type.type(:octavia_ovn_provider_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":6,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"1fa4df85_64e2fa31","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":61},"in_reply_to":"1fa4df85_fb5f6e6f","updated":"2020-03-02 11:32:04.000000000","message":"TY!","commit_id":"2a506fd76f12656e43675ae84281bfe6056e2faf"}]}