)]}'
{"manifests/provider/ovn.pp":[{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"1166c09c67f9a35cccea448201eeccfdf2f00efe","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ovn_nb_connection_real \u003d $ovn_nb_connection"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  octavia_ovn_provider_config {"},{"line_number":40,"context_line":"    \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection_real;"},{"line_number":41,"context_line":"    \u0027ovn/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":42,"context_line":"    \u0027ovn/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df33271e_58776fd5","side":"PARENT","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":31},"updated":"2020-03-27 21:08:24.000000000","message":"This change warrants an explanation. ;)\n\nWith wsg -- which is what the octavia_api container uses [1] -- there is currently no way additional config files can be provided as part of kolla_config. Thus, the implementation will resume using the one config file that is supported:\n/var/lib/config-data/puppet-generated/octavia/etc/octavia/octavia.conf\n\n[1]: https://review.opendev.org/#/c/707695/29/deployment/octavia/octavia-api-container-puppet.yaml\n/var/lib/kolla/config_files/octavia_api.json","commit_id":"dce599e49898d7973805a389d3abf5048f9f5099"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f14fcc72472491497722c51e388a1cf07292a8b1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ovn_nb_connection_real \u003d $ovn_nb_connection"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  octavia_ovn_provider_config {"},{"line_number":40,"context_line":"    \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection_real;"},{"line_number":41,"context_line":"    \u0027ovn/ovn_nb_private_key\u0027: value \u003d\u003e $ovn_nb_private_key;"},{"line_number":42,"context_line":"    \u0027ovn/ovn_nb_certificate\u0027: value \u003d\u003e $ovn_nb_certificate;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df33271e_df150e9e","side":"PARENT","line":39,"range":{"start_line":39,"start_character":2,"end_line":39,"end_character":31},"in_reply_to":"df33271e_58776fd5","updated":"2020-03-30 12:14:39.000000000","message":"Maybe add a comment to the code to that effect - like a TODO() or something?","commit_id":"dce599e49898d7973805a389d3abf5048f9f5099"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"9ac66633c4a633013eb8836c7958ab84e4493aed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ovn_nb_connection_real \u003d $ovn_nb_connection"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # TODO(flaviof): Use octavia_ovn_provider_config instead of octavia_config until we can figure out how"},{"line_number":40,"context_line":"  # to pass extra configuration files to the api running as wsgi process."},{"line_number":41,"context_line":"  octavia_config {"},{"line_number":42,"context_line":"    \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection_real;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"df33271e_42076219","line":39,"updated":"2020-03-30 13:19:10.000000000","message":"Erm, you mean the other way around? :)","commit_id":"7d01a984fc27c7420227684fb21b27d491c21c59"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"ebf0c59a0cd4f11439656dc3951fb9837450d73c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ovn_nb_connection_real \u003d $ovn_nb_connection"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # TODO(flaviof): Use octavia_ovn_provider_config instead of octavia_config until we can figure out how"},{"line_number":40,"context_line":"  # to pass extra configuration files to the api running as wsgi process."},{"line_number":41,"context_line":"  octavia_config {"},{"line_number":42,"context_line":"    \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection_real;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"df33271e_22869edc","line":39,"in_reply_to":"df33271e_42076219","updated":"2020-03-30 13:42:10.000000000","message":"Done","commit_id":"7d01a984fc27c7420227684fb21b27d491c21c59"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"a7891075331f510de6a8f5424cf291dde8d8479d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    $ovn_nb_connection_real \u003d $ovn_nb_connection"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # TODO(flaviof): Use octavia_ovn_provider_config instead of octavia_config until we can figure out how"},{"line_number":40,"context_line":"  # to pass extra configuration files to the api running as wsgi process."},{"line_number":41,"context_line":"  octavia_config {"},{"line_number":42,"context_line":"    \u0027ovn/ovn_nb_connection\u0027:  value \u003d\u003e $ovn_nb_connection_real;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"df33271e_827faa13","line":39,"in_reply_to":"df33271e_42076219","updated":"2020-03-30 13:34:34.000000000","message":"hmmm.... not really, but I can see how that may be confusing. Let me rephrase that. ;^)","commit_id":"7d01a984fc27c7420227684fb21b27d491c21c59"}]}