)]}'
{"manifests/policy.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"719aaaf3532cb3798caf53c0706b0f9066eec694","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $policies)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Openstacklib::Policy::Base {"},{"line_number":37,"context_line":"    file_path   \u003d\u003e $policy_path,"},{"line_number":38,"context_line":"    file_user   \u003d\u003e \u0027root\u0027,"},{"line_number":39,"context_line":"    file_group  \u003d\u003e $::octavia::params::group,"},{"line_number":40,"context_line":"    file_format \u003d\u003e \u0027yaml\u0027,"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  create_resources(\u0027openstacklib::policy::base\u0027, $policies)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf51134e_d92ccf9a","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":3},"updated":"2020-07-13 20:40:32.000000000","message":"I was wondering if this breaks the scope since this is a method of defining defaults for this resource. I\u0027m wondering if we need to switch up the create_resources to use this as a default rather than defining it like this. In theory this would break all policies when defining it in a single catalog (i think???)  But since this isn\u0027t a directly related to this we might want to revisit this in a follow up. I think create_resources task the resource name, data, defaults as params (it\u0027s been a while)","commit_id":"daa3c1269f29ecb7aac47f77e41c3ee8b082e15f"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"de744572868348f265a14f04fde2811ffde4f9d6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  validate_legacy(Hash, \u0027validate_hash\u0027, $policies)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  Openstacklib::Policy::Base {"},{"line_number":37,"context_line":"    file_path   \u003d\u003e $policy_path,"},{"line_number":38,"context_line":"    file_user   \u003d\u003e \u0027root\u0027,"},{"line_number":39,"context_line":"    file_group  \u003d\u003e $::octavia::params::group,"},{"line_number":40,"context_line":"    file_format \u003d\u003e \u0027yaml\u0027,"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  create_resources(\u0027openstacklib::policy::base\u0027, $policies)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf51134e_d967af24","line":41,"range":{"start_line":36,"start_character":0,"end_line":41,"end_character":3},"in_reply_to":"bf51134e_d92ccf9a","updated":"2020-07-13 21:41:29.000000000","message":"Yes I\u0027m thinking the same, we should add this as a default to create_resources.","commit_id":"daa3c1269f29ecb7aac47f77e41c3ee8b082e15f"}]}