)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"999e5f38a1f6ff400fb58fe8a46893d165b4a518","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f0c5e616_a026383a","updated":"2021-11-09 15:49:08.000000000","message":"Also, I\u0027m just wondering whether it makes sense to create a separate class(octavia::task_flow or mayby octavia::controller::task_flow) instead of adding more and more parameters into the single controller class.","commit_id":"072c8c0cfbe02a248698d7b76d4354685b199d20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8366b0b353c81d0f63ea8505ae7468dbcece005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1d826a88_061a164e","updated":"2021-12-07 01:23:26.000000000","message":"Thanks for updating the patch. We also need unit tests and release note about the change.","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4742f77208c000134e1eb00cc901418ed41890e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ac80a127_744111a4","updated":"2022-01-28 11:01:09.000000000","message":"@Gregory\n\nDo you have any update about this ? I don\u0027t see any issue from puppets\u0027 PoV. I assume you are testing the overall deployment by TripleO but that can be done separately, IMO.","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"85a07b8c406202d7f9983e5b048648cadf753544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c97d2b90_6f689d7e","updated":"2021-12-07 07:40:44.000000000","message":"Thanks for updating the patch Takashi!","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0a902e5f7dcc885b42df03316baf4b7900eb2bf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"07d049c5_a799f85c","updated":"2021-12-10 13:07:21.000000000","message":"checking CI in tht related commit","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8e0123fbe6fd86b6619504202cd37070cf5e3b60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4c132670_7bcc4a7f","updated":"2022-01-25 18:31:05.000000000","message":"recheck","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e1ac81006ffb503f9a6726502acbf078a62d72f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"737ea5b0_fc2d90c5","in_reply_to":"0f4f9a00_c5f44ca6","updated":"2022-02-28 23:06:25.000000000","message":"From puppet\u0027s PoV I think this patch is ready. I added support for the db-manage command to set up persistence database which was missing in the previous version.\n\nIf you don\u0027t mind, we can first land this in puppet-octavia. If we find any issue while implementing integration in TripleO then we can submit a follow-up fix for that.","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2582d0b32431d6688023483fcb6cd20ef66652b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ea663717_1d0d7d59","in_reply_to":"737ea5b0_fc2d90c5","updated":"2022-03-01 07:38:44.000000000","message":"Yeah, I totally agree,\nthanks for your help Takashi","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1e535ef25afa8aee2f5a1974a7b60c0698660c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0f4f9a00_c5f44ca6","in_reply_to":"ac80a127_744111a4","updated":"2022-02-28 16:52:07.000000000","message":"Sorry I wasn\u0027t paying attention to this change, but now it \u0027s back on my radar, I need to rebase the other patches that depend on this one.","commit_id":"c3a4bb2624b2328755f8167ad667ab18f7a219d6"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"02fe127391cfd950c35b4353f52ca7b042d04e97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0e799ad9_2604ed10","updated":"2022-03-01 15:25:21.000000000","message":"recheck","commit_id":"2b9f2a0813ea72605f8d673b5dd88defc4146262"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dda1e9eaebd44ee2d428fad8c91daae917d6a409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0f788c1e_a21728e0","updated":"2022-03-04 04:37:50.000000000","message":"recheck","commit_id":"2b9f2a0813ea72605f8d673b5dd88defc4146262"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"67878b2397df5eafdb943bddb1d613f2d89fc3b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3102c9b4_65dc5337","updated":"2022-03-02 09:03:05.000000000","message":"recheck","commit_id":"2b9f2a0813ea72605f8d673b5dd88defc4146262"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"930f6d6c17aeec67be9c3d4b0480d393579c59af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e1771e95_02f7ae8c","updated":"2022-03-02 10:09:58.000000000","message":"recheck","commit_id":"2b9f2a0813ea72605f8d673b5dd88defc4146262"}],"manifests/controller.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"97d8f5bb1d69a619e930f90a5722144c04790071","unresolved":true,"context_lines":[{"line_number":249,"context_line":"  $jobboard_expiration_time    \u003d $::os_service_default,"},{"line_number":250,"context_line":"  $jobboard_backend_password   \u003d $::os_service_default,"},{"line_number":251,"context_line":"  $persistence_connection      \u003d $::os_service_default,"},{"line_number":252,"context_line":"  $redis_vip                   \u003d hiera(\u0027redis_vip\u0027, undef),"},{"line_number":253,"context_line":") inherits octavia::params {"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"70975fbc_ae585cb8","line":252,"range":{"start_line":252,"start_character":40,"end_line":252,"end_character":49},"updated":"2021-11-03 09:54:01.000000000","message":"FYI: Do not use hiera in puppet-octavia but only implement native parameters. If you need this then this should be implemented in tripleo.","commit_id":"072c8c0cfbe02a248698d7b76d4354685b199d20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":249,"context_line":"  $jobboard_expiration_time    \u003d $::os_service_default,"},{"line_number":250,"context_line":"  $jobboard_backend_password   \u003d $::os_service_default,"},{"line_number":251,"context_line":"  $persistence_connection      \u003d $::os_service_default,"},{"line_number":252,"context_line":"  $redis_vip                   \u003d hiera(\u0027redis_vip\u0027, undef),"},{"line_number":253,"context_line":") inherits octavia::params {"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"d365bfa2_94741abb","line":252,"range":{"start_line":252,"start_character":40,"end_line":252,"end_character":49},"in_reply_to":"70975fbc_ae585cb8","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"072c8c0cfbe02a248698d7b76d4354685b199d20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"999e5f38a1f6ff400fb58fe8a46893d165b4a518","unresolved":true,"context_lines":[{"line_number":306,"context_line":"    \u0027keepalived_vrrp/vrrp_garp_refresh_interval\u0027 : value \u003d\u003e $vrrp_garp_refresh_interval;"},{"line_number":307,"context_line":"    \u0027keepalived_vrrp/vrrp_garp_refresh_count\u0027    : value \u003d\u003e $vrrp_garp_refresh_count;"},{"line_number":308,"context_line":"    \u0027task_flow/jobboard_enabled\u0027                 : value \u003d\u003e $jobboard_enabled;"},{"line_number":309,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027           : value \u003d\u003e $redis_vip;"},{"line_number":310,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027            : value \u003d\u003e $jobboard_backend_port;"},{"line_number":311,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027        : value \u003d\u003e $jobboard_backend_password;"},{"line_number":312,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027       : value \u003d\u003e $jobboard_backend_namespace;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"36662744_d3013e3e","line":309,"range":{"start_line":309,"start_character":61,"end_line":309,"end_character":70},"updated":"2021-11-09 15:49:08.000000000","message":"We basically avoid defining our own parameter names and just follows the original parameter names.","commit_id":"072c8c0cfbe02a248698d7b76d4354685b199d20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    \u0027keepalived_vrrp/vrrp_garp_refresh_interval\u0027 : value \u003d\u003e $vrrp_garp_refresh_interval;"},{"line_number":307,"context_line":"    \u0027keepalived_vrrp/vrrp_garp_refresh_count\u0027    : value \u003d\u003e $vrrp_garp_refresh_count;"},{"line_number":308,"context_line":"    \u0027task_flow/jobboard_enabled\u0027                 : value \u003d\u003e $jobboard_enabled;"},{"line_number":309,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027           : value \u003d\u003e $redis_vip;"},{"line_number":310,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027            : value \u003d\u003e $jobboard_backend_port;"},{"line_number":311,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027        : value \u003d\u003e $jobboard_backend_password;"},{"line_number":312,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027       : value \u003d\u003e $jobboard_backend_namespace;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"51b61200_3ce8421d","line":309,"range":{"start_line":309,"start_character":61,"end_line":309,"end_character":70},"in_reply_to":"36662744_d3013e3e","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"072c8c0cfbe02a248698d7b76d4354685b199d20"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8366b0b353c81d0f63ea8505ae7468dbcece005","unresolved":true,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  include octavia::deps"},{"line_number":224,"context_line":"  include octavia::db"},{"line_number":225,"context_line":"  include octavia::task_flow"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  if ! is_service_default($loadbalancer_topology) and"},{"line_number":228,"context_line":"      ! ($loadbalancer_topology in [\u0027SINGLE\u0027, \u0027ACTIVE_STANDBY\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"92bc1329_d2698e25","line":225,"range":{"start_line":225,"start_character":2,"end_line":225,"end_character":28},"updated":"2021-12-07 01:23:26.000000000","message":"I prefer not adding this hear and let users to include the class. This enforces ordering of class definition, which makes it difficult to use manifests file to define parameters(instead of hieradata)","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a85fe4ee8e41534ec4c59b8acbfb308f2c98630d","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  include octavia::deps"},{"line_number":224,"context_line":"  include octavia::db"},{"line_number":225,"context_line":"  include octavia::task_flow"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  if ! is_service_default($loadbalancer_topology) and"},{"line_number":228,"context_line":"      ! ($loadbalancer_topology in [\u0027SINGLE\u0027, \u0027ACTIVE_STANDBY\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fd43f9d2_fdf4c236","line":225,"range":{"start_line":225,"start_character":2,"end_line":225,"end_character":28},"in_reply_to":"8cbc57c5_45e0e2e9","updated":"2021-12-07 07:47:40.000000000","message":"Yes. The class should be included in own composition layer and in TripleO\u0027s case that should be implemented in puppet-tripleo.","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  include octavia::deps"},{"line_number":224,"context_line":"  include octavia::db"},{"line_number":225,"context_line":"  include octavia::task_flow"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  if ! is_service_default($loadbalancer_topology) and"},{"line_number":228,"context_line":"      ! ($loadbalancer_topology in [\u0027SINGLE\u0027, \u0027ACTIVE_STANDBY\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba6ec5b7_0042ab58","line":225,"range":{"start_line":225,"start_character":2,"end_line":225,"end_character":28},"in_reply_to":"92bc1329_d2698e25","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"85a07b8c406202d7f9983e5b048648cadf753544","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"  include octavia::deps"},{"line_number":224,"context_line":"  include octavia::db"},{"line_number":225,"context_line":"  include octavia::task_flow"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  if ! is_service_default($loadbalancer_topology) and"},{"line_number":228,"context_line":"      ! ($loadbalancer_topology in [\u0027SINGLE\u0027, \u0027ACTIVE_STANDBY\u0027]) {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"8cbc57c5_45e0e2e9","line":225,"range":{"start_line":225,"start_character":2,"end_line":225,"end_character":28},"in_reply_to":"ba6ec5b7_0042ab58","updated":"2021-12-07 07:40:44.000000000","message":"do you think it should be included in a puppet-tripleo manifest in case of tripleo deployments?","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"}],"manifests/task_flow.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b056937b03730e35254aca759427c57afeb96ea5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: octavia::task_flow"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9f337f61_7de9dca8","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":30},"updated":"2021-12-07 01:54:03.000000000","message":"also, it seems this class implements only part of the parameters currently available. Can we implement all parameters now ?","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: octavia::task_flow"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"76b602a3_c024bc74","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":30},"in_reply_to":"9f337f61_7de9dca8","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8366b0b353c81d0f63ea8505ae7468dbcece005","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  $jobboard_backend_namespace \u003d $::os_service_default,"},{"line_number":39,"context_line":"  $jobboard_expiration_time   \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $persistence_connection     \u003d $::os_service_default,"},{"line_number":41,"context_line":") inherits octavia::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"b3a50fcc_f2bdc39b","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":26},"updated":"2021-12-07 01:23:26.000000000","message":"Let\u0027s just include this. We don\u0027t need to use inherits unless we want to use octavia::params::\u003cfoo\u003e to define parameter defaults","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $jobboard_backend_namespace \u003d $::os_service_default,"},{"line_number":39,"context_line":"  $jobboard_expiration_time   \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $persistence_connection     \u003d $::os_service_default,"},{"line_number":41,"context_line":") inherits octavia::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"70686ef7_067d0aad","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":26},"in_reply_to":"b3a50fcc_f2bdc39b","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8366b0b353c81d0f63ea8505ae7468dbcece005","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  $jobboard_expiration_time   \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $persistence_connection     \u003d $::os_service_default,"},{"line_number":41,"context_line":") inherits octavia::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9fe8268e_e66cb343","line":42,"updated":"2021-12-07 01:23:26.000000000","message":"include octavia::deps is missing","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $jobboard_expiration_time   \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $persistence_connection     \u003d $::os_service_default,"},{"line_number":41,"context_line":") inherits octavia::params {"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"49d1f294_681e65e7","line":42,"in_reply_to":"9fe8268e_e66cb343","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"eef2584f5369bb9f0f029928afdbbbd1eae5b945","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"},{"line_number":46,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027      : value \u003d\u003e $jobboard_backend_port;"},{"line_number":47,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027  : value \u003d\u003e $jobboard_backend_password;"},{"line_number":48,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027 : value \u003d\u003e $jobboard_backend_namespace;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"4050115e_8c3d914b","line":45,"range":{"start_line":45,"start_character":55,"end_line":45,"end_character":77},"updated":"2021-12-07 01:25:42.000000000","message":"This is ListOpt so let\u0027s use\n\njoin(any2array($jobboard_backend_hosts), \u0027,\u0027)\n\nso that we can use native array.","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  octavia_config {"},{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"},{"line_number":46,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027      : value \u003d\u003e $jobboard_backend_port;"},{"line_number":47,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027  : value \u003d\u003e $jobboard_backend_password;"},{"line_number":48,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027 : value \u003d\u003e $jobboard_backend_namespace;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"d757b12d_4f23b466","line":45,"range":{"start_line":45,"start_character":55,"end_line":45,"end_character":77},"in_reply_to":"4050115e_8c3d914b","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"eef2584f5369bb9f0f029928afdbbbd1eae5b945","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"},{"line_number":46,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027      : value \u003d\u003e $jobboard_backend_port;"},{"line_number":47,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027  : value \u003d\u003e $jobboard_backend_password;"},{"line_number":48,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027 : value \u003d\u003e $jobboard_backend_namespace;"},{"line_number":49,"context_line":"    \u0027task_flow/jobboard_expiration_time\u0027   : value \u003d\u003e $jobboard_expiration_time;"},{"line_number":50,"context_line":"    \u0027task_flow/persistence_connection\u0027     : value \u003d\u003e $persistence_connection;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9ecd33a0_9d6cd9d7","line":47,"range":{"start_line":47,"start_character":55,"end_line":47,"end_character":80},"updated":"2021-12-07 01:25:42.000000000","message":"this should be secret.","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b92d7adf89a571a856714155e585ffcecc4469ec","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \u0027task_flow/jobboard_enabled\u0027           : value \u003d\u003e $jobboard_enabled;"},{"line_number":45,"context_line":"    \u0027task_flow/jobboard_backend_hosts\u0027     : value \u003d\u003e $jobboard_backend_hosts;"},{"line_number":46,"context_line":"    \u0027task_flow/jobboard_backend_port\u0027      : value \u003d\u003e $jobboard_backend_port;"},{"line_number":47,"context_line":"    \u0027task_flow/jobboard_backend_password\u0027  : value \u003d\u003e $jobboard_backend_password;"},{"line_number":48,"context_line":"    \u0027task_flow/jobboard_backend_namespace\u0027 : value \u003d\u003e $jobboard_backend_namespace;"},{"line_number":49,"context_line":"    \u0027task_flow/jobboard_expiration_time\u0027   : value \u003d\u003e $jobboard_expiration_time;"},{"line_number":50,"context_line":"    \u0027task_flow/persistence_connection\u0027     : value \u003d\u003e $persistence_connection;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"0f94c9c0_265511fa","line":47,"range":{"start_line":47,"start_character":55,"end_line":47,"end_character":80},"in_reply_to":"9ecd33a0_9d6cd9d7","updated":"2021-12-07 01:57:37.000000000","message":"Done","commit_id":"9da53e0fbeda3c69461acbd68395ecde5cf5eb43"}]}