)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1949f68ba90ee79eb685d8558c3cde10a09e9664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d0fd633_37f869fc","updated":"2022-06-02 04:51:47.000000000","message":"I think you can try this which I believe more compatible(and complete).\n https://review.opendev.org/c/openstack/puppet-octavia/+/844360","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"e2ea47285b830d9eb37462611320ca198eec5456","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f52c19b_b0d8c73d","updated":"2022-06-02 04:05:04.000000000","message":"Looks good, will need to update the tests too","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":34532,"name":"Timothy Rice","email":"timothy.rice@nexgencloud.com","username":"terice"},"change_message_id":"b827a1161102fa2ae74fe9f1fd3a09ef7f8f1155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12ceac47_c3cb89f6","updated":"2022-06-02 04:13:33.000000000","message":"Thanks for comments, acknowledged.","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5841e96a6903304bcd7398fd0de5acd4509ed315","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2b87641_b61283c9","updated":"2022-06-02 04:13:41.000000000","message":"The core problem is that Octavia registers some parameters to health_manager section but these parameters are actually used not only by health manager but also by worker. This is quite confusing and we\u0027d need to consider a different section if the parameters are needed by two services, IMO.\n\nI tend to keep the current structure which registers the health_manager options to the health_manager class which helps us to look up the parameters earsily.\nThis would not be the problem if a deployment have two services collocated. If not, then users can include octavia::health_manager with service/package management disabled.","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"a8446696624f1693a5b1f39993741a8b97e38bd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35d75c7f_a8867307","in_reply_to":"c2b87641_b61283c9","updated":"2022-06-02 04:26:55.000000000","message":"I\u0027m trying to avoid having to do this as it is prone to human error and makes it more complicated. We got caught out with this in production. Ideally if you include the octavia::worker class it should configure everything it needs.\n\nI can\u0027t figure out a better way than to specify this option in a class that will be used by both worker and health_manager","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"}],"manifests/health_manager.pp":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"e2ea47285b830d9eb37462611320ca198eec5456","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*heartbeat_key*]"},{"line_number":6,"context_line":"#   Key to validate amphora messages."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*enabled*]"},{"line_number":9,"context_line":"#   (optional) Should the service be enabled."},{"line_number":10,"context_line":"#   Defaults to true"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e3f67a22_7a385e05","side":"PARENT","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":1},"updated":"2022-06-02 04:05:04.000000000","message":"this should be moved down under DEPRECATED PARAMETERS (like workers variable)","commit_id":"1004a49811339f01f46d1735cc68311871a0e415"},{"author":{"_account_id":34532,"name":"Timothy Rice","email":"timothy.rice@nexgencloud.com","username":"terice"},"change_message_id":"b827a1161102fa2ae74fe9f1fd3a09ef7f8f1155","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*heartbeat_key*]"},{"line_number":6,"context_line":"#   Key to validate amphora messages."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*enabled*]"},{"line_number":9,"context_line":"#   (optional) Should the service be enabled."},{"line_number":10,"context_line":"#   Defaults to true"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7ee63d47_6fa61c7c","side":"PARENT","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"e3f67a22_7a385e05","updated":"2022-06-02 04:13:33.000000000","message":"Ack","commit_id":"1004a49811339f01f46d1735cc68311871a0e415"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5d9d4ebc2f0b56e4fd19c4d9b17e7be7145dd440","unresolved":true,"context_lines":[{"line_number":66,"context_line":"  $stats_update_threads  \u003d $::os_workers,"},{"line_number":67,"context_line":"  $failover_threads      \u003d $::os_service_default,"},{"line_number":68,"context_line":"  $heartbeat_timeout     \u003d $::os_service_default,"},{"line_number":69,"context_line":"  $health_check_interval \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $heartbeat_interval    \u003d $::os_service_default,"},{"line_number":71,"context_line":"  $sock_rlimit           \u003d $::os_service_default,"},{"line_number":72,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"edd91d00_8cd1b84b","line":69,"range":{"start_line":69,"start_character":2,"end_line":69,"end_character":49},"updated":"2022-06-02 04:49:13.000000000","message":"this is also used by octavia-worker IIUC.","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"}],"manifests/init.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13d2a2871c221f22e7bc4804bff3a1ea1a8eccae","unresolved":true,"context_lines":[{"line_number":221,"context_line":"  $notification_topics                \u003d $::os_service_default,"},{"line_number":222,"context_line":"  $topic                              \u003d \u0027octavia-rpc\u0027,"},{"line_number":223,"context_line":"  $purge_config                       \u003d false,"},{"line_number":224,"context_line":"  $heartbeat_key                      \u003d undef,"},{"line_number":225,"context_line":") inherits octavia::params {"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"a0bfc541_d24a201c","line":224,"range":{"start_line":224,"start_character":2,"end_line":224,"end_character":16},"updated":"2022-06-02 04:07:33.000000000","message":"Should we add this parameter to octavia::controller instead ?","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":34532,"name":"Timothy Rice","email":"timothy.rice@nexgencloud.com","username":"terice"},"change_message_id":"b827a1161102fa2ae74fe9f1fd3a09ef7f8f1155","unresolved":true,"context_lines":[{"line_number":221,"context_line":"  $notification_topics                \u003d $::os_service_default,"},{"line_number":222,"context_line":"  $topic                              \u003d \u0027octavia-rpc\u0027,"},{"line_number":223,"context_line":"  $purge_config                       \u003d false,"},{"line_number":224,"context_line":"  $heartbeat_key                      \u003d undef,"},{"line_number":225,"context_line":") inherits octavia::params {"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"  include octavia::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"56b7051a_a0cb462a","line":224,"range":{"start_line":224,"start_character":2,"end_line":224,"end_character":16},"in_reply_to":"a0bfc541_d24a201c","updated":"2022-06-02 04:13:33.000000000","message":"You\u0027re probably right. Let me check.","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"13d2a2871c221f22e7bc4804bff3a1ea1a8eccae","unresolved":true,"context_lines":[{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  # Heartbeat key is needed by both worker and health_manager processes"},{"line_number":293,"context_line":"  $heartbeat_key_real \u003d pick($::octavia::health_manager::heartbeat_key, $heartbeat_key)"},{"line_number":294,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $heartbeat_key_real)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"  octavia_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"4d3ec6ad_9c197d73","line":293,"range":{"start_line":293,"start_character":32,"end_line":293,"end_character":70},"updated":"2022-06-02 04:07:33.000000000","message":"this does not work unless the octavia::heatlh_manager class is included before the octavia class, and is quite likely to break existing deployment (TripleO is also affected).\n\nThe only solution I can suggest here is to unamange the parameter when the value is set to undef(default).","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"},{"author":{"_account_id":34532,"name":"Timothy Rice","email":"timothy.rice@nexgencloud.com","username":"terice"},"change_message_id":"b827a1161102fa2ae74fe9f1fd3a09ef7f8f1155","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  # Heartbeat key is needed by both worker and health_manager processes"},{"line_number":293,"context_line":"  $heartbeat_key_real \u003d pick($::octavia::health_manager::heartbeat_key, $heartbeat_key)"},{"line_number":294,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $heartbeat_key_real)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"  octavia_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"e979ef34_4f3625fe","line":293,"range":{"start_line":293,"start_character":32,"end_line":293,"end_character":70},"in_reply_to":"4d3ec6ad_9c197d73","updated":"2022-06-02 04:13:33.000000000","message":"Ack","commit_id":"7f3819eef74838d00b9b52e28b7882b1a5513acf"}]}