)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34532,"name":"Timothy Rice","email":"timothy.rice@nexgencloud.com","username":"terice"},"change_message_id":"6d8cc91d46e9fc22bb9d2fc79df11a0df70846b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab5729f0_87d0b938","updated":"2022-06-02 04:58:25.000000000","message":"lgtm","commit_id":"b9b3b9ad119233dfea76325813374134f8eb59a0"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"6fecd6f3f3401a96da87a9d93cd2eac89816ec2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"969789f5_164ea898","updated":"2022-06-02 23:33:14.000000000","message":"Nice!","commit_id":"dd729322ab31b72194ab58f630fdc20a35527549"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f93ad14591cb8e57687609e8ae2776b296b56483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2b30b612_35d1f52d","updated":"2022-06-03 07:15:20.000000000","message":"See comment, however I won\u0027t be blocking based on it, if it\u0027s OK with Takashi I\u0027m fine with it.","commit_id":"dd729322ab31b72194ab58f630fdc20a35527549"}],"manifests/health_manager.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f93ad14591cb8e57687609e8ae2776b296b56483","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    \u0027health_manager/sock_rlimit\u0027            : value \u003d\u003e $sock_rlimit;"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  if $::octavia::controller::heartbeat_key \u003d\u003d undef {"},{"line_number":135,"context_line":"    if $heartbeat_key \u003d\u003d undef {"},{"line_number":136,"context_line":"      fail(\u0027The heartbeat_key parameter is required.\u0027)"},{"line_number":137,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5c477d23_c328152d","line":134,"updated":"2022-06-03 07:15:20.000000000","message":"I don\u0027t really like this as it introduces a dependency on ordering of classes in manifests. Maybe that\u0027s the case today anyway or we could drop this code and just say it has no affect if not set in controller?","commit_id":"dd729322ab31b72194ab58f630fdc20a35527549"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e50ee611755f2c0b1a4796bacc045e9a202bd248","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    \u0027health_manager/sock_rlimit\u0027            : value \u003d\u003e $sock_rlimit;"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  if $::octavia::controller::heartbeat_key \u003d\u003d undef {"},{"line_number":135,"context_line":"    if $heartbeat_key \u003d\u003d undef {"},{"line_number":136,"context_line":"      fail(\u0027The heartbeat_key parameter is required.\u0027)"},{"line_number":137,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"585b6624_eeb47328","line":134,"in_reply_to":"5c477d23_c328152d","updated":"2022-06-03 07:20:41.000000000","message":"We should properly configure the heartbeat_key parameter to make Octavia functional, so we should not ignore the value if it is set via octavia::health_manager.\n\nIt\u0027s true this adds additional ordering constraint but it would be reasonable considering the fact that the octavia::controller class is actually required by health_manager as well.","commit_id":"dd729322ab31b72194ab58f630fdc20a35527549"}]}