)]}'
{"id":"openstack%2Fpuppet-openstack-cookiecutter~656141","triplet_id":"openstack%2Fpuppet-openstack-cookiecutter~master~Ic91d2eb60c27ed407c9ba58acf4c2d7eb4666423","project":"openstack/puppet-openstack-cookiecutter","branch":"master","topic":"bug/1826692","hashtags":[],"change_id":"Ic91d2eb60c27ed407c9ba58acf4c2d7eb4666423","subject":"Deprecate idle_timeout option","status":"MERGED","created":"2019-04-28 07:01:25.000000000","updated":"2019-04-29 07:51:39.000000000","submitted":"2019-04-29 07:51:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656141-1556524299669-3740e7af","meta_rev_id":"a9e995d1180677559f63f564f3023e39f4d23d05","_number":656141,"virtual_id_number":656141,"owner":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-04-29 07:06:03.000000000","_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-04-29 07:51:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-04-28 08:42:53.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-04-28 17:14:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-28 08:42:53.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-04-28 17:14:51.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-04-29 07:51:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"11f6e62396363268419c4431e2a658f97c841297","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-04-28 07:01:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7350422fc13887f2c60ff764c70517ee8635cc79","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-28 07:20:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-lint-ubuntu-bionic/6f700f7/ : FAILURE in 5m 55s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-syntax-4-centos-7/f995b23/ : SUCCESS in 7m 08s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-syntax-5-centos-7/62cd3c4/ : SUCCESS in 8m 49s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic/a0f62f3/ : SUCCESS in 6m 45s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-unit-4.8-centos-7/ad22d1b/ : FAILURE in 10m 21s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-unit-5.5-centos-7/e121498/ : FAILURE in 9m 46s\n- puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic/644b54a/ : FAILURE in 7m 39s\n- puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic/3035785/ : FAILURE in 9m 09s (non-voting)\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-beaker-rspec-centos-7/fa0465c/ : SUCCESS in 8m 28s\n- puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic http://logs.openstack.org/41/656141/1/check/puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic/0659037/ : SUCCESS in 6m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3ce99367e5dcb66a6fd9c0adebe78769d8857540","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-04-28 07:29:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c3ebef06b7598829947af6065a0a7ed1b456d85","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-28 08:03:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-lint-ubuntu-bionic/7d6ee7e/ : SUCCESS in 4m 52s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-4-centos-7/3256898/ : SUCCESS in 7m 59s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-5-centos-7/40c10aa/ : SUCCESS in 8m 12s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic/8b72b59/ : SUCCESS in 4m 53s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-4.8-centos-7/92d59ce/ : SUCCESS in 12m 35s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-5.5-centos-7/08481a2/ : SUCCESS in 10m 01s\n- puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic/3d36166/ : SUCCESS in 5m 37s\n- puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic/ac0bd3d/ : SUCCESS in 9m 20s (non-voting)\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-beaker-rspec-centos-7/2f77190/ : SUCCESS in 7m 32s\n- puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic/01aa72f/ : SUCCESS in 6m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"11da245d841d286bb39f969fe9a9d238341b69f5","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-04-28 08:42:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"03739f6ffbe83a492f57b30fa3120008f165816d","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-04-28 17:14:51.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f5802197dfee2b4269973894e0fc05d9f7b114f1","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-04-29 07:06:03.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"33bbecd86ddd8f65e3fc57a38e0cc5f1f5ce0b5a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 07:35:40.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-lint-ubuntu-bionic/1974edb/ : SUCCESS in 5m 40s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-4-centos-7/9c7da5e/ : SUCCESS in 11m 24s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-5-centos-7/53d0d77/ : SUCCESS in 10m 39s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic/c1b63cc/ : SUCCESS in 9m 20s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-4.8-centos-7/1fdbb8a/ : SUCCESS in 12m 45s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-5.5-centos-7/22409a8/ : SUCCESS in 12m 39s\n- puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic/99ad802/ : SUCCESS in 11m 12s\n- puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-unit-latest-ubuntu-bionic/d695399/ : SUCCESS in 11m 24s (non-voting)\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-beaker-rspec-centos-7/47a19c2/ : SUCCESS in 11m 53s\n- puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic http://logs.openstack.org/41/656141/2/check/puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic/60d524d/ : SUCCESS in 9m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e23e034639224ba4e565d2fb97233f72ac219036","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 07:35:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"497a617f76dbeb2eecc8f9a3ee6c65f5163e118d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 07:51:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-lint-ubuntu-bionic/1ca0661/ : SUCCESS in 7m 46s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-syntax-4-centos-7/cc53946/ : SUCCESS in 10m 51s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-syntax-5-centos-7/0095feb/ : SUCCESS in 10m 56s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic/ce1494f/ : SUCCESS in 9m 20s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-unit-4.8-centos-7/5a6fbf5/ : SUCCESS in 12m 54s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-unit-5.5-centos-7/6165072/ : SUCCESS in 12m 50s\n- puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-unit-6.0-ubuntu-bionic/d0fe6e8/ : SUCCESS in 8m 41s\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 http://logs.openstack.org/41/656141/2/gate/puppet-openstack-libraries-puppet-beaker-rspec-centos-7/2b9f89c/ : SUCCESS in 11m 14s","accounts_in_message":[],"_revision_number":2},{"id":"cdd03291b22cae1cf3ece472e36965cc206fed36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-29 07:51:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5466d6e6820291c73f546c41e3265c15683650c4","revisions":{"ee220896ad77c2265d0a07f640537d5a559b8e2b":{"kind":"REWORK","_number":1,"created":"2019-04-28 07:01:25.000000000","uploader":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"ref":"refs/changes/41/656141/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-cookiecutter","ref":"refs/changes/41/656141/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/1"}}},"commit":{"parents":[{"commit":"973fbf7fe491109b5098dfd0073fa2a3fd92c8ef","subject":"Merge \"Provide more useful fail message\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/973fbf7fe491109b5098dfd0073fa2a3fd92c8ef"}]}],"author":{"name":"ZhongShengping","email":"chdzsp@163.com","date":"2019-04-28 07:00:14.000000000","tz":480},"committer":{"name":"ZhongShengping","email":"chdzsp@163.com","date":"2019-04-28 07:00:14.000000000","tz":480},"subject":"Deprecate idle_timeout option","message":"Deprecate idle_timeout option\n\nThe idle_timeout parameter is deprecated, use connection_recycle_time\ninstead[1].\n\n[1]https://review.opendev.org/#/c/334182/\n\nChange-Id: Ic91d2eb60c27ed407c9ba58acf4c2d7eb4666423\nDepends-On: https://review.opendev.org/656106/\nCloses-Bug: #1826692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/ee220896ad77c2265d0a07f640537d5a559b8e2b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/ee220896ad77c2265d0a07f640537d5a559b8e2b"}]},"branch":"refs/heads/master"},"5466d6e6820291c73f546c41e3265c15683650c4":{"kind":"REWORK","_number":2,"created":"2019-04-28 07:29:22.000000000","uploader":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"ref":"refs/changes/41/656141/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-cookiecutter","ref":"refs/changes/41/656141/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-cookiecutter refs/changes/41/656141/2"}}},"commit":{"parents":[{"commit":"973fbf7fe491109b5098dfd0073fa2a3fd92c8ef","subject":"Merge \"Provide more useful fail message\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/973fbf7fe491109b5098dfd0073fa2a3fd92c8ef"}]}],"author":{"name":"ZhongShengping","email":"chdzsp@163.com","date":"2019-04-28 07:00:14.000000000","tz":480},"committer":{"name":"ZhongShengping","email":"chdzsp@163.com","date":"2019-04-28 07:28:04.000000000","tz":480},"subject":"Deprecate idle_timeout option","message":"Deprecate idle_timeout option\n\nThe idle_timeout parameter is deprecated, use connection_recycle_time\ninstead[1].\n\n[1]https://review.opendev.org/#/c/334182/\n\nChange-Id: Ic91d2eb60c27ed407c9ba58acf4c2d7eb4666423\nDepends-On: https://review.opendev.org/656106/\nCloses-Bug: #1826692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/5466d6e6820291c73f546c41e3265c15683650c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-cookiecutter/commit/5466d6e6820291c73f546c41e3265c15683650c4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}