)]}'
{"doc/source/coding-style.rst":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"730893a095110c5e5dd5c44e5b20e45253b5aff9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\\_\\_TOC\\_\\_"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Before coding"},{"line_number":4,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_bc2a417c","line":1,"updated":"2016-05-05 14:23:19.000000000","message":"could we have it in the index?","commit_id":"8b6a4ab27ab8c07503c66c4de5374972af0374cc"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\\_\\_TOC\\_\\_"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Before coding"},{"line_number":4,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_bfd4de1f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2016-05-10 17:24:23.000000000","message":"This should be showing up in the docs?","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Before coding"},{"line_number":4,"context_line":"-------------"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Noteː this document is work in progress and the content with evolve. Any"},{"line_number":7,"context_line":"contribution is welcome though ;-)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"-  Read this page"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_7f18b61e","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":4},"updated":"2016-05-10 17:24:23.000000000","message":"you can use .. note::","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   `Rspec \u003chttp://rspec-puppet.com/\u003e`__, and"},{"line_number":15,"context_line":"   `Beaker \u003chttps://github.com/puppetlabs/beaker\u003e`__"},{"line_number":16,"context_line":"-  If you want to create a new module, read"},{"line_number":17,"context_line":"   `Puppet/New\\_module \u003cPuppet/New_module\u003e`__"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Best practices"},{"line_number":20,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_3f974e49","line":17,"range":{"start_line":17,"start_character":43,"end_line":17,"end_character":45},"updated":"2016-05-10 17:24:23.000000000","message":"add the link http://docs.openstack.org/developer/puppet-openstack-guide/new-module.html","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Commit message"},{"line_number":35,"context_line":"~~~~~~~~~~~~~~"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Please read `GitCommitMessages \u003cGitCommitMessages\u003e`__."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Consistency"},{"line_number":40,"context_line":"~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_ff96663c","line":37,"range":{"start_line":37,"start_character":51,"end_line":37,"end_character":53},"updated":"2016-05-10 17:24:23.000000000","message":"please add the link","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":67,"context_line":"-------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Your code needs to be tested. Puppet OpenStack CI will"},{"line_number":70,"context_line":"`verify \u003cPuppet/CI\u003e`__ for you, but if you want to save time, you better"},{"line_number":71,"context_line":"to run tests locally before sending a patchː"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"-  `Lint \u003chttp://puppet-lint.com/\u003e`__"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_bfde9e0e","line":70,"range":{"start_line":70,"start_character":20,"end_line":70,"end_character":22},"updated":"2016-05-10 17:24:23.000000000","message":"please add the link","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"-  `Lint \u003chttp://puppet-lint.com/\u003e`__"},{"line_number":74,"context_line":"-  `Syntax \u003chttps://puppetlabs.com/blog/verifying-puppet-checking-syntax-and-writing-automated-tests\u003e`__"},{"line_number":75,"context_line":"-  `Puppet/Unit\\_testing \u003cPuppet/Unit_testing\u003e`__"},{"line_number":76,"context_line":"-  `Puppet/Functional\\_testing \u003cPuppet/Functional_testing\u003e`__"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Documentation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_7ff0b691","line":75,"range":{"start_line":75,"start_character":26,"end_line":75,"end_character":32},"updated":"2016-05-10 17:24:23.000000000","message":"http://docs.openstack.org/developer/puppet-openstack-guide/testing-your-code.html#unit-tests","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":73,"context_line":"-  `Lint \u003chttp://puppet-lint.com/\u003e`__"},{"line_number":74,"context_line":"-  `Syntax \u003chttps://puppetlabs.com/blog/verifying-puppet-checking-syntax-and-writing-automated-tests\u003e`__"},{"line_number":75,"context_line":"-  `Puppet/Unit\\_testing \u003cPuppet/Unit_testing\u003e`__"},{"line_number":76,"context_line":"-  `Puppet/Functional\\_testing \u003cPuppet/Functional_testing\u003e`__"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Documentation"},{"line_number":79,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_9f0aba88","line":76,"range":{"start_line":76,"start_character":39,"end_line":76,"end_character":57},"updated":"2016-05-10 17:24:23.000000000","message":"http://docs.openstack.org/developer/puppet-openstack-guide/testing-your-code.html#functional-tests","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"   reviews. If you need to discuss about already reviewed code, you can"},{"line_number":94,"context_line":"   ping the reviewers."},{"line_number":95,"context_line":"-  Add your patch on the `Puppet OpenStack meeting"},{"line_number":96,"context_line":"   Agenda \u003cMeetings/PuppetOpenStack#Agenda\u003e`__ (in Open Discussion"},{"line_number":97,"context_line":"   section)."},{"line_number":98,"context_line":"-  Use `Mailing list \u003cPuppet/Mailing_lists\u003e`__."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_1f252a08","line":96,"range":{"start_line":96,"start_character":36,"end_line":96,"end_character":42},"updated":"2016-05-10 17:24:23.000000000","message":"http://docs.openstack.org/developer/puppet-openstack-guide/meetings.html#next-meeting","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e734e5779483a3090d2f5705aeb4b4fcb19b7bbe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"-  Add your patch on the `Puppet OpenStack meeting"},{"line_number":96,"context_line":"   Agenda \u003cMeetings/PuppetOpenStack#Agenda\u003e`__ (in Open Discussion"},{"line_number":97,"context_line":"   section)."},{"line_number":98,"context_line":"-  Use `Mailing list \u003cPuppet/Mailing_lists\u003e`__."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_5f721212","line":98,"range":{"start_line":98,"start_character":22,"end_line":98,"end_character":23},"updated":"2016-05-10 17:24:23.000000000","message":"http://docs.openstack.org/developer/puppet-openstack-guide/mailing-list.html","commit_id":"36c4afdfd339d7e845e83d08a3d734989b6c60d8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"64c38bab7c903cf180078d50d541d49887719897","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Before coding"},{"line_number":2,"context_line":"-------------"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":".. note:: this document is work in progress and the content with evolve. Any"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dab17558_e547ecb9","line":1,"updated":"2016-05-10 21:22:09.000000000","message":"can we find another title? Coding Style maybe?","commit_id":"73354167cb6cddc3dc49e294c4264e2db824f830"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"68b2500f5202df70f32aaeece98ae9bbeab11ecf","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"We have a lot of modules to maintain, please keep our code consistent."},{"line_number":41,"context_line":"Before adding new parameters or new classes, see if other modules"},{"line_number":42,"context_line":"already implement them and keep consistent. See also our common librarie"},{"line_number":43,"context_line":"`OpenStackLib \u003chttp://git.openstack.org/cgit/openstack/puppet-openstacklib/\u003e`__"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Config file defaults and parameters"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_b2be95ab","line":42,"updated":"2016-05-11 19:02:32.000000000","message":"Is \"librarie\" on purpose? I can\u0027t find an Englinsh non-plural example of its usage this way.","commit_id":"d6e25313d71242ae5b1f3b96138b78a2e51b6689"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"68b2500f5202df70f32aaeece98ae9bbeab11ecf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"-------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Your code needs to be tested. Puppet OpenStack CI will"},{"line_number":68,"context_line":"`verify \u003chttp://docs.openstack.org/developer/puppet-openstack-guide/ci.html\u003e`__ for you, but if you want to save time, you better"},{"line_number":69,"context_line":"to run tests locally before sending a patchː"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"-  `Lint \u003chttp://puppet-lint.com/\u003e`__"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_1215e19a","line":68,"updated":"2016-05-11 19:02:32.000000000","message":"Replace \"you\" with \"you\u0027re\"","commit_id":"d6e25313d71242ae5b1f3b96138b78a2e51b6689"}]}
