)]}'
{"doc/source/new-module.rst":[{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"fd4250cd60998d98f65593145c7f71e277872324","unresolved":false,"context_lines":[{"line_number":118,"context_line":"without anyone looking at them for some time. After the first"},{"line_number":119,"context_line":"cookiecutter commit, add the rest of the bits piece by piece."},{"line_number":120,"context_line":"For example: Start with init.pp for common bits, then add an api.pp, etc."},{"line_number":121,"context_line":"For each bit, add its unit tests \u0026 functional tests (beaker). It will"},{"line_number":122,"context_line":"allow us to write modules with good design, good tests, and good code"},{"line_number":123,"context_line":"in general."},{"line_number":124,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_17642547","line":121,"updated":"2016-06-23 13:27:58.000000000","message":"A link to the testing doc would be useful here.","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"fd4250cd60998d98f65593145c7f71e277872324","unresolved":false,"context_lines":[{"line_number":126,"context_line":"A good Puppet module is one that we can use to successfully deploy an"},{"line_number":127,"context_line":"OpenStack service. For that, please add beaker and rspec tests when"},{"line_number":128,"context_line":"you\u0027re initiating a module. Not at the end of your work, but for every"},{"line_number":129,"context_line":"new class or feature. It helps to easily detect issues that we\u0027ll have when"},{"line_number":130,"context_line":"running Puppet catalog and quickly fix it. It also helps community to report"},{"line_number":131,"context_line":"feedback on packaging, Tempest, or to detect issues in our common libraries."},{"line_number":132,"context_line":"If you\u0027re not familiar with beaker, refer to existing modules for examples."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_57eced8e","line":129,"updated":"2016-06-23 13:27:58.000000000","message":"You use a lot of good examples. A link to a gerrit review that follows good feature + test addition would be super useful here.","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"fd4250cd60998d98f65593145c7f71e277872324","unresolved":false,"context_lines":[{"line_number":129,"context_line":"new class or feature. It helps to easily detect issues that we\u0027ll have when"},{"line_number":130,"context_line":"running Puppet catalog and quickly fix it. It also helps community to report"},{"line_number":131,"context_line":"feedback on packaging, Tempest, or to detect issues in our common libraries."},{"line_number":132,"context_line":"If you\u0027re not familiar with beaker, refer to existing modules for examples."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3aaa91ec_7745a96e","line":132,"updated":"2016-06-23 13:27:58.000000000","message":"another link plz :) either to something like:\n\nhttp://git.openstack.org/cgit/openstack/puppet-nova/tree/spec/acceptance/nova_wsgi_apache_spec.rb\n\nor to\n\nhttps://github.com/puppetlabs/beaker-rspec/blob/master/README.md","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"43d88e3aed4dd5c7f75b481b1c17f93ab9ebb2bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aa08908_1027cfb6","line":133,"updated":"2016-06-14 03:23:38.000000000","message":"Nice idea Matt o/\nI just think this tips not only belongs to new-modules but for every work we are doing. Maybe this should be in http://docs.openstack.org/developer/puppet-openstack-guide/coding-style.html i think.","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"12509b7dead8f98f750619c85233ebd8a2de8bd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7aa08908_b02ebb89","line":133,"in_reply_to":"7aa08908_1027cfb6","updated":"2016-06-14 03:25:29.000000000","message":"Oh also, we should just put a link here to the section in coding-style \u003d)","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"fd4250cd60998d98f65593145c7f71e277872324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3aaa91ec_3a9ca8bf","line":133,"in_reply_to":"7aa08908_b02ebb89","updated":"2016-06-23 13:27:58.000000000","message":"For bonus points it might be worth mentioning the openstack-spec-helper, although that might be considered out-of-scope or better put in a writing-tests doc.\n\nhttp://git.openstack.org/cgit/openstack/puppet-openstack_spec_helper/tree/README.md","commit_id":"079c7ae6f35f20b675f3d1e51fd8cd3ad40c88ed"}]}