)]}'
{"id":"openstack%2Fpuppet-openstack-guide~620751","triplet_id":"openstack%2Fpuppet-openstack-guide~master~Iaa779357bf65f206ed8ea012668bbd1b66c9260e","project":"openstack/puppet-openstack-guide","branch":"master","topic":"coding","hashtags":[],"change_id":"Iaa779357bf65f206ed8ea012668bbd1b66c9260e","subject":"Class structure and dependencies","status":"MERGED","created":"2018-11-28 23:49:12.000000000","updated":"2018-12-05 19:59:44.000000000","submitted":"2018-12-05 19:59:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"620751-1544039984994-ed8d3243","meta_rev_id":"958ae70bbf2e9574a98f9c6c1776ab78835276d6","_number":620751,"virtual_id_number":620751,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},{"value":0,"date":"2018-11-29 08:19:22.000000000","_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2018-12-05 19:59:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2018-12-05 19:47:45.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2018-11-29 08:43:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2018-11-29 15:23:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2018-12-05 19:47:45.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-11-29 08:43:29.000000000","updated_by":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"reviewer":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"state":"REVIEWER"},{"updated":"2018-11-29 15:23:34.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2018-12-05 19:47:45.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-12-05 19:59:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7a79378c0ef23532ec756ef0cd068e2a46e9c279","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-11-28 23:49:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6299948dd674e7e5d80accb019bee211b2a44b8","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-11-28 23:53:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6a5afb39940f123ca0cb97f6f0243d8576c25017","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-11-28 23:54:24.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1e6f5d0b9702efa193a777e6f15178f6dea5834d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-29 03:34:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/51/620751/3/check/openstack-tox-docs/5ca702d/html/ : SUCCESS in 5m 40s","accounts_in_message":[],"_revision_number":3},{"id":"543a1d46477c6d69daf953e725ceee3611b89749","author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"date":"2018-11-29 07:31:13.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nJust some language suggestions, other than that I\u0027m OK with the content.\n\nI feel the guide generally lacks some examples of how to implement the common use cases especially regarding what should be a parameter and what should be set via automatic class lookup","accounts_in_message":[],"_revision_number":3},{"id":"fab7a4aee559b782127eb270e2a249069d5e89f5","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-11-29 08:19:10.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6dabc88a05d550e45449b84ef974b7e66853ffcf","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-11-29 08:19:22.000000000","message":"Patch Set 4:\n\nThanks Pierre!","accounts_in_message":[],"_revision_number":4},{"id":"69b39b290b3a10c2be8ee1ed1343a8b3a8e6626e","author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"date":"2018-11-29 08:43:29.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"6bba4edb8fad7b0092eda49cd7b3fa3eeb3b8f1d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-29 10:16:15.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/51/620751/4/check/openstack-tox-docs/1adb6e8/html/ : SUCCESS in 4m 06s","accounts_in_message":[],"_revision_number":4},{"id":"d19759ae34775f3e26290384c782321521781be0","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-11-29 15:23:34.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"5a7d44c9f9326fb48e53c48c26890339c3e3e9f8","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-12-05 19:47:45.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"33d566eb897f9b2fbf848483b58e0aca6513e272","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 19:48:56.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"14b1ce95b7173ebafc110ccd42c30455c3814c9e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 19:59:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"b75db1752c440cd29e04fb816c39e812bfb41fa4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-05 19:59:44.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/51/620751/4/gate/openstack-tox-docs/f110977/html/ : SUCCESS in 5m 25s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0450457fb3b4002c37142ebafcc954ab3cb9172c","revisions":{"9bf3146eab24c20aff66b3a3c1627b9b26f5d527":{"kind":"REWORK","_number":1,"created":"2018-11-28 23:49:12.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/51/620751/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-guide","ref":"refs/changes/51/620751/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/1"}}},"commit":{"parents":[{"commit":"78ac1291ef0af51d3b964d63d45271e78ed71266","subject":"Replace the url to the latesd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/78ac1291ef0af51d3b964d63d45271e78ed71266"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:48:27.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:48:27.000000000","tz":60},"subject":"Class structure and dependencies","message":"Class structure and dependencies\n\nAdd a segment to the coding style about the preferred\nclass structure and our view on dependencies, keeping\nthe relationship between classes to a minimal.\n\nChange-Id: Iaa779357bf65f206ed8ea012668bbd1b66c9260e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/9bf3146eab24c20aff66b3a3c1627b9b26f5d527"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/9bf3146eab24c20aff66b3a3c1627b9b26f5d527"}]},"branch":"refs/heads/master"},"e23383d2ed88ce984f9cde65ac1dc43883937a53":{"kind":"REWORK","_number":2,"created":"2018-11-28 23:53:05.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/51/620751/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-guide","ref":"refs/changes/51/620751/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/2"}}},"commit":{"parents":[{"commit":"78ac1291ef0af51d3b964d63d45271e78ed71266","subject":"Replace the url to the latesd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/78ac1291ef0af51d3b964d63d45271e78ed71266"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:48:27.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:52:59.000000000","tz":60},"subject":"Class structure and dependencies","message":"Class structure and dependencies\n\nAdd a segment to the coding style about the preferred\nclass structure and our view on dependencies, keeping\nthe relationship between classes to a minimal.\n\nChange-Id: Iaa779357bf65f206ed8ea012668bbd1b66c9260e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/e23383d2ed88ce984f9cde65ac1dc43883937a53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/e23383d2ed88ce984f9cde65ac1dc43883937a53"}]},"branch":"refs/heads/master"},"3d6d2b90e3ad95a21a76edc40919a715bca54482":{"kind":"REWORK","_number":3,"created":"2018-11-28 23:54:24.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/51/620751/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-guide","ref":"refs/changes/51/620751/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/3"}}},"commit":{"parents":[{"commit":"78ac1291ef0af51d3b964d63d45271e78ed71266","subject":"Replace the url to the latesd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/78ac1291ef0af51d3b964d63d45271e78ed71266"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:48:27.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:53:44.000000000","tz":60},"subject":"Class structure and dependencies","message":"Class structure and dependencies\n\nAdd a segment to the coding style about the preferred\nclass structure and our view on dependencies, keeping\nthe relationship between classes to a minimal.\n\nChange-Id: Iaa779357bf65f206ed8ea012668bbd1b66c9260e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/3d6d2b90e3ad95a21a76edc40919a715bca54482"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/3d6d2b90e3ad95a21a76edc40919a715bca54482"}]},"branch":"refs/heads/master"},"0450457fb3b4002c37142ebafcc954ab3cb9172c":{"kind":"REWORK","_number":4,"created":"2018-11-29 08:19:10.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/51/620751/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-guide","ref":"refs/changes/51/620751/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-guide refs/changes/51/620751/4"}}},"commit":{"parents":[{"commit":"78ac1291ef0af51d3b964d63d45271e78ed71266","subject":"Replace the url to the latesd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/78ac1291ef0af51d3b964d63d45271e78ed71266"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-28 23:48:27.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2018-11-29 08:19:04.000000000","tz":60},"subject":"Class structure and dependencies","message":"Class structure and dependencies\n\nAdd a segment to the coding style about the preferred\nclass structure and our view on dependencies, keeping\nthe relationship between classes to a minimal.\n\nChange-Id: Iaa779357bf65f206ed8ea012668bbd1b66c9260e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/0450457fb3b4002c37142ebafcc954ab3cb9172c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-guide/commit/0450457fb3b4002c37142ebafcc954ab3cb9172c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}