)]}'
{"modules/openstack_integration/manifests/testing/scenario001.pp":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"b8706b715528f159309fe0574bc293c7a613e93c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  # Common resources"},{"line_number":20,"context_line":"  case $::osfamily {"},{"line_number":21,"context_line":"    \u0027Debian\u0027: {"},{"line_number":22,"context_line":"      include ::apt"},{"line_number":23,"context_line":"      class { \u0027::openstack_extras::repo::debian::ubuntu\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_a5379de1","line":20,"updated":"2015-07-29 15:17:08.000000000","message":"I guess this is needed because we are defendant on specific packages? I wonder if this could be removed, and changed in a more generic way, allowing us to control which repos we subscribe to in a more global way.\n\nLet me think and see if I can come up with something that I mean","commit_id":"61211cf77cd628e8498159b054ad51640aebe635"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b47bd1837360b48c0ce0202bc41c6de2c30baf3f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  # Common resources"},{"line_number":20,"context_line":"  case $::osfamily {"},{"line_number":21,"context_line":"    \u0027Debian\u0027: {"},{"line_number":22,"context_line":"      include ::apt"},{"line_number":23,"context_line":"      class { \u0027::openstack_extras::repo::debian::ubuntu\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_a3fa3573","line":20,"in_reply_to":"3a50d1a3_a5379de1","updated":"2015-07-29 15:55:56.000000000","message":"Well, this is the cleanest way to prepare packaging repositories with Puppet. We already use that method on Beaker, we might want to be consistent here.","commit_id":"61211cf77cd628e8498159b054ad51640aebe635"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"b8706b715528f159309fe0574bc293c7a613e93c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # Deploy MySQL Server"},{"line_number":40,"context_line":"  class { \u0027::mysql::server\u0027: }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Deploy Keystone"},{"line_number":43,"context_line":"  class { \u0027::keystone::client\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_e56e05c7","line":40,"updated":"2015-07-29 15:17:08.000000000","message":"So, I personally think we should be binding to 127.0.0.1 by default, which mean we likely need to be explicit here.\n\nThis way, we don\u0027t have to deal with jenkins or firewalls out of the box.","commit_id":"61211cf77cd628e8498159b054ad51640aebe635"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b47bd1837360b48c0ce0202bc41c6de2c30baf3f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  # Deploy MySQL Server"},{"line_number":40,"context_line":"  class { \u0027::mysql::server\u0027: }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # Deploy Keystone"},{"line_number":43,"context_line":"  class { \u0027::keystone::client\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a50d1a3_c3ce6159","line":40,"in_reply_to":"3a50d1a3_e56e05c7","updated":"2015-07-29 15:55:56.000000000","message":"this is already the case:\n\nhttps://github.com/puppetlabs/puppetlabs-mysql/blob/fd033183312961f6fdefeef4bcdf1c4aed520419/manifests/params.pp#L371","commit_id":"61211cf77cd628e8498159b054ad51640aebe635"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"6212a3937ee0cfd3609d30903cdddd2141d4aa5c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"  class { \u0027::keystone::endpoint\u0027:"},{"line_number":66,"context_line":"    public_url     \u003d\u003e \u0027http://127.0.0.1:5000\u0027,"},{"line_number":67,"context_line":"    admin_url      \u003d\u003e \u0027http://127.0.0.1:35357\u0027,"},{"line_number":68,"context_line":"    default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a4dcd0f_f94f60bc","line":66,"updated":"2015-08-14 02:59:00.000000000","message":"this is already default","commit_id":"e91711a4608510fcdbdaba051a3934f77c7cf8b6"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"6212a3937ee0cfd3609d30903cdddd2141d4aa5c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"  class { \u0027::keystone::endpoint\u0027:"},{"line_number":66,"context_line":"    public_url     \u003d\u003e \u0027http://127.0.0.1:5000\u0027,"},{"line_number":67,"context_line":"    admin_url      \u003d\u003e \u0027http://127.0.0.1:35357\u0027,"},{"line_number":68,"context_line":"    default_domain \u003d\u003e \u0027admin\u0027,"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a4dcd0f_79ca701c","line":67,"updated":"2015-08-14 02:59:00.000000000","message":"this is already default","commit_id":"e91711a4608510fcdbdaba051a3934f77c7cf8b6"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"69d585a01df35bfd405ddb5c405e9922bf397e57","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Common resources"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a4dcd0f_3f049ac4","line":16,"updated":"2015-08-14 22:27:03.000000000","message":"Not sure how I feel about this change. I know it works however if the current directory structure does not make sense now. Additionally, the naming of the repo, puppet-openstack-integration some what implies this so be a puppet module.\n\nUsing this syntax mean, nothing else can consume it as a puppet module.  Which is fine, if we want to go down that path.  However, just to keep in mind moving forward.\n\nLastly, I\u0027ve said this before, you\u0027ve basically just duplicated the code in the puppet keystone acceptance testing now.  So why bother having this repo then? In theory we could just include keystone::tests::acceptance1 or something.  Just having this repo use all the individual acceptance tests into a larger single node.\n\nI just cannot get past the feeling, we are going to do all this work, just to duplicate how the current beaker system works.","commit_id":"a7d5fc5b30bd190b9b5794cd72055690783a20e2"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"31b78900c74db71e4993e62becf2a83853932b69","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Common resources"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"1a4dcd0f_9217e544","line":16,"in_reply_to":"1a4dcd0f_3f049ac4","updated":"2015-08-14 22:54:58.000000000","message":"\u003e Additionally, the naming of the repo, puppet-openstack-integration some what implies this so be a puppet module.\n\nThe repo is explicitly not supposed to be a puppet module (the dash in openstack-integration would break on the forge). We wanted to be clear that nothing should consume it as a puppet module.\n\nRelatedly, I don\u0027t really see why we need this module structure buried here, we could just have a fixtures/ directory with manifests in it.\n\n\u003e Lastly, I\u0027ve said this before, you\u0027ve basically just duplicated the code in the puppet keystone acceptance testing now.\n\nI agree, but my assumption was this was just intended as a starting place. We should solicit feedback from operators on what kinds of scenarios we should be testing.","commit_id":"a7d5fc5b30bd190b9b5794cd72055690783a20e2"}]}