)]}'
{"id":"openstack%2Fpuppet-openstack-integration~210380","triplet_id":"openstack%2Fpuppet-openstack-integration~master~I1f05de578eb60bcfbf780171d0ef574eb90fb6d3","project":"openstack/puppet-openstack-integration","branch":"master","topic":"puppet/integ","hashtags":[],"change_id":"I1f05de578eb60bcfbf780171d0ef574eb90fb6d3","subject":"Move intall_modules.sh to tools directory","status":"ABANDONED","created":"2015-08-07 12:50:39.000000000","updated":"2015-08-14 17:54:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"456e855418dc33ed7b73abb7719b7965443dc1d4","_number":210380,"virtual_id_number":210380,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2015-08-13 10:40:30.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":1,"date":"2015-08-09 03:52:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":-1,"date":"2015-08-10 00:18:10.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-08-07 13:07:13.000000000","updated_by":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"reviewer":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"state":"REVIEWER"},{"updated":"2015-08-07 13:48:27.000000000","updated_by":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"reviewer":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"state":"REVIEWER"},{"updated":"2015-08-09 03:52:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-08-10 00:18:10.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"}],"messages":[{"id":"db3683fa6f07b301a9769469c4ab56db913ec1ca","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-07 12:50:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9da4f8a83dcc9e325246ced885e65ae0733aea7c","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-07 12:50:54.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"d66077f5b986cbe0b739e0b854973a57b0d76362","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-07 12:57:39.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"dbb11bfcd21eb0a99496e76fa4915199c1320580","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2015-08-07 13:02:59.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5bb8ad70ffeb1466441111540bcf6595c1674fdd","author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"date":"2015-08-07 13:07:13.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4868e5b8b346aa8edefe412644ec9d9c064b41e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 13:08:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/80/210380/1/check/gate-puppet-openstack-integration-puppet-lint/aadf0f1/ : SUCCESS in 37s\n- gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/80/210380/1/check/gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7/3ec0e80/ : SUCCESS in 58s\n- gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/80/210380/1/check/gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7/5e54caf/ : SUCCESS in 59s\n- gate-puppet-openstack-integration-dsvm-trusty http://logs.openstack.org/80/210380/1/check/gate-puppet-openstack-integration-dsvm-trusty/e6af1e9/ : SUCCESS in 1m 05s (non-voting)\n- gate-puppet-openstack-integration-dsvm-centos7 http://logs.openstack.org/80/210380/1/check/gate-puppet-openstack-integration-dsvm-centos7/ba7174a/ : SUCCESS in 1m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"899cd60da8463d9e31cff942a7366e3ecbca6067","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-07 13:36:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ebd2eb67a1c34c3452f2d8932bfb150ee7556c5d","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2015-08-07 13:48:27.000000000","message":"Patch Set 2: Code-Review-1\n\nThis change seems to completely by pass the puppet-modulesync-configs project.\n\nPersonally, I\u0027d rather see us merge there first, then do the sync of modules.","accounts_in_message":[],"_revision_number":2},{"id":"2e9091525a96f431bf93a8aba865b888139a8482","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-07 14:06:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/80/210380/2/check/gate-puppet-openstack-integration-puppet-lint/64e9cd9/ : SUCCESS in 29s\n- gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/80/210380/2/check/gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7/9da165e/ : SUCCESS in 1m 01s\n- gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/80/210380/2/check/gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7/8cd6449/ : SUCCESS in 1m 06s\n- gate-puppet-openstack-integration-dsvm-trusty http://logs.openstack.org/80/210380/2/check/gate-puppet-openstack-integration-dsvm-trusty/26770c2/ : FAILURE in 30s (non-voting)\n- gate-puppet-openstack-integration-dsvm-centos7 http://logs.openstack.org/80/210380/2/check/gate-puppet-openstack-integration-dsvm-centos7/9b4715a/ : FAILURE in 28s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4afcd32d86c56914fc88de39f2c4489ae8721c59","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-09 03:47:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"35bc9bdb1c373203a74e767e5162716f69c462b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-09 03:52:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/80/210380/3/check/gate-puppet-openstack-integration-puppet-lint/6dea28b/ : SUCCESS in 30s\n- gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/80/210380/3/check/gate-puppet-openstack-integration-puppet-syntax-3-dsvm-centos7/9d86486/ : SUCCESS in 53s\n- gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/80/210380/3/check/gate-puppet-openstack-integration-puppet-syntax-4-dsvm-centos7/2c40f50/ : SUCCESS in 53s\n- gate-puppet-openstack-integration-dsvm-trusty http://logs.openstack.org/80/210380/3/check/gate-puppet-openstack-integration-dsvm-trusty/5cb75f3/ : SUCCESS in 52s (non-voting)\n- gate-puppet-openstack-integration-dsvm-centos7 http://logs.openstack.org/80/210380/3/check/gate-puppet-openstack-integration-dsvm-centos7/4bdf2bf/ : SUCCESS in 55s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e38d1ec4d55251696961a84b649b7cb2a8902dce","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2015-08-10 00:18:10.000000000","message":"Patch Set 3: Code-Review-1\n\nI don\u0027t see the point of this. This seems like a noop change.\n\nThe scripts placement here was based on Infra\u0027s system-config which has install_modules.sh at the top level.","accounts_in_message":[],"_revision_number":3},{"id":"44505f4664cc929dd67aa21af2fae39dc535c573","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2015-08-10 00:38:07.000000000","message":"Patch Set 3:\n\nThis is also going to require patches to all the modules since they use this for functional tests, which seems like a lot of work to accomodate a noop change. http://git.openstack.org/cgit/openstack/puppet-keystone/tree/spec/spec_helper_acceptance.rb#n44","accounts_in_message":[],"_revision_number":3},{"id":"337ace45052d45ebe6e6e7c8e5852657bce226b3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-13 10:40:30.000000000","message":"Patch Set 3:\n\nso we keep the script in ./ ?","accounts_in_message":[],"_revision_number":3},{"id":"46568db6ee17173beaad60204205ccaa6d8fe86a","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2015-08-14 17:43:34.000000000","message":"Patch Set 3:\n\nYes, my preference would be to drop this patch unless there is a good reason for it.","accounts_in_message":[],"_revision_number":3},{"id":"9bf6fecf03c6302415a741dec4d9151fa5c2c24f","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-14 17:54:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"98dfd25fe21fda4c2a049ba78a0ef87e5d758c86","revisions":{"dc89ea11a262800a0e01d8e5ca1b6f5113034acd":{"kind":"REWORK","_number":1,"created":"2015-08-07 12:50:39.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/80/210380/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/80/210380/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/1"}}},"commit":{"parents":[{"commit":"9b8367d128dc330b2766551445cbcb624a534a6d","subject":"Put install_modules.sh in / to unlock CI jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/9b8367d128dc330b2766551445cbcb624a534a6d"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-07 12:50:18.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-07 12:50:38.000000000","tz":-240},"subject":"Revert \"Put install_modules.sh in / to unlock CI jobs\"","message":"Revert \"Put install_modules.sh in / to unlock CI jobs\"\n\nThis reverts commit 9b8367d128dc330b2766551445cbcb624a534a6d.\n\nChange-Id: I1f05de578eb60bcfbf780171d0ef574eb90fb6d3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/dc89ea11a262800a0e01d8e5ca1b6f5113034acd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/dc89ea11a262800a0e01d8e5ca1b6f5113034acd"}]},"branch":"refs/heads/master"},"12ae3db69535f3ab5e001d44b880567d60c6c861":{"kind":"REWORK","_number":2,"created":"2015-08-07 13:36:31.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/80/210380/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/80/210380/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/2"}}},"commit":{"parents":[{"commit":"1fa1f22851c978ded7ab430ce5411221ed58abf7","subject":"Revert \"Revert \"Initial run_tests.sh script\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/1fa1f22851c978ded7ab430ce5411221ed58abf7"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-07 12:50:18.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-07 13:35:41.000000000","tz":-240},"subject":"Move intall_modules.sh to tools directory","message":"Move intall_modules.sh to tools directory\n\n* Move install_modules.sh to tools directory\n* Adjust the script to keep Puppetfile in root repository\n\nChange-Id: I1f05de578eb60bcfbf780171d0ef574eb90fb6d3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/12ae3db69535f3ab5e001d44b880567d60c6c861"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/12ae3db69535f3ab5e001d44b880567d60c6c861"}]},"branch":"refs/heads/master"},"98dfd25fe21fda4c2a049ba78a0ef87e5d758c86":{"kind":"REWORK","_number":3,"created":"2015-08-09 03:47:07.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/80/210380/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/80/210380/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/80/210380/3"}}},"commit":{"parents":[{"commit":"1fa1f22851c978ded7ab430ce5411221ed58abf7","subject":"Revert \"Revert \"Initial run_tests.sh script\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/1fa1f22851c978ded7ab430ce5411221ed58abf7"}]}],"author":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-07 12:50:18.000000000","tz":-240},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2015-08-09 03:46:57.000000000","tz":-240},"subject":"Move intall_modules.sh to tools directory","message":"Move intall_modules.sh to tools directory\n\n* Move install_modules.sh to tools directory\n* Adjust the script to keep Puppetfile in root repository\n\nChange-Id: I1f05de578eb60bcfbf780171d0ef574eb90fb6d3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/98dfd25fe21fda4c2a049ba78a0ef87e5d758c86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/98dfd25fe21fda4c2a049ba78a0ef87e5d758c86"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}