)]}'
{".gitignore":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a63e24c9fb9d7d618d9df884c5e731045dddb69b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Gemfile.lock"},{"line_number":2,"context_line":".bundle/"},{"line_number":3,"context_line":".bundled_gems/"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"fa1b9901_093535f6","line":3,"updated":"2015-08-21 17:42:08.000000000","message":"We don\u0027t need any of this since we\u0027re installing r10k globally for now.","commit_id":"795486ac47c1c76f09b2e1d30423ac3f94e021fd"}],"Gemfile":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"321e5873561d14312a7076c2f76a88b04641b380","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"},{"line_number":20,"context_line":"  gem \u0027facter\u0027, facterversion, :require \u003d\u003e false"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"  gem \u0027facter\u0027, :require \u003d\u003e false"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_19cf472a","side":"PARENT","line":22,"updated":"2015-08-19 16:33:41.000000000","message":"Why was this changed?","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae152e761d522db55075df2c18df7ef43904c9fb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"},{"line_number":20,"context_line":"  gem \u0027facter\u0027, facterversion, :require \u003d\u003e false"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"  gem \u0027facter\u0027, :require \u003d\u003e false"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_64d5761a","side":"PARENT","line":22,"in_reply_to":"fa1b9901_19cf472a","updated":"2015-08-19 16:42:39.000000000","message":"Done","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"edd2e1352a497c3849356f9a9f88688c22e7c973","unresolved":false,"context_lines":[{"line_number":19,"context_line":"if facterversion \u003d ENV[\u0027FACTER_GEM_VERSION\u0027]"},{"line_number":20,"context_line":"  gem \u0027facter\u0027, facterversion, :require \u003d\u003e false"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"  gem \u0027facter\u0027, :require \u003d\u003e false"},{"line_number":23,"context_line":"end"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_91f00b00","side":"PARENT","line":22,"in_reply_to":"fa1b9901_64d5761a","updated":"2015-08-19 17:21:00.000000000","message":"The reason this was removed, we want to use facter and puppet from the OS, not from a gem. The reason for this is to use the OS version, more real world testing.","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"321e5873561d14312a7076c2f76a88b04641b380","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"},{"line_number":26,"context_line":"  gem \u0027puppet\u0027, puppetversion, :require \u003d\u003e false"},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"  gem \u0027puppet\u0027, :require \u003d\u003e false"},{"line_number":29,"context_line":"end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# vim:ft\u003druby"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_d9dd4fe1","side":"PARENT","line":28,"updated":"2015-08-19 16:33:41.000000000","message":"Why was this changed?","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"edd2e1352a497c3849356f9a9f88688c22e7c973","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"},{"line_number":26,"context_line":"  gem \u0027puppet\u0027, puppetversion, :require \u003d\u003e false"},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"  gem \u0027puppet\u0027, :require \u003d\u003e false"},{"line_number":29,"context_line":"end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# vim:ft\u003druby"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_31f1ff01","side":"PARENT","line":28,"in_reply_to":"fa1b9901_84da0a4b","updated":"2015-08-19 17:21:00.000000000","message":"same comment.","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae152e761d522db55075df2c18df7ef43904c9fb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"if puppetversion \u003d ENV[\u0027PUPPET_GEM_VERSION\u0027]"},{"line_number":26,"context_line":"  gem \u0027puppet\u0027, puppetversion, :require \u003d\u003e false"},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"  gem \u0027puppet\u0027, :require \u003d\u003e false"},{"line_number":29,"context_line":"end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# vim:ft\u003druby"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa1b9901_84da0a4b","side":"PARENT","line":28,"in_reply_to":"fa1b9901_d9dd4fe1","updated":"2015-08-19 16:42:39.000000000","message":"Done","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"}],"install_modules.sh":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"321e5873561d14312a7076c2f76a88b04641b380","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile r10k puppetfile install -v"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"gem install r10k --no-ri --no-rdoc"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If zuul-cloner is there, have it install modules using zuul refs"},{"line_number":37,"context_line":"if [ -e /usr/zuul-env/bin/zuul-cloner ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_f97613d6","side":"PARENT","line":34,"updated":"2015-08-19 16:33:41.000000000","message":"This needs to be here because we run this in the acceptance tests, which might be run on a vm on a laptop rather than a node in nodepool. In that case bundle installing it won\u0027t result in it being installed on the node.","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"edd2e1352a497c3849356f9a9f88688c22e7c973","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile r10k puppetfile install -v"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"gem install r10k --no-ri --no-rdoc"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If zuul-cloner is there, have it install modules using zuul refs"},{"line_number":37,"context_line":"if [ -e /usr/zuul-env/bin/zuul-cloner ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_712e9744","side":"PARENT","line":34,"in_reply_to":"fa1b9901_84c1aa56","updated":"2015-08-19 17:21:00.000000000","message":"No, we have moved this into the gem file, since it is a dependency of the project.  We should not be randomly installing gem files.","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae152e761d522db55075df2c18df7ef43904c9fb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile r10k puppetfile install -v"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"gem install r10k --no-ri --no-rdoc"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If zuul-cloner is there, have it install modules using zuul refs"},{"line_number":37,"context_line":"if [ -e /usr/zuul-env/bin/zuul-cloner ] ; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_84c1aa56","side":"PARENT","line":34,"in_reply_to":"fa1b9901_f97613d6","updated":"2015-08-19 16:42:39.000000000","message":"Done","commit_id":"8b9db6da8629bd9dfdc70395b2cfe15a3f9d71d6"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"321e5873561d14312a7076c2f76a88b04641b380","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export SCRIPT_DIR\u003d$(pwd)"},{"line_number":4,"context_line":"export PUPPETFILE_DIR\u003d${SCRIPT_DIR}/.modules"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install_external() {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_395d6b79","line":3,"updated":"2015-08-19 16:33:41.000000000","message":"Why was this changed? pwd won\u0027t evaluate to the right thing if not run from within the repo.","commit_id":"1fa1f22851c978ded7ab430ce5411221ed58abf7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae152e761d522db55075df2c18df7ef43904c9fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export SCRIPT_DIR\u003d$(pwd)"},{"line_number":4,"context_line":"export PUPPETFILE_DIR\u003d${SCRIPT_DIR}/.modules"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install_external() {"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_c4c32256","line":3,"in_reply_to":"fa1b9901_395d6b79","updated":"2015-08-19 16:42:39.000000000","message":"Done","commit_id":"1fa1f22851c978ded7ab430ce5411221ed58abf7"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"321e5873561d14312a7076c2f76a88b04641b380","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export SCRIPT_DIR\u003d$(pwd)"},{"line_number":4,"context_line":"export PUPPETFILE_DIR\u003d${SCRIPT_DIR}/.modules"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install_external() {"},{"line_number":7,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile1 ${GEM_HOME}/bin/r10k puppetfile install -v"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_1942e768","line":4,"updated":"2015-08-19 16:33:41.000000000","message":"Is the intent for this to be run as non-root? I don\u0027t expect that to work","commit_id":"1fa1f22851c978ded7ab430ce5411221ed58abf7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ae152e761d522db55075df2c18df7ef43904c9fb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export SCRIPT_DIR\u003d$(pwd)"},{"line_number":4,"context_line":"export PUPPETFILE_DIR\u003d${SCRIPT_DIR}/.modules"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install_external() {"},{"line_number":7,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile1 ${GEM_HOME}/bin/r10k puppetfile install -v"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_24a9be90","line":4,"in_reply_to":"fa1b9901_1942e768","updated":"2015-08-19 16:42:39.000000000","message":"Done","commit_id":"1fa1f22851c978ded7ab430ce5411221ed58abf7"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"edd2e1352a497c3849356f9a9f88688c22e7c973","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -ex"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"export SCRIPT_DIR\u003d$(pwd)"},{"line_number":4,"context_line":"export PUPPETFILE_DIR\u003d${SCRIPT_DIR}/.modules"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"install_external() {"},{"line_number":7,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile1 ${GEM_HOME}/bin/r10k puppetfile install -v"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fa1b9901_d1b9a316","line":4,"in_reply_to":"fa1b9901_24a9be90","updated":"2015-08-19 17:21:00.000000000","message":"Yes, it does work. And yes, for a local user to install gems.  We don\u0027t need root to install them.","commit_id":"1fa1f22851c978ded7ab430ce5411221ed58abf7"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a63e24c9fb9d7d618d9df884c5e731045dddb69b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  PUPPETFILE\u003d${SCRIPT_DIR}/Puppetfile ${GEM_BIN_DIR}r10k puppetfile install -v"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"gem install r10k --no-ri --no-rdoc"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# If zuul-cloner is there, have it install modules using zuul refs"},{"line_number":39,"context_line":"if [ -e /usr/zuul-env/bin/zuul-cloner ] ; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"fa1b9901_89ace536","line":36,"updated":"2015-08-21 17:42:08.000000000","message":"If we\u0027re installing globally we do not need $GEM_BIN_DIR (we can stop installing globally in a later patch if we want)","commit_id":"795486ac47c1c76f09b2e1d30423ac3f94e021fd"}],"run_tests.sh":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"a63e24c9fb9d7d618d9df884c5e731045dddb69b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    echo \"Please run the following to install bundler:\""},{"line_number":44,"context_line":"    echo \"  $ gem install bundler\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"$SUDO ./install_modules.sh"}],"source_content_type":"text/x-sh","patch_set":13,"id":"fa1b9901_c9709ddf","line":46,"updated":"2015-08-21 17:42:08.000000000","message":"We don\u0027t need all this $GEM_HOME logic since r10k is installed globally for now","commit_id":"795486ac47c1c76f09b2e1d30423ac3f94e021fd"}]}