)]}'
{"fixtures/scenario-aio.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  cinder  \u003d\u003e true,"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Now we explicitly setup all our class dependencies so everything runs in a"},{"line_number":39,"context_line":"# very specific order, the basics, message queue, database, then keystone so"},{"line_number":40,"context_line":"# we know everything else will have all the bootstrapped bits around so that"},{"line_number":41,"context_line":"# they finish setup properly, finally we secure keystone and provision some"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_d57a72f0","line":38,"updated":"2016-03-23 16:14:29.000000000","message":"So basically, people using puppet4 will have to set ordering in their manifests, that way?\nThis is really odd, because we did not have to do it before.","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/aodh.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::aodh {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  rabbitmq_user { \u0027aodh\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_356c8e34","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"not sure it\u0027s needed.","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":"  class { \u0027::aodh::db::mysql\u0027:"},{"line_number":39,"context_line":"    password      \u003d\u003e \u0027aodh\u0027,"},{"line_number":40,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":"  class { \u0027::aodh::keystone::auth\u0027:"},{"line_number":43,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_d561d23a","line":40,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/cinder.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":89,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"},{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_7549e6b6","side":"PARENT","line":91,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"cf864be1bc3ef8b0787d476865b2a52ebabeb6eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  class { \u0027::cinder::db::mysql\u0027:"},{"line_number":29,"context_line":"    password      \u003d\u003e \u0027cinder\u0027,"},{"line_number":30,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":"  class { \u0027::cinder::keystone::auth\u0027:"},{"line_number":33,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_b5cd3e33","line":30,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  class { \u0027::cinder::backends\u0027:"},{"line_number":86,"context_line":"    enabled_backends \u003d\u003e [\u0027BACKEND_1\u0027],"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  cinder_type { \u0027BACKEND_1\u0027:"},{"line_number":90,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":91,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_954c7ac9","line":88,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  cinder_type { \u0027BACKEND_1\u0027:"},{"line_number":88,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":89,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"},{"line_number":90,"context_line":"    require    \u003d\u003e Class[\u0027::cinder::keystone::auth\u0027],"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_15dda342","line":90,"updated":"2016-03-28 18:39:26.000000000","message":"we should not have to fix it, but instead in puppet-cinder, like here: https://github.com/openstack/puppet-cinder/blob/master/lib/puppet/type/cinder_type.rb#L22\n\nby requiring the keystone resource (keystone user role I guess)","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f909e6e1905b876394be8e6958116ddd5a40fda7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  cinder_type { \u0027BACKEND_1\u0027:"},{"line_number":88,"context_line":"    ensure     \u003d\u003e present,"},{"line_number":89,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"},{"line_number":90,"context_line":"    require    \u003d\u003e Class[\u0027::cinder::keystone::auth\u0027],"},{"line_number":91,"context_line":"  }"},{"line_number":92,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_155ac383","line":90,"in_reply_to":"ba0121b8_15dda342","updated":"2016-03-28 18:55:11.000000000","message":"It is a failure to run after the endpoint is created, not the user.","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"}],"manifests/glance.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  class { \u0027::glance::db::mysql\u0027:"},{"line_number":44,"context_line":"    password      \u003d\u003e \u0027glance\u0027,"},{"line_number":45,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  class { \u0027::glance::keystone::auth\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_35012e39","line":45,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    rabbit_use_ssl      \u003d\u003e $::openstack_integration::config::ssl,"},{"line_number":121,"context_line":"  }"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  contain(["},{"line_number":124,"context_line":"    \u0027::glance\u0027,"},{"line_number":125,"context_line":"    \u0027::glance::api\u0027,"},{"line_number":126,"context_line":"    \u0027::glance::client\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_f5ea1673","line":123,"updated":"2016-03-23 16:14:29.000000000","message":"will this syntax work with puppet3? if not, please do not use it.","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/gnocchi.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::gnocchi {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  # gnocchi is not packaged in Ubuntu Cloud Archive"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_95faba41","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"    class { \u0027::gnocchi::db::mysql\u0027:"},{"line_number":14,"context_line":"      password      \u003d\u003e \u0027gnocchi\u0027,"},{"line_number":15,"context_line":"      allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"    class { \u0027::gnocchi::keystone::auth\u0027:"},{"line_number":18,"context_line":"      password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_d596f2ee","line":15,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/heat.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::heat {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  rabbitmq_user { \u0027heat\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_159d0a0a","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  }"},{"line_number":29,"context_line":"  class { \u0027::heat::db::mysql\u0027:"},{"line_number":30,"context_line":"    password      \u003d\u003e \u0027heat\u0027,"},{"line_number":31,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"  class { \u0027::heat::keystone::auth\u0027:"},{"line_number":34,"context_line":"    password                  \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_558b02c3","line":31,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/horizon.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::horizon {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  $vhost_params \u003d { add_listen \u003d\u003e false }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_d5bd5269","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_f5b85677","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/ironic.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::ironic {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  include ::openstack_integration::config"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_55b2e294","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"  class { \u0027::ironic::db::mysql\u0027:"},{"line_number":42,"context_line":"    password      \u003d\u003e \u0027ironic\u0027,"},{"line_number":43,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":"  class { \u0027::ironic::keystone::auth\u0027:"},{"line_number":46,"context_line":"    public_url   \u003d\u003e \"${::openstack_integration::config::proto}://127.0.0.1:6385\","}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_b569befb","line":43,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    ssl_cert \u003d\u003e $::openstack_integration::params::cert_path,"},{"line_number":44,"context_line":"    workers  \u003d\u003e 2,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class { \u0027::keystone::roles::admin\u0027:"},{"line_number":48,"context_line":"    email    \u003d\u003e \u0027test@example.tld\u0027,"},{"line_number":49,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_952d9aaa","line":46,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    email    \u003d\u003e \u0027test@example.tld\u0027,"},{"line_number":49,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  class { \u0027::keystone::endpoint\u0027:"},{"line_number":53,"context_line":"    default_domain \u003d\u003e $default_domain,"},{"line_number":54,"context_line":"    public_url     \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_b51ede6d","line":51,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    admin_url      \u003d\u003e $::openstack_integration::config::keystone_admin_uri,"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  contain(["},{"line_number":59,"context_line":"    \u0027::keystone\u0027,"},{"line_number":60,"context_line":"    \u0027::keystone::client\u0027,"},{"line_number":61,"context_line":"    \u0027::keystone::endpoint\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_b537fefd","line":58,"updated":"2016-03-23 16:14:29.000000000","message":"ditto","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  include ::keystone::disable_admin_token_auth"},{"line_number":71,"context_line":"  Keystone::Resource::Service_identity\u003c||\u003e -\u003e Class[\u0027::openstack_extras::auth_file\u0027] -\u003e Class[\u0027::keystone::disable_admin_token_auth\u0027]"},{"line_number":72,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_b5be77d2","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":133},"updated":"2016-03-28 18:39:26.000000000","message":"this should be fixed in puppet-keystone, like we did with https://github.com/openstack/puppet-keystone/commit/ec8e0452b6846cb5b571307189b46f2488b35ae8","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f909e6e1905b876394be8e6958116ddd5a40fda7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  include ::keystone::disable_admin_token_auth"},{"line_number":71,"context_line":"  Keystone::Resource::Service_identity\u003c||\u003e -\u003e Class[\u0027::openstack_extras::auth_file\u0027] -\u003e Class[\u0027::keystone::disable_admin_token_auth\u0027]"},{"line_number":72,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_5868f2ba","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":133},"in_reply_to":"ba0121b8_b5be77d2","updated":"2016-03-28 18:55:11.000000000","message":"Done","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"}],"manifests/keystone/secure.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Secure Keystone after setup"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::keystone::secure {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  include ::openstack_integration::config"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_e0009203","line":3,"updated":"2016-03-23 16:14:29.000000000","message":"why do we need a separated class?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/mysql.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::mysql {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  contain ::mysql::server"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_000ca639","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::mysql {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  contain ::mysql::server"},{"line_number":6,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_c02c6e9b","line":5,"updated":"2016-03-23 16:14:29.000000000","message":"ditto, is it pupept3 friendly?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/neutron.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::neutron {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  include ::openstack_integration::config"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_002306a8","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  class { \u0027::neutron::db::mysql\u0027:"},{"line_number":22,"context_line":"    password      \u003d\u003e \u0027neutron\u0027,"},{"line_number":23,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":24,"context_line":"  }"},{"line_number":25,"context_line":"  class { \u0027::neutron::keystone::auth\u0027:"},{"line_number":26,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_40397ed6","line":23,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/nova.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  class { \u0027::nova::db::mysql\u0027:"},{"line_number":38,"context_line":"    password      \u003d\u003e \u0027nova\u0027,"},{"line_number":39,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"  class { \u0027::nova::db::mysql_api\u0027:"},{"line_number":42,"context_line":"    password      \u003d\u003e \u0027nova\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_802f1687","line":39,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"  class { \u0027::nova::db::mysql_api\u0027:"},{"line_number":42,"context_line":"    password      \u003d\u003e \u0027nova\u0027,"},{"line_number":43,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":"  class { \u0027::nova::keystone::auth\u0027:"},{"line_number":46,"context_line":"    public_url      \u003d\u003e \"${::openstack_integration::config::proto}://127.0.0.1:8774/v2/%(tenant_id)s\","}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_e04ed26d","line":43,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/provision.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.nano\","},{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"  Keystone_user_role[\u0027admin@openstack\u0027] -\u003e Exec[\u0027manage_m1.nano_nova_flavor\u0027]"},{"line_number":16,"context_line":"  Keystone_service\u003c||\u003e -\u003e Exec[\u0027manage_m1.nano_nova_flavor\u0027]"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  exec { \u0027manage_m1.micro_nova_flavor\u0027:"},{"line_number":19,"context_line":"    path     \u003d\u003e \u0027/usr/bin:/bin:/usr/sbin:/sbin\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_e0837254","line":16,"updated":"2016-03-23 16:14:29.000000000","message":"why is it needed? our current CI works without this ordering.\nDo we miss an autorequire in puppet-keystone?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.micro\","},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":"  Keystone_user_role[\u0027admin@openstack\u0027] -\u003e Exec[\u0027manage_m1.micro_nova_flavor\u0027]"},{"line_number":25,"context_line":"  Keystone_service\u003c||\u003e -\u003e Exec[\u0027manage_m1.micro_nova_flavor\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  neutron_network { \u0027public\u0027:"},{"line_number":28,"context_line":"    tenant_name     \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_207a8a77","line":25,"updated":"2016-03-23 16:14:29.000000000","message":"ditto","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.nano\","},{"line_number":14,"context_line":"    require  \u003d\u003e ["},{"line_number":15,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":16,"context_line":"      Class[\u0027nova::keystone::auth\u0027],"},{"line_number":17,"context_line":"    ],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_d587ab10","line":16,"updated":"2016-03-28 18:39:26.000000000","message":"which resource do we actually require? keystone_user_role is not enough?","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f909e6e1905b876394be8e6958116ddd5a40fda7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.nano\","},{"line_number":14,"context_line":"    require  \u003d\u003e ["},{"line_number":15,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":16,"context_line":"      Class[\u0027nova::keystone::auth\u0027],"},{"line_number":17,"context_line":"    ],"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_353c272f","line":16,"in_reply_to":"ba0121b8_d587ab10","updated":"2016-03-28 18:55:11.000000000","message":"We really need the Keystone_endpoint resources to specifically happen.  The issue is that these end up running before the public endpoint is provisioned.","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.micro\","},{"line_number":25,"context_line":"    require  \u003d\u003e ["},{"line_number":26,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":27,"context_line":"      Class[\u0027nova::keystone::auth\u0027],"},{"line_number":28,"context_line":"    ],"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_b58cb736","line":27,"updated":"2016-03-28 18:39:26.000000000","message":"which resource do we actually require? keystone_user_role is not enough?","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f909e6e1905b876394be8e6958116ddd5a40fda7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    unless   \u003d\u003e \"nova ${os_auth_options} flavor-list | grep m1.micro\","},{"line_number":25,"context_line":"    require  \u003d\u003e ["},{"line_number":26,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":27,"context_line":"      Class[\u0027nova::keystone::auth\u0027],"},{"line_number":28,"context_line":"    ],"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_d5116bb1","line":27,"in_reply_to":"ba0121b8_b58cb736","updated":"2016-03-28 18:55:11.000000000","message":"We really need the Keystone_endpoint resources to specifically happen.  The issue is that these end up running before the public endpoint is provisioned.","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    router_external \u003d\u003e true,"},{"line_number":34,"context_line":"    require         \u003d\u003e ["},{"line_number":35,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":36,"context_line":"      Class[\u0027neutron::keystone::auth\u0027],"},{"line_number":37,"context_line":"    ],"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_35926758","line":36,"updated":"2016-03-28 18:39:26.000000000","message":"which resource do we actually require? keystone_user_role is not enough?","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f909e6e1905b876394be8e6958116ddd5a40fda7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    router_external \u003d\u003e true,"},{"line_number":34,"context_line":"    require         \u003d\u003e ["},{"line_number":35,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":36,"context_line":"      Class[\u0027neutron::keystone::auth\u0027],"},{"line_number":37,"context_line":"    ],"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_f510efaa","line":36,"in_reply_to":"ba0121b8_35926758","updated":"2016-03-28 18:55:11.000000000","message":"We really need the Keystone_endpoint resources to specifically happen.  The issue is that these end up running before the public endpoint is provisioned.","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"767a348d21165dadfa82d589590fd0d571ea2468","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":83,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":84,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":85,"context_line":"    require          \u003d\u003e ["},{"line_number":86,"context_line":"      Keystone_user_role[\u0027admin@openstack\u0027],"},{"line_number":87,"context_line":"      Class[\u0027glance::keystone::auth\u0027],"},{"line_number":88,"context_line":"    ],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_15abe38a","line":85,"updated":"2016-03-28 18:39:26.000000000","message":"this is terrible, we should not have require on this provider, which is suppose to work out of the box.","commit_id":"ccc88054f84eb698f8a992d83ddc1fd57f7f8650"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e1f9d29c7f12c5ea7830edf34f75a38c65b13a1e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":74,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":75,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":76,"context_line":"    require          \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"  glance_image { \u0027cirros_alt\u0027:"},{"line_number":79,"context_line":"    ensure           \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"ba0121b8_b529c539","line":76,"updated":"2016-03-31 02:40:42.000000000","message":"it is something, imho, that we need to fix in Glance_image type, with an autorequire on keystone resources.","commit_id":"b96b0def8df68c0fded0eba094c2c7d8b563051d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56fd8fb5a2ea92bb86b39737780501de33d166b9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    router_external           \u003d\u003e true,"},{"line_number":28,"context_line":"    provider_physical_network \u003d\u003e \u0027external\u0027,"},{"line_number":29,"context_line":"    provider_network_type     \u003d\u003e \u0027flat\u0027,"},{"line_number":30,"context_line":"    require                   \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  neutron_subnet { \u0027public-subnet\u0027:"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_6dbcfd6c","line":30,"updated":"2016-04-04 19:24:16.000000000","message":"This is not an acceptable requirement, it needs to be fixd in the provider itself.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0755da580d5ddce446c562b2e99f5104bec8b398","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    router_external           \u003d\u003e true,"},{"line_number":28,"context_line":"    provider_physical_network \u003d\u003e \u0027external\u0027,"},{"line_number":29,"context_line":"    provider_network_type     \u003d\u003e \u0027flat\u0027,"},{"line_number":30,"context_line":"    require                   \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  neutron_subnet { \u0027public-subnet\u0027:"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_68b6abdd","line":30,"in_reply_to":"9a061dce_6dbcfd6c","updated":"2016-04-04 19:36:24.000000000","message":"well, I guess we can keep it, since we had this kind of orchestration before.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56fd8fb5a2ea92bb86b39737780501de33d166b9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":50,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":51,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":52,"context_line":"    require          \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"  glance_image { \u0027cirros_alt\u0027:"},{"line_number":55,"context_line":"    ensure           \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_8dbb5172","line":52,"updated":"2016-04-04 19:24:16.000000000","message":"This is not an acceptable requirement, it needs to be fixd in the provider itself.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0755da580d5ddce446c562b2e99f5104bec8b398","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":50,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":51,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":52,"context_line":"    require          \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"  glance_image { \u0027cirros_alt\u0027:"},{"line_number":55,"context_line":"    ensure           \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_e8cabb4e","line":52,"in_reply_to":"9a061dce_8dbb5172","updated":"2016-04-04 19:36:24.000000000","message":"well, I guess we can keep it, since we had this kind of orchestration before.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56fd8fb5a2ea92bb86b39737780501de33d166b9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":61,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":62,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":63,"context_line":"    require          \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_edb00d8e","line":63,"updated":"2016-04-04 19:24:16.000000000","message":"This is not an acceptable requirement, it needs to be fixd in the provider itself.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0755da580d5ddce446c562b2e99f5104bec8b398","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    # and 2/ if running in the gate, use /home/jenkins/cache/files/ cirros image."},{"line_number":61,"context_line":"    # source        \u003d\u003e \u0027/home/jenkins/cache/files/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":62,"context_line":"    source           \u003d\u003e \u0027http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img\u0027,"},{"line_number":63,"context_line":"    require          \u003d\u003e Class[\u0027::keystone::roles::admin\u0027],"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":25,"id":"9a061dce_08c28f33","line":63,"in_reply_to":"9a061dce_edb00d8e","updated":"2016-04-04 19:36:24.000000000","message":"same, I guess we can keep it, since we had this kind of orchestration before.","commit_id":"7f2ebbf93e729e4dace86eb09b6ce6cac1c7aeba"}],"manifests/rabbitmq.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    provider \u003d\u003e \u0027rabbitmqctl\u0027,"},{"line_number":50,"context_line":"    require  \u003d\u003e Class[\u0027::rabbitmq\u0027],"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_808b9667","side":"PARENT","line":52,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"cf864be1bc3ef8b0787d476865b2a52ebabeb6eb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::rabbitmq {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  include ::openstack_integration::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_4095fe84","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  contain \u0027::rabbitmq\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  rabbitmq_vhost { \u0027/\u0027:"},{"line_number":54,"context_line":"    provider \u003d\u003e \u0027rabbitmqctl\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_a08e9a76","line":51,"updated":"2016-03-23 16:14:29.000000000","message":"ditto","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/sahara.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::sahara {"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_c0ef4e1c","line":1,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  class { \u0027::sahara::db::mysql\u0027:"},{"line_number":20,"context_line":"    password      \u003d\u003e \u0027sahara\u0027,"},{"line_number":21,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":"  class { \u0027::sahara::keystone::auth\u0027:"},{"line_number":24,"context_line":"    password     \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_00f666f8","line":21,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}],"manifests/trove.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"##"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstack_integration::trove {"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  rabbitmq_user { \u0027trove\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_80e2762d","line":2,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"041caff0bed9ece4196a34b805c1d6a02b6b82ca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":"  class { \u0027::trove::db::mysql\u0027:"},{"line_number":27,"context_line":"    password      \u003d\u003e \u0027trove\u0027,"},{"line_number":28,"context_line":"    allowed_hosts \u003d\u003e [\u0027localhost\u0027],"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":"  class { \u0027::trove::keystone::auth\u0027:"},{"line_number":31,"context_line":"    password \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_20c8caa7","line":28,"updated":"2016-03-23 16:14:29.000000000","message":"do we really need this change?","commit_id":"28c33a472289cb9798e6fdcddcc3142e44adcf7a"}]}