)]}'
{"Puppetfile":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b334eaefde0c0a7179ab4b589cd2b3fe1f72b0ee","unresolved":false,"context_lines":[{"line_number":216,"context_line":"#  :git \u003d\u003e \u0027https://github.com/theforeman/puppet-dns\u0027,"},{"line_number":217,"context_line":"#  :ref \u003d\u003e \u00273.4.0\u0027"},{"line_number":218,"context_line":"   :git \u003d\u003e \u0027https://github.com/dmsimard/puppet-dns\u0027,"},{"line_number":219,"context_line":"   :ref \u003d\u003e \u0027454b53eb3e77dabdcdd73cb52bb12ded536337bb\u0027"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"mod \u0027corosync\u0027,"},{"line_number":222,"context_line":"  :git \u003d\u003e \u0027https://github.com/voxpupuli/puppet-corosync\u0027,"}],"source_content_type":"application/octet-stream","patch_set":61,"id":"5a8bc5a2_6e88adc7","line":219,"updated":"2016-09-28 01:36:37.000000000","message":"our bot will try to use the tag every night, not sure we can do that. I would suggest to wait for your PR merged upstream.","commit_id":"e27848a2ef4498e92f048d66671605be929a20ef"}],"manifests/designate.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"ba45cf15d146be4d033e0877abceab698bf7ec28","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    rndc_key_file    \u003d\u003e $::dns::params::rndckeypath,"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # TODO: Implement pools.yaml management in puppet-designate"},{"line_number":92,"context_line":"  file { \u0027/etc/designate/pools.yaml\u0027:"},{"line_number":93,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":94,"context_line":"    content \u003d\u003e template(\"${module_name}/pools.yaml.erb\"),"}],"source_content_type":"text/x-puppet","patch_set":45,"id":"7a8ec9b2_b09ec460","line":91,"updated":"2016-09-18 13:56:34.000000000","message":"@Emilien, can you remove -W ? It looks like this might be a legit failure for some reason, maybe around the scheduling here: http://logs.openstack.org/60/337860/45/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/9c730a1/console.html#_2016-09-18_02_16_58_399833\n\nI\u0027ll add a logoutput to try and troubleshoot.","commit_id":"e43aca2f957634324f1868857e03477cadb72aab"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"808854dfa8a578ce8fe20b37cd4828fce9ad78b0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":100,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":101,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":102,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":103,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":104,"context_line":"    require     \u003d\u003e Service[\u0027designate-central\u0027]"},{"line_number":105,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":46,"id":"7a8ec9b2_6dda8f18","line":102,"range":{"start_line":102,"start_character":19,"end_line":102,"end_character":23},"updated":"2016-09-19 10:13:52.000000000","message":"strange error here: http://logs.openstack.org/60/337860/46/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/a296409/console.html#_2016-09-18_15_29_59_899140\n\nBtw, do we need truer here? May be on_failure?","commit_id":"bd1616c95a1e0747ebf7b4769fca697d91e26234"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f609c6167b6c6aa969e914f6601430b4ca7db2cf","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":100,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":101,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":102,"context_line":"    logoutput   \u003d\u003e true,"},{"line_number":103,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":104,"context_line":"    require     \u003d\u003e Service[\u0027designate-central\u0027]"},{"line_number":105,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":46,"id":"7a8ec9b2_324a9828","line":102,"range":{"start_line":102,"start_character":19,"end_line":102,"end_character":23},"in_reply_to":"7a8ec9b2_6dda8f18","updated":"2016-09-19 13:24:13.000000000","message":"There\u0027s a breaking whitespace character before the \"true\". That happens, sometimes, with my keyboard layout.\n\nI might switch to on_failure, yes, but the problem seems to be that this command was silently failing - I added logoutput to try and diagnose the problem.","commit_id":"bd1616c95a1e0747ebf7b4769fca697d91e26234"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"6025b7c6d7f7f7aa5f4832537cd9fe8bdb94417e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    rndc_key_file    \u003d\u003e $::dns::params::rndckeypath,"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # TODO: Implement pools.yaml management in puppet-designate"},{"line_number":92,"context_line":"  file { \u0027/etc/designate/pools.yaml\u0027:"},{"line_number":93,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":94,"context_line":"    content \u003d\u003e template(\"${module_name}/pools.yaml.erb\"),"},{"line_number":95,"context_line":"    require \u003d\u003e Package[\u0027designate-common\u0027],"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  # Validate that designate-central is ready for pool update"},{"line_number":99,"context_line":"  $command \u003d \"openstack --os-auth-url ${::openstack_integration::config::keystone_auth_uri} \\"},{"line_number":100,"context_line":"--os-project-name services --os-username designate --os-password a_big_secret zone list\""},{"line_number":101,"context_line":"  openstacklib::service_validation { \u0027designate-central\u0027:"},{"line_number":102,"context_line":"    command   \u003d\u003e $command,"},{"line_number":103,"context_line":"    timeout   \u003d\u003e \u002715\u0027,"},{"line_number":104,"context_line":"    require   \u003d\u003e Anchor[\u0027designate::service::end\u0027],"},{"line_number":105,"context_line":"    subscribe \u003d\u003e Service[\u0027designate-central\u0027]"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  exec { \u0027Update designate pools\u0027:"},{"line_number":109,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":110,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":111,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":112,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":113,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":114,"context_line":"    require     \u003d\u003e Openstacklib::Service_validation[\u0027designate-central\u0027]"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":57,"id":"5a8bc5a2_407f5e14","line":115,"range":{"start_line":91,"start_character":0,"end_line":115,"end_character":3},"updated":"2016-09-27 14:23:59.000000000","message":"I need to figure out how to chain those properly to work and be idempotent.. but I can\u0027t seem to be able to ?\n1) Install pools.yaml only once designate-common is installed (this is fine)\n2) Update designate pools only once designate-central is not only running but available\n\nThe issue I\u0027m seeing with the current patchset is that the service_validation is not idempotent -- or, well, at least, it\u0027ll still run on the second puppet run so the tests are failing due to lack of perceived idempotency.","commit_id":"ed45d4e7a588532e69784c8e9827a425a2b6fb79"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3ddffcea74645615e3608332e4108465320d7a90","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    rndc_key_file    \u003d\u003e $::dns::params::rndckeypath,"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # TODO: Implement pools.yaml management in puppet-designate"},{"line_number":92,"context_line":"  file { \u0027/etc/designate/pools.yaml\u0027:"},{"line_number":93,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":94,"context_line":"    content \u003d\u003e template(\"${module_name}/pools.yaml.erb\"),"},{"line_number":95,"context_line":"    require \u003d\u003e Package[\u0027designate-common\u0027],"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  # Validate that designate-central is ready for pool update"},{"line_number":99,"context_line":"  $command \u003d \"openstack --os-auth-url ${::openstack_integration::config::keystone_auth_uri} \\"},{"line_number":100,"context_line":"--os-project-name services --os-username designate --os-password a_big_secret zone list\""},{"line_number":101,"context_line":"  openstacklib::service_validation { \u0027designate-central\u0027:"},{"line_number":102,"context_line":"    command   \u003d\u003e $command,"},{"line_number":103,"context_line":"    timeout   \u003d\u003e \u002715\u0027,"},{"line_number":104,"context_line":"    require   \u003d\u003e Anchor[\u0027designate::service::end\u0027],"},{"line_number":105,"context_line":"    subscribe \u003d\u003e Service[\u0027designate-central\u0027]"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  exec { \u0027Update designate pools\u0027:"},{"line_number":109,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":110,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":111,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":112,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":113,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":114,"context_line":"    require     \u003d\u003e Openstacklib::Service_validation[\u0027designate-central\u0027]"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":57,"id":"5a8bc5a2_80fb2646","line":115,"range":{"start_line":91,"start_character":0,"end_line":115,"end_character":3},"in_reply_to":"5a8bc5a2_407f5e14","updated":"2016-09-27 14:27:19.000000000","message":"So one way is to make the service_validation accept refresh only as well so that it only occurs when we update the pool.yaml.  Then have it notify the update.","commit_id":"ed45d4e7a588532e69784c8e9827a425a2b6fb79"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"87178e6b9ec3608a13d20c3e4524d5baf3505bb6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":110,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":111,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":112,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":113,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":114,"context_line":"    require     \u003d\u003e Openstacklib::Service_validation[\u0027designate-central\u0027]"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":61,"id":"5a8bc5a2_ab546821","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":32},"updated":"2016-09-28 00:23:52.000000000","message":"do we still need this?","commit_id":"e27848a2ef4498e92f048d66671605be929a20ef"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"3ce352bb0be47062967fff163b53070a8e31b159","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    command     \u003d\u003e \u0027designate-manage pool update --file /etc/designate/pools.yaml\u0027,"},{"line_number":110,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":111,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":112,"context_line":"    logoutput   \u003d\u003e \u0027on_failure\u0027,"},{"line_number":113,"context_line":"    subscribe   \u003d\u003e File[\u0027/etc/designate/pools.yaml\u0027],"},{"line_number":114,"context_line":"    require     \u003d\u003e Openstacklib::Service_validation[\u0027designate-central\u0027]"},{"line_number":115,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":61,"id":"5a8bc5a2_2b169855","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":32},"in_reply_to":"5a8bc5a2_ab546821","updated":"2016-09-28 00:27:05.000000000","message":"Yeah I think it\u0027s fair to /always/ log the output of a command on an exec if it fails so the failure is not as opaque.","commit_id":"e27848a2ef4498e92f048d66671605be929a20ef"}],"manifests/tempest.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0057fcb7f06ca7f0c6b08cb0d557db0afe672ce5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*designate*]"},{"line_number":16,"context_line":"#   (optional) Define if Designate needs to be tested."},{"line_number":17,"context_line":"#   Default to false.#"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*glance*]"},{"line_number":20,"context_line":"#   (optional) Define if Glance needs to be tested."}],"source_content_type":"text/x-puppet","patch_set":45,"id":"7a8ec9b2_dbcffe53","line":17,"updated":"2016-09-17 20:30:58.000000000","message":"remove useless #","commit_id":"e43aca2f957634324f1868857e03477cadb72aab"}]}