)]}'
{"Puppetfile":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"853c6640f5b6cb8bc9d1aae881341a6710466b8b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"mod \u0027ceph\u0027,"},{"line_number":17,"context_line":"  :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-ceph\u0027,"},{"line_number":18,"context_line":"  :ref \u003d\u003e \u0027310a70ed27e34af8714564b279c6644e3bfbb9e4\u0027"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"mod \u0027cinder\u0027,"},{"line_number":21,"context_line":"  :git \u003d\u003e \u0027https://git.openstack.org/openstack/puppet-cinder\u0027,"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"dada55a8_e1555c50","line":18,"updated":"2016-07-19 20:19:03.000000000","message":"?","commit_id":"27fc8d3f695a75f3bfb408e4a8902437ceb8e9a3"}],"README.md":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"|     -      | scenario001 | scenario002 | scenario003 | scenario004 | scenario-aio |"},{"line_number":35,"context_line":"|:----------:|:-----------:|:-----------:|:-----------:|:------------:--------------|"},{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_4abbed0e","line":36,"range":{"start_line":36,"start_character":57,"end_line":36,"end_character":67},"updated":"2016-07-08 17:08:46.000000000","message":"Should mention if there\u0027s SSL or not","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"|     -      | scenario001 | scenario002 | scenario003 | scenario004 | scenario-aio |"},{"line_number":35,"context_line":"|:----------:|:-----------:|:-----------:|:-----------:|:------------:--------------|"},{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_1b41353a","line":36,"range":{"start_line":36,"start_character":57,"end_line":36,"end_character":67},"in_reply_to":"1aa78d24_4abbed0e","updated":"2016-07-08 18:04:38.000000000","message":"I will fall inline with the first three and say \u0027yes\u0027","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":34,"context_line":"|     -      | scenario001 | scenario002 | scenario003 | scenario004 | scenario-aio |"},{"line_number":35,"context_line":"|:----------:|:-----------:|:-----------:|:-----------:|:------------:--------------|"},{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_0ac1e580","line":37,"range":{"start_line":37,"start_character":57,"end_line":37,"end_character":67},"updated":"2016-07-08 17:08:46.000000000","message":"Should mention if there\u0027s ipv6 or not","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"|     -      | scenario001 | scenario002 | scenario003 | scenario004 | scenario-aio |"},{"line_number":35,"context_line":"|:----------:|:-----------:|:-----------:|:-----------:|:------------:--------------|"},{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_db6dedcd","line":37,"range":{"start_line":37,"start_character":57,"end_line":37,"end_character":67},"in_reply_to":"1aa78d24_0ac1e580","updated":"2016-07-08 18:04:38.000000000","message":"Done","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_6ae7c940","line":39,"range":{"start_line":39,"start_character":57,"end_line":39,"end_character":68},"updated":"2016-07-08 17:08:46.000000000","message":"Should mention uuid or fernet here (preferably fernet since it\u0027s going to be the default driver)","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"| ssl        |     yes     |      yes    |      yes    |             |     no       |"},{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_bb80e147","line":39,"range":{"start_line":39,"start_character":57,"end_line":39,"end_character":68},"in_reply_to":"1aa78d24_6ae7c940","updated":"2016-07-08 18:04:38.000000000","message":"I don\u0027t know yet but based on your comment I will say it will be fernet.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_6a1a2919","line":40,"range":{"start_line":40,"start_character":59,"end_line":40,"end_character":66},"updated":"2016-07-08 17:08:46.000000000","message":"I don\u0027t see swift included in scenario004. Should this be rbd or rgw ? I must admit I never tried glance over rgw, only rbd.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"| ipv6       |   centos7   |    centos7  |    centos7  |             |     no       |"},{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_fbc0a97e","line":40,"range":{"start_line":40,"start_character":59,"end_line":40,"end_character":66},"in_reply_to":"1aa78d24_6a1a2919","updated":"2016-07-08 18:04:38.000000000","message":"The goal is to test services which can backend with swift as provided by RGW.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_6a5509c5","line":41,"range":{"start_line":41,"start_character":58,"end_line":41,"end_character":67},"updated":"2016-07-08 17:08:46.000000000","message":"I guess there should be a X here or something","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_bb458118","line":41,"range":{"start_line":41,"start_character":58,"end_line":41,"end_character":67},"in_reply_to":"1aa78d24_6a5509c5","updated":"2016-07-08 18:04:38.000000000","message":"I will make it rbd to be consistent with the 001.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_ea5739c8","line":42,"range":{"start_line":42,"start_character":58,"end_line":42,"end_character":67},"updated":"2016-07-08 17:08:46.000000000","message":"Which neutron driver is used ?","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |             |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |     swift   |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |             |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |             |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_7b0959dd","line":42,"range":{"start_line":42,"start_character":58,"end_line":42,"end_character":67},"in_reply_to":"1aa78d24_ea5739c8","updated":"2016-07-08 18:04:38.000000000","message":"I will do ovs unless there is a reason to do otherwise.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"c87f49015758be30360a9e6d3020fc0c10238b90","unresolved":false,"context_lines":[{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"},{"line_number":46,"context_line":"| aodh       |      X      |             |             |             |              |"},{"line_number":47,"context_line":"| gnocchi    |     rbd     |             |             |     swift   |              |"},{"line_number":48,"context_line":"| heat       |             |             |       X     |             |              |"},{"line_number":49,"context_line":"| swift      |             |       X     |             |             |              |"},{"line_number":50,"context_line":"| sahara     |             |             |       X     |             |              |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_6af189cd","line":47,"range":{"start_line":47,"start_character":60,"end_line":47,"end_character":67},"updated":"2016-07-08 17:08:46.000000000","message":"Same comment as glance re: swift vs rgw vs rbd","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"8a748f0cbbfc0808114104f59cfc3d546ec65f3a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"},{"line_number":46,"context_line":"| aodh       |      X      |             |             |             |              |"},{"line_number":47,"context_line":"| gnocchi    |     rbd     |             |             |     swift   |              |"},{"line_number":48,"context_line":"| heat       |             |             |       X     |             |              |"},{"line_number":49,"context_line":"| swift      |             |       X     |             |             |              |"},{"line_number":50,"context_line":"| sahara     |             |             |       X     |             |              |"}],"source_content_type":"text/x-gfm","patch_set":2,"id":"1aa78d24_fbe38903","line":47,"range":{"start_line":47,"start_character":60,"end_line":47,"end_character":67},"in_reply_to":"1aa78d24_6af189cd","updated":"2016-07-08 18:04:38.000000000","message":"see glance reply.","commit_id":"79915509d7a7304241b95b89e857a16d8bf88573"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"44e25a0f780841ea7aade69211736b67618c8b03","unresolved":false,"context_lines":[{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |   fernet    |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |    swift    |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |     rbd     |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |     ovs     |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"},{"line_number":46,"context_line":"| aodh       |      X      |             |             |             |              |"},{"line_number":47,"context_line":"| gnocchi    |     rbd     |             |             |     swift   |              |"}],"source_content_type":"text/x-gfm","patch_set":30,"id":"fa7ab95a_42a03291","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":85},"updated":"2016-08-25 19:57:00.000000000","message":"it looks like you removed theses, so we should probably update this","commit_id":"e575bc756da590e8bf223c589551a93b4a83fc9e"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f3413a64d7346d088bfa49be7fd73d68f2da5e48","unresolved":false,"context_lines":[{"line_number":38,"context_line":"| keystone   |      X      |       X     |       X     |      X      |      X       |"},{"line_number":39,"context_line":"| tokens     |    uuid     |     uuid    |    fernet   |   fernet    |    uuid      |"},{"line_number":40,"context_line":"| glance     |     rbd     |     swift   |     file    |    swift    |    file      |"},{"line_number":41,"context_line":"| nova       |     rbd     |       X     |       X     |     rbd     |      X       |"},{"line_number":42,"context_line":"| neutron    |     ovs     |      ovs    | linuxbridge |     ovs     |     ovs      |"},{"line_number":43,"context_line":"| lbaas      |     v2      |      v1     |     v1      |             |     v1       |"},{"line_number":44,"context_line":"| cinder     |     rbd     |     iscsi   |             |             |   iscsi      |"},{"line_number":45,"context_line":"| ceilometer |      X      |             |             |             |              |"},{"line_number":46,"context_line":"| aodh       |      X      |             |             |             |              |"},{"line_number":47,"context_line":"| gnocchi    |     rbd     |             |             |     swift   |              |"}],"source_content_type":"text/x-gfm","patch_set":30,"id":"fa7ab95a_6b1a7119","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":85},"in_reply_to":"fa7ab95a_42a03291","updated":"2016-08-25 20:52:04.000000000","message":"I dropped lbass and cinder from 004 because I am trying to test \u0027swiftable\u0027 services. These two are not impacted by the RGW/Keystone V3 patch I am writing the test for. Glance is the first target then gnocchi. Lbass/cinder can be re-added at the end for completeness.","commit_id":"e575bc756da590e8bf223c589551a93b4a83fc9e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eacdc5af7631fa4d300004114578d0371184fe58","unresolved":false,"context_lines":[{"line_number":59,"context_line":"| mongodb    |             |       X     |             |             |              |"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"swift support in Radosgw is http only. The patch will be updated when documenation "},{"line_number":62,"context_line":"and packages are ready"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"When the Jenkins slave is created, the *run_tests.sh* script will executed."},{"line_number":65,"context_line":"This script will execute *install_modules.sh* that prepare /etc/puppet/modules"}],"source_content_type":"text/x-gfm","patch_set":33,"id":"fa7ab95a_74750630","line":62,"updated":"2016-08-30 17:48:57.000000000","message":"just put swift+rgw in the tab and remove this comment.","commit_id":"b1ad4d2b932d75b42661a1d82ecac7dcfa664d7e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cc790bdc82bd9a482dc5879d7dbcc50413ba511d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"| designate  |             |             |     bind    |              |"},{"line_number":48,"context_line":"| backup     |             |    swift    |             |              |"},{"line_number":49,"context_line":"| gnocchi    |     rbd     |             |             |              |"},{"line_number":50,"context_line":"| ec2api     |             |       X     |             |              |"},{"line_number":51,"context_line":"| heat       |             |             |       X     |              |"},{"line_number":52,"context_line":"| swift      |             |       X     |             |              |"},{"line_number":53,"context_line":"| sahara     |             |             |       X     |              |"}],"source_content_type":"text/x-gfm","patch_set":65,"id":"ba5da102_3c6e9d95","side":"PARENT","line":50,"updated":"2016-10-31 11:57:27.000000000","message":"sounds like a wrong rebase.","commit_id":"34bc917b98068250250f9280d03204bb5e403841"}],"fixtures/scenario004.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"853c6640f5b6cb8bc9d1aae881341a6710466b8b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"include ::openstack_integration::rabbitmq"},{"line_number":27,"context_line":"include ::openstack_integration::mysql"},{"line_number":28,"context_line":"class{ \u0027::openstack_integration::keystone\u0027:"},{"line_number":29,"context_line":"  enable_pki_setup \u003d\u003e true,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":"include ::openstack_integration::glance"},{"line_number":32,"context_line":"include ::openstack_integration::neutron"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"dada55a8_e1039c40","line":29,"updated":"2016-07-19 20:19:03.000000000","message":"why do you need PKI? I thought it was deprecated in Keystone.","commit_id":"27fc8d3f695a75f3bfb408e4a8902437ceb8e9a3"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2c2fa6efd65fe045a8e46bdda0b6028434e31d63","unresolved":false,"context_lines":[{"line_number":44,"context_line":"include ::openstack_integration::mysql"},{"line_number":45,"context_line":"include ::openstack_integration::keystone"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class{ \u0027::openstack_integration::ceph\u0027:"},{"line_number":48,"context_line":"  deploy_rgw \u003d\u003e true,"},{"line_number":49,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"bacf61ea_ad33f060","line":47,"range":{"start_line":47,"start_character":3,"end_line":47,"end_character":7},"updated":"2016-08-06 01:24:34.000000000","message":"Missing space","commit_id":"2964ad1a491cbc10ba2a1b82640fe350a2727b7b"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"e44a5d494e1d3caedac0dfa55792f5ff5d4a2fe9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"include ::openstack_integration::mysql"},{"line_number":38,"context_line":"include ::openstack_integration::keystone"},{"line_number":39,"context_line":"class { \u0027::openstack_integration::glance\u0027:"},{"line_number":40,"context_line":"  backend \u003d\u003e \u0027swift\u0027,"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":"include ::openstack_integration::neutron"},{"line_number":43,"context_line":"class { \u0027::openstack_integration::nova\u0027:"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"1a95cdbc_799bd572","line":40,"range":{"start_line":40,"start_character":14,"end_line":40,"end_character":19},"updated":"2016-10-06 00:29:36.000000000","message":"you don\u0027t need to setup swift?","commit_id":"e8bd70d71e625182f51ea9b7db65724a1d92af2a"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"696217ff180ec6c3560bf7cc2b334c257532ef8c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"include ::openstack_integration::mysql"},{"line_number":38,"context_line":"include ::openstack_integration::keystone"},{"line_number":39,"context_line":"class { \u0027::openstack_integration::glance\u0027:"},{"line_number":40,"context_line":"  backend \u003d\u003e \u0027swift\u0027,"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":"include ::openstack_integration::neutron"},{"line_number":43,"context_line":"class { \u0027::openstack_integration::nova\u0027:"}],"source_content_type":"text/x-puppet","patch_set":49,"id":"1a95cdbc_399f8d51","line":40,"range":{"start_line":40,"start_character":14,"end_line":40,"end_character":19},"in_reply_to":"1a95cdbc_799bd572","updated":"2016-10-06 00:34:36.000000000","message":"Ceph is providing the swift service via RGW. Setting deploy_rgw to true below has p-o-i::ceph configure the Ceph RGW service and integrate it with Keystone.","commit_id":"e8bd70d71e625182f51ea9b7db65724a1d92af2a"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"1ec15689a50e210a966ee5dcfae8ad84b9b68736","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  #swift      \u003d\u003e true,"},{"line_number":70,"context_line":"  aodh       \u003d\u003e true,"},{"line_number":71,"context_line":"  gnocchi    \u003d\u003e $gnocchi_enabled,"},{"line_number":72,"context_line":"  cinder     \u003d\u003e true,"},{"line_number":73,"context_line":"  ceilometer \u003d\u003e true,"},{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":58,"id":"fa6399be_4b56502a","line":72,"updated":"2016-10-11 21:28:50.000000000","message":"This shouldn\u0027t be true, it\u0027s not deployed. This is causing the endpoint not found errors here:\n\n    http://logs.openstack.org/06/339106/58/experimental/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7-nv/d8e464d/console.html#_2016-10-11_04_49_50_118279","commit_id":"d61da0690012e9db64d02e4e00c4857309b9dacb"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2a91ecdfdb8fba6d9807e652e1035bda665630da","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# might not start."},{"line_number":59,"context_line":"# TODO(Xarses): When we use ceph-rgw this way, we should put the swift"},{"line_number":60,"context_line":"# tag on the radosgw service"},{"line_number":61,"context_line":"Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e -\u003e Service \u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"include ::openstack_integration::provision"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":59,"id":"fa6399be_5524c2c3","line":61,"updated":"2016-10-13 22:00:28.000000000","message":"could we add this thing in puppet-ceph directly? so we make it transparent for our users. Maybe use \u0027openstack\u0027 tag?","commit_id":"56ed6fd17ebc3582e4990bc0bb94c179f4416e7f"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"5a02e5aec382eee3198ac85977f3e2c015f27753","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# might not start."},{"line_number":59,"context_line":"# TODO(Xarses): When we use ceph-rgw this way, we should put the swift"},{"line_number":60,"context_line":"# tag on the radosgw service"},{"line_number":61,"context_line":"Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e -\u003e Service \u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"include ::openstack_integration::provision"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":59,"id":"fa6399be_104175a9","line":61,"in_reply_to":"fa6399be_3b981fc0","updated":"2016-10-14 00:12:03.000000000","message":"1) Could this go into p-o-i::ceph?\n2) (noob question) If this goes into puppet-ceph, can the \"Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e -\u003e Service \u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e\" occur without puppet-glance first?","commit_id":"56ed6fd17ebc3582e4990bc0bb94c179f4416e7f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"81fe235475d39d963ce0a6f28bf4aeee1e32664d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# might not start."},{"line_number":59,"context_line":"# TODO(Xarses): When we use ceph-rgw this way, we should put the swift"},{"line_number":60,"context_line":"# tag on the radosgw service"},{"line_number":61,"context_line":"Service\u003c| tag \u003d\u003d \u0027ceph-radosgw\u0027 |\u003e -\u003e Service \u003c| tag \u003d\u003d \u0027glance-service\u0027 |\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"include ::openstack_integration::provision"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":59,"id":"fa6399be_3b981fc0","line":61,"in_reply_to":"fa6399be_5524c2c3","updated":"2016-10-13 22:39:59.000000000","message":"I want to do exactly that, hence the TODO","commit_id":"56ed6fd17ebc3582e4990bc0bb94c179f4416e7f"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"3513137ccbfd8614ee9cd99c39c09fce87e466ae","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"include ::openstack_integration::provision"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Don\u0027t test swift, radosgw won\u0027t pass the current tests"},{"line_number":53,"context_line":"# Glance, nova, neutron are true by default."},{"line_number":54,"context_line":"include ::openstack_integration::tempest"}],"source_content_type":"text/x-puppet","patch_set":69,"id":"ba5da102_e2b873ca","line":52,"updated":"2016-11-03 17:09:06.000000000","message":"Is there a minimal subset/regex we could use ? I can see rgw not passing all the normal swift tests but it should probably pass a few ?","commit_id":"4f9710d9ca34f5213c9b94b87c4018a7dca27ce3"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"d79d42ea8f52f1ed8b10f31bb88523336daed7d2","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"include ::openstack_integration::provision"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Don\u0027t test swift, radosgw won\u0027t pass the current tests"},{"line_number":53,"context_line":"# Glance, nova, neutron are true by default."},{"line_number":54,"context_line":"include ::openstack_integration::tempest"}],"source_content_type":"text/x-puppet","patch_set":69,"id":"ba5da102_fe580b8c","line":52,"in_reply_to":"ba5da102_e2b873ca","updated":"2016-11-03 18:29:26.000000000","message":"yes, there is a subset that pass, but I wasn\u0027t able to find a criteria that would enable only the smoke tests and disable the failing classes, or to say that specific tests are ok to fail. Tempest doesn\u0027t allow for both white-list and black-list and using a negative regex in the white-list didn\u0027t yield results for me.","commit_id":"4f9710d9ca34f5213c9b94b87c4018a7dca27ce3"}],"manifests/ceph.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5165f62c150519bb0cf61131033dfd3ba569ace9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    #These could be always set in the aboce call to ceph::profile::params"},{"line_number":55,"context_line":"    frontend_type             \u003d\u003e \u0027civetweb\u0027,"},{"line_number":56,"context_line":"    rgw_frontends             \u003d\u003e \u0027civetweb port\u003d7480\u0027,"},{"line_number":57,"context_line":"    rgw_user                  \u003d\u003e \u0027root\u0027,"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  $ceph_pools \u003d [\u0027glance\u0027, \u0027nova\u0027, \u0027cinder\u0027, \u0027gnocchi\u0027]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1aa78d24_d17b96bc","line":57,"updated":"2016-07-12 13:16:48.000000000","message":"isn\u0027t ceph?","commit_id":"f87fcc0af70d029e17a3575b6d24c41b21c2d90a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5165f62c150519bb0cf61131033dfd3ba569ace9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    class { \u0027::ceph::profile::rgw\u0027: }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    #add keystone accounts"},{"line_number":91,"context_line":"    keystone_user { \u0027testuser\u0027:"},{"line_number":92,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":93,"context_line":"      enabled  \u003d\u003e true,"},{"line_number":94,"context_line":"      email    \u003d\u003e \u0027testuser@example.com\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1aa78d24_314bfa88","line":91,"updated":"2016-07-12 13:16:48.000000000","message":"I would rather make the name more explicit, related to ceph, etc.","commit_id":"f87fcc0af70d029e17a3575b6d24c41b21c2d90a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5165f62c150519bb0cf61131033dfd3ba569ace9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"    keystone_user_role { \u0027testuser@openstack\u0027:"},{"line_number":98,"context_line":"      ensure \u003d\u003e present,"},{"line_number":99,"context_line":"      roles  \u003d\u003e [\u0027_member_\u0027],"},{"line_number":100,"context_line":"    }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    #configure rgw to use keystone"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1aa78d24_11507e31","line":99,"updated":"2016-07-12 13:16:48.000000000","message":"are you sure about _member_? I thought this one didn\u0027t exist anymore...","commit_id":"f87fcc0af70d029e17a3575b6d24c41b21c2d90a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"853c6640f5b6cb8bc9d1aae881341a6710466b8b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# [*deploy_rgw*]"},{"line_number":4,"context_line":"#   (optional) Setting flag to enable the deployment"},{"line_number":5,"context_line":"#   of Ceph RadosGW and configure various services"},{"line_number":6,"context_line":"#   to use Swift provided by RGW as a backend. "},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"class openstack_integration::ceph ("},{"line_number":9,"context_line":"  $deploy_rgw \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"dada55a8_01f9904d","line":6,"updated":"2016-07-19 20:19:03.000000000","message":"Defaults to false.","commit_id":"27fc8d3f695a75f3bfb408e4a8902437ceb8e9a3"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    })"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    #setup service user"},{"line_number":127,"context_line":"    keystone_user { \"${auth_name}\":"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e \"${password}\","},{"line_number":130,"context_line":"      email    \u003d\u003e \"${email}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_78437f13","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":34},"updated":"2016-08-01 16:04:43.000000000","message":"same","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    #setup service user"},{"line_number":127,"context_line":"    keystone_user { \"${auth_name}\":"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e \"${password}\","},{"line_number":130,"context_line":"      email    \u003d\u003e \"${email}\","},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_78f53feb","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":31},"updated":"2016-08-01 16:04:43.000000000","message":"what\u0027s with the bare string interpolations? if we aren\u0027t mapping it with another string, it should just be $password","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    keystone_user { \"${auth_name}\":"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e \"${password}\","},{"line_number":130,"context_line":"      email    \u003d\u003e \"${email}\","},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    keystone_role{ \u0027Member\u0027:"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_d8c70b94","line":130,"range":{"start_line":130,"start_character":18,"end_line":130,"end_character":28},"updated":"2016-08-01 16:04:43.000000000","message":"same","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":134,"context_line":"      ensure \u003d\u003e present,"},{"line_number":135,"context_line":"    }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    #keystone_user_role { \u0027user_one@project_one\u0027:"},{"line_number":138,"context_line":"    keystone_user_role { \"${auth_name}@${project}\":"},{"line_number":139,"context_line":"      ensure \u003d\u003e present,"},{"line_number":140,"context_line":"      roles  \u003d\u003e $roles,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_581b1b81","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":49},"updated":"2016-08-01 16:04:43.000000000","message":"random code in comment","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    }"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"   #setup test user"},{"line_number":144,"context_line":"   keystone_user { \"${test_user}\":"},{"line_number":145,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":146,"context_line":"     password \u003d\u003e \"${test_pass}\","},{"line_number":147,"context_line":"     email    \u003d\u003e \"${test_email}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_58615ba8","line":144,"range":{"start_line":144,"start_character":19,"end_line":144,"end_character":33},"updated":"2016-08-01 16:04:43.000000000","message":"same","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":143,"context_line":"   #setup test user"},{"line_number":144,"context_line":"   keystone_user { \"${test_user}\":"},{"line_number":145,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":146,"context_line":"     password \u003d\u003e \"${test_pass}\","},{"line_number":147,"context_line":"     email    \u003d\u003e \"${test_email}\","},{"line_number":148,"context_line":"   }"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_785a5ff3","line":146,"range":{"start_line":146,"start_character":17,"end_line":146,"end_character":31},"updated":"2016-08-01 16:04:43.000000000","message":"same","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":144,"context_line":"   keystone_user { \"${test_user}\":"},{"line_number":145,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":146,"context_line":"     password \u003d\u003e \"${test_pass}\","},{"line_number":147,"context_line":"     email    \u003d\u003e \"${test_email}\","},{"line_number":148,"context_line":"   }"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"   keystone_user_role { \"${test_user}@${project}\":"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_f8fdafb1","line":147,"range":{"start_line":147,"start_character":17,"end_line":147,"end_character":32},"updated":"2016-08-01 16:04:43.000000000","message":"same","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    })"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    #setup service user"},{"line_number":127,"context_line":"    keystone_user { ${auth_name}:"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e ${password},"},{"line_number":130,"context_line":"      email    \u003d\u003e ${email},"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_3e6444b7","line":127,"range":{"start_line":127,"start_character":20,"end_line":127,"end_character":32},"updated":"2016-08-01 20:36:54.000000000","message":"just $auth_name","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    #setup service user"},{"line_number":127,"context_line":"    keystone_user { ${auth_name}:"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e ${password},"},{"line_number":130,"context_line":"      email    \u003d\u003e ${email},"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_de752864","line":129,"range":{"start_line":129,"start_character":18,"end_line":129,"end_character":29},"updated":"2016-08-01 20:36:54.000000000","message":"$password","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    keystone_user { ${auth_name}:"},{"line_number":128,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":129,"context_line":"      password \u003d\u003e ${password},"},{"line_number":130,"context_line":"      email    \u003d\u003e ${email},"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    #create Member role"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_fe662cb9","line":130,"range":{"start_line":130,"start_character":18,"end_line":130,"end_character":26},"updated":"2016-08-01 20:36:54.000000000","message":"$email","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"   #setup test user"},{"line_number":145,"context_line":"   keystone_user { ${test_user}:"},{"line_number":146,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":147,"context_line":"     password \u003d\u003e ${test_pass},"},{"line_number":148,"context_line":"     email    \u003d\u003e ${test_email},"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_3e0ba4d7","line":145,"range":{"start_line":145,"start_character":19,"end_line":145,"end_character":31},"updated":"2016-08-01 20:36:54.000000000","message":"similar","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"   #setup test user"},{"line_number":145,"context_line":"   keystone_user { ${test_user}:"},{"line_number":146,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":147,"context_line":"     password \u003d\u003e ${test_pass},"},{"line_number":148,"context_line":"     email    \u003d\u003e ${test_email},"},{"line_number":149,"context_line":"   }"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_9e0e10e3","line":147,"range":{"start_line":147,"start_character":17,"end_line":147,"end_character":29},"updated":"2016-08-01 20:36:54.000000000","message":"similar","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"91370b5fc80fe8795527eb5a522b326b7886572e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   keystone_user { ${test_user}:"},{"line_number":146,"context_line":"     ensure   \u003d\u003e present,"},{"line_number":147,"context_line":"     password \u003d\u003e ${test_pass},"},{"line_number":148,"context_line":"     email    \u003d\u003e ${test_email},"},{"line_number":149,"context_line":"   }"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   keystone_user_role { \"${test_user}@${project}\":"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_bef794d1","line":148,"range":{"start_line":148,"start_character":17,"end_line":148,"end_character":30},"updated":"2016-08-01 20:36:54.000000000","message":"similar","commit_id":"d16e75b03e5887ee2f9178988c311086ec771aeb"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2c2fa6efd65fe045a8e46bdda0b6028434e31d63","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    osds                      \u003d\u003e {"},{"line_number":52,"context_line":"      \u0027/var/lib/ceph/data\u0027 \u003d\u003e {},"},{"line_number":53,"context_line":"    },"},{"line_number":54,"context_line":"    #configure Ceph RadosGW"},{"line_number":55,"context_line":"    #These could be always set in the aboce call to ceph::profile::params"},{"line_number":56,"context_line":"    frontend_type             \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"    rgw_frontends             \u003d\u003e \u0027civetweb port\u003d8080\u0027,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"bacf61ea_adfc9072","line":54,"range":{"start_line":54,"start_character":5,"end_line":54,"end_character":27},"updated":"2016-08-06 01:24:34.000000000","message":"Nit: Please capitalize first word and add a space between \"#\" and first word","commit_id":"2964ad1a491cbc10ba2a1b82640fe350a2727b7b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2c2fa6efd65fe045a8e46bdda0b6028434e31d63","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      \u0027/var/lib/ceph/data\u0027 \u003d\u003e {},"},{"line_number":53,"context_line":"    },"},{"line_number":54,"context_line":"    #configure Ceph RadosGW"},{"line_number":55,"context_line":"    #These could be always set in the aboce call to ceph::profile::params"},{"line_number":56,"context_line":"    frontend_type             \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"    rgw_frontends             \u003d\u003e \u0027civetweb port\u003d8080\u0027,"},{"line_number":58,"context_line":"    rgw_user                  \u003d\u003e \u0027ceph\u0027,"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"bacf61ea_0dd5dce3","line":55,"range":{"start_line":55,"start_character":38,"end_line":55,"end_character":43},"updated":"2016-08-06 01:24:34.000000000","message":"Typo","commit_id":"2964ad1a491cbc10ba2a1b82640fe350a2727b7b"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"2c2fa6efd65fe045a8e46bdda0b6028434e31d63","unresolved":false,"context_lines":[{"line_number":118,"context_line":"      email    \u003d\u003e \u0027rgwuser@example.com\u0027,"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":"    # not sure we actually need it"},{"line_number":121,"context_line":"    keystone_role{ \u0027Member\u0027:"},{"line_number":122,"context_line":"      ensure \u003d\u003e present,"},{"line_number":123,"context_line":"    }"},{"line_number":124,"context_line":"    keystone_user_role { \u0027rgwuser@openstack\u0027:"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"bacf61ea_2df1c095","line":121,"range":{"start_line":121,"start_character":13,"end_line":121,"end_character":18},"updated":"2016-08-06 01:24:34.000000000","message":"Missing space","commit_id":"2964ad1a491cbc10ba2a1b82640fe350a2727b7b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eacdc5af7631fa4d300004114578d0371184fe58","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    # These could be always set in the above call to ceph::profile::params"},{"line_number":56,"context_line":"    frontend_type             \u003d\u003e \u0027civetweb\u0027,"},{"line_number":57,"context_line":"    rgw_frontends             \u003d\u003e \u0027civetweb port\u003d8080\u0027,"},{"line_number":58,"context_line":"    rgw_user                  \u003d\u003e \u0027ceph\u0027,"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  $ceph_pools \u003d [\u0027glance\u0027, \u0027nova\u0027, \u0027cinder\u0027, \u0027gnocchi\u0027]"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"fa7ab95a_b4df8e0b","line":58,"updated":"2016-08-30 17:48:57.000000000","message":"please align correctly","commit_id":"b1ad4d2b932d75b42661a1d82ecac7dcfa664d7e"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"b5867c0b6822b685e8ec29bbc9a840d2222e92ba","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    ceph::rgw::keystone { \u0027radosgw.gateway\u0027:"},{"line_number":103,"context_line":"      rgw_keystone_url            \u003d\u003e $::openstack_integration::config::keystone_admin_uri,"},{"line_number":104,"context_line":"      rgw_keystone_version        \u003d\u003e \u0027v3\u0027,"},{"line_number":105,"context_line":"      user                        \u003d\u003e \u0027ceph\u0027,"},{"line_number":106,"context_line":"      use_pki                     \u003d\u003e false,"},{"line_number":107,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":108,"context_line":"      rgw_keystone_admin_domain   \u003d\u003e $user_domain,"}],"source_content_type":"text/x-puppet","patch_set":63,"id":"fa6399be_7a6fc3fb","line":105,"range":{"start_line":105,"start_character":37,"end_line":105,"end_character":43},"updated":"2016-10-14 23:14:34.000000000","message":"@Keith, why is this ceph and not the os_default user for apache?","commit_id":"c3979828db62cd9c624a0babb0e6b9554b7f3121"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f65cf8797a299b8d6b88ed898bd31eba17a8b26e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    ceph::rgw::keystone { \u0027radosgw.gateway\u0027:"},{"line_number":103,"context_line":"      rgw_keystone_url            \u003d\u003e $::openstack_integration::config::keystone_admin_uri,"},{"line_number":104,"context_line":"      rgw_keystone_version        \u003d\u003e \u0027v3\u0027,"},{"line_number":105,"context_line":"      user                        \u003d\u003e \u0027ceph\u0027,"},{"line_number":106,"context_line":"      use_pki                     \u003d\u003e false,"},{"line_number":107,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":108,"context_line":"      rgw_keystone_admin_domain   \u003d\u003e $user_domain,"}],"source_content_type":"text/x-puppet","patch_set":63,"id":"fa6399be_4a4dca98","line":105,"range":{"start_line":105,"start_character":37,"end_line":105,"end_character":43},"in_reply_to":"fa6399be_7a6fc3fb","updated":"2016-10-15 02:55:33.000000000","message":"I changed this to \u0027ceph\u0027 as the radosgw process runs as the ceph user instead of the web user. Same as the rgw_user line 61.","commit_id":"c3979828db62cd9c624a0babb0e6b9554b7f3121"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"b5867c0b6822b685e8ec29bbc9a840d2222e92ba","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      rgw_keystone_version        \u003d\u003e \u0027v3\u0027,"},{"line_number":105,"context_line":"      user                        \u003d\u003e \u0027ceph\u0027,"},{"line_number":106,"context_line":"      use_pki                     \u003d\u003e false,"},{"line_number":107,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":108,"context_line":"      rgw_keystone_admin_domain   \u003d\u003e $user_domain,"},{"line_number":109,"context_line":"      rgw_keystone_admin_project  \u003d\u003e $project,"},{"line_number":110,"context_line":"      rgw_keystone_admin_user     \u003d\u003e $auth_name,"}],"source_content_type":"text/x-puppet","patch_set":63,"id":"fa6399be_ba5cfb4b","line":107,"range":{"start_line":107,"start_character":37,"end_line":107,"end_character":56},"updated":"2016-10-14 23:14:34.000000000","message":"@Keith, This isn\u0027t the default _member_, Member we have in puppet-ceph, can you elaborate on why you changed them?","commit_id":"c3979828db62cd9c624a0babb0e6b9554b7f3121"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"f65cf8797a299b8d6b88ed898bd31eba17a8b26e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      rgw_keystone_version        \u003d\u003e \u0027v3\u0027,"},{"line_number":105,"context_line":"      user                        \u003d\u003e \u0027ceph\u0027,"},{"line_number":106,"context_line":"      use_pki                     \u003d\u003e false,"},{"line_number":107,"context_line":"      rgw_keystone_accepted_roles \u003d\u003e [\u0027admin\u0027, \u0027Member\u0027],"},{"line_number":108,"context_line":"      rgw_keystone_admin_domain   \u003d\u003e $user_domain,"},{"line_number":109,"context_line":"      rgw_keystone_admin_project  \u003d\u003e $project,"},{"line_number":110,"context_line":"      rgw_keystone_admin_user     \u003d\u003e $auth_name,"}],"source_content_type":"text/x-puppet","patch_set":63,"id":"fa6399be_0a2f52a1","line":107,"range":{"start_line":107,"start_character":37,"end_line":107,"end_character":56},"in_reply_to":"fa6399be_ba5cfb4b","updated":"2016-10-15 02:55:33.000000000","message":"I may have unknowingly drifted from the norm in ceph::rgw::keystone::auth and used it in p-o-i::ceph. I am agnostic on the roles and will agree to change as needed. p-o-i::swift use a similar set of roles.","commit_id":"c3979828db62cd9c624a0babb0e6b9554b7f3121"}],"manifests/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"853c6640f5b6cb8bc9d1aae881341a6710466b8b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $default_domain      \u003d undef,"},{"line_number":20,"context_line":"  $using_domain_config \u003d false,"},{"line_number":21,"context_line":"  $token_provider      \u003d \u0027uuid\u0027,"},{"line_number":22,"context_line":"  $enable_pki_setup    \u003d false,"},{"line_number":23,"context_line":"  $signing_keyfile     \u003d \u0027/etc/keystone/ssl/private/signing_key.pem\u0027,"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  include ::openstack_integration::config"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"dada55a8_2195b4dd","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":68},"updated":"2016-07-19 20:19:03.000000000","message":"why that?","commit_id":"27fc8d3f695a75f3bfb408e4a8902437ceb8e9a3"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#   (optional) Define the token provider to use."},{"line_number":16,"context_line":"#   Default to \u0027uuid\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*enable_pki_setup*}"},{"line_number":19,"context_line":"#   (optional) enable the configuration of keystone PKI keys"},{"line_number":20,"context_line":"#   Defaults to false"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_9ba46d08","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":20},"updated":"2016-08-01 16:04:43.000000000","message":"I don\u0027t see this defined anywhere","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"bf99ad881421596acd6c8a4d773629dcf4122b17","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    $enable_fernet_setup \u003d false"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  #class { \u0027::keystone::client\u0027: }"},{"line_number":46,"context_line":"  class { \u0027::keystone::cron::token_flush\u0027: }"},{"line_number":47,"context_line":"  class { \u0027::keystone::db::mysql\u0027:"},{"line_number":48,"context_line":"    password \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_dbe0a52b","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":3},"updated":"2016-08-01 16:04:43.000000000","message":"random commented out code?","commit_id":"c28c42ae567f8a7ca7ee4183d2f43a22f2a7edfd"}]}