)]}'
{"manifests/barbican.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5d72b8754562212831cecddd895bb9d2f4b3832d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"  class { \u0027::barbican::db\u0027:"},{"line_number":45,"context_line":"    database_connection \u003d\u003e \u0027mysql+pymysql://barbican:barbican@127.0.0.1/barbican?charset\u003dutf8\u0027,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":"  class { \u0027::barbican::api\u0027:"},{"line_number":48,"context_line":"    host_href                   \u003d\u003e \"${::openstack_integration::config::base_url}:9311\","},{"line_number":49,"context_line":"    auth_type                   \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_dc095f2e","line":46,"updated":"2016-07-28 10:30:00.000000000","message":"looks like something wrong with barbican db manifests:\n\nhttp://logs.openstack.org/06/339806/42/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7-nv/78bfd34/console.html#_2016-07-28_08_39_43_272531","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91c1bb6295ee8c4d3c47cee7a09ff76b57116e7e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"  class { \u0027::barbican::db\u0027:"},{"line_number":45,"context_line":"    database_connection \u003d\u003e \u0027mysql+pymysql://barbican:barbican@127.0.0.1/barbican?charset\u003dutf8\u0027,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":"  class { \u0027::barbican::api\u0027:"},{"line_number":48,"context_line":"    host_href                   \u003d\u003e \"${::openstack_integration::config::base_url}:9311\","},{"line_number":49,"context_line":"    auth_type                   \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_2be5cf36","line":46,"in_reply_to":"bacf61ea_dc095f2e","updated":"2016-07-28 11:57:08.000000000","message":"yeah i\u0027m looking into it","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5d3626fec5cd58032785d7c6b4377e95386adeab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"caclass openstack_integration::barbican {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  include ::openstack_integration::config"},{"line_number":4,"context_line":"  include ::openstack_integration::params"}],"source_content_type":"text/x-puppet","patch_set":43,"id":"bacf61ea_00f9c580","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":7},"updated":"2016-07-28 12:36:41.000000000","message":"typo class","commit_id":"e0a91de74e718cc3cc47cfcb554e63e24f3d8f23"}],"manifests/cinder.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0c844237c9e88d81ecad5b0b59ba618613cb7fa8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    rabbit_use_ssl      \u003d\u003e $::openstack_integration::config::ssl,"},{"line_number":63,"context_line":"    debug               \u003d\u003e true,"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":"  if $volume_encryption {"},{"line_number":66,"context_line":"    $keymgr_api_class            \u003d \u0027cinder.keymgr.barbican.BarbicanKeyManager\u0027"},{"line_number":67,"context_line":"    $keymgr_encryption_api_url   \u003d \"${::openstack_integration::config::base_url}:9311/v1\""},{"line_number":68,"context_line":"    $keymgr_encryption_auth_url  \u003d \"${::openstack_integration::config::base_url}:5000/v3\""},{"line_number":69,"context_line":"  } else {"},{"line_number":70,"context_line":"    $keymgr_api_class            \u003d undef"},{"line_number":71,"context_line":"    $keymgr_encryption_api_url   \u003d undef"},{"line_number":72,"context_line":"    $keymgr_encryption_auth_url  \u003d undef"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"  class { \u0027::cinder::api\u0027:"},{"line_number":75,"context_line":"    keystone_password   \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":76,"context_line":"    auth_uri            \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_f25c3ef2","line":73,"range":{"start_line":65,"start_character":0,"end_line":73,"end_character":3},"updated":"2016-07-14 20:57:42.000000000","message":"bad indentation","commit_id":"6eefeb4fe6b6d0bce39a61e34c55d14f97c9a1c2"}],"manifests/keystone.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2d65f4e45381de16bb4203ad8389bca6b075a5d8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    auth_url       \u003d\u003e \"${::openstack_integration::config::keystone_auth_uri}/v3/\","},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  # Needed for Barbican"},{"line_number":102,"context_line":"  keystone_role { \u0027creator\u0027:"},{"line_number":103,"context_line":"    ensure \u003d\u003e present,"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":35,"id":"dada55a8_c99bf664","line":104,"range":{"start_line":101,"start_character":0,"end_line":104,"end_character":3},"updated":"2016-07-26 12:41:47.000000000","message":"so create it in barbican.pp","commit_id":"4d9f10861a8ff87d359ef74b246a024beb2ba9b8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b44974f91352085f2ce527216c3c5db0d117f3c2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # this role and assign users to it.  This code is not executed, however,"},{"line_number":108,"context_line":"  # when tempest_roles is defined.  Therefore we need to make sure this"},{"line_number":109,"context_line":"  # role is created here, and added to tempest_roles."},{"line_number":110,"context_line":"  "},{"line_number":111,"context_line":"  keystone_role { \u0027creator\u0027:"},{"line_number":112,"context_line":"    ensure \u003d\u003e present,"},{"line_number":113,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_3956cd29","line":110,"updated":"2016-07-28 10:29:09.000000000","message":"empty spaces","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91c1bb6295ee8c4d3c47cee7a09ff76b57116e7e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  # this role and assign users to it.  This code is not executed, however,"},{"line_number":108,"context_line":"  # when tempest_roles is defined.  Therefore we need to make sure this"},{"line_number":109,"context_line":"  # role is created here, and added to tempest_roles."},{"line_number":110,"context_line":"  "},{"line_number":111,"context_line":"  keystone_role { \u0027creator\u0027:"},{"line_number":112,"context_line":"    ensure \u003d\u003e present,"},{"line_number":113,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_cbf35309","line":110,"in_reply_to":"bacf61ea_3956cd29","updated":"2016-07-28 11:57:08.000000000","message":"Done","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b44974f91352085f2ce527216c3c5db0d117f3c2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  "},{"line_number":111,"context_line":"  keystone_role { \u0027creator\u0027:"},{"line_number":112,"context_line":"    ensure \u003d\u003e present,"},{"line_number":113,"context_line":"  }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  keystone_role { \u0027Member\u0027:"},{"line_number":116,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_79368504","line":113,"updated":"2016-07-28 10:29:09.000000000","message":"do we need to create this role every time?","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91c1bb6295ee8c4d3c47cee7a09ff76b57116e7e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  "},{"line_number":111,"context_line":"  keystone_role { \u0027creator\u0027:"},{"line_number":112,"context_line":"    ensure \u003d\u003e present,"},{"line_number":113,"context_line":"  }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"  keystone_role { \u0027Member\u0027:"},{"line_number":116,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_6beea723","line":113,"in_reply_to":"bacf61ea_79368504","updated":"2016-07-28 11:57:08.000000000","message":"yeah, they are required when running Tempest","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"}],"manifests/tempest.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b92283e9198e5abd15df8a054ad4b5c99719e744","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027creator\u0027],  # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"dada55a8_41212db4","line":115,"updated":"2016-07-22 11:07:05.000000000","message":"in case of array, you need: join([\u0027creator\u0027, ... ], \u0027,\u0027)","commit_id":"0e13f60746f6e11f5227a3077408ea11da63a4c9"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"03aaab98160209abf571ca7c5304eb2ef50fa52f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027creator\u0027],  # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"dada55a8_1c083c28","line":115,"in_reply_to":"dada55a8_41212db4","updated":"2016-07-22 11:08:34.000000000","message":"That makes sense. Thanks. Anyway, I\u0027m trying to test if I only need the creator role. probably the member roles should be present anyway.","commit_id":"0e13f60746f6e11f5227a3077408ea11da63a4c9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b44974f91352085f2ce527216c3c5db0d117f3c2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027Member\u0027, \u0027creator\u0027], # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_f92275b8","line":115,"updated":"2016-07-28 10:29:09.000000000","message":"may be we can pass it as parameter?","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91c1bb6295ee8c4d3c47cee7a09ff76b57116e7e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027Member\u0027, \u0027creator\u0027], # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":42,"id":"bacf61ea_8b379baf","line":115,"in_reply_to":"bacf61ea_f92275b8","updated":"2016-07-28 11:57:08.000000000","message":"they are really specific for our CI, like other parameters here, I suggest we keep it like this.","commit_id":"07a2005836d72dfb19bebbd44b659788d86cf68e"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"ed8fe9265b1456819d031d45750d2a4328073534","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027Member\u0027, \u0027creator\u0027], # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":45,"id":"bacf61ea_8da570a3","line":115,"range":{"start_line":115,"start_character":30,"end_line":115,"end_character":52},"updated":"2016-08-01 08:38:36.000000000","message":"I\u0027m unsure if this way of defining it will work. I tried it before and for some reason it will only add the first role defined in the list. you would need to use a join, or explicitly set the list in string form as this:\n\n\u0027Member,creator\u0027","commit_id":"2627afe733a6bb64e979ad1388f2a0880375eeb9"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"63c9f0d0f13415b90b6612f4afe4a5a91f5b4fa3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    admin_password          \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":113,"context_line":"    admin_domain_name       \u003d\u003e \u0027Default\u0027,"},{"line_number":114,"context_line":"    auth_version            \u003d\u003e \u0027v3\u0027,"},{"line_number":115,"context_line":"    tempest_roles           \u003d\u003e [\u0027Member\u0027, \u0027creator\u0027], # needed to use barbican."},{"line_number":116,"context_line":"    image_name              \u003d\u003e \u0027cirros\u0027,"},{"line_number":117,"context_line":"    image_name_alt          \u003d\u003e \u0027cirros_alt\u0027,"},{"line_number":118,"context_line":"    cinder_available        \u003d\u003e $cinder,"}],"source_content_type":"text/x-puppet","patch_set":45,"id":"bacf61ea_256ec996","line":115,"range":{"start_line":115,"start_character":30,"end_line":115,"end_character":52},"in_reply_to":"bacf61ea_8da570a3","updated":"2016-08-02 14:26:10.000000000","message":"There was a change made to puppet-tempest to allow this to work.  At this point, the tests were passing.  The only problem is some puppet-4 issues that Emilien is investigating.","commit_id":"2627afe733a6bb64e979ad1388f2a0880375eeb9"}]}