)]}'
{"manifests/nova.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"844d29e11b4ed898a32cdef99cf5147893415154","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    barbican_auth_endpoint      \u003d\u003e $keymgr_auth_endpoint,"},{"line_number":113,"context_line":"    barbican_endpoint           \u003d\u003e $barbican_endpoint,"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":"  class { \u0027::nova::compute::libvirt\u0027:"},{"line_number":116,"context_line":"    libvirt_virt_type     \u003d\u003e $libvirt_virt_type,"},{"line_number":117,"context_line":"    migration_support     \u003d\u003e true,"},{"line_number":118,"context_line":"    vncserver_listen      \u003d\u003e \u00270.0.0.0\u0027,"},{"line_number":119,"context_line":"    # TODO: enable it again when puppet 4.5 will be idempotent"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_fa1474e9","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":48},"updated":"2016-08-18 10:11:13.000000000","message":"why not to override $::nova::compute::libvirt::libvirt_virt_type directly?","commit_id":"df8841bd390cbcc92b9851fb955adc61a720fcfa"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"209ad1ba486d039e3c22b02c6e49e78dc88c8d1e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    barbican_auth_endpoint      \u003d\u003e $keymgr_auth_endpoint,"},{"line_number":113,"context_line":"    barbican_endpoint           \u003d\u003e $barbican_endpoint,"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":"  class { \u0027::nova::compute::libvirt\u0027:"},{"line_number":116,"context_line":"    libvirt_virt_type     \u003d\u003e $libvirt_virt_type,"},{"line_number":117,"context_line":"    migration_support     \u003d\u003e true,"},{"line_number":118,"context_line":"    vncserver_listen      \u003d\u003e \u00270.0.0.0\u0027,"},{"line_number":119,"context_line":"    # TODO: enable it again when puppet 4.5 will be idempotent"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_a11f5eb5","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":48},"in_reply_to":"3ac371cc_2659c48e","updated":"2016-08-18 14:54:24.000000000","message":"Not right now but perhaps one day. We discussed yesterday with openstack-infra the use case around nested virtualization (and tested it on https://review.openstack.org/#/c/356695/) but today nested virtualization is not a requirement or guaranteed from nodepool providers.\n\nFor example, it would work on nodes from OSIC but maybe not on another provider.\nopenstack-infra apparently doesn\u0027t have plans for this yet.\n\nIt just feels silly to test with a hypervisor (pure qemu) that realistically, no one in their right mind would use in production.\nThis hook will be used to test p-o-i with KVM instead of QEMU in RDO\u0027s CI until KVM testing is available upstream.\n\nI see where you\u0027re going, I\u0027m not going to fight over this. I was adding it here for convenience for people wanting to use p-o-i with another hypervisor in a straightforward way.","commit_id":"df8841bd390cbcc92b9851fb955adc61a720fcfa"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e3eae37717c49029957a285f7aa7efea6804451","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    barbican_auth_endpoint      \u003d\u003e $keymgr_auth_endpoint,"},{"line_number":113,"context_line":"    barbican_endpoint           \u003d\u003e $barbican_endpoint,"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":"  class { \u0027::nova::compute::libvirt\u0027:"},{"line_number":116,"context_line":"    libvirt_virt_type     \u003d\u003e $libvirt_virt_type,"},{"line_number":117,"context_line":"    migration_support     \u003d\u003e true,"},{"line_number":118,"context_line":"    vncserver_listen      \u003d\u003e \u00270.0.0.0\u0027,"},{"line_number":119,"context_line":"    # TODO: enable it again when puppet 4.5 will be idempotent"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_2659c48e","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":48},"in_reply_to":"3ac371cc_8fd9bdf5","updated":"2016-08-18 14:41:52.000000000","message":"Will this parameter be used in p-o-i jobs?","commit_id":"df8841bd390cbcc92b9851fb955adc61a720fcfa"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"98c7e8d6bd8e79072064013ce9eb0a293818a53d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    barbican_auth_endpoint      \u003d\u003e $keymgr_auth_endpoint,"},{"line_number":113,"context_line":"    barbican_endpoint           \u003d\u003e $barbican_endpoint,"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":"  class { \u0027::nova::compute::libvirt\u0027:"},{"line_number":116,"context_line":"    libvirt_virt_type     \u003d\u003e $libvirt_virt_type,"},{"line_number":117,"context_line":"    migration_support     \u003d\u003e true,"},{"line_number":118,"context_line":"    vncserver_listen      \u003d\u003e \u00270.0.0.0\u0027,"},{"line_number":119,"context_line":"    # TODO: enable it again when puppet 4.5 will be idempotent"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3ac371cc_8fd9bdf5","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":48},"in_reply_to":"3ac371cc_fa1474e9","updated":"2016-08-18 11:30:29.000000000","message":"I don\u0027t know, because it\u0027s more straightforward here ? I mean, we could drop every parameter from p-o-i and use hiera everywhere instead of sending parameters from fixtures.","commit_id":"df8841bd390cbcc92b9851fb955adc61a720fcfa"}]}