)]}'
{"id":"openstack%2Fpuppet-openstack-integration~356708","triplet_id":"openstack%2Fpuppet-openstack-integration~master~Ie80740b67561ca21e1e81e9e571e66e8d505d940","project":"openstack/puppet-openstack-integration","branch":"master","hashtags":[],"change_id":"Ie80740b67561ca21e1e81e9e571e66e8d505d940","subject":"Parameterize the libvirt_virt_type parameter so it can be overridden","status":"MERGED","created":"2016-08-17 20:51:12.000000000","updated":"2016-08-18 16:17:16.000000000","submitted":"2016-08-18 16:17:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"deefd1d7c736d766977bf30008d5bb643f24ee68","_number":356708,"virtual_id_number":356708,"owner":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":2,"date":"2016-08-18 16:17:16.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"recommended":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"all":[{"value":1,"date":"2016-08-17 21:41:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},{"value":2,"date":"2016-08-17 21:47:49.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2016-08-18 15:22:39.000000000","_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"all":[{"value":0,"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2016-08-18 15:22:39.000000000","_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-17 21:41:43.000000000","updated_by":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"reviewer":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"state":"REVIEWER"},{"updated":"2016-08-17 21:47:49.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2016-08-18 15:22:39.000000000","updated_by":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"reviewer":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"state":"REVIEWER"},{"updated":"2016-08-18 16:17:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e3f962145776045a7fa088f772b9fedc19c56c68","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2016-08-17 20:51:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81cc630be07c19fb13932e18f3dac6d308d8a8e4","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2016-08-17 21:17:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"41d657b7fe35a1fa785443e7390e5f8a9a0b5d91","author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"date":"2016-08-17 21:41:43.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"0c02e25b840506f5264c64534b13efb8154929c1","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2016-08-17 21:47:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"dab63d05b82637c7ebf4d687833c0363d9c783c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-17 22:04:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-puppet-lint/4a335b7/ : SUCCESS in 2m 55s\n- gate-puppet-openstack-integration-puppet-syntax-3-centos-7 http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-puppet-syntax-3-centos-7/9e6b9d7/ : SUCCESS in 3m 03s\n- gate-puppet-openstack-integration-puppet-syntax-4-centos-7 http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-puppet-syntax-4-centos-7/4a0209f/ : SUCCESS in 3m 03s\n- gate-puppet-openstack-integration-3-scenario001-tempest-centos-7 http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/eb48155/ : SUCCESS in 26m 24s\n- gate-puppet-openstack-integration-3-scenario002-tempest-centos-7 http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario002-tempest-centos-7/be9731c/ : SUCCESS in 26m 21s\n- gate-puppet-openstack-integration-3-scenario003-tempest-centos-7 http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/0aee37c/ : SUCCESS in 29m 28s\n- gate-puppet-openstack-integration-3-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario001-tempest-ubuntu-xenial/8eac225/ : SUCCESS in 23m 02s\n- gate-puppet-openstack-integration-3-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario002-tempest-ubuntu-xenial/10da879/ : SUCCESS in 21m 51s\n- gate-puppet-openstack-integration-3-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-3-scenario003-tempest-ubuntu-xenial/1922c2c/ : SUCCESS in 20m 08s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-nv/48b3b38/ : SUCCESS in 21m 56s (non-voting)\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7-nv/0fdb95b/ : FAILURE in 18m 09s (non-voting)\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial-nv/eb13406/ : SUCCESS in 22m 33s (non-voting)\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7-nv/7797c8b/ : SUCCESS in 27m 23s (non-voting)\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial-nv/0e9e461/ : SUCCESS in 20m 12s (non-voting)\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7-nv http://logs.openstack.org/08/356708/2/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7-nv/bc51249/ : SUCCESS in 24m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"844d29e11b4ed898a32cdef99cf5147893415154","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2016-08-18 10:11:13.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"98c7e8d6bd8e79072064013ce9eb0a293818a53d","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2016-08-18 11:30:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4e3eae37717c49029957a285f7aa7efea6804451","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2016-08-18 14:41:52.000000000","message":"Patch Set 2: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"209ad1ba486d039e3c22b02c6e49e78dc88c8d1e","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2016-08-18 14:54:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"69be30878bf987a7f4165ce1f7dc3261268c7f06","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2016-08-18 15:22:39.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2828d72255c9890e8480123557d68e4f7dd2cbd1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-18 15:23:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e4530f6e9441be0eda46ee4cda39b87de89c47c1","date":"2016-08-18 16:17:16.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"deefd1d7c736d766977bf30008d5bb643f24ee68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-18 16:17:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-puppet-lint/7d6e210/ : SUCCESS in 4m 50s\n- gate-puppet-openstack-integration-puppet-syntax-3-centos-7 http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-puppet-syntax-3-centos-7/c7b536b/ : SUCCESS in 3m 02s\n- gate-puppet-openstack-integration-puppet-syntax-4-centos-7 http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-puppet-syntax-4-centos-7/eb69877/ : SUCCESS in 4m 12s\n- gate-puppet-openstack-integration-3-scenario001-tempest-centos-7 http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/d14e6f9/ : SUCCESS in 25m 43s\n- gate-puppet-openstack-integration-3-scenario002-tempest-centos-7 http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario002-tempest-centos-7/b6f4a90/ : SUCCESS in 27m 41s\n- gate-puppet-openstack-integration-3-scenario003-tempest-centos-7 http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario003-tempest-centos-7/c65f0f9/ : SUCCESS in 23m 50s\n- gate-puppet-openstack-integration-3-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario001-tempest-ubuntu-xenial/dd8b9b1/ : SUCCESS in 36m 33s\n- gate-puppet-openstack-integration-3-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario002-tempest-ubuntu-xenial/ce4f34a/ : SUCCESS in 50m 14s\n- gate-puppet-openstack-integration-3-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/08/356708/2/gate/gate-puppet-openstack-integration-3-scenario003-tempest-ubuntu-xenial/231c626/ : SUCCESS in 31m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"df8841bd390cbcc92b9851fb955adc61a720fcfa","revisions":{"0efcd06655f6ab018d57f61c6569d753eda6e830":{"kind":"REWORK","_number":1,"created":"2016-08-17 20:51:12.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/08/356708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/08/356708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/1"}}},"commit":{"parents":[{"commit":"c9fae323f9fb7c666943a082226c9bd7fb98f0cc","subject":"Promote RDO repository to latest consistent URL","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/c9fae323f9fb7c666943a082226c9bd7fb98f0cc"}]}],"author":{"name":"David Moreau-Simard","email":"dms@redhat.com","date":"2016-08-17 20:49:06.000000000","tz":-240},"committer":{"name":"David Moreau-Simard","email":"dms@redhat.com","date":"2016-08-17 20:49:06.000000000","tz":-240},"subject":"Parameterize the libvirt_virt_type parameter so it can be overridden","message":"Parameterize the libvirt_virt_type parameter so it can be overridden\n\nWhen running puppet-openstack-integration in certain contexts, for\nexample outside of the gate, we might want to choose a different\nhypervisor such as KVM.\nMaking it a parameter will allow it to be overridden by hiera\neasily.\n\nChange-Id: Ie80740b67561ca21e1e81e9e571e66e8d505d940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/0efcd06655f6ab018d57f61c6569d753eda6e830"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/0efcd06655f6ab018d57f61c6569d753eda6e830"}]},"branch":"refs/heads/master"},"df8841bd390cbcc92b9851fb955adc61a720fcfa":{"kind":"REWORK","_number":2,"created":"2016-08-17 21:17:31.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/08/356708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/08/356708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/08/356708/2"}}},"commit":{"parents":[{"commit":"c9fae323f9fb7c666943a082226c9bd7fb98f0cc","subject":"Promote RDO repository to latest consistent URL","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/c9fae323f9fb7c666943a082226c9bd7fb98f0cc"}]}],"author":{"name":"David Moreau-Simard","email":"dms@redhat.com","date":"2016-08-17 20:49:06.000000000","tz":-240},"committer":{"name":"David Moreau-Simard","email":"dms@redhat.com","date":"2016-08-17 21:17:27.000000000","tz":-240},"subject":"Parameterize the libvirt_virt_type parameter so it can be overridden","message":"Parameterize the libvirt_virt_type parameter so it can be overridden\n\nWhen running puppet-openstack-integration in certain contexts, for\nexample outside of the gate, we might want to choose a different\nhypervisor such as KVM.\nMaking it a parameter will allow it to be overridden by hiera\neasily.\n\nChange-Id: Ie80740b67561ca21e1e81e9e571e66e8d505d940\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/df8841bd390cbcc92b9851fb955adc61a720fcfa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/df8841bd390cbcc92b9851fb955adc61a720fcfa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}